)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"908b23ae66fdbba9e736dc4904d4156e7266a36a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3df81021_a3e9e039","updated":"2023-06-22 17:15:20.000000000","message":"just couple of nits. And one question (reason for -1, to not miss the discussion) about updates to this. Will the broken ones be fixed? Perhaps a release not is needed to inform about the actions to recover from it (like reattach the FIP)","commit_id":"e84ca276694226629b2842dc8d08c5be6f252c78"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"5bafd59f5b37951c9370c97ea8bce5375af3afe5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"51a03ff6_8a10a999","in_reply_to":"3df81021_a3e9e039","updated":"2023-06-23 08:04:03.000000000","message":"Just deploying the patch, without any action will no modify the existing LB_HC, for sure. So I prefer to recreate the HM in order to the recreate the LBHC including the new info in the external_ids. Recreate the HM has a minor impact that reattach the FIP, and just reattaching the FIP any existing LB_HC will no update with the new external_id keys.","commit_id":"e84ca276694226629b2842dc8d08c5be6f252c78"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"031fda8c5af81fc1ba86efccf91f775fcb2ba25f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ca2725b3_8207ede4","in_reply_to":"51a03ff6_8a10a999","updated":"2023-06-23 09:04:09.000000000","message":"ok, so we should include this explanation in a release node","commit_id":"e84ca276694226629b2842dc8d08c5be6f252c78"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"32a4e4271f5475d7774f2a5a229eccbab67753eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bb67cee6_7b584806","in_reply_to":"ca2725b3_8207ede4","updated":"2023-06-23 14:16:56.000000000","message":"in a note better... 😊","commit_id":"e84ca276694226629b2842dc8d08c5be6f252c78"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"49acc52d383e9b85f942fcc52441268e80fd0374","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"52658617_9eb5506f","updated":"2023-06-28 09:51:44.000000000","message":"Just some nits/questions here and there","commit_id":"e882dcad0b2ce675710cefedc4dc1c9982a025f2"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"942c9549a09f49864e0f51a95864bccd88ce3d35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6a046636_e8087708","updated":"2023-06-28 08:30:26.000000000","message":"anything missing here? the relnotes stuff seems to be resolved?","commit_id":"e882dcad0b2ce675710cefedc4dc1c9982a025f2"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"6736d4e16cd321bf43e371d67dc72c81a3999196","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5615ba22_6f458fcb","updated":"2023-07-07 08:15:48.000000000","message":"A following patch will be created to include a maintenance task to be sure that  existing LBHCs are upgraded to include this new fields and fix any issue on the vip field.","commit_id":"e921782abba977b6849833753f91848f81ec0789"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f2ca588884a93bd09b502e9060535a0ace02b95b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"707ad10e_85a2727d","updated":"2023-07-07 08:34:45.000000000","message":"LGTM, just one nit on the release note, and one extra concern","commit_id":"e921782abba977b6849833753f91848f81ec0789"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c0eeaa6e3642ec28f816f8b2f619392e6f01d8ba","unresolved":true,"context_lines":[{"line_number":2231,"context_line":"                                         (\u0027external_ids\u0027, vip_fip_info)))"},{"line_number":2232,"context_line":"            if ovn_lb.health_check:"},{"line_number":2233,"context_line":"                vip \u003d fip_info[\u0027vip_fip\u0027]"},{"line_number":2234,"context_line":"                if ovn_lb.health_check[0].vip:"},{"line_number":2235,"context_line":"                    port \u003d ovn_lb.health_check[0].vip.rsplit(\u0027:\u0027, 1)[1]"},{"line_number":2236,"context_line":"                    vip +\u003d \u0027:\u0027 + port"},{"line_number":2237,"context_line":"                kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"866ba41a_11ff59ee","line":2234,"range":{"start_line":2234,"start_character":3,"end_line":2234,"end_character":46},"updated":"2023-06-21 12:07:11.000000000","message":"should we handle the case where there is none? should this fail or skip the rest?","commit_id":"bd31020b4d2ccb762c87dba0e78f63c3fd800946"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"2d6b6dc310081756e08da4dea4f7b8a4d40600bd","unresolved":true,"context_lines":[{"line_number":2231,"context_line":"                                         (\u0027external_ids\u0027, vip_fip_info)))"},{"line_number":2232,"context_line":"            if ovn_lb.health_check:"},{"line_number":2233,"context_line":"                vip \u003d fip_info[\u0027vip_fip\u0027]"},{"line_number":2234,"context_line":"                if ovn_lb.health_check[0].vip:"},{"line_number":2235,"context_line":"                    port \u003d ovn_lb.health_check[0].vip.rsplit(\u0027:\u0027, 1)[1]"},{"line_number":2236,"context_line":"                    vip +\u003d \u0027:\u0027 + port"},{"line_number":2237,"context_line":"                kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"b47b62ca_9f018e8c","line":2234,"range":{"start_line":2234,"start_character":3,"end_line":2234,"end_character":46},"in_reply_to":"866ba41a_11ff59ee","updated":"2023-06-21 12:19:32.000000000","message":"This is covered by the if two lines above, and this check is necessary to cover cases when the lb_hc is created and the listener doesn\u0027t have port yet, where the vip field is [].\n\nBut we could have some error with multi listener (different port)... let think about it","commit_id":"bd31020b4d2ccb762c87dba0e78f63c3fd800946"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"32a4e4271f5475d7774f2a5a229eccbab67753eb","unresolved":false,"context_lines":[{"line_number":2231,"context_line":"                                         (\u0027external_ids\u0027, vip_fip_info)))"},{"line_number":2232,"context_line":"            if ovn_lb.health_check:"},{"line_number":2233,"context_line":"                vip \u003d fip_info[\u0027vip_fip\u0027]"},{"line_number":2234,"context_line":"                if ovn_lb.health_check[0].vip:"},{"line_number":2235,"context_line":"                    port \u003d ovn_lb.health_check[0].vip.rsplit(\u0027:\u0027, 1)[1]"},{"line_number":2236,"context_line":"                    vip +\u003d \u0027:\u0027 + port"},{"line_number":2237,"context_line":"                kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"87ff2266_d2efef27","line":2234,"range":{"start_line":2234,"start_character":3,"end_line":2234,"end_character":46},"in_reply_to":"b47b62ca_9f018e8c","updated":"2023-06-23 14:16:56.000000000","message":"cover with las patchset","commit_id":"bd31020b4d2ccb762c87dba0e78f63c3fd800946"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"908b23ae66fdbba9e736dc4904d4156e7266a36a","unresolved":true,"context_lines":[{"line_number":2231,"context_line":"            commands.append("},{"line_number":2232,"context_line":"                self.ovn_nbdb_api.db_set(\u0027Load_Balancer\u0027, ovn_lb.uuid,"},{"line_number":2233,"context_line":"                                         (\u0027external_ids\u0027, vip_fip_info)))"},{"line_number":2234,"context_line":"            if ovn_lb.health_check:"},{"line_number":2235,"context_line":"                for lb_hc in ovn_lb.health_check:"},{"line_number":2236,"context_line":"                    vip \u003d fip_info[\u0027vip_fip\u0027]"},{"line_number":2237,"context_line":"                    external_ids \u003d copy.deepcopy(lb_hc.external_ids)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ae15a71e_ee442c9f","line":2234,"range":{"start_line":2234,"start_character":12,"end_line":2234,"end_character":35},"updated":"2023-06-22 17:15:20.000000000","message":"this if is not needed,if there is non, the for block does not get executed","commit_id":"e84ca276694226629b2842dc8d08c5be6f252c78"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"5bafd59f5b37951c9370c97ea8bce5375af3afe5","unresolved":false,"context_lines":[{"line_number":2231,"context_line":"            commands.append("},{"line_number":2232,"context_line":"                self.ovn_nbdb_api.db_set(\u0027Load_Balancer\u0027, ovn_lb.uuid,"},{"line_number":2233,"context_line":"                                         (\u0027external_ids\u0027, vip_fip_info)))"},{"line_number":2234,"context_line":"            if ovn_lb.health_check:"},{"line_number":2235,"context_line":"                for lb_hc in ovn_lb.health_check:"},{"line_number":2236,"context_line":"                    vip \u003d fip_info[\u0027vip_fip\u0027]"},{"line_number":2237,"context_line":"                    external_ids \u003d copy.deepcopy(lb_hc.external_ids)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dd39dc34_d509f179","line":2234,"range":{"start_line":2234,"start_character":12,"end_line":2234,"end_character":35},"in_reply_to":"ae15a71e_ee442c9f","updated":"2023-06-23 08:04:03.000000000","message":"Done","commit_id":"e84ca276694226629b2842dc8d08c5be6f252c78"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"49acc52d383e9b85f942fcc52441268e80fd0374","unresolved":true,"context_lines":[{"line_number":2236,"context_line":"                lb_hc_external_ids \u003d copy.deepcopy(lb_hc.external_ids)"},{"line_number":2237,"context_line":"                lb_hc_external_ids[ovn_const.LB_EXT_IDS_HM_VIP] \u003d vip"},{"line_number":2238,"context_line":"                if lb_hc.vip:"},{"line_number":2239,"context_line":"                    port \u003d lb_hc.vip.rsplit(\u0027:\u0027, 1)[1]"},{"line_number":2240,"context_line":"                    vip +\u003d \u0027:\u0027 + port"},{"line_number":2241,"context_line":"                kwargs \u003d {"},{"line_number":2242,"context_line":"                    \u0027vip\u0027: vip,"}],"source_content_type":"text/x-python","patch_set":6,"id":"65f4bb7c_d39f1b17","line":2239,"range":{"start_line":2239,"start_character":27,"end_line":2239,"end_character":54},"updated":"2023-06-28 09:51:44.000000000","message":"this is the same as rsplit(\":\")[-1], right?","commit_id":"e882dcad0b2ce675710cefedc4dc1c9982a025f2"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"b82d03fe59ed9f67b8b71f864931ea21ea88cf67","unresolved":false,"context_lines":[{"line_number":2236,"context_line":"                lb_hc_external_ids \u003d copy.deepcopy(lb_hc.external_ids)"},{"line_number":2237,"context_line":"                lb_hc_external_ids[ovn_const.LB_EXT_IDS_HM_VIP] \u003d vip"},{"line_number":2238,"context_line":"                if lb_hc.vip:"},{"line_number":2239,"context_line":"                    port \u003d lb_hc.vip.rsplit(\u0027:\u0027, 1)[1]"},{"line_number":2240,"context_line":"                    vip +\u003d \u0027:\u0027 + port"},{"line_number":2241,"context_line":"                kwargs \u003d {"},{"line_number":2242,"context_line":"                    \u0027vip\u0027: vip,"}],"source_content_type":"text/x-python","patch_set":6,"id":"74aa5116_a44f2770","line":2239,"range":{"start_line":2239,"start_character":27,"end_line":2239,"end_character":54},"in_reply_to":"65f4bb7c_d39f1b17","updated":"2023-07-04 15:26:17.000000000","message":"Yes, the same, indeed this way looks more efficient than mine.","commit_id":"e882dcad0b2ce675710cefedc4dc1c9982a025f2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"49acc52d383e9b85f942fcc52441268e80fd0374","unresolved":true,"context_lines":[{"line_number":2476,"context_line":""},{"line_number":2477,"context_line":"    def _update_lbhc_vip_port(self, lbhc, vip_port):"},{"line_number":2478,"context_line":"        if lbhc.vip:"},{"line_number":2479,"context_line":"            vip \u003d lbhc.vip.rsplit(\u0027:\u0027, 1)[0] + \u0027:\u0027 + str(vip_port)"},{"line_number":2480,"context_line":"        else:"},{"line_number":2481,"context_line":"            # If initially the lbhc was created with no port info, vip field"},{"line_number":2482,"context_line":"            # will be empty, so get it from lbhc external_ids"}],"source_content_type":"text/x-python","patch_set":6,"id":"63bc4a89_1897ed30","line":2479,"range":{"start_line":2479,"start_character":33,"end_line":2479,"end_character":40},"updated":"2023-06-28 09:51:44.000000000","message":"why you need the 1 here? is not the same lbhc.vip.rsplit(\":\")[0]?","commit_id":"e882dcad0b2ce675710cefedc4dc1c9982a025f2"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"b82d03fe59ed9f67b8b71f864931ea21ea88cf67","unresolved":false,"context_lines":[{"line_number":2476,"context_line":""},{"line_number":2477,"context_line":"    def _update_lbhc_vip_port(self, lbhc, vip_port):"},{"line_number":2478,"context_line":"        if lbhc.vip:"},{"line_number":2479,"context_line":"            vip \u003d lbhc.vip.rsplit(\u0027:\u0027, 1)[0] + \u0027:\u0027 + str(vip_port)"},{"line_number":2480,"context_line":"        else:"},{"line_number":2481,"context_line":"            # If initially the lbhc was created with no port info, vip field"},{"line_number":2482,"context_line":"            # will be empty, so get it from lbhc external_ids"}],"source_content_type":"text/x-python","patch_set":6,"id":"8446a38d_3fd780b1","line":2479,"range":{"start_line":2479,"start_character":33,"end_line":2479,"end_character":40},"in_reply_to":"63bc4a89_1897ed30","updated":"2023-07-04 15:26:17.000000000","message":"The 1 there is to ensure split just one time by the end to cover IPv6 cases. But as done in your previous comment looks more efficient (CPU time) your option.","commit_id":"e882dcad0b2ce675710cefedc4dc1c9982a025f2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f2ca588884a93bd09b502e9060535a0ace02b95b","unresolved":true,"context_lines":[{"line_number":2236,"context_line":"                lb_hc_external_ids \u003d copy.deepcopy(lb_hc.external_ids)"},{"line_number":2237,"context_line":"                lb_hc_external_ids[ovn_const.LB_EXT_IDS_HM_VIP] \u003d vip"},{"line_number":2238,"context_line":"                if lb_hc.vip:"},{"line_number":2239,"context_line":"                    port \u003d lb_hc.vip.rsplit(\u0027:\u0027)[-1]"},{"line_number":2240,"context_line":"                    vip +\u003d \u0027:\u0027 + port"},{"line_number":2241,"context_line":"                kwargs \u003d {"},{"line_number":2242,"context_line":"                    \u0027vip\u0027: vip,"}],"source_content_type":"text/x-python","patch_set":8,"id":"986fa378_9dbb4666","line":2239,"range":{"start_line":2239,"start_character":20,"end_line":2239,"end_character":52},"updated":"2023-07-07 08:34:45.000000000","message":"could it happen that this comes from previously (wrongly) created lb_hc which do not have the port information in there, and you are getting here the IP instead?","commit_id":"e921782abba977b6849833753f91848f81ec0789"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"13ec202f28b6bb443319e23027acfdea2bc9c887","unresolved":false,"context_lines":[{"line_number":2236,"context_line":"                lb_hc_external_ids \u003d copy.deepcopy(lb_hc.external_ids)"},{"line_number":2237,"context_line":"                lb_hc_external_ids[ovn_const.LB_EXT_IDS_HM_VIP] \u003d vip"},{"line_number":2238,"context_line":"                if lb_hc.vip:"},{"line_number":2239,"context_line":"                    port \u003d lb_hc.vip.rsplit(\u0027:\u0027)[-1]"},{"line_number":2240,"context_line":"                    vip +\u003d \u0027:\u0027 + port"},{"line_number":2241,"context_line":"                kwargs \u003d {"},{"line_number":2242,"context_line":"                    \u0027vip\u0027: vip,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ea4184bc_a1cd1d64","line":2239,"range":{"start_line":2239,"start_character":20,"end_line":2239,"end_character":52},"in_reply_to":"986fa378_9dbb4666","updated":"2023-07-13 07:41:50.000000000","message":"Done","commit_id":"e921782abba977b6849833753f91848f81ec0789"}],"ovn_octavia_provider/tests/unit/test_helper.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"908b23ae66fdbba9e736dc4904d4156e7266a36a","unresolved":true,"context_lines":[{"line_number":3190,"context_line":""},{"line_number":3191,"context_line":"    @mock.patch(\u0027ovn_octavia_provider.helper.OvnProviderHelper.\u0027"},{"line_number":3192,"context_line":"                \u0027_find_ovn_lbs\u0027)"},{"line_number":3193,"context_line":"    def test_handle_vip_fip_associate1(self, fb):"},{"line_number":3194,"context_line":"        lb \u003d mock.MagicMock()"},{"line_number":3195,"context_line":"        fip_info \u003d {"},{"line_number":3196,"context_line":"            \u0027action\u0027: \u0027associate\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"c628b0f5_f42a75d8","line":3193,"range":{"start_line":3193,"start_character":37,"end_line":3193,"end_character":38},"updated":"2023-06-22 17:15:20.000000000","message":"this is a typo, right?","commit_id":"e84ca276694226629b2842dc8d08c5be6f252c78"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"13980b00bfbac65b3be27dbbce3924a91ea0b576","unresolved":false,"context_lines":[{"line_number":3190,"context_line":""},{"line_number":3191,"context_line":"    @mock.patch(\u0027ovn_octavia_provider.helper.OvnProviderHelper.\u0027"},{"line_number":3192,"context_line":"                \u0027_find_ovn_lbs\u0027)"},{"line_number":3193,"context_line":"    def test_handle_vip_fip_associate1(self, fb):"},{"line_number":3194,"context_line":"        lb \u003d mock.MagicMock()"},{"line_number":3195,"context_line":"        fip_info \u003d {"},{"line_number":3196,"context_line":"            \u0027action\u0027: \u0027associate\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1d0c1d2f_bfc4e1f2","line":3193,"range":{"start_line":3193,"start_character":37,"end_line":3193,"end_character":38},"in_reply_to":"c628b0f5_f42a75d8","updated":"2023-06-22 17:23:30.000000000","message":"Done","commit_id":"e84ca276694226629b2842dc8d08c5be6f252c78"}],"releasenotes/notes/lbhc-fix-fip-05820d5a9d94a919.yaml":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"49acc52d383e9b85f942fcc52441268e80fd0374","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Load Balancer Health Check for Floating IPs are not populated with the"},{"line_number":5,"context_line":"    protocol port. At this way, when a backend is detected on ERROR state"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4df29322_0d39d3b2","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"updated":"2023-06-28 09:51:44.000000000","message":"this patch is also removing the part of the code that was in charge of creating the HC for the FIPs upon an ovn-octavia upgrade with a previous fix. Will this be handle by performing a or b? Perhaps worth highlighting it as before that was automatically done, and not it requires user interaction","commit_id":"e882dcad0b2ce675710cefedc4dc1c9982a025f2"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"b82d03fe59ed9f67b8b71f864931ea21ea88cf67","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Load Balancer Health Check for Floating IPs are not populated with the"},{"line_number":5,"context_line":"    protocol port. At this way, when a backend is detected on ERROR state"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"653a03b6_559cef4b","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"in_reply_to":"4df29322_0d39d3b2","updated":"2023-07-04 15:26:17.000000000","message":"The complete solution should be run A option, to be sure all required LBHC are created, including the new info in external_ids field. B option will recreate the FIP\u0027s HC but the VIP ones will remain without no new info in external_ids so we can discard it.\n\nThe removed part of the code was not creating all HC for the FIPs when the LB has more than one listener (different listener port) because it was assuming that just 2 HC should exists in case of VIP + FIP.\n\nSo let me thing about a solution on a sync task on installing this version to automatic recreate all existing HC including the new fields in external_ids and ensuring we are getting al VIP and FIP HCs.","commit_id":"e882dcad0b2ce675710cefedc4dc1c9982a025f2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"13ec202f28b6bb443319e23027acfdea2bc9c887","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Load Balancer Health Check for Floating IPs are not populated with the"},{"line_number":5,"context_line":"    protocol port. At this way, when a backend is detected on ERROR state"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8d2b6f09_5defe05a","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"in_reply_to":"653a03b6_559cef4b","updated":"2023-07-13 07:41:50.000000000","message":"Done","commit_id":"e882dcad0b2ce675710cefedc4dc1c9982a025f2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"49acc52d383e9b85f942fcc52441268e80fd0374","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    available:"},{"line_number":9,"context_line":"    a) Recreate the entire Health Monitor, this will recreate any Load Balancer"},{"line_number":10,"context_line":"    Health Check associated with it. (Recommended)"},{"line_number":11,"context_line":"    b) Reattach the Floating IP to the LB VIP port"},{"line_number":12,"context_line":"fixes:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    [`bug 1997418 \u003chttps://bugs.launchpad.net/neutron/+bug/1997418\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6a897047_08bb083d","line":11,"range":{"start_line":11,"start_character":7,"end_line":11,"end_character":50},"updated":"2023-06-28 09:51:44.000000000","message":"what is the caveat of this option? why a) is recommended? if there is an issue with this option, worth to add it here too","commit_id":"e882dcad0b2ce675710cefedc4dc1c9982a025f2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"13ec202f28b6bb443319e23027acfdea2bc9c887","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    available:"},{"line_number":9,"context_line":"    a) Recreate the entire Health Monitor, this will recreate any Load Balancer"},{"line_number":10,"context_line":"    Health Check associated with it. (Recommended)"},{"line_number":11,"context_line":"    b) Reattach the Floating IP to the LB VIP port"},{"line_number":12,"context_line":"fixes:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    [`bug 1997418 \u003chttps://bugs.launchpad.net/neutron/+bug/1997418\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"147969f4_40a1b766","line":11,"range":{"start_line":11,"start_character":7,"end_line":11,"end_character":50},"in_reply_to":"6a897047_08bb083d","updated":"2023-07-13 07:41:50.000000000","message":"Done","commit_id":"e882dcad0b2ce675710cefedc4dc1c9982a025f2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f2ca588884a93bd09b502e9060535a0ace02b95b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Load Balancer Health Check for Floating IPs are not populated with the"},{"line_number":5,"context_line":"    protocol port. At this way, when a backend is detected on ERROR state"},{"line_number":6,"context_line":"    requests to the Floating IP are still distribute to the ERROR\u0027ed members."},{"line_number":7,"context_line":"    In order to fix the existing Load Balancer Health Checks should be required"},{"line_number":8,"context_line":"    to recreate the entire Health Monitor, this will recreate any Load Balancer"},{"line_number":9,"context_line":"    Health Check associated with it."},{"line_number":10,"context_line":"fixes:"},{"line_number":11,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"4a488b37_b1324cad","line":8,"range":{"start_line":7,"start_character":61,"end_line":8,"end_character":16},"updated":"2023-07-07 08:34:45.000000000","message":"nit, perhaps rephrase it to make it more clear: \nIn order to fix the existing Load Balancer Health Checks it is required to recreate the entire Octavia Health Monitor, which will recreate the associated OVN Load Balancer Health Check(s).","commit_id":"e921782abba977b6849833753f91848f81ec0789"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"13ec202f28b6bb443319e23027acfdea2bc9c887","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Load Balancer Health Check for Floating IPs are not populated with the"},{"line_number":5,"context_line":"    protocol port. At this way, when a backend is detected on ERROR state"},{"line_number":6,"context_line":"    requests to the Floating IP are still distribute to the ERROR\u0027ed members."},{"line_number":7,"context_line":"    In order to fix the existing Load Balancer Health Checks should be required"},{"line_number":8,"context_line":"    to recreate the entire Health Monitor, this will recreate any Load Balancer"},{"line_number":9,"context_line":"    Health Check associated with it."},{"line_number":10,"context_line":"fixes:"},{"line_number":11,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"6bb533a9_98b15139","line":8,"range":{"start_line":7,"start_character":61,"end_line":8,"end_character":16},"in_reply_to":"4a488b37_b1324cad","updated":"2023-07-13 07:41:50.000000000","message":"Done","commit_id":"e921782abba977b6849833753f91848f81ec0789"}]}