)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"dd5e8421913b4df86cb6ecff4de84d8d01cf635d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Fernando Royo \u003cfroyo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-06-23 17:14:33 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"On HM delete request update related pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a HM is delete, Octavia API will block the related"},{"line_number":10,"context_line":"pool with a provision_status to PENDING_UPDATE, waiting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0b8ea955_dbfe960e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":40},"updated":"2023-06-28 10:04:44.000000000","message":"perhaps better as:\nUpdate pool upon HM deletion request","commit_id":"d389e4a9a55927ca05b2696c7ba3f4fc53da6d03"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"0a50baf72e3bddd5bc721eea6758f597bed92975","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Fernando Royo \u003cfroyo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-06-23 17:14:33 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"On HM delete request update related pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a HM is delete, Octavia API will block the related"},{"line_number":10,"context_line":"pool with a provision_status to PENDING_UPDATE, waiting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7d64618a_eb23c398","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":40},"in_reply_to":"0b8ea955_dbfe960e","updated":"2023-07-07 08:06:07.000000000","message":"Done","commit_id":"d389e4a9a55927ca05b2696c7ba3f4fc53da6d03"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"dd5e8421913b4df86cb6ecff4de84d8d01cf635d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"On HM delete request update related pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a HM is delete, Octavia API will block the related"},{"line_number":10,"context_line":"pool with a provision_status to PENDING_UPDATE, waiting"},{"line_number":11,"context_line":"for the new status after finish the HM delete action on the"},{"line_number":12,"context_line":"provider. When multiple pools are attached to a LB, this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fc454871_468b96a8","line":9,"range":{"start_line":9,"start_character":13,"end_line":9,"end_character":20},"updated":"2023-06-28 10:04:44.000000000","message":"deleted","commit_id":"d389e4a9a55927ca05b2696c7ba3f4fc53da6d03"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"0a50baf72e3bddd5bc721eea6758f597bed92975","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"On HM delete request update related pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a HM is delete, Octavia API will block the related"},{"line_number":10,"context_line":"pool with a provision_status to PENDING_UPDATE, waiting"},{"line_number":11,"context_line":"for the new status after finish the HM delete action on the"},{"line_number":12,"context_line":"provider. When multiple pools are attached to a LB, this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ce1c9b41_188d8d3e","line":9,"range":{"start_line":9,"start_character":13,"end_line":9,"end_character":20},"in_reply_to":"fc454871_468b96a8","updated":"2023-07-07 08:06:07.000000000","message":"Done","commit_id":"d389e4a9a55927ca05b2696c7ba3f4fc53da6d03"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"dd5e8421913b4df86cb6ecff4de84d8d01cf635d","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a HM is delete, Octavia API will block the related"},{"line_number":10,"context_line":"pool with a provision_status to PENDING_UPDATE, waiting"},{"line_number":11,"context_line":"for the new status after finish the HM delete action on the"},{"line_number":12,"context_line":"provider. When multiple pools are attached to a LB, this"},{"line_number":13,"context_line":"status is sending for the first pool obtained, keeping the"},{"line_number":14,"context_line":"related pool in PENDING_UPDATE."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"13a2ce2c_1ba191dc","line":11,"updated":"2023-06-28 10:04:44.000000000","message":"after finishing the HM deletion","commit_id":"d389e4a9a55927ca05b2696c7ba3f4fc53da6d03"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"0a50baf72e3bddd5bc721eea6758f597bed92975","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a HM is delete, Octavia API will block the related"},{"line_number":10,"context_line":"pool with a provision_status to PENDING_UPDATE, waiting"},{"line_number":11,"context_line":"for the new status after finish the HM delete action on the"},{"line_number":12,"context_line":"provider. When multiple pools are attached to a LB, this"},{"line_number":13,"context_line":"status is sending for the first pool obtained, keeping the"},{"line_number":14,"context_line":"related pool in PENDING_UPDATE."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8d087d4e_5223fe58","line":11,"in_reply_to":"13a2ce2c_1ba191dc","updated":"2023-07-07 08:06:07.000000000","message":"Done","commit_id":"d389e4a9a55927ca05b2696c7ba3f4fc53da6d03"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"dd5e8421913b4df86cb6ecff4de84d8d01cf635d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"pool with a provision_status to PENDING_UPDATE, waiting"},{"line_number":11,"context_line":"for the new status after finish the HM delete action on the"},{"line_number":12,"context_line":"provider. When multiple pools are attached to a LB, this"},{"line_number":13,"context_line":"status is sending for the first pool obtained, keeping the"},{"line_number":14,"context_line":"related pool in PENDING_UPDATE."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch ensures that the update status sent by the ovn"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"95522fdc_2dcb6f5b","line":13,"updated":"2023-06-28 10:04:44.000000000","message":"status is sent","commit_id":"d389e4a9a55927ca05b2696c7ba3f4fc53da6d03"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"0a50baf72e3bddd5bc721eea6758f597bed92975","unresolved":false,"context_lines":[{"line_number":10,"context_line":"pool with a provision_status to PENDING_UPDATE, waiting"},{"line_number":11,"context_line":"for the new status after finish the HM delete action on the"},{"line_number":12,"context_line":"provider. When multiple pools are attached to a LB, this"},{"line_number":13,"context_line":"status is sending for the first pool obtained, keeping the"},{"line_number":14,"context_line":"related pool in PENDING_UPDATE."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch ensures that the update status sent by the ovn"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"17276dd5_6f3a8442","line":13,"in_reply_to":"95522fdc_2dcb6f5b","updated":"2023-07-07 08:06:07.000000000","message":"Done","commit_id":"d389e4a9a55927ca05b2696c7ba3f4fc53da6d03"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"dd5e8421913b4df86cb6ecff4de84d8d01cf635d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e0f51a92_f11db281","updated":"2023-06-28 10:04:44.000000000","message":"I\u0027m not sure I\u0027m getting this, what is the relation betweeh the pool_id_related (the id of the pool passed on the call) and the pool_id?\n\nIf I get it right, get_pool_key(pool_id_related) is just adding the prefix \"pool_\" that is being removed when getting the pool_id, so I\u0027m not sure why it matters the change from \"if pool_id\" to \"if pool_id_related\".\n\nI\u0027m assuming the main change here is that before we were just looking for the \"pool_\" prefix, and now we are looking for the right id.","commit_id":"d389e4a9a55927ca05b2696c7ba3f4fc53da6d03"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"0a50baf72e3bddd5bc721eea6758f597bed92975","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6756bc50_536c85a5","in_reply_to":"e0f51a92_f11db281","updated":"2023-07-07 08:06:07.000000000","message":"yeah, you are right! I will update the patch replacing the references to pool_id ---\u003e pool_id_related (pool attached to HM passed on the call)","commit_id":"d389e4a9a55927ca05b2696c7ba3f4fc53da6d03"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"df7e19c1ed46916a3204fe8ba8eb02d3e4785249","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0ff2f384_49904690","updated":"2023-07-07 08:24:41.000000000","message":"LGTM, my only concern is that we are removing the part of the code that controls the missing pool_id, not sure if that was not needed or there is an actual need for this","commit_id":"edaf8ec4469147461bb46b30afcfc9519eef3c67"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a2a15a0a7413688a5ffcde75b75f20a8c4d4abee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1911f9f2_2c8d3770","updated":"2023-07-07 08:28:29.000000000","message":"after discussion, it seems it is not needed, so it LGTM","commit_id":"edaf8ec4469147461bb46b30afcfc9519eef3c67"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"00c57178dd89fb7972fad532dfdf3f25a620e2cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cbfc868a_1115d90a","updated":"2023-07-13 10:45:48.000000000","message":"recheck ovn-octavia-provider-functional-master unrelated","commit_id":"edaf8ec4469147461bb46b30afcfc9519eef3c67"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"32e80884a325fb925603aef46be3521e8b415b10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e50a0ad0_c381213e","in_reply_to":"0ff2f384_49904690","updated":"2023-07-07 08:30:38.000000000","message":"if the pool is missing probably the pool has been deleted previously, and that action the first step is to delete the HM associated (if it exists) [1]. So I think we can trust on the pool_id passed on the call.\n\nhttps://opendev.org/openstack/ovn-octavia-provider/src/branch/master/ovn_octavia_provider/driver.py#L149","commit_id":"edaf8ec4469147461bb46b30afcfc9519eef3c67"}]}