)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"6e77ee75c611affb4304166552333b337accc755","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"83eb888c_e3a4ee1c","updated":"2023-10-05 07:59:11.000000000","message":"Code looks ok, but this change should depend on the neutron modification to handle that device owner as a distributed port","commit_id":"c1bcc890fafe128d8248f48ea8d06e714234e1f5"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0b5991fec8f981c706115880d34d33d7fe1d0095","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3ac9ea6b_14e26240","updated":"2023-10-05 11:10:26.000000000","message":"-1 to ensure discussion","commit_id":"b4a982ac32e78bf37e35a24bc321070afcad4fb6"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"214da1563b22e5ca10f21287c4a8d095e168beeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"44cfd56b_5c6cbfaa","updated":"2023-10-05 11:11:50.000000000","message":"It seems though that the old ports will still be recognized by ovn-octavia, so I think it can be handle in a follow up patch","commit_id":"b4a982ac32e78bf37e35a24bc321070afcad4fb6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2a72a16d57765368f22d2a025835fc9c36cce9ac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4039ff45_798b8678","updated":"2023-10-05 11:08:46.000000000","message":"What about the pre-existing LBs with network:distributed? Will there be some background task to change device_owner - or should there be a reno to ask users to recreate their LBs?","commit_id":"b4a982ac32e78bf37e35a24bc321070afcad4fb6"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"987f79b746781ab68d6d9aa0336d1fa6af4b21f2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e3cd5ad6_62953301","in_reply_to":"063aeefa_16e76814","updated":"2023-10-05 12:23:20.000000000","message":"yeah, that was the idea. Implement some maintenance task to update any existing port with the new values.","commit_id":"b4a982ac32e78bf37e35a24bc321070afcad4fb6"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0b5991fec8f981c706115880d34d33d7fe1d0095","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"063aeefa_16e76814","in_reply_to":"4039ff45_798b8678","updated":"2023-10-05 11:10:26.000000000","message":"right! that is true. I think the plan was doing something similar to maintenance task in neutron, I suppose in a follow up patch set","commit_id":"b4a982ac32e78bf37e35a24bc321070afcad4fb6"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"27448e9e5fe28bf0ef51b24a8f5162eab4941f80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"eb5ef9f2_092faa32","updated":"2023-10-13 10:56:01.000000000","message":"recheck openstack-tox-py39 unrelated","commit_id":"c1915ddfe55bf7b00c1a36f31eb7952813434ee7"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"8a42afc5c38d79a0e63625c304e7ea159a8170a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4cadc610_740d6760","updated":"2023-10-13 14:00:17.000000000","message":"perhaps more than closes-bug is related to bug, right? as you need to other dependent changes for close it, right?","commit_id":"afed1dff06d121f8c4d770cb838a39633ebfd86e"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"76ee0d0edc324905e8b83094f94db3e687b17192","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c95c0c78_54c2e533","in_reply_to":"4cadc610_740d6760","updated":"2023-10-13 14:06:18.000000000","message":"This patch and the one related to Neutron [1] are required to close the bug completely. This other one [2] might make more sense to mark it as Related-Bug, instead of Closes-Bug.\n\n[1] https://review.opendev.org/c/openstack/neutron/+/897345\n[2] https://review.opendev.org/c/openstack/ovn-octavia-provider/+/897858","commit_id":"afed1dff06d121f8c4d770cb838a39633ebfd86e"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"8b9ad21134bea748bdc8ef6a05e5003097281f9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f546aedc_09af414d","updated":"2023-10-18 09:11:14.000000000","message":"recheck just to confirm tempest are failing","commit_id":"e2dbc59be51597adbc54838fc5367a49b19ad5a2"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"23295c590aafef17dcdf7c9425bd3d7a54ced938","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e3e93a76_934050a6","updated":"2023-10-18 15:37:33.000000000","message":"recheck ovn-octavia-provider-functional-release unrelated","commit_id":"e2dbc59be51597adbc54838fc5367a49b19ad5a2"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"495358eca525834519552c555011c547585763ee","unresolved":true,"context_lines":[{"line_number":140,"context_line":"                \u0027fixed_ips\u0027: [{\u0027subnet_id\u0027: subnet_id}],"},{"line_number":141,"context_line":"                \u0027admin_state_up\u0027: True,"},{"line_number":142,"context_line":"                \u0027port_security_enabled\u0027: False,"},{"line_number":143,"context_line":"                \u0027device_owner\u0027: ovn_const.OVN_LB_HM_PORT_DISTRIBUTED,"},{"line_number":144,"context_line":"                \u0027project_id\u0027: project_id}"},{"line_number":145,"context_line":"        neutron_client \u003d clients.get_neutron_client()"},{"line_number":146,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9dec119e_2bf82af5","line":143,"range":{"start_line":143,"start_character":16,"end_line":143,"end_character":69},"updated":"2023-10-05 08:29:03.000000000","message":"as mentioned in the other patch, perhaps worth to include device_id too","commit_id":"88586129cfbac60d70445399e8c3f006e39debd5"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"54f99c209cf51ca5d50e373665fd69b12f09698e","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                \u0027fixed_ips\u0027: [{\u0027subnet_id\u0027: subnet_id}],"},{"line_number":141,"context_line":"                \u0027admin_state_up\u0027: True,"},{"line_number":142,"context_line":"                \u0027port_security_enabled\u0027: False,"},{"line_number":143,"context_line":"                \u0027device_owner\u0027: ovn_const.OVN_LB_HM_PORT_DISTRIBUTED,"},{"line_number":144,"context_line":"                \u0027project_id\u0027: project_id}"},{"line_number":145,"context_line":"        neutron_client \u003d clients.get_neutron_client()"},{"line_number":146,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"cb422999_97cdd0aa","line":143,"range":{"start_line":143,"start_character":16,"end_line":143,"end_character":69},"in_reply_to":"9dec119e_2bf82af5","updated":"2023-10-05 10:42:25.000000000","message":"Done","commit_id":"88586129cfbac60d70445399e8c3f006e39debd5"}]}