)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"14845a24e501124025836735aa7605e6d94fd623","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"925f139f_c10406b8","updated":"2023-10-11 05:44:05.000000000","message":"perhaps this requires a release note about the addition of maintenance tasks framework","commit_id":"5cd756e10f6bd39839b0d8e552c52282a617e7bf"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"a8b137c4d7bced2fe507297f98234413090532e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4c1d5ec0_d291c90f","in_reply_to":"925f139f_c10406b8","updated":"2023-10-11 07:00:13.000000000","message":"yeah, good point!","commit_id":"5cd756e10f6bd39839b0d8e552c52282a617e7bf"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"123dd886b5e4c424e36d8eb0ae18b601627b031b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ed61e9d3_5d276779","updated":"2023-10-11 08:16:30.000000000","message":"Just some nit on the release notes","commit_id":"64c5af6a0e604f6a30eb04bd3a2aa30b9d69a130"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e356d5648f76f260242e905cc7d5d9f7c4b80e3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"719cb511_885b5ab1","updated":"2023-10-17 07:58:05.000000000","message":"maintenance task should keep checking to avoid issues during upgrades: periodics.NeverAgain()","commit_id":"9a41ca5f0df5dd62bbb69f6a0781e3c7f6493524"}],"ovn_octavia_provider/maintenance.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"14845a24e501124025836735aa7605e6d94fd623","unresolved":true,"context_lines":[{"line_number":79,"context_line":"            device_owner\u003dn_const.DEVICE_OWNER_DISTRIBUTED)"},{"line_number":80,"context_line":"        for port in ovn_lb_hm_ports:"},{"line_number":81,"context_line":"            if port.name.startswith(\u0027ovn-lb-hm\u0027):"},{"line_number":82,"context_line":"                LOG.debug(\u0027Maintenance task: changing port id %s\u0027, port.id)"},{"line_number":83,"context_line":"                neutron_client.update_port("},{"line_number":84,"context_line":"                    port.id, device_owner\u003dovn_const.OVN_LB_HM_PORT_DISTRIBUTED,"},{"line_number":85,"context_line":"                    device_id\u003dport.name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f3cfe857_4a10dc76","line":82,"range":{"start_line":82,"start_character":27,"end_line":82,"end_character":69},"updated":"2023-10-11 05:44:05.000000000","message":"perhaps a more clear message is needed, for instance: \"Maintenance task: changing device owner for port id %s\"","commit_id":"5cd756e10f6bd39839b0d8e552c52282a617e7bf"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"a8b137c4d7bced2fe507297f98234413090532e4","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            device_owner\u003dn_const.DEVICE_OWNER_DISTRIBUTED)"},{"line_number":80,"context_line":"        for port in ovn_lb_hm_ports:"},{"line_number":81,"context_line":"            if port.name.startswith(\u0027ovn-lb-hm\u0027):"},{"line_number":82,"context_line":"                LOG.debug(\u0027Maintenance task: changing port id %s\u0027, port.id)"},{"line_number":83,"context_line":"                neutron_client.update_port("},{"line_number":84,"context_line":"                    port.id, device_owner\u003dovn_const.OVN_LB_HM_PORT_DISTRIBUTED,"},{"line_number":85,"context_line":"                    device_id\u003dport.name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"b922dae1_0f1feaad","line":82,"range":{"start_line":82,"start_character":27,"end_line":82,"end_character":69},"in_reply_to":"f3cfe857_4a10dc76","updated":"2023-10-11 07:00:13.000000000","message":"Done","commit_id":"5cd756e10f6bd39839b0d8e552c52282a617e7bf"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"14845a24e501124025836735aa7605e6d94fd623","unresolved":true,"context_lines":[{"line_number":82,"context_line":"                LOG.debug(\u0027Maintenance task: changing port id %s\u0027, port.id)"},{"line_number":83,"context_line":"                neutron_client.update_port("},{"line_number":84,"context_line":"                    port.id, device_owner\u003dovn_const.OVN_LB_HM_PORT_DISTRIBUTED,"},{"line_number":85,"context_line":"                    device_id\u003dport.name)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        LOG.debug(\u0027Maintenance task: Changing device_owner to OVN LB HM ports \u0027"},{"line_number":88,"context_line":"                  \u0027finished.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"227c62fe_e481e92c","line":85,"range":{"start_line":85,"start_character":19,"end_line":85,"end_character":40},"updated":"2023-10-11 05:44:05.000000000","message":"perhaps a note about also adding a device_id is needed","commit_id":"5cd756e10f6bd39839b0d8e552c52282a617e7bf"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"a8b137c4d7bced2fe507297f98234413090532e4","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                LOG.debug(\u0027Maintenance task: changing port id %s\u0027, port.id)"},{"line_number":83,"context_line":"                neutron_client.update_port("},{"line_number":84,"context_line":"                    port.id, device_owner\u003dovn_const.OVN_LB_HM_PORT_DISTRIBUTED,"},{"line_number":85,"context_line":"                    device_id\u003dport.name)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        LOG.debug(\u0027Maintenance task: Changing device_owner to OVN LB HM ports \u0027"},{"line_number":88,"context_line":"                  \u0027finished.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9844d9cd_55ed5557","line":85,"range":{"start_line":85,"start_character":19,"end_line":85,"end_character":40},"in_reply_to":"227c62fe_e481e92c","updated":"2023-10-11 07:00:13.000000000","message":"Done","commit_id":"5cd756e10f6bd39839b0d8e552c52282a617e7bf"}],"ovn_octavia_provider/releasenotes/notes/maintenance-task-framework-a366242c89f5af11.yaml":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"123dd886b5e4c424e36d8eb0ae18b601627b031b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    Additionally, the \"device_id\" will be populated during update action."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Additionally, this way of working on periodic and one-shot tasks will allow"},{"line_number":11,"context_line":"    for future changes that may require the addition, modification, or deletion"},{"line_number":12,"context_line":"    of existing entities."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"eef4edc3_2f247e9a","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":19},"updated":"2023-10-11 08:16:30.000000000","message":"this sections are separated in the docs, so you cannot assume the other one has been read. This should be something like: \"A maintenance task thread has been added to work on periodic and one-shot tasks that also allows the future changes to perform the needed upgrades actions\"","commit_id":"64c5af6a0e604f6a30eb04bd3a2aa30b9d69a130"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"b812ec74c617e2057d49735ea3f3a8ba40661f40","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    Additionally, the \"device_id\" will be populated during update action."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Additionally, this way of working on periodic and one-shot tasks will allow"},{"line_number":11,"context_line":"    for future changes that may require the addition, modification, or deletion"},{"line_number":12,"context_line":"    of existing entities."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"65c5f461_92982804","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":19},"in_reply_to":"eef4edc3_2f247e9a","updated":"2023-10-11 09:41:30.000000000","message":"Done","commit_id":"64c5af6a0e604f6a30eb04bd3a2aa30b9d69a130"}]}
