)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb6a235421624b241df1bf2aa16e826a16ba29d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fab9a93a_28e7d7dc","updated":"2023-12-22 11:09:52.000000000","message":"Imports sections should be fixed but as it was not correct before this patch too, we can fix it in follow up patch","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"4074b0895ba680989e6119d44a9242c201241c44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c0778b19_ae55e92f","updated":"2023-12-21 12:18:32.000000000","message":"LGTM, just a small nit in case a respin is needed","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"9c2f67745d45c5626df38d0ac857b05bf491389f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d93d45dd_a6b0a3e5","updated":"2023-12-21 12:11:33.000000000","message":"recheck ovn-octavia-provider-functional-master","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"dc48c15c9ba4090d9905bba31f81745bcbb6a699","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c4b6c16c_5f00e27a","updated":"2023-12-22 12:20:14.000000000","message":"taking advantage of the recheck, done all changes proposed in reviews","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"30e64c934a9a1302f31fb59e5c81f2755b80ffba","unresolved":true,"context_lines":[{"line_number":997,"context_line":"                        lb_vip \u003d f\u0027[{lb_vip}]\u0027"},{"line_number":998,"context_line":"                        vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v6)"},{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"                if vip_fip:"},{"line_number":1001,"context_line":"                    if netaddr.IPNetwork(vip_fip).version \u003d\u003d 6:"},{"line_number":1002,"context_line":"                        vip_fip \u003d f\u0027[{vip_fip}]\u0027"},{"line_number":1003,"context_line":"                        vip_ips[vip_fip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v6)"},{"line_number":1004,"context_line":""},{"line_number":1005,"context_line":"                if additional_vip_fips:"},{"line_number":1006,"context_line":"                    for addi_vip_fip in additional_vip_fips.split(\u0027,\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d289fee3_b3352854","line":1003,"range":{"start_line":1000,"start_character":1,"end_line":1003,"end_character":76},"updated":"2023-12-21 06:42:24.000000000","message":"we cannot have vip to fip for ipv6 vips","commit_id":"216e37d500fbb5fa82ca0f2e0c33198f55019293"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"afc8add5908d3a4fb64bd6a03cefe534cab8d0b2","unresolved":false,"context_lines":[{"line_number":997,"context_line":"                        lb_vip \u003d f\u0027[{lb_vip}]\u0027"},{"line_number":998,"context_line":"                        vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v6)"},{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"                if vip_fip:"},{"line_number":1001,"context_line":"                    if netaddr.IPNetwork(vip_fip).version \u003d\u003d 6:"},{"line_number":1002,"context_line":"                        vip_fip \u003d f\u0027[{vip_fip}]\u0027"},{"line_number":1003,"context_line":"                        vip_ips[vip_fip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v6)"},{"line_number":1004,"context_line":""},{"line_number":1005,"context_line":"                if additional_vip_fips:"},{"line_number":1006,"context_line":"                    for addi_vip_fip in additional_vip_fips.split(\u0027,\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"64608adc_ce723945","line":1003,"range":{"start_line":1000,"start_character":1,"end_line":1003,"end_character":76},"in_reply_to":"d289fee3_b3352854","updated":"2023-12-21 10:18:34.000000000","message":"Done","commit_id":"216e37d500fbb5fa82ca0f2e0c33198f55019293"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"30e64c934a9a1302f31fb59e5c81f2755b80ffba","unresolved":true,"context_lines":[{"line_number":1002,"context_line":"                        vip_fip \u003d f\u0027[{vip_fip}]\u0027"},{"line_number":1003,"context_line":"                        vip_ips[vip_fip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v6)"},{"line_number":1004,"context_line":""},{"line_number":1005,"context_line":"                if additional_vip_fips:"},{"line_number":1006,"context_line":"                    for addi_vip_fip in additional_vip_fips.split(\u0027,\u0027):"},{"line_number":1007,"context_line":"                        if netaddr.IPNetwork(addi_vip_fip).version \u003d\u003d 6:"},{"line_number":1008,"context_line":"                            addi_vip_fip \u003d f\u0027[{addi_vip_fip}]\u0027"},{"line_number":1009,"context_line":"                            vip_ips[addi_vip_fip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join("},{"line_number":1010,"context_line":"                                ips_v6)"},{"line_number":1011,"context_line":"        return vip_ips"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    def _refresh_lb_vips(self, ovn_lb, lb_external_ids):"}],"source_content_type":"text/x-python","patch_set":1,"id":"91e4d882_b6972c3d","line":1010,"range":{"start_line":1005,"start_character":3,"end_line":1010,"end_character":39},"updated":"2023-12-21 06:42:24.000000000","message":"ditto","commit_id":"216e37d500fbb5fa82ca0f2e0c33198f55019293"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"afc8add5908d3a4fb64bd6a03cefe534cab8d0b2","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"                        vip_fip \u003d f\u0027[{vip_fip}]\u0027"},{"line_number":1003,"context_line":"                        vip_ips[vip_fip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v6)"},{"line_number":1004,"context_line":""},{"line_number":1005,"context_line":"                if additional_vip_fips:"},{"line_number":1006,"context_line":"                    for addi_vip_fip in additional_vip_fips.split(\u0027,\u0027):"},{"line_number":1007,"context_line":"                        if netaddr.IPNetwork(addi_vip_fip).version \u003d\u003d 6:"},{"line_number":1008,"context_line":"                            addi_vip_fip \u003d f\u0027[{addi_vip_fip}]\u0027"},{"line_number":1009,"context_line":"                            vip_ips[addi_vip_fip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join("},{"line_number":1010,"context_line":"                                ips_v6)"},{"line_number":1011,"context_line":"        return vip_ips"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    def _refresh_lb_vips(self, ovn_lb, lb_external_ids):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4c540a43_f4d74e00","line":1010,"range":{"start_line":1005,"start_character":3,"end_line":1010,"end_character":39},"in_reply_to":"91e4d882_b6972c3d","updated":"2023-12-21 10:18:34.000000000","message":"Done","commit_id":"216e37d500fbb5fa82ca0f2e0c33198f55019293"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"4480443a287c7317aecbdb42d5f80272537489d4","unresolved":true,"context_lines":[{"line_number":977,"context_line":"                        ips_v6.append(f\u0027[{mb_ip}]:{mb_port}\u0027)"},{"line_number":978,"context_line":"                    else:"},{"line_number":979,"context_line":"                        ips_v4.append(f\u0027{mb_ip}:{mb_port}\u0027)"},{"line_number":980,"context_line":"            if ips_v4:"},{"line_number":981,"context_line":"                for lb_vip in lb_vips:"},{"line_number":982,"context_line":"                    if netaddr.IPNetwork(lb_vip).version \u003d\u003d 4:"},{"line_number":983,"context_line":"                        vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v4)"},{"line_number":984,"context_line":""},{"line_number":985,"context_line":"                if vip_fip:"},{"line_number":986,"context_line":"                    if netaddr.IPNetwork(vip_fip).version \u003d\u003d 4:"},{"line_number":987,"context_line":"                        vip_ips[vip_fip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v4)"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"                if additional_vip_fips:"},{"line_number":990,"context_line":"                    for addi_vip_fip in additional_vip_fips.split(\u0027,\u0027):"},{"line_number":991,"context_line":"                        if netaddr.IPNetwork(addi_vip_fip).version \u003d\u003d 4:"},{"line_number":992,"context_line":"                            vip_ips[addi_vip_fip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join("},{"line_number":993,"context_line":"                                ips_v4)"},{"line_number":994,"context_line":"            if ips_v6:"},{"line_number":995,"context_line":"                for lb_vip in lb_vips:"},{"line_number":996,"context_line":"                    if netaddr.IPNetwork(lb_vip).version \u003d\u003d 6:"},{"line_number":997,"context_line":"                        lb_vip \u003d f\u0027[{lb_vip}]\u0027"},{"line_number":998,"context_line":"                        vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v6)"},{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"        return vip_ips"},{"line_number":1001,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"91061c93_c2307f1d","line":998,"range":{"start_line":980,"start_character":0,"end_line":998,"end_character":75},"updated":"2023-12-21 10:09:31.000000000","message":"perhaps we could avoid extra checkings by doing it like:\n\nfor lb_vip in lb_vips:\n    if ips_v4 and netaddr.IPNetwork(lb_vip).version \u003d\u003d 4:\n        vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v4)\n    if ips_v6 and netaddr.IPNetwork(lb_vip).version \u003d\u003d 6:\n        vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v6)\n\nif ips_v4 and vip_fip:\n    if netaddr.IPNetwork(vip_fip).version \u003d\u003d 4:\n        vip_ips[vip_fip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v4)\n\nif ips_v4 and additional_vip_fips:\n    for addi_vip_fip in additional_vip_fips.split(\u0027,\u0027):\n        if netaddr.IPNetwork(addi_vip_fip).version \u003d\u003d 4:\n            vip_ips[addi_vip_fip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v4)","commit_id":"51e6101250cc35dde3b646947934460836260f17"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"07971697a73688374b139bdad5964a8701068119","unresolved":false,"context_lines":[{"line_number":977,"context_line":"                        ips_v6.append(f\u0027[{mb_ip}]:{mb_port}\u0027)"},{"line_number":978,"context_line":"                    else:"},{"line_number":979,"context_line":"                        ips_v4.append(f\u0027{mb_ip}:{mb_port}\u0027)"},{"line_number":980,"context_line":"            if ips_v4:"},{"line_number":981,"context_line":"                for lb_vip in lb_vips:"},{"line_number":982,"context_line":"                    if netaddr.IPNetwork(lb_vip).version \u003d\u003d 4:"},{"line_number":983,"context_line":"                        vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v4)"},{"line_number":984,"context_line":""},{"line_number":985,"context_line":"                if vip_fip:"},{"line_number":986,"context_line":"                    if netaddr.IPNetwork(vip_fip).version \u003d\u003d 4:"},{"line_number":987,"context_line":"                        vip_ips[vip_fip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v4)"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"                if additional_vip_fips:"},{"line_number":990,"context_line":"                    for addi_vip_fip in additional_vip_fips.split(\u0027,\u0027):"},{"line_number":991,"context_line":"                        if netaddr.IPNetwork(addi_vip_fip).version \u003d\u003d 4:"},{"line_number":992,"context_line":"                            vip_ips[addi_vip_fip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join("},{"line_number":993,"context_line":"                                ips_v4)"},{"line_number":994,"context_line":"            if ips_v6:"},{"line_number":995,"context_line":"                for lb_vip in lb_vips:"},{"line_number":996,"context_line":"                    if netaddr.IPNetwork(lb_vip).version \u003d\u003d 6:"},{"line_number":997,"context_line":"                        lb_vip \u003d f\u0027[{lb_vip}]\u0027"},{"line_number":998,"context_line":"                        vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v6)"},{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"        return vip_ips"},{"line_number":1001,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a02b626_4a03fad2","line":998,"range":{"start_line":980,"start_character":0,"end_line":998,"end_character":75},"in_reply_to":"91061c93_c2307f1d","updated":"2023-12-21 10:18:25.000000000","message":"Done, adding the [ ] for the ipv6, thx!","commit_id":"51e6101250cc35dde3b646947934460836260f17"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb6a235421624b241df1bf2aa16e826a16ba29d8","unresolved":true,"context_lines":[{"line_number":973,"context_line":"            for mb_ip, mb_port, mb_subnet, mb_id in self._extract_member_info("},{"line_number":974,"context_line":"                    lb_external_ids[pool_id]):"},{"line_number":975,"context_line":"                if not self._is_member_offline(ovn_lb, mb_id):"},{"line_number":976,"context_line":"                    if netaddr.IPNetwork(mb_ip).version \u003d\u003d 6:"},{"line_number":977,"context_line":"                        ips_v6.append(f\u0027[{mb_ip}]:{mb_port}\u0027)"},{"line_number":978,"context_line":"                    else:"},{"line_number":979,"context_line":"                        ips_v4.append(f\u0027{mb_ip}:{mb_port}\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4bd0309e_09f9f03a","line":976,"range":{"start_line":976,"start_character":58,"end_line":976,"end_character":60},"updated":"2023-12-22 11:09:52.000000000","message":"please change to use IP_VERSION_6 constant here","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"dc48c15c9ba4090d9905bba31f81745bcbb6a699","unresolved":false,"context_lines":[{"line_number":973,"context_line":"            for mb_ip, mb_port, mb_subnet, mb_id in self._extract_member_info("},{"line_number":974,"context_line":"                    lb_external_ids[pool_id]):"},{"line_number":975,"context_line":"                if not self._is_member_offline(ovn_lb, mb_id):"},{"line_number":976,"context_line":"                    if netaddr.IPNetwork(mb_ip).version \u003d\u003d 6:"},{"line_number":977,"context_line":"                        ips_v6.append(f\u0027[{mb_ip}]:{mb_port}\u0027)"},{"line_number":978,"context_line":"                    else:"},{"line_number":979,"context_line":"                        ips_v4.append(f\u0027{mb_ip}:{mb_port}\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"05a0a91a_1d4c2e67","line":976,"range":{"start_line":976,"start_character":58,"end_line":976,"end_character":60},"in_reply_to":"4bd0309e_09f9f03a","updated":"2023-12-22 12:20:14.000000000","message":"Done","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"4074b0895ba680989e6119d44a9242c201241c44","unresolved":true,"context_lines":[{"line_number":979,"context_line":"                        ips_v4.append(f\u0027{mb_ip}:{mb_port}\u0027)"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"            for lb_vip in lb_vips:"},{"line_number":982,"context_line":"                if ips_v4 and netaddr.IPNetwork(lb_vip).version \u003d\u003d 4:"},{"line_number":983,"context_line":"                    vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v4)"},{"line_number":984,"context_line":"                if ips_v6 and netaddr.IPNetwork(lb_vip).version \u003d\u003d 6:"},{"line_number":985,"context_line":"                    lb_vip \u003d f\u0027[{lb_vip}]\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"653b76f9_83351a1e","line":982,"range":{"start_line":982,"start_character":67,"end_line":982,"end_character":68},"updated":"2023-12-21 12:18:32.000000000","message":"you are using the n_const.IP_VERSION_4 in other places, perhaps worth using it here too, though this was here before this patch","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"dc48c15c9ba4090d9905bba31f81745bcbb6a699","unresolved":false,"context_lines":[{"line_number":979,"context_line":"                        ips_v4.append(f\u0027{mb_ip}:{mb_port}\u0027)"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"            for lb_vip in lb_vips:"},{"line_number":982,"context_line":"                if ips_v4 and netaddr.IPNetwork(lb_vip).version \u003d\u003d 4:"},{"line_number":983,"context_line":"                    vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v4)"},{"line_number":984,"context_line":"                if ips_v6 and netaddr.IPNetwork(lb_vip).version \u003d\u003d 6:"},{"line_number":985,"context_line":"                    lb_vip \u003d f\u0027[{lb_vip}]\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"419c96bb_e733d6b7","line":982,"range":{"start_line":982,"start_character":67,"end_line":982,"end_character":68},"in_reply_to":"1acab67a_67a31e60","updated":"2023-12-22 12:20:14.000000000","message":"Done","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb6a235421624b241df1bf2aa16e826a16ba29d8","unresolved":true,"context_lines":[{"line_number":979,"context_line":"                        ips_v4.append(f\u0027{mb_ip}:{mb_port}\u0027)"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"            for lb_vip in lb_vips:"},{"line_number":982,"context_line":"                if ips_v4 and netaddr.IPNetwork(lb_vip).version \u003d\u003d 4:"},{"line_number":983,"context_line":"                    vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v4)"},{"line_number":984,"context_line":"                if ips_v6 and netaddr.IPNetwork(lb_vip).version \u003d\u003d 6:"},{"line_number":985,"context_line":"                    lb_vip \u003d f\u0027[{lb_vip}]\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1acab67a_67a31e60","line":982,"range":{"start_line":982,"start_character":67,"end_line":982,"end_character":68},"in_reply_to":"653b76f9_83351a1e","updated":"2023-12-22 11:09:52.000000000","message":"please use constants, but it can be follow up patch also","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb6a235421624b241df1bf2aa16e826a16ba29d8","unresolved":true,"context_lines":[{"line_number":981,"context_line":"            for lb_vip in lb_vips:"},{"line_number":982,"context_line":"                if ips_v4 and netaddr.IPNetwork(lb_vip).version \u003d\u003d 4:"},{"line_number":983,"context_line":"                    vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v4)"},{"line_number":984,"context_line":"                if ips_v6 and netaddr.IPNetwork(lb_vip).version \u003d\u003d 6:"},{"line_number":985,"context_line":"                    lb_vip \u003d f\u0027[{lb_vip}]\u0027"},{"line_number":986,"context_line":"                    vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v6)"},{"line_number":987,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"52ef2c01_4ae1075a","line":984,"range":{"start_line":984,"start_character":67,"end_line":984,"end_character":68},"updated":"2023-12-22 11:09:52.000000000","message":"ditto","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"dc48c15c9ba4090d9905bba31f81745bcbb6a699","unresolved":false,"context_lines":[{"line_number":981,"context_line":"            for lb_vip in lb_vips:"},{"line_number":982,"context_line":"                if ips_v4 and netaddr.IPNetwork(lb_vip).version \u003d\u003d 4:"},{"line_number":983,"context_line":"                    vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v4)"},{"line_number":984,"context_line":"                if ips_v6 and netaddr.IPNetwork(lb_vip).version \u003d\u003d 6:"},{"line_number":985,"context_line":"                    lb_vip \u003d f\u0027[{lb_vip}]\u0027"},{"line_number":986,"context_line":"                    vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v6)"},{"line_number":987,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f214be7_7ea70e29","line":984,"range":{"start_line":984,"start_character":67,"end_line":984,"end_character":68},"in_reply_to":"52ef2c01_4ae1075a","updated":"2023-12-22 12:20:14.000000000","message":"Done","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb6a235421624b241df1bf2aa16e826a16ba29d8","unresolved":true,"context_lines":[{"line_number":986,"context_line":"                    vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v6)"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"            if ips_v4 and vip_fip:"},{"line_number":989,"context_line":"                if netaddr.IPNetwork(vip_fip).version \u003d\u003d 4:"},{"line_number":990,"context_line":"                    vip_ips[vip_fip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v4)"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"            if ips_v4 and additional_vip_fips:"}],"source_content_type":"text/x-python","patch_set":4,"id":"cea00039_11ffe66a","line":989,"range":{"start_line":989,"start_character":57,"end_line":989,"end_character":58},"updated":"2023-12-22 11:09:52.000000000","message":"ditto","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"dc48c15c9ba4090d9905bba31f81745bcbb6a699","unresolved":false,"context_lines":[{"line_number":986,"context_line":"                    vip_ips[lb_vip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v6)"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"            if ips_v4 and vip_fip:"},{"line_number":989,"context_line":"                if netaddr.IPNetwork(vip_fip).version \u003d\u003d 4:"},{"line_number":990,"context_line":"                    vip_ips[vip_fip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join(ips_v4)"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"            if ips_v4 and additional_vip_fips:"}],"source_content_type":"text/x-python","patch_set":4,"id":"352ab001_5d8a3d6f","line":989,"range":{"start_line":989,"start_character":57,"end_line":989,"end_character":58},"in_reply_to":"cea00039_11ffe66a","updated":"2023-12-22 12:20:14.000000000","message":"Done","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb6a235421624b241df1bf2aa16e826a16ba29d8","unresolved":true,"context_lines":[{"line_number":991,"context_line":""},{"line_number":992,"context_line":"            if ips_v4 and additional_vip_fips:"},{"line_number":993,"context_line":"                for addi_vip_fip in additional_vip_fips.split(\u0027,\u0027):"},{"line_number":994,"context_line":"                    if netaddr.IPNetwork(addi_vip_fip).version \u003d\u003d 4:"},{"line_number":995,"context_line":"                        vip_ips[addi_vip_fip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join("},{"line_number":996,"context_line":"                            ips_v4)"},{"line_number":997,"context_line":"        return vip_ips"}],"source_content_type":"text/x-python","patch_set":4,"id":"cb8994e8_ccf1a2c3","line":994,"range":{"start_line":994,"start_character":66,"end_line":994,"end_character":67},"updated":"2023-12-22 11:09:52.000000000","message":"ditto","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"dc48c15c9ba4090d9905bba31f81745bcbb6a699","unresolved":false,"context_lines":[{"line_number":991,"context_line":""},{"line_number":992,"context_line":"            if ips_v4 and additional_vip_fips:"},{"line_number":993,"context_line":"                for addi_vip_fip in additional_vip_fips.split(\u0027,\u0027):"},{"line_number":994,"context_line":"                    if netaddr.IPNetwork(addi_vip_fip).version \u003d\u003d 4:"},{"line_number":995,"context_line":"                        vip_ips[addi_vip_fip + \u0027:\u0027 + vip_port] \u003d \u0027,\u0027.join("},{"line_number":996,"context_line":"                            ips_v4)"},{"line_number":997,"context_line":"        return vip_ips"}],"source_content_type":"text/x-python","patch_set":4,"id":"88002082_563d6564","line":994,"range":{"start_line":994,"start_character":66,"end_line":994,"end_character":67},"in_reply_to":"cb8994e8_ccf1a2c3","updated":"2023-12-22 12:20:14.000000000","message":"Done","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"}],"ovn_octavia_provider/tests/functional/test_driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb6a235421624b241df1bf2aa16e826a16ba29d8","unresolved":true,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib import constants as n_const"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from octavia_lib.api.drivers import exceptions as o_exceptions"},{"line_number":19,"context_line":"from octavia_lib.common import constants as o_constants"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5d67de18_879fb6ef","line":17,"updated":"2023-12-22 11:09:52.000000000","message":"this import should be in the same section like other 3rd party libs imports","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"dc48c15c9ba4090d9905bba31f81745bcbb6a699","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib import constants as n_const"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from octavia_lib.api.drivers import exceptions as o_exceptions"},{"line_number":19,"context_line":"from octavia_lib.common import constants as o_constants"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"55736cbc_486183d6","line":17,"in_reply_to":"5d67de18_879fb6ef","updated":"2023-12-22 12:20:14.000000000","message":"Done","commit_id":"16bd0d2f1d947405b7f23961239c00359259e323"}]}