)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ed4c3753b73a121964dc7048922ac5aef205aa77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"af9b6fca_8df51566","updated":"2024-03-12 16:13:09.000000000","message":"The failures does not look related (different jobs and/or tests failing on each run). Since I know this is priority, I am approving it now in the hopes that the gate will succeed.","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"b92b575a4238c754593b8bdef79d7bcfadf3bc9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4d7e747b_abdedce9","updated":"2024-03-12 10:33:06.000000000","message":"recheck ovn-octavia-provider-functional-master unrelated","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"4a745b72633b0e33a35fec92889ba215e0425a3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5f7ee216_9ea38d96","updated":"2024-03-12 19:30:02.000000000","message":"recheck ovn-octavia-provider-functional-master unrelated","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"929bf74d31861f16180ad3b439450423d096ccc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c9997984_f3369520","updated":"2024-03-12 15:49:10.000000000","message":"recheck ovn-octavia-provider-functional-master unrelated","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"07bb10abdd5fb1a4bd5c51b7f75d74d3dea06b42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e3be36a3_af489ea2","updated":"2024-03-12 14:30:50.000000000","message":"recheck ovn-octavia-provider-functional-master unrelated","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"a6a7650929e31f7b2fefe6537998c466132de345","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e76a7089_45844dbe","updated":"2024-03-12 12:45:15.000000000","message":"recheck ovn-octavia-provider-functional-master unrelated","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"29aef960862aad7a90cee99a476e63f895a08865","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"45f216b0_f4f4792e","updated":"2024-03-13 07:49:40.000000000","message":"recheck ovn-octavia-provider-functional-master unrelated","commit_id":"db93fa7adf7c799bb63a571b45b9a7f523bff8e7"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"4f4f61a430c80eb6e70867166349aae1afd39a9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"994cf70d_ebfb72fd","updated":"2024-03-15 11:07:08.000000000","message":"recheck after merging 912349","commit_id":"a867cd6cc23e381c46d5f48d2927d81a0dd01d75"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"984e28cbf75e3d38b96be5eff2049268c25d075b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d51d16a2_4016e7cc","updated":"2024-03-13 12:19:52.000000000","message":"recheck functional","commit_id":"a867cd6cc23e381c46d5f48d2927d81a0dd01d75"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"832d63929eba308f2f433e4c98d4149afdc6be43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4670bb46_cd5f3b14","updated":"2024-03-14 09:33:46.000000000","message":"recheck ovn-octavia-provider-functional-master #912349","commit_id":"a867cd6cc23e381c46d5f48d2927d81a0dd01d75"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"280af277ddab10078f6e3b111ba86ebad4f4dd37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5789a355_a281e657","updated":"2024-03-14 12:49:45.000000000","message":"recheck ovn-octavia-provider-functional-master #912349","commit_id":"a867cd6cc23e381c46d5f48d2927d81a0dd01d75"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"8998d7859ae5c3d7882da6cc56102842fb99e8b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d1741e9d_81eeaa21","updated":"2024-03-14 11:14:59.000000000","message":"recheck ovn-octavia-provider-functional-master #912349","commit_id":"a867cd6cc23e381c46d5f48d2927d81a0dd01d75"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"896dc7fcec83b1f8852b2ae14c24d7848686e3a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d9a1adbd_2213d38f","updated":"2024-03-13 14:19:52.000000000","message":"recheck ovn-octavia-provider-functional-master #912349","commit_id":"a867cd6cc23e381c46d5f48d2927d81a0dd01d75"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"dc29c3cc2c8625085fbae6fa2a1b034e7ef4d3e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"25e79c1a_231ccbd1","updated":"2024-03-15 12:38:16.000000000","message":"recheck ovn-octavia-provider-functional-master unrealted","commit_id":"a867cd6cc23e381c46d5f48d2927d81a0dd01d75"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"17c930b79eb8130407c8e702b442811f656a998c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"658cdc08_bec2ce08","updated":"2024-03-15 13:42:22.000000000","message":"recheck ovn-octavia-provider-functional-master unrealted","commit_id":"a867cd6cc23e381c46d5f48d2927d81a0dd01d75"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"929e2b6a15b06cdc8ca0aa5b24922ebf3e6de66b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"419dddf4_26ca4117","updated":"2024-04-01 10:14:12.000000000","message":"recheck ovn-octavia-provider-functional-release unrelated","commit_id":"a867cd6cc23e381c46d5f48d2927d81a0dd01d75"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"1e32d677c2a85ad352a3097f98a66c93e29813ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"431c654b_468735b3","updated":"2024-03-18 08:57:58.000000000","message":"recheck ovn-octavia-provider-functional-release unrelated","commit_id":"a867cd6cc23e381c46d5f48d2927d81a0dd01d75"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"98f8880e3ff2af052d00f2ffc52f2caac2e6dcaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9b95b5b7_93092bf2","updated":"2024-03-18 17:26:34.000000000","message":"recheck ovn-octavia-provider-functional-release unrelated","commit_id":"a867cd6cc23e381c46d5f48d2927d81a0dd01d75"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"a10cfdfc1c3011aa121fefe376a53ca1a00c594f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"cb85bafd_dc2999c2","updated":"2024-03-15 17:10:14.000000000","message":"recheck ovn-octavia-provider-functional-release unrelated","commit_id":"a867cd6cc23e381c46d5f48d2927d81a0dd01d75"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"9a82b84d2b3b0fb0df802ce61c5f554e4aabbd9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"120493d5_299fa0d0","updated":"2024-04-10 10:24:27.000000000","message":"recheck ovn-octavia-provider-functional-release unrelated","commit_id":"bd1137ad57b6e336800d701d6d52733abf968aa5"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"982a7243ffe9f4e871d29a2348a9d34b190552e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ec585f3c_856798bd","updated":"2024-04-10 08:22:21.000000000","message":"recheck ovn-octavia-provider-functional-release unrelated","commit_id":"bd1137ad57b6e336800d701d6d52733abf968aa5"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"0e398551e78057a9a8bb2a22d48c8040e2cb6a79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"cec807e4_21b34424","updated":"2024-04-09 14:10:48.000000000","message":"recheck unrelated","commit_id":"bd1137ad57b6e336800d701d6d52733abf968aa5"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c0f7e81d0e98688a7a52fe8fc53cacdb15e9f0d8","unresolved":true,"context_lines":[{"line_number":2783,"context_line":"        # into [ ... ]. So replace this method calls to ovsdbapp ones when it"},{"line_number":2784,"context_line":"        # is fixed"},{"line_number":2785,"context_line":"        if delete:"},{"line_number":2786,"context_line":"            self._lb_del_ip_port_mapping(ovn_lb, backend_ip)"},{"line_number":2787,"context_line":"        else:"},{"line_number":2788,"context_line":"            self._lb_add_ip_port_mapping(ovn_lb, backend_ip, port_name, src_ip)"},{"line_number":2789,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"97cd473f_e438c575","line":2786,"range":{"start_line":2786,"start_character":12,"end_line":2786,"end_character":60},"updated":"2024-03-06 09:17:33.000000000","message":"I think this should remain the same but we should overwrite the main function in impl_idl_ovn.py instead. Moving (and adapting) the code from lines 2727-2771 there","commit_id":"3f5dbe26f2bac2e0edd63fa59d6226f1ec44b3f2"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"18546fa8598dbb54af09b59b3c4196c9c01cf2d3","unresolved":false,"context_lines":[{"line_number":2783,"context_line":"        # into [ ... ]. So replace this method calls to ovsdbapp ones when it"},{"line_number":2784,"context_line":"        # is fixed"},{"line_number":2785,"context_line":"        if delete:"},{"line_number":2786,"context_line":"            self._lb_del_ip_port_mapping(ovn_lb, backend_ip)"},{"line_number":2787,"context_line":"        else:"},{"line_number":2788,"context_line":"            self._lb_add_ip_port_mapping(ovn_lb, backend_ip, port_name, src_ip)"},{"line_number":2789,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2f0e23ee_cd585769","line":2786,"range":{"start_line":2786,"start_character":12,"end_line":2786,"end_character":60},"in_reply_to":"97cd473f_e438c575","updated":"2024-03-06 11:14:15.000000000","message":"Good catch! It makes complete sense to aim for simplicity in the future patch once ovsdbapp fixes this issue","commit_id":"3f5dbe26f2bac2e0edd63fa59d6226f1ec44b3f2"}],"ovn_octavia_provider/maintenance.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2517f6af237e9bcd54a4f7764e1ae4d20b060a2b","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        keys following the format:"},{"line_number":130,"context_line":"        `${MEMBER_IP}\u003d${LSP_NAME_MEMBER}:${HEALTH_SRC_IP}`. However, when"},{"line_number":131,"context_line":"        `MEMBER_IP` and `HEALTH_SRC_IP` are IPv6 addresses, they should be"},{"line_number":132,"context_line":"        enclosed in `[]`."},{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        LOG.debug(\u0027Maintenance task: Ensure correct formatting of \u0027"},{"line_number":135,"context_line":"                  \u0027ip_port_mappings for IPv6 backend members.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df702b55_18d083b9","line":132,"updated":"2024-03-11 18:43:08.000000000","message":"This task sounds like something that can be removed in the future. Just nit, but would be good to mark it with a #TODO for us not to forget to delete it later.","commit_id":"50e1238aae25e00914e0d4254e9740df3f769d23"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"da79c140170f1a1998f18d5547ac63c2ac70a209","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        keys following the format:"},{"line_number":130,"context_line":"        `${MEMBER_IP}\u003d${LSP_NAME_MEMBER}:${HEALTH_SRC_IP}`. However, when"},{"line_number":131,"context_line":"        `MEMBER_IP` and `HEALTH_SRC_IP` are IPv6 addresses, they should be"},{"line_number":132,"context_line":"        enclosed in `[]`."},{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        LOG.debug(\u0027Maintenance task: Ensure correct formatting of \u0027"},{"line_number":135,"context_line":"                  \u0027ip_port_mappings for IPv6 backend members.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aaebbfe_9519b6c2","line":132,"in_reply_to":"df702b55_18d083b9","updated":"2024-03-11 20:32:36.000000000","message":"yeah, make total sense.","commit_id":"50e1238aae25e00914e0d4254e9740df3f769d23"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"56ea0a2f4629d00202b384d0b4f1b830a0c8a713","unresolved":true,"context_lines":[{"line_number":146,"context_line":"                        break"},{"line_number":147,"context_line":"                except netaddr.core.AddrFormatError:"},{"line_number":148,"context_line":"                    break"},{"line_number":149,"context_line":"                port_name, src_ip \u003d v.split(\u0027:\u0027, 1)"},{"line_number":150,"context_line":"                mappings[f\u0027[{k}]\u0027] \u003d f\u0027{port_name}:[{src_ip}]\u0027"},{"line_number":151,"context_line":"                self.ovn_nbdb_api.db_clear(\u0027Load_Balancer\u0027, lb.uuid,"},{"line_number":152,"context_line":"                                           \u0027ip_port_mappings\u0027).execute("}],"source_content_type":"text/x-python","patch_set":3,"id":"5b5e4515_8ecae20e","line":149,"range":{"start_line":149,"start_character":15,"end_line":149,"end_character":25},"updated":"2024-03-06 11:56:24.000000000","message":"this should be renamed to port_uuid or hm_port_uuid","commit_id":"50e1238aae25e00914e0d4254e9740df3f769d23"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"da79c140170f1a1998f18d5547ac63c2ac70a209","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                        break"},{"line_number":147,"context_line":"                except netaddr.core.AddrFormatError:"},{"line_number":148,"context_line":"                    break"},{"line_number":149,"context_line":"                port_name, src_ip \u003d v.split(\u0027:\u0027, 1)"},{"line_number":150,"context_line":"                mappings[f\u0027[{k}]\u0027] \u003d f\u0027{port_name}:[{src_ip}]\u0027"},{"line_number":151,"context_line":"                self.ovn_nbdb_api.db_clear(\u0027Load_Balancer\u0027, lb.uuid,"},{"line_number":152,"context_line":"                                           \u0027ip_port_mappings\u0027).execute("}],"source_content_type":"text/x-python","patch_set":3,"id":"bbd589cc_1467abf7","line":149,"range":{"start_line":149,"start_character":15,"end_line":149,"end_character":25},"in_reply_to":"5b5e4515_8ecae20e","updated":"2024-03-11 20:32:36.000000000","message":"Acknowledged","commit_id":"50e1238aae25e00914e0d4254e9740df3f769d23"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ee1f21841539612110b1e5206ecc60d820242c7f","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from futurist import periodics"},{"line_number":19,"context_line":"import netaddr"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron_lib import constants as n_const"},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":7,"id":"73482510_a662ee4b","line":20,"updated":"2024-03-12 20:08:04.000000000","message":"Wrong empty line, wondering why the linter doesn\u0027t notice this.","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"a4a441960281a241362993e9c0e825bffe3472a0","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from futurist import periodics"},{"line_number":19,"context_line":"import netaddr"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron_lib import constants as n_const"},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":7,"id":"e76c9d78_7aac9b2f","line":20,"in_reply_to":"73482510_a662ee4b","updated":"2024-03-12 20:48:38.000000000","message":"yeah, let us remove it","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ee1f21841539612110b1e5206ecc60d820242c7f","unresolved":true,"context_lines":[{"line_number":145,"context_line":"                    # can jump to next item"},{"line_number":146,"context_line":"                    if netaddr.IPNetwork(k).version \u003d\u003d n_const.IP_VERSION_4:"},{"line_number":147,"context_line":"                        break"},{"line_number":148,"context_line":"                except netaddr.core.AddrFormatError:"},{"line_number":149,"context_line":"                    break"},{"line_number":150,"context_line":"                port_uuid, src_ip \u003d v.split(\u0027:\u0027, 1)"},{"line_number":151,"context_line":"                mappings[f\u0027[{k}]\u0027] \u003d f\u0027{port_uuid}:[{src_ip}]\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"39fbc2ac_922261bc","line":148,"range":{"start_line":148,"start_character":31,"end_line":148,"end_character":36},"updated":"2024-03-12 20:08:04.000000000","message":"This is not needed since the main package imports it https://github.com/netaddr/netaddr/blob/2c89b344a8e402773cab569ea9e522b1d683109c/netaddr/__init__.py#L20","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"682bedf1fc384c0b6df58458a457d2f24a8e1501","unresolved":true,"context_lines":[{"line_number":145,"context_line":"                    # can jump to next item"},{"line_number":146,"context_line":"                    if netaddr.IPNetwork(k).version \u003d\u003d n_const.IP_VERSION_4:"},{"line_number":147,"context_line":"                        break"},{"line_number":148,"context_line":"                except netaddr.core.AddrFormatError:"},{"line_number":149,"context_line":"                    break"},{"line_number":150,"context_line":"                port_uuid, src_ip \u003d v.split(\u0027:\u0027, 1)"},{"line_number":151,"context_line":"                mappings[f\u0027[{k}]\u0027] \u003d f\u0027{port_uuid}:[{src_ip}]\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"623f6f7f_106b3df3","line":148,"range":{"start_line":148,"start_character":31,"end_line":148,"end_character":36},"in_reply_to":"39fbc2ac_922261bc","updated":"2024-03-12 20:11:45.000000000","message":"Forgot to add this is just a supernit :)","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"a4a441960281a241362993e9c0e825bffe3472a0","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                    # can jump to next item"},{"line_number":146,"context_line":"                    if netaddr.IPNetwork(k).version \u003d\u003d n_const.IP_VERSION_4:"},{"line_number":147,"context_line":"                        break"},{"line_number":148,"context_line":"                except netaddr.core.AddrFormatError:"},{"line_number":149,"context_line":"                    break"},{"line_number":150,"context_line":"                port_uuid, src_ip \u003d v.split(\u0027:\u0027, 1)"},{"line_number":151,"context_line":"                mappings[f\u0027[{k}]\u0027] \u003d f\u0027{port_uuid}:[{src_ip}]\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"2a8640e7_acffd4e2","line":148,"range":{"start_line":148,"start_character":31,"end_line":148,"end_character":36},"in_reply_to":"623f6f7f_106b3df3","updated":"2024-03-12 20:48:38.000000000","message":"Acknowledged","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ee1f21841539612110b1e5206ecc60d820242c7f","unresolved":true,"context_lines":[{"line_number":149,"context_line":"                    break"},{"line_number":150,"context_line":"                port_uuid, src_ip \u003d v.split(\u0027:\u0027, 1)"},{"line_number":151,"context_line":"                mappings[f\u0027[{k}]\u0027] \u003d f\u0027{port_uuid}:[{src_ip}]\u0027"},{"line_number":152,"context_line":"                self.ovn_nbdb_api.db_clear(\u0027Load_Balancer\u0027, lb.uuid,"},{"line_number":153,"context_line":"                                           \u0027ip_port_mappings\u0027).execute("},{"line_number":154,"context_line":"                                               check_error\u003dTrue)"},{"line_number":155,"context_line":"                self.ovn_nbdb_api.db_set("},{"line_number":156,"context_line":"                    \u0027Load_Balancer\u0027, lb.uuid,"},{"line_number":157,"context_line":"                    (\u0027ip_port_mappings\u0027, mappings)).execute(check_error\u003dTrue)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        LOG.debug(\u0027Maintenance task: no more ip_port_mappings to format, \u0027"},{"line_number":160,"context_line":"                  \u0027stopping the periodic task.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"228c2f1f_bcca98ad","line":157,"range":{"start_line":152,"start_character":0,"end_line":157,"end_character":77},"updated":"2024-03-12 20:08:04.000000000","message":"Shouldn\u0027t this be executed outside of the L141 loop and not per port mapping?","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"a4a441960281a241362993e9c0e825bffe3472a0","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                    break"},{"line_number":150,"context_line":"                port_uuid, src_ip \u003d v.split(\u0027:\u0027, 1)"},{"line_number":151,"context_line":"                mappings[f\u0027[{k}]\u0027] \u003d f\u0027{port_uuid}:[{src_ip}]\u0027"},{"line_number":152,"context_line":"                self.ovn_nbdb_api.db_clear(\u0027Load_Balancer\u0027, lb.uuid,"},{"line_number":153,"context_line":"                                           \u0027ip_port_mappings\u0027).execute("},{"line_number":154,"context_line":"                                               check_error\u003dTrue)"},{"line_number":155,"context_line":"                self.ovn_nbdb_api.db_set("},{"line_number":156,"context_line":"                    \u0027Load_Balancer\u0027, lb.uuid,"},{"line_number":157,"context_line":"                    (\u0027ip_port_mappings\u0027, mappings)).execute(check_error\u003dTrue)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        LOG.debug(\u0027Maintenance task: no more ip_port_mappings to format, \u0027"},{"line_number":160,"context_line":"                  \u0027stopping the periodic task.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"39b8cff3_e1e72d85","line":157,"range":{"start_line":152,"start_character":0,"end_line":157,"end_character":77},"in_reply_to":"228c2f1f_bcca98ad","updated":"2024-03-12 20:48:38.000000000","message":"good catch!","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"}],"ovn_octavia_provider/ovsdb/impl_idl_ovn.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"56ea0a2f4629d00202b384d0b4f1b830a0c8a713","unresolved":true,"context_lines":[{"line_number":139,"context_line":"            self.api.tables[\u0027Logical_Router\u0027].rows.values()]"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# NOTE(froyo): remove this class once ovsdbapp manages the IPv6 into [ ]"},{"line_number":143,"context_line":"class DelBackendFromIPPortMapping(command.BaseCommand):"},{"line_number":144,"context_line":"    table \u003d \u0027Load_Balancer\u0027"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b37e8d9f_aaa12f4e","line":142,"updated":"2024-03-06 11:56:24.000000000","message":"if you have a bug opened against ovsdbapp, worth to add it here","commit_id":"50e1238aae25e00914e0d4254e9740df3f769d23"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"da79c140170f1a1998f18d5547ac63c2ac70a209","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            self.api.tables[\u0027Logical_Router\u0027].rows.values()]"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# NOTE(froyo): remove this class once ovsdbapp manages the IPv6 into [ ]"},{"line_number":143,"context_line":"class DelBackendFromIPPortMapping(command.BaseCommand):"},{"line_number":144,"context_line":"    table \u003d \u0027Load_Balancer\u0027"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"74038ee6_e344dd70","line":142,"in_reply_to":"b37e8d9f_aaa12f4e","updated":"2024-03-11 20:32:36.000000000","message":"Acknowledged","commit_id":"50e1238aae25e00914e0d4254e9740df3f769d23"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ee1f21841539612110b1e5206ecc60d820242c7f","unresolved":true,"context_lines":[{"line_number":175,"context_line":"        if netaddr.IPNetwork(backend_ip).version \u003d\u003d n_const.IP_VERSION_6:"},{"line_number":176,"context_line":"            self.backend_ip \u003d f\u0027[{backend_ip}]\u0027"},{"line_number":177,"context_line":"            self.src_ip \u003d f\u0027[{src_ip}]\u0027"},{"line_number":178,"context_line":"        else:"},{"line_number":179,"context_line":"            self.backend_ip \u003d backend_ip"},{"line_number":180,"context_line":"            self.src_ip \u003d src_ip"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def run_idl(self, txn):"},{"line_number":183,"context_line":"        lb \u003d self.api.lookup(self.table, self.lb)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1c47c09e_122daae2","line":180,"range":{"start_line":178,"start_character":0,"end_line":180,"end_character":32},"updated":"2024-03-12 20:08:04.000000000","message":"Do we need this? It\u0027s already assigned on L172 and L174 respectively","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"a4a441960281a241362993e9c0e825bffe3472a0","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        if netaddr.IPNetwork(backend_ip).version \u003d\u003d n_const.IP_VERSION_6:"},{"line_number":176,"context_line":"            self.backend_ip \u003d f\u0027[{backend_ip}]\u0027"},{"line_number":177,"context_line":"            self.src_ip \u003d f\u0027[{src_ip}]\u0027"},{"line_number":178,"context_line":"        else:"},{"line_number":179,"context_line":"            self.backend_ip \u003d backend_ip"},{"line_number":180,"context_line":"            self.src_ip \u003d src_ip"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def run_idl(self, txn):"},{"line_number":183,"context_line":"        lb \u003d self.api.lookup(self.table, self.lb)"}],"source_content_type":"text/x-python","patch_set":7,"id":"83207f4f_e6855323","line":180,"range":{"start_line":178,"start_character":0,"end_line":180,"end_character":32},"in_reply_to":"1c47c09e_122daae2","updated":"2024-03-12 20:48:38.000000000","message":"Done","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ee1f21841539612110b1e5206ecc60d820242c7f","unresolved":true,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def run_idl(self, txn):"},{"line_number":183,"context_line":"        lb \u003d self.api.lookup(self.table, self.lb)"},{"line_number":184,"context_line":"        lb.setkey(\u0027ip_port_mappings\u0027, self.backend_ip,"},{"line_number":185,"context_line":"                  \u0027%s:%s\u0027 % (self.port_name, self.src_ip))"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1dcbad5e_319295f1","line":184,"updated":"2024-03-12 20:08:04.000000000","message":"I liked the exception logging in the previous command. Why is it there but not here? Things can go south here too.","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"a4a441960281a241362993e9c0e825bffe3472a0","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def run_idl(self, txn):"},{"line_number":183,"context_line":"        lb \u003d self.api.lookup(self.table, self.lb)"},{"line_number":184,"context_line":"        lb.setkey(\u0027ip_port_mappings\u0027, self.backend_ip,"},{"line_number":185,"context_line":"                  \u0027%s:%s\u0027 % (self.port_name, self.src_ip))"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"44425a4a_757e8331","line":184,"in_reply_to":"1dcbad5e_319295f1","updated":"2024-03-12 20:48:38.000000000","message":"Done","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ee1f21841539612110b1e5206ecc60d820242c7f","unresolved":true,"context_lines":[{"line_number":221,"context_line":"        return GetLrsCommand(self)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    # NOTE(froyo): remove this method once ovsdbapp manages the IPv6 into [ ]"},{"line_number":224,"context_line":"    def lb_del_ip_port_mapping(self, lb_uuid, backend_ip):"},{"line_number":225,"context_line":"        return DelBackendFromIPPortMapping(self, lb_uuid, backend_ip)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    # NOTE(froyo): remove this method once ovsdbapp manages the IPv6 into [ ]"}],"source_content_type":"text/x-python","patch_set":7,"id":"42e53839_6afd6bfa","line":224,"updated":"2024-03-12 20:08:04.000000000","message":"I might be dumb but is it used anwyhere?","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"a4a441960281a241362993e9c0e825bffe3472a0","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        return GetLrsCommand(self)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    # NOTE(froyo): remove this method once ovsdbapp manages the IPv6 into [ ]"},{"line_number":224,"context_line":"    def lb_del_ip_port_mapping(self, lb_uuid, backend_ip):"},{"line_number":225,"context_line":"        return DelBackendFromIPPortMapping(self, lb_uuid, backend_ip)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    # NOTE(froyo): remove this method once ovsdbapp manages the IPv6 into [ ]"}],"source_content_type":"text/x-python","patch_set":7,"id":"4b96f887_83aa8f16","line":224,"in_reply_to":"050163e6_9c9eaff4","updated":"2024-03-12 20:48:38.000000000","message":"Done","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0880dceb406d2e246ebd2787ce5b996a8ace3f67","unresolved":true,"context_lines":[{"line_number":221,"context_line":"        return GetLrsCommand(self)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    # NOTE(froyo): remove this method once ovsdbapp manages the IPv6 into [ ]"},{"line_number":224,"context_line":"    def lb_del_ip_port_mapping(self, lb_uuid, backend_ip):"},{"line_number":225,"context_line":"        return DelBackendFromIPPortMapping(self, lb_uuid, backend_ip)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    # NOTE(froyo): remove this method once ovsdbapp manages the IPv6 into [ ]"}],"source_content_type":"text/x-python","patch_set":7,"id":"050163e6_9c9eaff4","line":224,"in_reply_to":"42e53839_6afd6bfa","updated":"2024-03-12 20:15:12.000000000","message":"Ah, it\u0027s overriding the ovsdbapp methods. Ok :)","commit_id":"582ab17987a24bbcfbb50b7d8656c1f93b6af157"}]}