)]}'
{"ovn_octavia_provider/helper.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"453f10efc8a35f1c37a1bde7758196600075525d","unresolved":true,"context_lines":[{"line_number":2197,"context_line":"                    for m_info in value.split(\u0027,\u0027):"},{"line_number":2198,"context_line":"                        mem_id, mem_ip_port, mem_subnet \u003d m_info.split(\u0027_\u0027)[1:]"},{"line_number":2199,"context_line":"                        if mem_subnet \u003d\u003d subnet_id:"},{"line_number":2200,"context_line":"                            members.append(mem_id)"},{"line_number":2201,"context_line":"        return members"},{"line_number":2202,"context_line":""},{"line_number":2203,"context_line":"    def member_delete(self, member):"}],"source_content_type":"text/x-python","patch_set":1,"id":"e6d6c8fd_c6f0159e","line":2200,"updated":"2024-04-30 07:24:35.000000000","message":"nitty nit: there could be small optimization of this method IMO. IIUC you don\u0027t need to get list of all members from the subnet but just know if there is ANY member from that subnet still connected. So You could simply return True here or False in line 2201. That way you wouldn\u0027t iterate over whole list always.\nIt would also simplify slightly list code in line 2214 as it could be there something like:\n\n    if not self._members_in_subnet(ovn_lb, mem_subnet):\n        ......","commit_id":"f218b397ec929396605da7c635329f66c27fa40a"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"52583a4713a999d6ea0e6f92b481a3dfd33baa12","unresolved":false,"context_lines":[{"line_number":2197,"context_line":"                    for m_info in value.split(\u0027,\u0027):"},{"line_number":2198,"context_line":"                        mem_id, mem_ip_port, mem_subnet \u003d m_info.split(\u0027_\u0027)[1:]"},{"line_number":2199,"context_line":"                        if mem_subnet \u003d\u003d subnet_id:"},{"line_number":2200,"context_line":"                            members.append(mem_id)"},{"line_number":2201,"context_line":"        return members"},{"line_number":2202,"context_line":""},{"line_number":2203,"context_line":"    def member_delete(self, member):"}],"source_content_type":"text/x-python","patch_set":1,"id":"89218014_3683e349","line":2200,"in_reply_to":"e4329827_bd026627","updated":"2024-04-30 11:40:40.000000000","message":"Done","commit_id":"f218b397ec929396605da7c635329f66c27fa40a"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"dafd41c4ae755b53e75acb6f7a8fe61cbe8eeca0","unresolved":true,"context_lines":[{"line_number":2197,"context_line":"                    for m_info in value.split(\u0027,\u0027):"},{"line_number":2198,"context_line":"                        mem_id, mem_ip_port, mem_subnet \u003d m_info.split(\u0027_\u0027)[1:]"},{"line_number":2199,"context_line":"                        if mem_subnet \u003d\u003d subnet_id:"},{"line_number":2200,"context_line":"                            members.append(mem_id)"},{"line_number":2201,"context_line":"        return members"},{"line_number":2202,"context_line":""},{"line_number":2203,"context_line":"    def member_delete(self, member):"}],"source_content_type":"text/x-python","patch_set":1,"id":"e4329827_bd026627","line":2200,"in_reply_to":"e6d6c8fd_c6f0159e","updated":"2024-04-30 10:01:58.000000000","message":"make totally sense! done!","commit_id":"f218b397ec929396605da7c635329f66c27fa40a"}]}