)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f55db4822e01f19a3ceb5245efa18105f0938553","unresolved":true,"context_lines":[{"line_number":10,"context_line":"stores the ovsdb_connection on the Backend class itself ensures"},{"line_number":11,"context_line":"that when Octavia does the imports necessary for instantiating the"},{"line_number":12,"context_line":"driver, that the ovsdb_connection will remain on the class even"},{"line_number":13,"context_line":"though the instances are deleted. This will allow us to resuse the"},{"line_number":14,"context_line":"OVSDB connection between APIs despite octavia-api knowing nothing"},{"line_number":15,"context_line":"about it."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fbf05102_da13b7d9","line":13,"updated":"2024-05-10 20:55:22.000000000","message":"reuse","commit_id":"a4ea12133b53ac27a1ec26d37de0ed85eee70d9e"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"cde951592eb39f7c6284c989f4a5d7f7ded16e1c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"stores the ovsdb_connection on the Backend class itself ensures"},{"line_number":11,"context_line":"that when Octavia does the imports necessary for instantiating the"},{"line_number":12,"context_line":"driver, that the ovsdb_connection will remain on the class even"},{"line_number":13,"context_line":"though the instances are deleted. This will allow us to resuse the"},{"line_number":14,"context_line":"OVSDB connection between APIs despite octavia-api knowing nothing"},{"line_number":15,"context_line":"about it."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff29425b_b3b0948f","line":13,"in_reply_to":"fbf05102_da13b7d9","updated":"2024-05-11 01:14:37.000000000","message":"Done","commit_id":"a4ea12133b53ac27a1ec26d37de0ed85eee70d9e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f55db4822e01f19a3ceb5245efa18105f0938553","unresolved":true,"context_lines":[{"line_number":12,"context_line":"driver, that the ovsdb_connection will remain on the class even"},{"line_number":13,"context_line":"though the instances are deleted. This will allow us to resuse the"},{"line_number":14,"context_line":"OVSDB connection between APIs despite octavia-api knowing nothing"},{"line_number":15,"context_line":"about it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4f5df34ab32e8b33ff54f311b9b2ac00c9be1e05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1bde5992_1e97d8bf","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":9},"updated":"2024-05-10 20:55:22.000000000","message":"you could also mention here that this also has a nice side-effect of not running __del__ in a random thread due to garbage collector behavior. Which in turn fixes the situation where connection is never closed because __del__ crashes when executed in the same thread where the idl thread started.","commit_id":"a4ea12133b53ac27a1ec26d37de0ed85eee70d9e"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"cde951592eb39f7c6284c989f4a5d7f7ded16e1c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"driver, that the ovsdb_connection will remain on the class even"},{"line_number":13,"context_line":"though the instances are deleted. This will allow us to resuse the"},{"line_number":14,"context_line":"OVSDB connection between APIs despite octavia-api knowing nothing"},{"line_number":15,"context_line":"about it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4f5df34ab32e8b33ff54f311b9b2ac00c9be1e05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f078e44_2f5d18c0","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":9},"in_reply_to":"1bde5992_1e97d8bf","updated":"2024-05-11 01:14:37.000000000","message":"Done","commit_id":"a4ea12133b53ac27a1ec26d37de0ed85eee70d9e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f55db4822e01f19a3ceb5245efa18105f0938553","unresolved":true,"context_lines":[{"line_number":13,"context_line":"though the instances are deleted. This will allow us to resuse the"},{"line_number":14,"context_line":"OVSDB connection between APIs despite octavia-api knowing nothing"},{"line_number":15,"context_line":"about it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4f5df34ab32e8b33ff54f311b9b2ac00c9be1e05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"51643d0a_ac0ac11b","line":16,"updated":"2024-05-10 20:55:22.000000000","message":"you may mention that this is, in effect, a revert of I46681c7649d604d9a3fc5ad2c4c91167fe4873ee (do we have an explanation why we did I46681c7649d604d9a3fc5ad2c4c91167fe4873ee in the first place? shouldn\u0027t we\u0027ve kept the other branch of try-except in place?)","commit_id":"a4ea12133b53ac27a1ec26d37de0ed85eee70d9e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b6cf1429fe469fca9248a8d7f71bc8f126169adb","unresolved":true,"context_lines":[{"line_number":13,"context_line":"though the instances are deleted. This will allow us to resuse the"},{"line_number":14,"context_line":"OVSDB connection between APIs despite octavia-api knowing nothing"},{"line_number":15,"context_line":"about it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4f5df34ab32e8b33ff54f311b9b2ac00c9be1e05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"89a433a3_fee132c8","line":16,"in_reply_to":"2780ceda_b79f5441","updated":"2024-05-13 21:48:41.000000000","message":"I misunderstood the idea behind the \"revert\". It was not a wrong revert, it made sense in the context when the code was written (in networking-ovn). Disregard.","commit_id":"a4ea12133b53ac27a1ec26d37de0ed85eee70d9e"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"cde951592eb39f7c6284c989f4a5d7f7ded16e1c","unresolved":true,"context_lines":[{"line_number":13,"context_line":"though the instances are deleted. This will allow us to resuse the"},{"line_number":14,"context_line":"OVSDB connection between APIs despite octavia-api knowing nothing"},{"line_number":15,"context_line":"about it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4f5df34ab32e8b33ff54f311b9b2ac00c9be1e05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"682e3e7f_03791544","line":16,"in_reply_to":"51643d0a_ac0ac11b","updated":"2024-05-11 01:14:37.000000000","message":"Since this is a copy of that code into a different project, it won\u0027t really be a revert since neutron will still have that code.\n\nApparently there used to be a lot of annoying log messages caused by the testing framework. Presumably because connections would stick around between tests? It seems like creating a special version for testing and not runtime to work around that would have been good if that was the case. But the patch author did not take the time to create a LP bug for the issue so that we could be sure many years later. Shame on them.","commit_id":"a4ea12133b53ac27a1ec26d37de0ed85eee70d9e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ac5283db1cbc347a0f388d945475119f2ef55bb1","unresolved":true,"context_lines":[{"line_number":13,"context_line":"though the instances are deleted. This will allow us to resuse the"},{"line_number":14,"context_line":"OVSDB connection between APIs despite octavia-api knowing nothing"},{"line_number":15,"context_line":"about it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4f5df34ab32e8b33ff54f311b9b2ac00c9be1e05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2780ceda_b79f5441","line":16,"in_reply_to":"682e3e7f_03791544","updated":"2024-05-13 20:42:07.000000000","message":"Should we still refer to prior art somewhere here, to keep the chain of logic as documented as possible? I don\u0027t want to repeat archaeology search later, again.","commit_id":"a4ea12133b53ac27a1ec26d37de0ed85eee70d9e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1f17dbeab41c4430bff5755a62ca8a9b670dd881","unresolved":false,"context_lines":[{"line_number":13,"context_line":"though the instances are deleted. This will allow us to resuse the"},{"line_number":14,"context_line":"OVSDB connection between APIs despite octavia-api knowing nothing"},{"line_number":15,"context_line":"about it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4f5df34ab32e8b33ff54f311b9b2ac00c9be1e05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f420927b_c795f609","line":16,"in_reply_to":"89a433a3_fee132c8","updated":"2024-05-13 21:48:49.000000000","message":"Done","commit_id":"a4ea12133b53ac27a1ec26d37de0ed85eee70d9e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f55db4822e01f19a3ceb5245efa18105f0938553","unresolved":true,"context_lines":[{"line_number":14,"context_line":"OVSDB connection between APIs despite octavia-api knowing nothing"},{"line_number":15,"context_line":"about it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4f5df34ab32e8b33ff54f311b9b2ac00c9be1e05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"83833163_6b0c512d","line":17,"updated":"2024-05-10 20:55:22.000000000","message":"we should probably have a bug reported with the tracebacks we got in that cursed env.","commit_id":"a4ea12133b53ac27a1ec26d37de0ed85eee70d9e"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"cde951592eb39f7c6284c989f4a5d7f7ded16e1c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"OVSDB connection between APIs despite octavia-api knowing nothing"},{"line_number":15,"context_line":"about it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4f5df34ab32e8b33ff54f311b9b2ac00c9be1e05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"44e28f9a_8d46cb03","line":17,"in_reply_to":"83833163_6b0c512d","updated":"2024-05-11 01:14:37.000000000","message":"The patch author should definitely do this. Shame on them.","commit_id":"a4ea12133b53ac27a1ec26d37de0ed85eee70d9e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f55db4822e01f19a3ceb5245efa18105f0938553","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e6214d66_a2c89542","updated":"2024-05-10 20:55:22.000000000","message":"Seems reasonable but we\u0027ll need CI results. I hear that unit tests crash at least.","commit_id":"a4ea12133b53ac27a1ec26d37de0ed85eee70d9e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"424f8f9f62db0daa5594c36cf9f234b175cec236","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"af7141e0_0a711aac","updated":"2024-05-10 20:59:04.000000000","message":"We will need to clean up the comment, commit message, etc. But code wise it\u0027s good.","commit_id":"1b0eb138e6ab7c8ab70ab19bcf3cb592a1f20f21"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2b39fa06afbaa93d4298642487a0bbf4e1e682c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b8fbbee0_b22e999e","updated":"2024-05-10 23:33:39.000000000","message":"recheck","commit_id":"1b0eb138e6ab7c8ab70ab19bcf3cb592a1f20f21"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"451a487bc83d1ace4094db425df2bdca917c594b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c85fb8fe_a594c046","updated":"2024-05-11 02:31:50.000000000","message":"Test failures in tempest jobs suggest that uwsgi o-api process at one point stops serving any requests. Then tempest REST client times out on /load-balancer/ URL; and we can see in apache access log that lbaas requests start returning 500 (instead of 2xx, 4xx, or 501 - as seems \"normal\" for o-api with ovn). Clearly, something deadlocks / dies in apache/uwsgi/o-api chain. And clearly it\u0027s related to this patch. We\u0027ll need to fix this and/or explain why this is happening.","commit_id":"c948e5968d1147d45510ed7d9843757102bca3ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"464b16a5f14eeabf6f505fef8b2ad0b75e216705","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d2748496_0e9c246d","updated":"2024-05-13 17:12:29.000000000","message":"I\u0027d prefer someone outside the co-authorship group reviews it too before we merge.","commit_id":"0866aa4bbfb391723ca5bc8167e8cefacc103a2e"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"db12b858ce084ca93e5253079598a7270f90d429","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6bfe00ed_32bf3a85","updated":"2024-05-13 14:52:26.000000000","message":"LGTM waiting for CI","commit_id":"0866aa4bbfb391723ca5bc8167e8cefacc103a2e"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"199a7d23a5135307c06ef3015ff305dd93f7a6dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ffd450c2_e2a10769","updated":"2024-05-13 15:44:01.000000000","message":"recheck ovn-octavia-provider-functional-release unrelated","commit_id":"0866aa4bbfb391723ca5bc8167e8cefacc103a2e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"dfc17a46d9f867354b50dc276f211e23aacca352","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bc4a750a_df773ae5","updated":"2024-05-13 17:14:58.000000000","message":"vlog change doesn\u0027t belong here.","commit_id":"0866aa4bbfb391723ca5bc8167e8cefacc103a2e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"04a65ffde15c54d4a9c8b67e738e599c952bf16e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1087f041_d900d25f","updated":"2024-05-13 17:14:07.000000000","message":"vlog should definitely be removed; I would also love if we are given some time to chime in here with reviews. I won\u0027t get to it in several days. But I think it\u0027s ok?","commit_id":"0866aa4bbfb391723ca5bc8167e8cefacc103a2e"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"b426f78f88db2996ab5ac547642e26338fc4fa67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"33abf14c_3c667e67","updated":"2024-05-14 15:16:47.000000000","message":"Have pep8 been modified from yesterday to today?","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"36bdae430ed54585bb1aa08feb58dd5423330552","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"aef02f96_e70b453d","updated":"2024-05-13 20:43:17.000000000","message":"I found time to review the code; left some comments; we can proceed as usual.","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3cbe4b9c8aa661b73b209a9dc32d420b64d3f978","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b783710f_8d016902","updated":"2024-05-13 19:28:39.000000000","message":"I\u0027m *asking* to please note merge this until everyone involved has some chance to consider the implications of this drastic change. I am asking for some time to review this before the end of this week at most.\n\nI am setting -2 since I think it\u0027s the only sticky state that would guarantee no merging before then. It\u0027s in no way a reflection of my opinion about the change (which is a piece of cake - I am sure.)","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b2c2f8800d0f38ad4d458e2f8d6f2bbd7b8eed52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"adaacd73_41841964","updated":"2024-05-14 14:43:38.000000000","message":"Thanks Ihar, I\u0027m not putting +W - would be good if Fernando gave his blessing too.","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"23df6b47569b37ccc76af597d0a63990a30ea907","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f73547bb_bb0b6e23","updated":"2024-05-14 12:56:55.000000000","message":"The patch LGTM, putting +1 because of the present negative vote but can change to +2 if we decided there are no actions required on this patch.","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e0f8b7dca9e35237757252426af1c3a2706c9be0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c4b4916f_0d8d8121","updated":"2024-05-14 14:04:24.000000000","message":"This is fine and all my stupid questions were addressed. 😊","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"c4fb6208490748b5e07e8797c682419c83327e0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"96be7c63_34952556","updated":"2024-05-14 15:16:57.000000000","message":"recheck pep8","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a97433d648ee3ad87888f35831a0dd6765dce9bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"24156c75_361941f6","updated":"2024-05-14 23:17:11.000000000","message":"recheck","commit_id":"9c2274e813fe167b79b1ceb7f8da188e251cc6ef"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"ba968b18ecd12a32f11368fd16a74a10be9c52da","unresolved":true,"context_lines":[{"line_number":49,"context_line":"CONF \u003d cfg.CONF  # Gets Octavia Conf as it runs under o-api domain"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":52,"context_line":"vlog.use_python_logger()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class OvnProviderHelper():"}],"source_content_type":"text/x-python","patch_set":7,"id":"4fc10534_ee204c8e","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":22},"updated":"2024-05-13 14:50:57.000000000","message":"do we really want to keep it? it looks very verbose","commit_id":"b338826785f8a414bb47a33d28091cbe774631c6"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"aadb9c42a319f00e420aa3b69a06ba79adcdb213","unresolved":true,"context_lines":[{"line_number":49,"context_line":"CONF \u003d cfg.CONF  # Gets Octavia Conf as it runs under o-api domain"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":52,"context_line":"vlog.use_python_logger()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class OvnProviderHelper():"}],"source_content_type":"text/x-python","patch_set":7,"id":"aacabc30_5f46f54d","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":22},"in_reply_to":"4233b2f1_b829439c","updated":"2024-05-13 17:28:52.000000000","message":"I remember some talk with Terry about this, recommending me to put up somewhere to get info about connecting/disconnnecting/reconnecting about ovsdbapp, but let\u0027s let him be the one to enlighten us, because now the connection has changed its life cycle","commit_id":"b338826785f8a414bb47a33d28091cbe774631c6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"04a65ffde15c54d4a9c8b67e738e599c952bf16e","unresolved":true,"context_lines":[{"line_number":49,"context_line":"CONF \u003d cfg.CONF  # Gets Octavia Conf as it runs under o-api domain"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":52,"context_line":"vlog.use_python_logger()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class OvnProviderHelper():"}],"source_content_type":"text/x-python","patch_set":7,"id":"4233b2f1_b829439c","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":22},"in_reply_to":"4fc10534_ee204c8e","updated":"2024-05-13 17:14:07.000000000","message":"I don\u0027t think so; and I don\u0027t think it belongs here.","commit_id":"b338826785f8a414bb47a33d28091cbe774631c6"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"f97ad52387eeb13d5ba9d51a84bd133dab4eba05","unresolved":true,"context_lines":[{"line_number":49,"context_line":"CONF \u003d cfg.CONF  # Gets Octavia Conf as it runs under o-api domain"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":52,"context_line":"vlog.use_python_logger()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class OvnProviderHelper():"}],"source_content_type":"text/x-python","patch_set":7,"id":"d8d44b8c_b88e295d","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":22},"in_reply_to":"aacabc30_5f46f54d","updated":"2024-05-13 17:57:46.000000000","message":"It would probably be better to take it out and make a real configurable version of it similar to how neutron configures the ovsdb log level. I mostly put it in to sneak in some debugging information that we could use while testing the patch.","commit_id":"b338826785f8a414bb47a33d28091cbe774631c6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e0f8b7dca9e35237757252426af1c3a2706c9be0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"CONF \u003d cfg.CONF  # Gets Octavia Conf as it runs under o-api domain"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":52,"context_line":"vlog.use_python_logger()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class OvnProviderHelper():"}],"source_content_type":"text/x-python","patch_set":7,"id":"7e428bb5_346c561e","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":22},"in_reply_to":"d8d44b8c_b88e295d","updated":"2024-05-14 14:04:24.000000000","message":"Done","commit_id":"b338826785f8a414bb47a33d28091cbe774631c6"}],"ovn_octavia_provider/ovsdb/impl_idl_ovn.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f55db4822e01f19a3ceb5245efa18105f0938553","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        self.api.nb_global.increment(\u0027nb_cfg\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# This version of Backend doesn\u0027t use a class variable for ovsdb_connection"},{"line_number":56,"context_line":"# and therefor allows networking-ovn to manage connection scope on its own"},{"line_number":57,"context_line":"class Backend(ovs_idl.Backend):"},{"line_number":58,"context_line":"    lookup_table \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa058993_f3351df3","side":"PARENT","line":55,"updated":"2024-05-10 20:55:22.000000000","message":"this comment should be removed","commit_id":"f034bab144b68cf96c538339e389c4cc7c6d7d63"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"cde951592eb39f7c6284c989f4a5d7f7ded16e1c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.api.nb_global.increment(\u0027nb_cfg\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# This version of Backend doesn\u0027t use a class variable for ovsdb_connection"},{"line_number":56,"context_line":"# and therefor allows networking-ovn to manage connection scope on its own"},{"line_number":57,"context_line":"class Backend(ovs_idl.Backend):"},{"line_number":58,"context_line":"    lookup_table \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"e356b102_c1dc446a","side":"PARENT","line":55,"in_reply_to":"fa058993_f3351df3","updated":"2024-05-11 01:14:37.000000000","message":"Done","commit_id":"f034bab144b68cf96c538339e389c4cc7c6d7d63"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ac5283db1cbc347a0f388d945475119f2ef55bb1","unresolved":true,"context_lines":[{"line_number":229,"context_line":"        return idlutils.get_schema_helper(connection_string, self.SCHEMA)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"class OvnSbIdlForLb(ovsdb_monitor.OvnIdl):"},{"line_number":233,"context_line":"    SCHEMA \u003d \"OVN_Southbound\""},{"line_number":234,"context_line":"    TABLES \u003d (\u0027Load_Balancer\u0027, \u0027Service_Monitor\u0027)"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"822068b6_de4cb4a8","line":232,"updated":"2024-05-13 20:42:07.000000000","message":"I wonder if we should patch sb class also; or at least explain if a) it should be done later, in a separate patch; or b) why it is not needed.","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"23df6b47569b37ccc76af597d0a63990a30ea907","unresolved":true,"context_lines":[{"line_number":229,"context_line":"        return idlutils.get_schema_helper(connection_string, self.SCHEMA)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"class OvnSbIdlForLb(ovsdb_monitor.OvnIdl):"},{"line_number":233,"context_line":"    SCHEMA \u003d \"OVN_Southbound\""},{"line_number":234,"context_line":"    TABLES \u003d (\u0027Load_Balancer\u0027, \u0027Service_Monitor\u0027)"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"872ed9f7_20887e68","line":232,"in_reply_to":"822068b6_de4cb4a8","updated":"2024-05-14 12:56:55.000000000","message":"I\u0027d be fine doing it later, leaving as is for now, perhaps opening an LP bug. This patch is about fixing the connections being created per request. Quickly grepping it seems this class is used only in agent - that means it\u0027s not used in the path of the request processing.","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"eae6c16c821a33dd09d2de80b08fbf86f3ca2304","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        return idlutils.get_schema_helper(connection_string, self.SCHEMA)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"class OvnSbIdlForLb(ovsdb_monitor.OvnIdl):"},{"line_number":233,"context_line":"    SCHEMA \u003d \"OVN_Southbound\""},{"line_number":234,"context_line":"    TABLES \u003d (\u0027Load_Balancer\u0027, \u0027Service_Monitor\u0027)"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"59477712_bc2022cd","line":232,"in_reply_to":"822068b6_de4cb4a8","updated":"2024-05-15 13:50:26.000000000","message":"The reason was just simply \"SB only exists in the agent, the bug is with the driver, so nothing to fix\". Generally I tend to be against muddying fixes with modifications to parts of the code that aren\u0027t affected. Any refactor would likely change how all of these work.","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e0f8b7dca9e35237757252426af1c3a2706c9be0","unresolved":true,"context_lines":[{"line_number":229,"context_line":"        return idlutils.get_schema_helper(connection_string, self.SCHEMA)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"class OvnSbIdlForLb(ovsdb_monitor.OvnIdl):"},{"line_number":233,"context_line":"    SCHEMA \u003d \"OVN_Southbound\""},{"line_number":234,"context_line":"    TABLES \u003d (\u0027Load_Balancer\u0027, \u0027Service_Monitor\u0027)"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7baa1158_77beb446","line":232,"in_reply_to":"872ed9f7_20887e68","updated":"2024-05-14 14:04:24.000000000","message":"a commit message update explaining why this is not a problem suffices","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"}],"ovn_octavia_provider/ovsdb/ovsdb_monitor.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2160274f6d80e2d6ff7e67f43454491e99e6417d","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        #    these neutron servers would receive the notify events from"},{"line_number":55,"context_line":"        #    idl.Idl"},{"line_number":56,"context_line":"        #"},{"line_number":57,"context_line":"        #  - we do not want all the neutron servers to handle these events"},{"line_number":58,"context_line":"        #"},{"line_number":59,"context_line":"        #  - only the neutron server which has the lock will handle the"},{"line_number":60,"context_line":"        #    notify events."}],"source_content_type":"text/x-python","patch_set":10,"id":"61005aa4_d082adc3","line":57,"updated":"2024-05-13 19:53:43.000000000","message":"I\u0027m trying to figure out the code here, and I\u0027m confused by this comment. Why is it talking about neutron-servers?.. Anyone knows?","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"6321c16582b4044670a011eaaf0a92dc9d70fdc9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        #    these neutron servers would receive the notify events from"},{"line_number":55,"context_line":"        #    idl.Idl"},{"line_number":56,"context_line":"        #"},{"line_number":57,"context_line":"        #  - we do not want all the neutron servers to handle these events"},{"line_number":58,"context_line":"        #"},{"line_number":59,"context_line":"        #  - only the neutron server which has the lock will handle the"},{"line_number":60,"context_line":"        #    notify events."}],"source_content_type":"text/x-python","patch_set":10,"id":"a9b7041d_29058786","line":57,"in_reply_to":"61005aa4_d082adc3","updated":"2024-05-13 20:54:50.000000000","message":"because all of this was copied from the neutron tree verbatim at one point.","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cd87fa5a373c7b1364b5ff5a4f30c36a0bd848a3","unresolved":true,"context_lines":[{"line_number":67,"context_line":"    def notify(self, event, row, updates\u003dNone):"},{"line_number":68,"context_line":"        # Do not handle the notification if the event lock is requested,"},{"line_number":69,"context_line":"        # but not granted by the ovsdb-server."},{"line_number":70,"context_line":"        if self.is_lock_contended:"},{"line_number":71,"context_line":"            return"},{"line_number":72,"context_line":"        if not self.notify_handler:"},{"line_number":73,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":10,"id":"d28b0d7f_010def6b","line":70,"updated":"2024-05-13 20:25:14.000000000","message":"I wonder if this lock is needed. The notify thread is running in agent only. Does the agent run multiple workers? Or is it some remnants from when this code resided in networking-ovn?..","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b14e439f439867412107e0b47817d7edf0a80713","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def notify(self, event, row, updates\u003dNone):"},{"line_number":68,"context_line":"        # Do not handle the notification if the event lock is requested,"},{"line_number":69,"context_line":"        # but not granted by the ovsdb-server."},{"line_number":70,"context_line":"        if self.is_lock_contended:"},{"line_number":71,"context_line":"            return"},{"line_number":72,"context_line":"        if not self.notify_handler:"},{"line_number":73,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":10,"id":"e821daa3_046699a3","line":70,"in_reply_to":"c2cf874f_06be7f23","updated":"2024-05-13 21:47:50.000000000","message":"I misunderstood the notion of \"agent\" in Octavia. Indeed, now I see it\u0027s just a translator from OVN to OVN. so it\u0027s important one \"agent\" handles the events. (There is a risk in how it handles locks that some events may be lost on crash. But this is a separate topic that I don\u0027t think we should focus on.)","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"6321c16582b4044670a011eaaf0a92dc9d70fdc9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def notify(self, event, row, updates\u003dNone):"},{"line_number":68,"context_line":"        # Do not handle the notification if the event lock is requested,"},{"line_number":69,"context_line":"        # but not granted by the ovsdb-server."},{"line_number":70,"context_line":"        if self.is_lock_contended:"},{"line_number":71,"context_line":"            return"},{"line_number":72,"context_line":"        if not self.notify_handler:"},{"line_number":73,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":10,"id":"c2cf874f_06be7f23","line":70,"in_reply_to":"d28b0d7f_010def6b","updated":"2024-05-13 20:54:50.000000000","message":"It is needed in the agent, but nowhere else. it\u0027s one reason eventually I\u0027d like to refactor to multiple API classes. Also, setting the attribute here and then doing the lock elsewhere is weird. But not something I was willing to change as part of a bug fix.","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"}],"ovn_octavia_provider/tests/unit/ovsdb/test_impl_idl_ovn.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"534bc8cd76d1ad31267cacb28f079eea50e3ea92","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @mock.patch.object(real_ovs_idl.Backend, \u0027autocreate_indices\u0027, mock.Mock(),"},{"line_number":56,"context_line":"                       create\u003dTrue)"},{"line_number":57,"context_line":"    def test_start(self):"},{"line_number":58,"context_line":"        with mock.patch(\u0027ovsdbapp.backend.ovs_idl.connection.Connection\u0027,"},{"line_number":59,"context_line":"                        side_effect\u003dlambda x, timeout: mock.Mock()):"},{"line_number":60,"context_line":"            idl1 \u003d impl_idl_ovn.OvnNbIdlForLb()"}],"source_content_type":"text/x-python","patch_set":2,"id":"c88cbafb_db46e91f","line":57,"updated":"2024-05-10 20:58:34.000000000","message":"(no action required) the name of the test case is too generic, should be smth like `test_start_reuses_connection`","commit_id":"1b0eb138e6ab7c8ab70ab19bcf3cb592a1f20f21"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"cde951592eb39f7c6284c989f4a5d7f7ded16e1c","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @mock.patch.object(real_ovs_idl.Backend, \u0027autocreate_indices\u0027, mock.Mock(),"},{"line_number":56,"context_line":"                       create\u003dTrue)"},{"line_number":57,"context_line":"    def test_start(self):"},{"line_number":58,"context_line":"        with mock.patch(\u0027ovsdbapp.backend.ovs_idl.connection.Connection\u0027,"},{"line_number":59,"context_line":"                        side_effect\u003dlambda x, timeout: mock.Mock()):"},{"line_number":60,"context_line":"            idl1 \u003d impl_idl_ovn.OvnNbIdlForLb()"}],"source_content_type":"text/x-python","patch_set":2,"id":"afc25e80_2fe46455","line":57,"in_reply_to":"c88cbafb_db46e91f","updated":"2024-05-11 01:14:37.000000000","message":"Done","commit_id":"1b0eb138e6ab7c8ab70ab19bcf3cb592a1f20f21"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6742dbe18dda06d942406c86b607b006ec041572","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        super().setUp()"},{"line_number":38,"context_line":"        ovn_config.register_opts()"},{"line_number":39,"context_line":"        # TODO(haleyb) - figure out why every test in this class generates"},{"line_number":40,"context_line":"        # this warning, think it\u0027s in relation to reading this schema file:"},{"line_number":41,"context_line":"        # sys:1: ResourceWarning: unclosed file \u003c_io.FileIO name\u003d1 mode\u003d\u0027wb\u0027"},{"line_number":42,"context_line":"        # closefd\u003dTrue\u003e ResourceWarning: Enable tracemalloc to get the object"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa1371e_2abdcb8c","line":39,"updated":"2024-05-13 20:29:38.000000000","message":"I am not sure this comment is valid anymore. I believe we fixed it with this patch. Need to validate.","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"23df6b47569b37ccc76af597d0a63990a30ea907","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        super().setUp()"},{"line_number":38,"context_line":"        ovn_config.register_opts()"},{"line_number":39,"context_line":"        # TODO(haleyb) - figure out why every test in this class generates"},{"line_number":40,"context_line":"        # this warning, think it\u0027s in relation to reading this schema file:"},{"line_number":41,"context_line":"        # sys:1: ResourceWarning: unclosed file \u003c_io.FileIO name\u003d1 mode\u003d\u0027wb\u0027"},{"line_number":42,"context_line":"        # closefd\u003dTrue\u003e ResourceWarning: Enable tracemalloc to get the object"}],"source_content_type":"text/x-python","patch_set":10,"id":"8bf5d672_e5150515","line":39,"in_reply_to":"1fa1371e_2abdcb8c","updated":"2024-05-14 12:56:55.000000000","message":"I tried with older version without this patch and the error is no longer present. Seems unrelated to this patch and imho should be cleaned up in a separate patch.","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e0f8b7dca9e35237757252426af1c3a2706c9be0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        super().setUp()"},{"line_number":38,"context_line":"        ovn_config.register_opts()"},{"line_number":39,"context_line":"        # TODO(haleyb) - figure out why every test in this class generates"},{"line_number":40,"context_line":"        # this warning, think it\u0027s in relation to reading this schema file:"},{"line_number":41,"context_line":"        # sys:1: ResourceWarning: unclosed file \u003c_io.FileIO name\u003d1 mode\u003d\u0027wb\u0027"},{"line_number":42,"context_line":"        # closefd\u003dTrue\u003e ResourceWarning: Enable tracemalloc to get the object"}],"source_content_type":"text/x-python","patch_set":10,"id":"a46b1d11_2b4e9803","line":39,"in_reply_to":"8bf5d672_e5150515","updated":"2024-05-14 14:04:24.000000000","message":"that may be the case; I remember we saw this exact error when we were not mocking out Connection; and now that we do, it doesn\u0027t happen. Perhaps it was fixed before us touching the code in the first place. If so, no need to change this here of course.","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b547a821141ec788f23b6715840ad7c8bc3a4924","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        super().setUp()"},{"line_number":66,"context_line":"        ovn_config.register_opts()"},{"line_number":67,"context_line":"        # TODO(haleyb) - figure out why every test in this class generates"},{"line_number":68,"context_line":"        # this warning, think it\u0027s in relation to reading this schema file:"},{"line_number":69,"context_line":"        # sys:1: ResourceWarning: unclosed file \u003c_io.FileIO name\u003d1 mode\u003d\u0027wb\u0027"},{"line_number":70,"context_line":"        # closefd\u003dTrue\u003e ResourceWarning: Enable tracemalloc to get the object"}],"source_content_type":"text/x-python","patch_set":10,"id":"eb1ceb2c_0e1c21fc","line":67,"updated":"2024-05-13 20:47:30.000000000","message":"also here?","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9d4e1f83575272e7a3212ee93efa57f9fc14f35b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        super().setUp()"},{"line_number":66,"context_line":"        ovn_config.register_opts()"},{"line_number":67,"context_line":"        # TODO(haleyb) - figure out why every test in this class generates"},{"line_number":68,"context_line":"        # this warning, think it\u0027s in relation to reading this schema file:"},{"line_number":69,"context_line":"        # sys:1: ResourceWarning: unclosed file \u003c_io.FileIO name\u003d1 mode\u003d\u0027wb\u0027"},{"line_number":70,"context_line":"        # closefd\u003dTrue\u003e ResourceWarning: Enable tracemalloc to get the object"}],"source_content_type":"text/x-python","patch_set":10,"id":"cc19e753_a946edcc","line":67,"in_reply_to":"eb1ceb2c_0e1c21fc","updated":"2024-05-14 15:41:57.000000000","message":"Done","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"}],"ovn_octavia_provider/tests/unit/test_helper.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ac5283db1cbc347a0f388d945475119f2ef55bb1","unresolved":true,"context_lines":[{"line_number":4006,"context_line":"        ovn_helper.OvnProviderHelper.ovn_nbdb_api_for_events \u003d None"},{"line_number":4007,"context_line":"        prov_helper1 \u003d ovn_helper.OvnProviderHelper()"},{"line_number":4008,"context_line":"        prov_helper2 \u003d ovn_helper.OvnProviderHelper()"},{"line_number":4009,"context_line":"        # One connection for API requests"},{"line_number":4010,"context_line":"        self.assertIs(prov_helper1.ovn_nbdb_api.ovsdb_connection,"},{"line_number":4011,"context_line":"                      prov_helper2.ovn_nbdb_api.ovsdb_connection)"},{"line_number":4012,"context_line":"        # One connection to handle events"}],"source_content_type":"text/x-python","patch_set":10,"id":"f6924160_6f974080","line":4009,"updated":"2024-05-13 20:42:07.000000000","message":"interesting... was this test case meant to check that connection is the same? and it passed?","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"eae6c16c821a33dd09d2de80b08fbf86f3ca2304","unresolved":false,"context_lines":[{"line_number":4006,"context_line":"        ovn_helper.OvnProviderHelper.ovn_nbdb_api_for_events \u003d None"},{"line_number":4007,"context_line":"        prov_helper1 \u003d ovn_helper.OvnProviderHelper()"},{"line_number":4008,"context_line":"        prov_helper2 \u003d ovn_helper.OvnProviderHelper()"},{"line_number":4009,"context_line":"        # One connection for API requests"},{"line_number":4010,"context_line":"        self.assertIs(prov_helper1.ovn_nbdb_api.ovsdb_connection,"},{"line_number":4011,"context_line":"                      prov_helper2.ovn_nbdb_api.ovsdb_connection)"},{"line_number":4012,"context_line":"        # One connection to handle events"}],"source_content_type":"text/x-python","patch_set":10,"id":"28672d40_7b7eb1f6","line":4009,"in_reply_to":"f6924160_6f974080","updated":"2024-05-15 13:50:26.000000000","message":"lol, so I looked into it and the OvnProviderHelper is mocked. start() is returning a MagicMock()\n\n```\ntest ovn_nbdb_api1: \u003cMagicMock name\u003d\u0027OvnNbIdlForLb().start()\u0027 id\u003d\u0027140371082924288\u0027\u003e\ntest ovn_nbdb_api2: \u003cMagicMock name\u003d\u0027OvnNbIdlForLb().start()\u0027 id\u003d\u0027140371082924288\u0027\u003e\n```","commit_id":"223c1058587cfe37f58ea81c24d6bdabf14e3595"}]}