)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"3fe10a0ca24f9576e4dd1863787c91df2efb3681","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5f4c709a_a5f705b2","updated":"2024-10-11 12:03:24.000000000","message":"recheck ovn-octavia-provider-functional-release unrelated","commit_id":"bc2718f13509c5fd253437986b35af5a9285f4ea"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"f62793141e2f0a651405d2ec4740599d7cf39422","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"afb1918d_86b4d18c","updated":"2024-10-14 09:04:15.000000000","message":"recheck post_failure unrelated","commit_id":"bc2718f13509c5fd253437986b35af5a9285f4ea"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"fb813492fc092c1c359f87999b65a823ef66cb75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"360edc8e_c992d655","updated":"2024-11-28 17:14:53.000000000","message":"recheck ovn-octavia-provider-tempest-release unrelated","commit_id":"ca376260491c70fb1fff64ccd26460bfbe6b893e"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"96947dc94de20ffe09d83ca682e85d0f90a6b5dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"69eedbe5_27df3e16","updated":"2025-02-18 20:38:44.000000000","message":"recheck after merging https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/941928","commit_id":"e7068ae6a0f0744993fa9db14c8885a9c813b7ae"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"d88c86de8fea55db2b2d0745e631199a5bc44c31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"0d591b3a_f6f411a0","updated":"2025-02-19 11:27:30.000000000","message":"recheck after tempest fix merged","commit_id":"e7068ae6a0f0744993fa9db14c8885a9c813b7ae"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"86785b050403488a2038ebd0631b288f5c9ff8d7","unresolved":true,"context_lines":[{"line_number":2013,"context_line":"        if pool[constants.LISTENER_ID]:"},{"line_number":2014,"context_line":"            listener_key \u003d self._get_listener_key(pool[constants.LISTENER_ID])"},{"line_number":2015,"context_line":"            # NOTE(froyo): checking is not already when ovn-db-sync-tool is"},{"line_number":2016,"context_line":"            # triggered, because listener_creaet could be added already if"},{"line_number":2017,"context_line":"            # pool is considered as default one"},{"line_number":2018,"context_line":"            if listener_key in ovn_lb.external_ids and \\"},{"line_number":2019,"context_line":"                    str(pool_key) not in external_ids[listener_key]:"}],"source_content_type":"text/x-python","patch_set":8,"id":"f5790e0b_bc352de4","line":2016,"range":{"start_line":2016,"start_character":33,"end_line":2016,"end_character":48},"updated":"2024-11-13 09:54:46.000000000","message":"nitty nit: typo","commit_id":"86ffeb21072c9aa87d99799ed448a265769a9943"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"f07b7a14019540c25cdbd73081c2c646e6bb884c","unresolved":false,"context_lines":[{"line_number":2013,"context_line":"        if pool[constants.LISTENER_ID]:"},{"line_number":2014,"context_line":"            listener_key \u003d self._get_listener_key(pool[constants.LISTENER_ID])"},{"line_number":2015,"context_line":"            # NOTE(froyo): checking is not already when ovn-db-sync-tool is"},{"line_number":2016,"context_line":"            # triggered, because listener_creaet could be added already if"},{"line_number":2017,"context_line":"            # pool is considered as default one"},{"line_number":2018,"context_line":"            if listener_key in ovn_lb.external_ids and \\"},{"line_number":2019,"context_line":"                    str(pool_key) not in external_ids[listener_key]:"}],"source_content_type":"text/x-python","patch_set":8,"id":"80b1bdcd_1fe9ef03","line":2016,"range":{"start_line":2016,"start_character":33,"end_line":2016,"end_character":48},"in_reply_to":"f5790e0b_bc352de4","updated":"2024-11-18 16:04:14.000000000","message":"Done","commit_id":"86ffeb21072c9aa87d99799ed448a265769a9943"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"86785b050403488a2038ebd0631b288f5c9ff8d7","unresolved":true,"context_lines":[{"line_number":2080,"context_line":""},{"line_number":2081,"context_line":"        The method performs the following steps:"},{"line_number":2082,"context_line":"        1. Update pool key on OVN Loadbalancer external_ids if needed"},{"line_number":2083,"context_line":"        2. Update OVN LoadBalancer options from Pool info if needed"},{"line_number":2084,"context_line":""},{"line_number":2085,"context_line":"        :param pool: The source pool object from Octavia DB"},{"line_number":2086,"context_line":"        :param ovn_lb: The OVN LoadBalancer object that needs to be sync"}],"source_content_type":"text/x-python","patch_set":8,"id":"468927bc_ae0751ac","line":2083,"updated":"2024-11-13 09:54:46.000000000","message":"You say here that you are updating pool key and LB options only if needed but from the code I see that external_ids are updated always. Is that correct?","commit_id":"86ffeb21072c9aa87d99799ed448a265769a9943"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"f07b7a14019540c25cdbd73081c2c646e6bb884c","unresolved":false,"context_lines":[{"line_number":2080,"context_line":""},{"line_number":2081,"context_line":"        The method performs the following steps:"},{"line_number":2082,"context_line":"        1. Update pool key on OVN Loadbalancer external_ids if needed"},{"line_number":2083,"context_line":"        2. Update OVN LoadBalancer options from Pool info if needed"},{"line_number":2084,"context_line":""},{"line_number":2085,"context_line":"        :param pool: The source pool object from Octavia DB"},{"line_number":2086,"context_line":"        :param ovn_lb: The OVN LoadBalancer object that needs to be sync"}],"source_content_type":"text/x-python","patch_set":8,"id":"95d46595_68f0003e","line":2083,"in_reply_to":"468927bc_ae0751ac","updated":"2024-11-18 16:04:14.000000000","message":"that\u0027s correct. we can drop ` if needed` here","commit_id":"86ffeb21072c9aa87d99799ed448a265769a9943"}],"p.patch":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b55749887708008ccbf1154cfdb8e045be96e5cb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"diff --git a/ovn_octavia_provider/common/clients.py b/ovn_octavia_provider/common/clients.py"},{"line_number":2,"context_line":"index 04bcffb..ff14aef 100644"},{"line_number":3,"context_line":"--- a/ovn_octavia_provider/common/clients.py"},{"line_number":4,"context_line":"+++ b/ovn_octavia_provider/common/clients.py"}],"source_content_type":"text/x-diff","patch_set":9,"id":"a1e0e8dd_0dc0f1eb","line":1,"updated":"2024-11-19 10:22:11.000000000","message":"this is probably added here by mistake :)","commit_id":"73d890e88a399e3836e956b481fc765727a5e734"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"2f2661f18b92e5c99b477dd200f97adadd502797","unresolved":false,"context_lines":[{"line_number":1,"context_line":"diff --git a/ovn_octavia_provider/common/clients.py b/ovn_octavia_provider/common/clients.py"},{"line_number":2,"context_line":"index 04bcffb..ff14aef 100644"},{"line_number":3,"context_line":"--- a/ovn_octavia_provider/common/clients.py"},{"line_number":4,"context_line":"+++ b/ovn_octavia_provider/common/clients.py"}],"source_content_type":"text/x-diff","patch_set":9,"id":"b9ba4b2f_e1b25b69","line":1,"in_reply_to":"a1e0e8dd_0dc0f1eb","updated":"2024-11-19 11:58:42.000000000","message":"Done","commit_id":"73d890e88a399e3836e956b481fc765727a5e734"}]}