)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a65fccb03ac31b05c972e417c36c4a56ab5897dd","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Skip LB association to provider networks with localnet ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Provider networks (VLANs) with localnet ports cause datapath"},{"line_number":10,"context_line":"confusion when Load Balancers are associated to them. When traffic"},{"line_number":11,"context_line":"arrives via Floating IPs, this results in SYN packet drops and"},{"line_number":12,"context_line":"high latency issues."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"685ca072_242f2352","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":24},"updated":"2025-12-11 13:58:57.000000000","message":"VLAN and flat too","commit_id":"43e25f946a7b1d3e89716a6e9c11b42d7614dbea"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"dac570aca1eb64b1f3bce05f786eededb70f14eb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Skip LB association to provider networks with localnet ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Provider networks (VLANs) with localnet ports cause datapath"},{"line_number":10,"context_line":"confusion when Load Balancers are associated to them. When traffic"},{"line_number":11,"context_line":"arrives via Floating IPs, this results in SYN packet drops and"},{"line_number":12,"context_line":"high latency issues."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"87387560_d67b1b29","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":24},"in_reply_to":"685ca072_242f2352","updated":"2025-12-17 13:02:31.000000000","message":"Done","commit_id":"43e25f946a7b1d3e89716a6e9c11b42d7614dbea"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"0a54fd7a54201bb3ac2a38c7b0a79ad4fb933a21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"965a8c28_23278b1f","updated":"2025-12-17 14:33:20.000000000","message":"recheck functional-release","commit_id":"54082ca185de43a22293733a026ce049cf177a45"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a65fccb03ac31b05c972e417c36c4a56ab5897dd","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            self._clean_up_hm_port(subnet_id)"},{"line_number":139,"context_line":"            return None"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def _ls_has_localnet_port(self, ovn_ls):"},{"line_number":142,"context_line":"        \"\"\"Check if a Logical Switch has a localnet port (provider network)."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        Provider networks have localnet ports that connect to physical"}],"source_content_type":"text/x-python","patch_set":2,"id":"bdd34bf7_ccc375af","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":29},"updated":"2025-12-11 13:58:57.000000000","message":"Suggestion (for this patch and [1]): a LS.external_ids created by Neutron, always have \"neutron:provnet-physical-network\" if it is a provider network.\n\n[1]https://opendev.org/openstack/ovn-octavia-provider/src/branch/master/ovn_octavia_provider/helper.py#L1595","commit_id":"43e25f946a7b1d3e89716a6e9c11b42d7614dbea"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"dac570aca1eb64b1f3bce05f786eededb70f14eb","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            self._clean_up_hm_port(subnet_id)"},{"line_number":139,"context_line":"            return None"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def _ls_has_localnet_port(self, ovn_ls):"},{"line_number":142,"context_line":"        \"\"\"Check if a Logical Switch has a localnet port (provider network)."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        Provider networks have localnet ports that connect to physical"}],"source_content_type":"text/x-python","patch_set":2,"id":"5878f510_4491af9f","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":29},"in_reply_to":"bdd34bf7_ccc375af","updated":"2025-12-17 13:02:31.000000000","message":"Done","commit_id":"43e25f946a7b1d3e89716a6e9c11b42d7614dbea"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3eaeb45d61f42fa6f897424f949520b020ddf710","unresolved":true,"context_lines":[{"line_number":1000,"context_line":"                                \u0027not found in OVN NBDB. Exiting.\u0027,"},{"line_number":1001,"context_line":"                                {\u0027ls\u0027: ls_name, \u0027lb\u0027: ovn_lb.name})"},{"line_number":1002,"context_line":"                    return commands"},{"line_number":1003,"context_line":"            # NOTE(froyo): Skip association if this is a provider network."},{"line_number":1004,"context_line":"            # Provider networks have localnet ports (e.g., VLAN networks) and"},{"line_number":1005,"context_line":"            # associating LBs to them causes datapath issues when traffic"},{"line_number":1006,"context_line":"            # arrives via Floating IPs, resulting in SYN packet drops and"}],"source_content_type":"text/x-python","patch_set":2,"id":"7e08fc44_1b41dc98","line":1003,"range":{"start_line":1003,"start_character":12,"end_line":1003,"end_character":74},"updated":"2025-12-11 12:39:38.000000000","message":"That introduces a limitation in the LB association. If the internal network is a provider network (VLAN, flat), it won\u0027t be possible to associate a LB. Is that something expected? I think that introduces a limitation that at least should be documented.","commit_id":"43e25f946a7b1d3e89716a6e9c11b42d7614dbea"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a65fccb03ac31b05c972e417c36c4a56ab5897dd","unresolved":false,"context_lines":[{"line_number":1000,"context_line":"                                \u0027not found in OVN NBDB. Exiting.\u0027,"},{"line_number":1001,"context_line":"                                {\u0027ls\u0027: ls_name, \u0027lb\u0027: ovn_lb.name})"},{"line_number":1002,"context_line":"                    return commands"},{"line_number":1003,"context_line":"            # NOTE(froyo): Skip association if this is a provider network."},{"line_number":1004,"context_line":"            # Provider networks have localnet ports (e.g., VLAN networks) and"},{"line_number":1005,"context_line":"            # associating LBs to them causes datapath issues when traffic"},{"line_number":1006,"context_line":"            # arrives via Floating IPs, resulting in SYN packet drops and"}],"source_content_type":"text/x-python","patch_set":2,"id":"663ebf8f_c6ee5795","line":1003,"range":{"start_line":1003,"start_character":12,"end_line":1003,"end_character":74},"in_reply_to":"7e08fc44_1b41dc98","updated":"2025-12-11 13:58:57.000000000","message":"As commented in private, Fernando commented that this is the same behaviour as in [1]. THis is not preventing using provnets, it is only is not necessary.\n\n[1]https://opendev.org/openstack/ovn-octavia-provider/src/branch/master/ovn_octavia_provider/helper.py#L1595","commit_id":"43e25f946a7b1d3e89716a6e9c11b42d7614dbea"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f54e1865c709a7cbf9d26a9f921d843ff1d33c2a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        \"\"\""},{"line_number":152,"context_line":"        if not ovn_ls:"},{"line_number":153,"context_line":"            return False"},{"line_number":154,"context_line":"        physical_network \u003d ovn_ls.external_ids.get("},{"line_number":155,"context_line":"            \u0027neutron:provnet-physical-network\u0027)"},{"line_number":156,"context_line":"        if physical_network:"},{"line_number":157,"context_line":"            LOG.debug(\"Logical Switch %s is a provider network \""},{"line_number":158,"context_line":"                      \"(physical network: %s)\","}],"source_content_type":"text/x-python","patch_set":3,"id":"86114ce0_b4cb0b4e","line":155,"range":{"start_line":154,"start_character":8,"end_line":155,"end_character":47},"updated":"2025-12-19 07:32:02.000000000","message":"+1","commit_id":"54082ca185de43a22293733a026ce049cf177a45"}]}
