)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"59a7ff37c6e8996ffcf07139643fa9f545e819da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"39ef869d_49634bd9","updated":"2026-07-28 06:50:50.000000000","message":"Note: this patch made me realize that passing vip_port_id is not compatible with using additional_vips in the OVN provider","commit_id":"eb663131ef97a43f2ea156f6e1a6399a58b2a499"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"024bce5fbaa4e16674ec07836981461d3c71c92d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0340730b_90b7ec12","in_reply_to":"39ef869d_49634bd9","updated":"2026-07-28 07:01:37.000000000","message":"But Octavia API [0] doesn\u0027t allow to pass port_id to the additional_vip param. I didn\u0027t try on the OVN provider that case, but it should create additional ports for additinal vips.\n\n\n[0] https://docs.openstack.org/api-ref/load-balancer/v2/#create-a-load-balancer","commit_id":"eb663131ef97a43f2ea156f6e1a6399a58b2a499"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"4b8fb205d69da2694593c91cfb9c0210154402a3","unresolved":true,"context_lines":[{"line_number":3058,"context_line":"                neutron_client.update_port("},{"line_number":3059,"context_line":"                    existing_port_id,"},{"line_number":3060,"context_line":"                    name\u003df\u0027{ovn_const.LB_VIP_PORT_PREFIX}{lb_id}\u0027,"},{"line_number":3061,"context_line":"                    device_owner\u003dvip_device_owner,"},{"line_number":3062,"context_line":"                    device_id\u003dvip_device_id)"},{"line_number":3063,"context_line":"                vip_port \u003d neutron_client.get_port(existing_port_id)"},{"line_number":3064,"context_line":"            else:"},{"line_number":3065,"context_line":"                vip_port \u003d self._create_neutron_port("}],"source_content_type":"text/x-python","patch_set":1,"id":"97259a7e_95691950","line":3062,"range":{"start_line":3061,"start_character":20,"end_line":3062,"end_character":44},"updated":"2026-07-16 20:01:28.000000000","message":"by setting these device_owner \u0026 device_id, the provider deletes the user\u0027s VIP port when the LB is deleted, however it\u0027s expected that the components don\u0027t delete users\u0027 resources, users may need to reuse the port for other usage.","commit_id":"5dd6571df08dcf25d523c40dde0f0ab0ca7e2537"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"de25a040e13b3f2d7b07f4e84ef63e40650bfee1","unresolved":false,"context_lines":[{"line_number":3058,"context_line":"                neutron_client.update_port("},{"line_number":3059,"context_line":"                    existing_port_id,"},{"line_number":3060,"context_line":"                    name\u003df\u0027{ovn_const.LB_VIP_PORT_PREFIX}{lb_id}\u0027,"},{"line_number":3061,"context_line":"                    device_owner\u003dvip_device_owner,"},{"line_number":3062,"context_line":"                    device_id\u003dvip_device_id)"},{"line_number":3063,"context_line":"                vip_port \u003d neutron_client.get_port(existing_port_id)"},{"line_number":3064,"context_line":"            else:"},{"line_number":3065,"context_line":"                vip_port \u003d self._create_neutron_port("}],"source_content_type":"text/x-python","patch_set":1,"id":"a477e88b_bf20e541","line":3062,"range":{"start_line":3061,"start_character":20,"end_line":3062,"end_character":44},"in_reply_to":"5d6d99e5_f9bdcded","updated":"2026-07-22 16:50:25.000000000","message":"That makes total sense! good catch man!","commit_id":"5dd6571df08dcf25d523c40dde0f0ab0ca7e2537"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"89ba7adea03b45ece05f8ce8eee22ec2469ca2f6","unresolved":true,"context_lines":[{"line_number":3058,"context_line":"                neutron_client.update_port("},{"line_number":3059,"context_line":"                    existing_port_id,"},{"line_number":3060,"context_line":"                    name\u003df\u0027{ovn_const.LB_VIP_PORT_PREFIX}{lb_id}\u0027,"},{"line_number":3061,"context_line":"                    device_owner\u003dvip_device_owner,"},{"line_number":3062,"context_line":"                    device_id\u003dvip_device_id)"},{"line_number":3063,"context_line":"                vip_port \u003d neutron_client.get_port(existing_port_id)"},{"line_number":3064,"context_line":"            else:"},{"line_number":3065,"context_line":"                vip_port \u003d self._create_neutron_port("}],"source_content_type":"text/x-python","patch_set":1,"id":"5d6d99e5_f9bdcded","line":3062,"range":{"start_line":3061,"start_character":20,"end_line":3062,"end_character":44},"in_reply_to":"97259a7e_95691950","updated":"2026-07-16 20:18:50.000000000","message":"let me rephrase: the provider should not change the ownership (or the name or device_id) of the port because it belongs to the user.\nFor the same reason, it should also not delete the VIP port on deletion.","commit_id":"5dd6571df08dcf25d523c40dde0f0ab0ca7e2537"}]}