)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"1a8e6338879dbac69be4f50407d10fe9e0c72bd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3620fb01_658eae7a","updated":"2026-10-13 21:06:49.000000000","message":"recheck - looks like an unrelated timeout, the event took 13 seconds to arrive in the logs and had 10.","commit_id":"ff35e8ee590e60d8b07b570116227b96d7042af8"}],"ovsdbapp/event.py":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"661a1bd5801edf5abdb47ed86dbd6610550f00be","unresolved":true,"context_lines":[{"line_number":202,"context_line":"                        self.unwatch_event(match)"},{"line_number":203,"context_line":"                finally:"},{"line_number":204,"context_line":"                    self.notifications.task_done()"},{"line_number":205,"context_line":"            except Exception:"},{"line_number":206,"context_line":"                # If any unexpected exception happens we don\u0027t want the"},{"line_number":207,"context_line":"                # notify_loop to exit."},{"line_number":208,"context_line":"                LOG.exception(\u0027Unexpected exception in notify_loop\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"62ab76bd_5272b538","line":205,"updated":"2026-09-30 00:50:11.000000000","message":"why nest the exception handling again? Just put a finally after this exception block?","commit_id":"24bcae91896a0b65b66b81c1a220cd2a4c4a834a"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"14b36e8e10e5028fe2009a4759e969c1953ebd1a","unresolved":true,"context_lines":[{"line_number":202,"context_line":"                        self.unwatch_event(match)"},{"line_number":203,"context_line":"                finally:"},{"line_number":204,"context_line":"                    self.notifications.task_done()"},{"line_number":205,"context_line":"            except Exception:"},{"line_number":206,"context_line":"                # If any unexpected exception happens we don\u0027t want the"},{"line_number":207,"context_line":"                # notify_loop to exit."},{"line_number":208,"context_line":"                LOG.exception(\u0027Unexpected exception in notify_loop\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ee21_329358ba","line":205,"in_reply_to":"62ab76bd_5272b538","updated":"2026-09-30 13:57:49.000000000","message":"It\u0027s just defensive for an unlikely, but possible issue where Qeueue.get() raises an Exception, since we should only call task_done if get() succeeds. Without the nest, we would set task_done() on any exception, including a failed get(). get() can raise even in the blocking case (but, I think maybe only shutdown() which we don\u0027t use) but this code expresses what the actual requirement is: a successful get() being required for a task_done().","commit_id":"24bcae91896a0b65b66b81c1a220cd2a4c4a834a"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"1a8e6338879dbac69be4f50407d10fe9e0c72bd5","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                        self.unwatch_event(match)"},{"line_number":203,"context_line":"                finally:"},{"line_number":204,"context_line":"                    self.notifications.task_done()"},{"line_number":205,"context_line":"            except Exception:"},{"line_number":206,"context_line":"                # If any unexpected exception happens we don\u0027t want the"},{"line_number":207,"context_line":"                # notify_loop to exit."},{"line_number":208,"context_line":"                LOG.exception(\u0027Unexpected exception in notify_loop\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3b702063_3fe79b3b","line":205,"in_reply_to":"71645608_d252fe1f","updated":"2026-10-13 21:06:49.000000000","message":"Done","commit_id":"24bcae91896a0b65b66b81c1a220cd2a4c4a834a"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"def46d6b27d65ad80986508bca3c1530d7bd7d7c","unresolved":true,"context_lines":[{"line_number":202,"context_line":"                        self.unwatch_event(match)"},{"line_number":203,"context_line":"                finally:"},{"line_number":204,"context_line":"                    self.notifications.task_done()"},{"line_number":205,"context_line":"            except Exception:"},{"line_number":206,"context_line":"                # If any unexpected exception happens we don\u0027t want the"},{"line_number":207,"context_line":"                # notify_loop to exit."},{"line_number":208,"context_line":"                LOG.exception(\u0027Unexpected exception in notify_loop\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"71645608_d252fe1f","line":205,"in_reply_to":"9a30ee21_329358ba","updated":"2026-10-01 01:34:37.000000000","message":"Okay. I\u0027ll agree with that.","commit_id":"24bcae91896a0b65b66b81c1a220cd2a4c4a834a"}]}