)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0b655ee45b6248e1d8a1da55f50c75540aee646e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"791f6f77_0bd0b71a","updated":"2026-10-04 00:39:38.000000000","message":"Thanks for working on this. Can you also add this to the templates section of project.yaml:\n\nopenstack-cover-jobs\n\nas I don\u0027t see the cover job running here.","commit_id":"7faf3c7e511ad9c066288cdf6155a934460ce5ff"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"68b3ae846e6e36684ac4c055e21b3463e2865c99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d9e3ac1_9bd3d0ea","in_reply_to":"791f6f77_0bd0b71a","updated":"2026-10-04 04:12:31.000000000","message":"Done.","commit_id":"7faf3c7e511ad9c066288cdf6155a934460ce5ff"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"92e86a8e701096907b1996939770b86d95d9c97d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"19f7621c_85e02251","updated":"2026-10-14 12:44:52.000000000","message":"good idea to make things simpler","commit_id":"f606d6e8371fad0604429732130c5f5d0c33d2a8"}],"tox.ini":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f9d4c20f6a0694be3dc170a6dc96e15e26bbb12a","unresolved":true,"context_lines":[{"line_number":42,"context_line":"  coverage combine"},{"line_number":43,"context_line":"  coverage html -d cover"},{"line_number":44,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":45,"context_line":"  coverage report"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[testenv:docs]"},{"line_number":48,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3d1977ba_14624334","line":45,"updated":"2026-10-04 00:41:00.000000000","message":"Should probably pick a number here so we don\u0027t regress, for example, this is the neutron line:\n\ncoverage report --fail-under\u003d80 --skip-covered","commit_id":"7faf3c7e511ad9c066288cdf6155a934460ce5ff"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c99bf82f53426650fd65db1ff8428e96988dc62f","unresolved":true,"context_lines":[{"line_number":42,"context_line":"  coverage combine"},{"line_number":43,"context_line":"  coverage html -d cover"},{"line_number":44,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":45,"context_line":"  coverage report"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[testenv:docs]"},{"line_number":48,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"53527866_cf7dfd02","line":45,"in_reply_to":"05a6f64a_87e28012","updated":"2026-10-13 21:18:54.000000000","message":"Yeah, dropping the job altogether is fine for the way the project is tested. There is no expectation of unit tests for most of the functionality and they\u0027re almost actively discouraged except for things like helper functions etc. that actually have defined input/output w/o going through ovsdb-server or situations where you cannot reliably get ovsdb-server to respond in a particular way and have to mock. Otherwise, we rely on functional tests.","commit_id":"7faf3c7e511ad9c066288cdf6155a934460ce5ff"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c08ba077c4fe7abfe85fd3e478ae24828b9b8207","unresolved":true,"context_lines":[{"line_number":42,"context_line":"  coverage combine"},{"line_number":43,"context_line":"  coverage html -d cover"},{"line_number":44,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":45,"context_line":"  coverage report"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[testenv:docs]"},{"line_number":48,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"4e8eeb6f_3c7eed3f","line":45,"in_reply_to":"3d1977ba_14624334","updated":"2026-10-04 04:12:13.000000000","message":"We can\u0027t add fail-under now because the current coverage is only 17% . We should probably try improving it.\nWe can technically add --skip-covered but I think it\u0027s more beneficial to show the full list so that developers can view full status. The repository doesn\u0027t contain too many files.\n\nWhile writing this I noticed I didn\u0027t add coverage options, which I\u0027ve fixed in the 2nd version.","commit_id":"7faf3c7e511ad9c066288cdf6155a934460ce5ff"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8a0b2645c3fc0e0b8680c59a328f493af617ffe3","unresolved":true,"context_lines":[{"line_number":42,"context_line":"  coverage combine"},{"line_number":43,"context_line":"  coverage html -d cover"},{"line_number":44,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":45,"context_line":"  coverage report"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[testenv:docs]"},{"line_number":48,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"05a6f64a_87e28012","line":45,"in_reply_to":"44576a3c_1a0ae8a5","updated":"2026-10-13 14:40:19.000000000","message":"Maybe we should rather drop the env ? Alternative we can keep the standard working env but I find it a bit overkilling to add the job based on the current testing situation.","commit_id":"7faf3c7e511ad9c066288cdf6155a934460ce5ff"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"07b56cb50f7eea62fd6fa6b07e7bcd557a051cd1","unresolved":true,"context_lines":[{"line_number":42,"context_line":"  coverage combine"},{"line_number":43,"context_line":"  coverage html -d cover"},{"line_number":44,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":45,"context_line":"  coverage report"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[testenv:docs]"},{"line_number":48,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"58f609c6_bee6bd5c","line":45,"in_reply_to":"4e8eeb6f_3c7eed3f","updated":"2026-10-05 13:37:12.000000000","message":"Oh, I didn\u0027t know it was that low, definitely should try and improve it. Thanks for doing this.","commit_id":"7faf3c7e511ad9c066288cdf6155a934460ce5ff"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"46114f727e9ea011c5a8603de3ac8dca4a1dcd2e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  coverage combine"},{"line_number":43,"context_line":"  coverage html -d cover"},{"line_number":44,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":45,"context_line":"  coverage report"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[testenv:docs]"},{"line_number":48,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"0def3379_8cad0008","line":45,"in_reply_to":"53527866_cf7dfd02","updated":"2026-10-14 06:11:52.000000000","message":"Done","commit_id":"7faf3c7e511ad9c066288cdf6155a934460ce5ff"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"005d59060f1747a90dfc8bd5b2630e087f914fbc","unresolved":true,"context_lines":[{"line_number":42,"context_line":"  coverage combine"},{"line_number":43,"context_line":"  coverage html -d cover"},{"line_number":44,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":45,"context_line":"  coverage report"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[testenv:docs]"},{"line_number":48,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"44576a3c_1a0ae8a5","line":45,"in_reply_to":"58f609c6_bee6bd5c","updated":"2026-10-13 13:25:38.000000000","message":"ovsdbapp in general will never have much coverage with unit tests, because almost all of the code is tested with functional tests and unit tests are not appropriate since almost all behavior is \"side effects\" due to reliance on ovsdb-server. unit tests tend to end up just testing the mock library. So I\u0027m not sure coverage is useful at all for us.","commit_id":"7faf3c7e511ad9c066288cdf6155a934460ce5ff"}]}
