)]}'
{"ovsdbapp/backend/ovs_idl/connection.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5329b39ec2a9e62d887f8d655c8c2babfdae108b","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            self.thread.setDaemon(True)"},{"line_number":121,"context_line":"            self.thread.start()"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @removals.remove("},{"line_number":124,"context_line":"        version\u003d\u0027Ocata\u0027, removal_version\u003d\u0027Pike\u0027,"},{"line_number":125,"context_line":"        message\u003d\"Use idlutils.get_schema_helper(conn, schema, retry\u003dTrue)\")"},{"line_number":126,"context_line":"    def get_schema_helper(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_94729cac","line":123,"updated":"2017-04-19 14:58:17.000000000","message":"seem like we should kill it in the library.","commit_id":"a540180790c474f152ff5533f796635c1f7d764c"}],"ovsdbapp/backend/ovs_idl/idlutils.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"1fba63750862c751d504a45b345b056c9dc983e2","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def get_schema_helper(connection, schema_name,"},{"line_number":120,"context_line":"                      retry\u003dTrue, try_add_manager\u003dTrue, **kwargs):"},{"line_number":121,"context_line":"    \"\"\"Create a schema helper object by querying an ovsdb-server"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    :param connection: The ovsdb-server connection string"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_21674b50","line":120,"updated":"2017-04-17 18:58:41.000000000","message":"Is it worth being more explicit about the separation of normal kwargs and those to be passed through to enable_connection_uri?\n\nsomething like a single dict arg called enable_connection_uri_kwargs.  Kind of long, but ...","commit_id":"fc81415ba543376c63d581e7d34c805c64ae0c49"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"4306152c5d568f92b1a19d5c3098008cb57a2450","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def get_schema_helper(connection, schema_name,"},{"line_number":120,"context_line":"                      retry\u003dTrue, try_add_manager\u003dTrue, **kwargs):"},{"line_number":121,"context_line":"    \"\"\"Create a schema helper object by querying an ovsdb-server"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    :param connection: The ovsdb-server connection string"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_1c0a78d1","line":120,"in_reply_to":"7ffa3b31_21674b50","updated":"2017-04-17 19:10:10.000000000","message":"Part of me would almost rather rename _get_schema_helper to get_schema_helper and just make whoever uses ovsdbapp do their own retrying stuff. Neutron is the only thing that really uses all of this retry/try_add_manager execute stuff. Especially since the enable_connection_uri stuff is Open_vSwitch schema specific.\n\nThe parameters of this function really are starting to look pretty silly.","commit_id":"fc81415ba543376c63d581e7d34c805c64ae0c49"}]}
