)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"4e532a5e4a21dcc5090464b02e698e5e07431143","unresolved":false,"context_lines":[{"line_number":14,"context_line":"to implement any kind of architecture using OVN that they see fit."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"TODO in this patch:"},{"line_number":17,"context_line":"1. Get feedback as to this plan!"},{"line_number":18,"context_line":"2. Implement the Command classes (should be very straight forward)"},{"line_number":19,"context_line":"3. Implement the IDL implementation of the API (also easy)"},{"line_number":20,"context_line":"4. Write a *lot* of tests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df140735_9086b865","line":17,"updated":"2017-06-06 13:30:24.000000000","message":"+1!! sounds great\n\nbtw: as far as I\u0027ve seen, ovn-nbctl commands don\u0027t cover a 100% of things we need to do -sometimes you need to go through it\u0027s ovsdb interface), but well, we should incorporate those to ovn-nbctl too :)","commit_id":"70729fb3fc57a7364c875b111b6de719e969f84e"},{"author":{"_account_id":11762,"name":"Han Zhou","email":"zhouhan@gmail.com","username":"hanzhou"},"change_message_id":"f4a5dcbe26fc5dd2ab62e4289f5de629a937d2fc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add OVN Northbound API for LS, LSP, and DHCP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implments the ovn-nbctl API for the Logical_Switch,"},{"line_number":10,"context_line":"Logical_Switch_Port, and DHCP_Options commands. Additional patches"},{"line_number":11,"context_line":"will implement logical router and load balancer functionality."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"3f1d235d_21a1b0aa","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":38},"updated":"2017-06-30 00:57:18.000000000","message":"I was confused, but it is in fact OVN NB API, instead of ovn-nbctl the CLI :)","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add OVN Northbound API for LS, LSP, and DHCP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implments the ovn-nbctl API for the Logical_Switch,"},{"line_number":10,"context_line":"Logical_Switch_Port, and DHCP_Options commands. Additional patches"},{"line_number":11,"context_line":"will implement logical router and load balancer functionality."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"3f1d235d_a78830c6","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":38},"in_reply_to":"3f1d235d_21a1b0aa","updated":"2017-06-30 03:08:58.000000000","message":"It is the OVN NB API based very heavily on the ovn-nbctl CLI API. :P","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"}],"bindep.txt":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":9,"context_line":"libtool [test]"},{"line_number":10,"context_line":"gcc [test]"},{"line_number":11,"context_line":"patch [test]"},{"line_number":12,"context_line":"make [test]"}],"source_content_type":"text/plain","patch_set":25,"id":"5f201791_1c6e42ff","line":12,"updated":"2017-06-29 18:44:27.000000000","message":"Idea: We could send a follow-up patch to make the list in alphabetical order.","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"libtool [test]"},{"line_number":10,"context_line":"gcc [test]"},{"line_number":11,"context_line":"patch [test]"},{"line_number":12,"context_line":"make [test]"}],"source_content_type":"text/plain","patch_set":25,"id":"3f1d235d_e17df86e","line":12,"in_reply_to":"5f201791_1c6e42ff","updated":"2017-06-30 03:08:58.000000000","message":"Done","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"}],"ovsdbapp/backend/ovs_idl/__init__.py":[{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"31eda3b6d9b03d813c8e5ef743adfbc5bc52dab2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def db_find(self, table, *conditions, **kwargs):"},{"line_number":60,"context_line":"        return cmd.DbFindCommand(self, table, *conditions, **kwargs)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def lookup(self, table, record):"},{"line_number":63,"context_line":"        t \u003d self.tables[table]"},{"line_number":64,"context_line":"        try:"},{"line_number":65,"context_line":"            if isinstance(record, uuid.UUID):"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_2933bead","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":36},"updated":"2017-06-22 06:22:42.000000000","message":"Do you think it\u0027s useful to add a default arg that can passed into row_by_value to reduce some unnecessary try/catch","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"6aba39fa3cfc2a8f1d4972726bce1e4feb24097b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def db_find(self, table, *conditions, **kwargs):"},{"line_number":60,"context_line":"        return cmd.DbFindCommand(self, table, *conditions, **kwargs)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def lookup(self, table, record):"},{"line_number":63,"context_line":"        t \u003d self.tables[table]"},{"line_number":64,"context_line":"        try:"},{"line_number":65,"context_line":"            if isinstance(record, uuid.UUID):"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_895d24eb","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":36},"in_reply_to":"5f201791_2933bead","updated":"2017-06-22 19:21:01.000000000","message":"Seems reasonable. Most of the time I prefer try/except, but there are always exceptions.","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"31eda3b6d9b03d813c8e5ef743adfbc5bc52dab2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            idlutils.RowLookup(table, idlutils.get_index_column(t), None))"},{"line_number":86,"context_line":"        # no table means uuid only, no column means lookup table has one row"},{"line_number":87,"context_line":"        if rl.table is None:"},{"line_number":88,"context_line":"            raise ValueError(\"Table %s can only be queried by UUID\") % table"},{"line_number":89,"context_line":"        if rl.column is None:"},{"line_number":90,"context_line":"            return next(iter(t.rows.values()))"},{"line_number":91,"context_line":"        row \u003d idlutils.row_by_value(self, rl.table, rl.column, record)"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_5f046c17","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":76},"updated":"2017-06-22 06:22:42.000000000","message":"A question here, if it\u0027s searched by uuid, but is not found in above code, then here, whether the message is inaccurate?","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"6aba39fa3cfc2a8f1d4972726bce1e4feb24097b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            idlutils.RowLookup(table, idlutils.get_index_column(t), None))"},{"line_number":86,"context_line":"        # no table means uuid only, no column means lookup table has one row"},{"line_number":87,"context_line":"        if rl.table is None:"},{"line_number":88,"context_line":"            raise ValueError(\"Table %s can only be queried by UUID\") % table"},{"line_number":89,"context_line":"        if rl.column is None:"},{"line_number":90,"context_line":"            return next(iter(t.rows.values()))"},{"line_number":91,"context_line":"        row \u003d idlutils.row_by_value(self, rl.table, rl.column, record)"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_df3625e8","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":76},"in_reply_to":"5f201791_5f046c17","updated":"2017-06-22 19:21:01.000000000","message":"I think you are right. I\u0027ll try to work up a test that hits this case.","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from ovsdbapp.backend.ovs_idl import command as cmd"},{"line_number":16,"context_line":"from ovsdbapp.backend.ovs_idl import idlutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"_NO_DEFAULT \u003d object()"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"5f201791_dc732ae6","line":18,"updated":"2017-06-29 18:44:27.000000000","message":"Super nit: Empty line not needed","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from ovsdbapp.backend.ovs_idl import command as cmd"},{"line_number":16,"context_line":"from ovsdbapp.backend.ovs_idl import idlutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"_NO_DEFAULT \u003d object()"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_a1970091","line":18,"in_reply_to":"5f201791_dc732ae6","updated":"2017-06-30 03:08:58.000000000","message":"Done","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        row \u003d idlutils.row_by_value(self, rl.table, rl.column, record)"},{"line_number":103,"context_line":"        if rl.uuid_column:"},{"line_number":104,"context_line":"            rows \u003d getattr(row, rl.uuid_column)"},{"line_number":105,"context_line":"            if len(rows) !\u003d 1:"},{"line_number":106,"context_line":"                raise idlutils.RowNotFound(table\u003dtable, col\u003d\u0027record\u0027,"},{"line_number":107,"context_line":"                                           match\u003drecord)"},{"line_number":108,"context_line":"            row \u003d rows[0]"}],"source_content_type":"text/x-python","patch_set":25,"id":"5f201791_120aab1e","line":105,"range":{"start_line":105,"start_character":12,"end_line":105,"end_character":29},"updated":"2017-06-29 18:44:27.000000000","message":"Can it happen that there will be multiple rows with same uuid or does the \u0027u\u0027 in uuid stands for unique? :)\n\nIf it returns a list of none or one item, then it would be more correct to do:\n\n if rows:\n\nIf it can return multiple entries then RowNotFound exception isn\u0027t correct.","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        row \u003d idlutils.row_by_value(self, rl.table, rl.column, record)"},{"line_number":103,"context_line":"        if rl.uuid_column:"},{"line_number":104,"context_line":"            rows \u003d getattr(row, rl.uuid_column)"},{"line_number":105,"context_line":"            if len(rows) !\u003d 1:"},{"line_number":106,"context_line":"                raise idlutils.RowNotFound(table\u003dtable, col\u003d\u0027record\u0027,"},{"line_number":107,"context_line":"                                           match\u003drecord)"},{"line_number":108,"context_line":"            row \u003d rows[0]"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_813d24bd","line":105,"range":{"start_line":105,"start_character":12,"end_line":105,"end_character":29},"in_reply_to":"5f201791_120aab1e","updated":"2017-06-30 03:08:58.000000000","message":"If the uuid column is correctly specified in the lookup table, then I believe the value will have either 0 or 1 entries. But, if there is a bug where the column is a (non-optional) set of values (say Bridge.ports), then we could get multiple results which is undefined for this type of search.\n\nThis code is really just duplicated from idlutils with minor changes. I could probably come up with a better exception for the unlikely case that rows \u003e 1. Though I may rather just do some work on this function in general to more align it with db-ctl-base.c in another patch.\n\ngood catch.","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"}],"ovsdbapp/exceptions.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class OvsdbConnectionUnavailable(OvsdbAppException):"},{"line_number":58,"context_line":"    message \u003d \"OVS database connection to %(db_schema)s failed with error: \" \\"},{"line_number":59,"context_line":"              \"\u0027%(error)s\u0027. Verify that the OVS and OVN services are \" \\"},{"line_number":60,"context_line":"              \"available and that the \u0027ovn_nb_connection\u0027 and \" \\"},{"line_number":61,"context_line":"              \"\u0027ovn_sb_connection\u0027 configuration options are correct.\""}],"source_content_type":"text/x-python","patch_set":25,"id":"5f201791_522dc392","line":58,"range":{"start_line":58,"start_character":77,"end_line":58,"end_character":78},"updated":"2017-06-29 18:44:27.000000000","message":"Can we use parenthesis instead?","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class OvsdbConnectionUnavailable(OvsdbAppException):"},{"line_number":58,"context_line":"    message \u003d \"OVS database connection to %(db_schema)s failed with error: \" \\"},{"line_number":59,"context_line":"              \"\u0027%(error)s\u0027. Verify that the OVS and OVN services are \" \\"},{"line_number":60,"context_line":"              \"available and that the \u0027ovn_nb_connection\u0027 and \" \\"},{"line_number":61,"context_line":"              \"\u0027ovn_sb_connection\u0027 configuration options are correct.\""}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_616328de","line":58,"range":{"start_line":58,"start_character":77,"end_line":58,"end_character":78},"in_reply_to":"5f201791_522dc392","updated":"2017-06-30 03:08:58.000000000","message":"If you prefer. For some reason I\u0027ve never been a huge fan of things that look almost but not quite like tuples of strings\n\n (\"one\"\n  \"two\"\n  \"three)","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"}],"ovsdbapp/schema/ovn_northbound/api.py":[{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"31eda3b6d9b03d813c8e5ef743adfbc5bc52dab2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class API(api.API):"},{"line_number":21,"context_line":"    \"\"\"An API based off of the ovn-nbctl CLI interface"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    This API basicaly mirrors the ovn-nbctl operations with these changes:"},{"line_number":24,"context_line":"    1. Methods that create objects will return a read-only view of the object"},{"line_number":25,"context_line":"    2. Methods which list objects will return a list of read-only view objects"},{"line_number":26,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_e6ebb5ad","line":23,"range":{"start_line":23,"start_character":13,"end_line":23,"end_character":21},"updated":"2017-06-22 06:22:42.000000000","message":"basically","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"6aba39fa3cfc2a8f1d4972726bce1e4feb24097b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class API(api.API):"},{"line_number":21,"context_line":"    \"\"\"An API based off of the ovn-nbctl CLI interface"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    This API basicaly mirrors the ovn-nbctl operations with these changes:"},{"line_number":24,"context_line":"    1. Methods that create objects will return a read-only view of the object"},{"line_number":25,"context_line":"    2. Methods which list objects will return a list of read-only view objects"},{"line_number":26,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_3f0f59e2","line":23,"range":{"start_line":23,"start_character":13,"end_line":23,"end_character":21},"in_reply_to":"5f201791_e6ebb5ad","updated":"2017-06-22 19:21:01.000000000","message":"Done","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"31eda3b6d9b03d813c8e5ef743adfbc5bc52dab2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \"\"\"Create a logical switch named \u0027switch\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        :param switch:    The name of the switch (optional)"},{"line_number":33,"context_line":"        :type switch:     string or uuid.UUID"},{"line_number":34,"context_line":"        :param may_exist: If True, don\u0027t fail if the switch already exists"},{"line_number":35,"context_line":"        :type may_exist:  boolean"},{"line_number":36,"context_line":"        :param columns:   Additional columns to directly set on the switch"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_3f9bf0c9","line":33,"range":{"start_line":33,"start_character":26,"end_line":33,"end_character":45},"updated":"2017-06-22 06:22:42.000000000","message":"I think only need to specific string here, although we can pass a network uuid string to ls_add as name.","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"6aba39fa3cfc2a8f1d4972726bce1e4feb24097b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \"\"\"Create a logical switch named \u0027switch\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        :param switch:    The name of the switch (optional)"},{"line_number":33,"context_line":"        :type switch:     string or uuid.UUID"},{"line_number":34,"context_line":"        :param may_exist: If True, don\u0027t fail if the switch already exists"},{"line_number":35,"context_line":"        :type may_exist:  boolean"},{"line_number":36,"context_line":"        :param columns:   Additional columns to directly set on the switch"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_7f6031a6","line":33,"range":{"start_line":33,"start_character":26,"end_line":33,"end_character":45},"in_reply_to":"5f201791_3f9bf0c9","updated":"2017-06-22 19:21:01.000000000","message":"Not sure I understand. ovn-nbctl does a name_or_uuid lookup here, so I do. Instead of just allowing a string representation of a uuid, I allow uuid.UUID since Row.uuid returns a uuid.UUID instance, not a string and it makes it easier to pass.","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"fdcc8a8ea65f3419eb78892e887970aa057cf790","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \"\"\"Create a logical switch named \u0027switch\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        :param switch:    The name of the switch (optional)"},{"line_number":33,"context_line":"        :type switch:     string or uuid.UUID"},{"line_number":34,"context_line":"        :param may_exist: If True, don\u0027t fail if the switch already exists"},{"line_number":35,"context_line":"        :type may_exist:  boolean"},{"line_number":36,"context_line":"        :param columns:   Additional columns to directly set on the switch"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_5e5c4e7d","line":33,"range":{"start_line":33,"start_character":26,"end_line":33,"end_character":45},"in_reply_to":"5f201791_7f6031a6","updated":"2017-06-23 02:17:10.000000000","message":"Fair enough","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"31eda3b6d9b03d813c8e5ef743adfbc5bc52dab2","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        :param switch:    The name or uuid of the switch"},{"line_number":115,"context_line":"        :type switch:     string or uuid.UUID"},{"line_number":116,"context_line":"        :param port:      The name of the port"},{"line_number":117,"context_line":"        :type port:       string or uuid.UUID"},{"line_number":118,"context_line":"        :param parent:    The name of the parent port (requires tag)"},{"line_number":119,"context_line":"        :type parent:     string"},{"line_number":120,"context_line":"        :param tag:       The tag_request field of the port. 0 causes"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_bfaee0e4","line":117,"range":{"start_line":117,"start_character":26,"end_line":117,"end_character":45},"updated":"2017-06-22 06:22:42.000000000","message":"Same as above","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"31eda3b6d9b03d813c8e5ef743adfbc5bc52dab2","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        \"\"\""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @abc.abstractmethod"},{"line_number":141,"context_line":"    def lsp_list(switch):"},{"line_number":142,"context_line":"        \"\"\"Get the logical ports on switch"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        :param switch:  The name or uuid of the switch"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_a6525d66","line":141,"updated":"2017-06-22 06:22:42.000000000","message":"miss self","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"6aba39fa3cfc2a8f1d4972726bce1e4feb24097b","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        \"\"\""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @abc.abstractmethod"},{"line_number":141,"context_line":"    def lsp_list(switch):"},{"line_number":142,"context_line":"        \"\"\"Get the logical ports on switch"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        :param switch:  The name or uuid of the switch"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_1f125d0a","line":141,"in_reply_to":"5f201791_a6525d66","updated":"2017-06-22 19:21:01.000000000","message":"Done","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import abc"},{"line_number":14,"context_line":"import six"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from ovsdbapp import api"}],"source_content_type":"text/x-python","patch_set":25,"id":"5f201791_922ebb89","line":13,"updated":"2017-06-29 18:44:27.000000000","message":"There should be an empty line. six is third party module","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import abc"},{"line_number":14,"context_line":"import six"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from ovsdbapp import api"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_2184105e","line":13,"in_reply_to":"5f201791_922ebb89","updated":"2017-06-30 03:08:58.000000000","message":"Done","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"}],"ovsdbapp/schema/ovn_northbound/commands.py":[{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"31eda3b6d9b03d813c8e5ef743adfbc5bc52dab2","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        if direction:"},{"line_number":138,"context_line":"            self.conditions +\u003d [(\u0027direction\u0027, \u0027\u003d\u0027, direction)]"},{"line_number":139,"context_line":"            # priority can be 0"},{"line_number":140,"context_line":"            if None not in (priority, match):"},{"line_number":141,"context_line":"                self.conditions +\u003d [(\u0027priority\u0027, \u0027\u003d\u0027, priority),"},{"line_number":142,"context_line":"                                    (\u0027match\u0027, \u0027\u003d\u0027, match)]"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_7fda8817","line":140,"range":{"start_line":140,"start_character":12,"end_line":140,"end_character":45},"updated":"2017-06-22 06:22:42.000000000","message":"Simplified to \"if match\" or \"if priority is not None\"?","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"6aba39fa3cfc2a8f1d4972726bce1e4feb24097b","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        if direction:"},{"line_number":138,"context_line":"            self.conditions +\u003d [(\u0027direction\u0027, \u0027\u003d\u0027, direction)]"},{"line_number":139,"context_line":"            # priority can be 0"},{"line_number":140,"context_line":"            if None not in (priority, match):"},{"line_number":141,"context_line":"                self.conditions +\u003d [(\u0027priority\u0027, \u0027\u003d\u0027, priority),"},{"line_number":142,"context_line":"                                    (\u0027match\u0027, \u0027\u003d\u0027, match)]"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_9fd54de8","line":140,"range":{"start_line":140,"start_character":12,"end_line":140,"end_character":45},"in_reply_to":"5f201791_7fda8817","updated":"2017-06-22 19:21:01.000000000","message":"Either would work due to the check above, but I worried a little about it looking odd since the check was several lines away. I\u0027ll go ahead and change to if match: and put a comment about priority being guaranteed.","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"31eda3b6d9b03d813c8e5ef743adfbc5bc52dab2","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    def run_idl(self, txn):"},{"line_number":178,"context_line":"        ls \u003d self.api.lookup(\u0027Logical_Switch\u0027, self.switch)"},{"line_number":179,"context_line":"        try:"},{"line_number":180,"context_line":"            lsp \u003d self.api.lookup(\u0027Logical_Switch_Port\u0027, self.port)"},{"line_number":181,"context_line":"            if self.may_exist:"},{"line_number":182,"context_line":"                msg \u003d None"},{"line_number":183,"context_line":"                if lsp not in ls.ports:"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_291f3e6d","line":180,"range":{"start_line":180,"start_character":18,"end_line":180,"end_character":67},"updated":"2017-06-22 06:22:42.000000000","message":"Suggest use row_by_value like LsAddCommand since port should be name","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"6aba39fa3cfc2a8f1d4972726bce1e4feb24097b","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    def run_idl(self, txn):"},{"line_number":178,"context_line":"        ls \u003d self.api.lookup(\u0027Logical_Switch\u0027, self.switch)"},{"line_number":179,"context_line":"        try:"},{"line_number":180,"context_line":"            lsp \u003d self.api.lookup(\u0027Logical_Switch_Port\u0027, self.port)"},{"line_number":181,"context_line":"            if self.may_exist:"},{"line_number":182,"context_line":"                msg \u003d None"},{"line_number":183,"context_line":"                if lsp not in ls.ports:"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_5f31f5a1","line":180,"range":{"start_line":180,"start_character":18,"end_line":180,"end_character":67},"in_reply_to":"5f201791_291f3e6d","updated":"2017-06-22 19:21:01.000000000","message":"This is on purpose. api.lookup does a name or uuid (or index column) lookup just like in ovn-nbctl. I don\u0027t want to specifically limit to searching by name like row_by_value does.","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"fdcc8a8ea65f3419eb78892e887970aa057cf790","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    def run_idl(self, txn):"},{"line_number":178,"context_line":"        ls \u003d self.api.lookup(\u0027Logical_Switch\u0027, self.switch)"},{"line_number":179,"context_line":"        try:"},{"line_number":180,"context_line":"            lsp \u003d self.api.lookup(\u0027Logical_Switch_Port\u0027, self.port)"},{"line_number":181,"context_line":"            if self.may_exist:"},{"line_number":182,"context_line":"                msg \u003d None"},{"line_number":183,"context_line":"                if lsp not in ls.ports:"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f201791_3e03d275","line":180,"range":{"start_line":180,"start_character":18,"end_line":180,"end_character":67},"in_reply_to":"5f201791_5f31f5a1","updated":"2017-06-23 02:17:10.000000000","message":"You are right, it\u0027s better to be consistent with ovn-nbctl.","commit_id":"9253fa98be767de8339bc77e69a5c39e35a105ea"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                if self.may_exist:"},{"line_number":37,"context_line":"                    self.result \u003d ovs_idl.RowView(sw)"},{"line_number":38,"context_line":"                    return"},{"line_number":39,"context_line":"                raise RuntimeError(\"Switch exists\")"},{"line_number":40,"context_line":"        elif self.may_exist:"},{"line_number":41,"context_line":"            raise RuntimeError(\"may_exist requires name\")"},{"line_number":42,"context_line":"        sw \u003d txn.insert(self.api.tables[\u0027Logical_Switch\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_e0b7473a","line":39,"range":{"start_line":39,"start_character":36,"end_line":39,"end_character":49},"updated":"2017-06-29 18:44:27.000000000","message":"We should add self.switch to this message","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                if self.may_exist:"},{"line_number":37,"context_line":"                    self.result \u003d ovs_idl.RowView(sw)"},{"line_number":38,"context_line":"                    return"},{"line_number":39,"context_line":"                raise RuntimeError(\"Switch exists\")"},{"line_number":40,"context_line":"        elif self.may_exist:"},{"line_number":41,"context_line":"            raise RuntimeError(\"may_exist requires name\")"},{"line_number":42,"context_line":"        sw \u003d txn.insert(self.api.tables[\u0027Logical_Switch\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_c7a9ecdf","line":39,"range":{"start_line":39,"start_character":36,"end_line":39,"end_character":49},"in_reply_to":"3f1d235d_e0b7473a","updated":"2017-06-30 03:08:58.000000000","message":"Done","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def __init__(self, api, switch, direction, priority, match, action,"},{"line_number":83,"context_line":"                 log\u003dFalse, may_exist\u003dFalse, **external_ids):"},{"line_number":84,"context_line":"        if direction not in (\u0027from-lport\u0027, \u0027to-lport\u0027):"},{"line_number":85,"context_line":"            raise TypeError(\"direction must be either from-lport or to-lport\")"},{"line_number":86,"context_line":"        if not (0 \u003c\u003d priority \u003c\u003d 32767):"},{"line_number":87,"context_line":"            raise TypeError(\"priority must be beween 0 and 32767, inclusive\")"},{"line_number":88,"context_line":"        if action not in (\u0027allow\u0027, \u0027allow-related\u0027, \u0027drop\u0027, \u0027reject\u0027):"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_806413bb","line":85,"range":{"start_line":85,"start_character":18,"end_line":85,"end_character":27},"updated":"2017-06-29 18:44:27.000000000","message":"Wouldn\u0027t ValueError make more sense here?","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def __init__(self, api, switch, direction, priority, match, action,"},{"line_number":83,"context_line":"                 log\u003dFalse, may_exist\u003dFalse, **external_ids):"},{"line_number":84,"context_line":"        if direction not in (\u0027from-lport\u0027, \u0027to-lport\u0027):"},{"line_number":85,"context_line":"            raise TypeError(\"direction must be either from-lport or to-lport\")"},{"line_number":86,"context_line":"        if not (0 \u003c\u003d priority \u003c\u003d 32767):"},{"line_number":87,"context_line":"            raise TypeError(\"priority must be beween 0 and 32767, inclusive\")"},{"line_number":88,"context_line":"        if action not in (\u0027allow\u0027, \u0027allow-related\u0027, \u0027drop\u0027, \u0027reject\u0027):"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_615448cb","line":85,"range":{"start_line":85,"start_character":18,"end_line":85,"end_character":27},"in_reply_to":"3f1d235d_806413bb","updated":"2017-06-30 03:08:58.000000000","message":"It depends on whether you consider the type of \"direction\" as \"string\" or an enumeration of two values. I think of it more as an enum.","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                 log\u003dFalse, may_exist\u003dFalse, **external_ids):"},{"line_number":84,"context_line":"        if direction not in (\u0027from-lport\u0027, \u0027to-lport\u0027):"},{"line_number":85,"context_line":"            raise TypeError(\"direction must be either from-lport or to-lport\")"},{"line_number":86,"context_line":"        if not (0 \u003c\u003d priority \u003c\u003d 32767):"},{"line_number":87,"context_line":"            raise TypeError(\"priority must be beween 0 and 32767, inclusive\")"},{"line_number":88,"context_line":"        if action not in (\u0027allow\u0027, \u0027allow-related\u0027, \u0027drop\u0027, \u0027reject\u0027):"},{"line_number":89,"context_line":"            raise TypeError(\"action must be allow/allow-related/drop/reject\")"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_00700372","line":86,"range":{"start_line":86,"start_character":33,"end_line":86,"end_character":38},"updated":"2017-06-29 18:44:27.000000000","message":"This should be a constant","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                 log\u003dFalse, may_exist\u003dFalse, **external_ids):"},{"line_number":84,"context_line":"        if direction not in (\u0027from-lport\u0027, \u0027to-lport\u0027):"},{"line_number":85,"context_line":"            raise TypeError(\"direction must be either from-lport or to-lport\")"},{"line_number":86,"context_line":"        if not (0 \u003c\u003d priority \u003c\u003d 32767):"},{"line_number":87,"context_line":"            raise TypeError(\"priority must be beween 0 and 32767, inclusive\")"},{"line_number":88,"context_line":"        if action not in (\u0027allow\u0027, \u0027allow-related\u0027, \u0027drop\u0027, \u0027reject\u0027):"},{"line_number":89,"context_line":"            raise TypeError(\"action must be allow/allow-related/drop/reject\")"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_87abf4d4","line":86,"range":{"start_line":86,"start_character":33,"end_line":86,"end_character":38},"in_reply_to":"3f1d235d_00700372","updated":"2017-06-30 03:08:58.000000000","message":"Done","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if direction not in (\u0027from-lport\u0027, \u0027to-lport\u0027):"},{"line_number":85,"context_line":"            raise TypeError(\"direction must be either from-lport or to-lport\")"},{"line_number":86,"context_line":"        if not (0 \u003c\u003d priority \u003c\u003d 32767):"},{"line_number":87,"context_line":"            raise TypeError(\"priority must be beween 0 and 32767, inclusive\")"},{"line_number":88,"context_line":"        if action not in (\u0027allow\u0027, \u0027allow-related\u0027, \u0027drop\u0027, \u0027reject\u0027):"},{"line_number":89,"context_line":"            raise TypeError(\"action must be allow/allow-related/drop/reject\")"},{"line_number":90,"context_line":"        super(AclAddCommand, self).__init__(api)"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_e06ce79d","line":87,"range":{"start_line":87,"start_character":18,"end_line":87,"end_character":27},"updated":"2017-06-29 18:44:27.000000000","message":"ditto about ValueError","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if direction not in (\u0027from-lport\u0027, \u0027to-lport\u0027):"},{"line_number":85,"context_line":"            raise TypeError(\"direction must be either from-lport or to-lport\")"},{"line_number":86,"context_line":"        if not (0 \u003c\u003d priority \u003c\u003d 32767):"},{"line_number":87,"context_line":"            raise TypeError(\"priority must be beween 0 and 32767, inclusive\")"},{"line_number":88,"context_line":"        if action not in (\u0027allow\u0027, \u0027allow-related\u0027, \u0027drop\u0027, \u0027reject\u0027):"},{"line_number":89,"context_line":"            raise TypeError(\"action must be allow/allow-related/drop/reject\")"},{"line_number":90,"context_line":"        super(AclAddCommand, self).__init__(api)"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_c1e1dc00","line":87,"range":{"start_line":87,"start_character":18,"end_line":87,"end_character":27},"in_reply_to":"3f1d235d_e06ce79d","updated":"2017-06-30 03:08:58.000000000","message":"I\u0027ll change this one. Though 0 \u003c\u003d \"bob\" \u003c\u003d 32767 is also False, so at this point I\u0027m not sure a distinction between ValueError and TypeError even makes sense in Python.","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if not (0 \u003c\u003d priority \u003c\u003d 32767):"},{"line_number":87,"context_line":"            raise TypeError(\"priority must be beween 0 and 32767, inclusive\")"},{"line_number":88,"context_line":"        if action not in (\u0027allow\u0027, \u0027allow-related\u0027, \u0027drop\u0027, \u0027reject\u0027):"},{"line_number":89,"context_line":"            raise TypeError(\"action must be allow/allow-related/drop/reject\")"},{"line_number":90,"context_line":"        super(AclAddCommand, self).__init__(api)"},{"line_number":91,"context_line":"        self.switch \u003d switch"},{"line_number":92,"context_line":"        self.direction \u003d direction"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_c069eb8b","line":89,"range":{"start_line":89,"start_character":18,"end_line":89,"end_character":27},"updated":"2017-06-29 18:44:27.000000000","message":"ditto","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if not (0 \u003c\u003d priority \u003c\u003d 32767):"},{"line_number":87,"context_line":"            raise TypeError(\"priority must be beween 0 and 32767, inclusive\")"},{"line_number":88,"context_line":"        if action not in (\u0027allow\u0027, \u0027allow-related\u0027, \u0027drop\u0027, \u0027reject\u0027):"},{"line_number":89,"context_line":"            raise TypeError(\"action must be allow/allow-related/drop/reject\")"},{"line_number":90,"context_line":"        super(AclAddCommand, self).__init__(api)"},{"line_number":91,"context_line":"        self.switch \u003d switch"},{"line_number":92,"context_line":"        self.direction \u003d direction"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_61f0c8ca","line":89,"range":{"start_line":89,"start_character":18,"end_line":89,"end_character":27},"in_reply_to":"3f1d235d_c069eb8b","updated":"2017-06-30 03:08:58.000000000","message":"Leaving due to \"this is logically an enum type\" :p","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def run_idl(self, txn):"},{"line_number":101,"context_line":"        ls \u003d self.api.lookup(\u0027Logical_Switch\u0027, self.switch)"},{"line_number":102,"context_line":"        acls \u003d filter(lambda x: x.direction \u003d\u003d self.direction and"},{"line_number":103,"context_line":"                      x.priority \u003d\u003d self.priority and"},{"line_number":104,"context_line":"                      x.match \u003d\u003d self.match,"},{"line_number":105,"context_line":"                      ls.acls)"},{"line_number":106,"context_line":"        if acls:"},{"line_number":107,"context_line":"            if self.may_exist:"},{"line_number":108,"context_line":"                self.result \u003d ovs_idl.RowView(acls[0])"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_40ba7bde","line":105,"range":{"start_line":102,"start_character":0,"end_line":105,"end_character":30},"updated":"2017-06-29 18:44:27.000000000","message":"list comprehension is preferable:\n\n def acl_params_are_same(command, row):\n     return (command.direction \u003d\u003d row.direction and\n             command.priority \u003d\u003d row.priority and\n             command.match \u003d\u003d row.match)\n\n ...\n\n filter_cond \u003d [acl for acl in ls.acl\n                if acl_params_are_same(self, acl)]","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def run_idl(self, txn):"},{"line_number":101,"context_line":"        ls \u003d self.api.lookup(\u0027Logical_Switch\u0027, self.switch)"},{"line_number":102,"context_line":"        acls \u003d filter(lambda x: x.direction \u003d\u003d self.direction and"},{"line_number":103,"context_line":"                      x.priority \u003d\u003d self.priority and"},{"line_number":104,"context_line":"                      x.match \u003d\u003d self.match,"},{"line_number":105,"context_line":"                      ls.acls)"},{"line_number":106,"context_line":"        if acls:"},{"line_number":107,"context_line":"            if self.may_exist:"},{"line_number":108,"context_line":"                self.result \u003d ovs_idl.RowView(acls[0])"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_218ad01a","line":105,"range":{"start_line":102,"start_character":0,"end_line":105,"end_character":30},"in_reply_to":"3f1d235d_40ba7bde","updated":"2017-06-30 03:08:58.000000000","message":"Nobody ever lets me use functional-looking code any more. :p For some reason I just really hate defining one-use functions. Just for fun, I did a test with timeit and lambda/filter were consistently faster than defining a function and using a list comprehension.","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            if self.may_exist:"},{"line_number":108,"context_line":"                self.result \u003d ovs_idl.RowView(acls[0])"},{"line_number":109,"context_line":"                return"},{"line_number":110,"context_line":"            raise RuntimeError(\"ACL already exists\")"},{"line_number":111,"context_line":"        acl \u003d txn.insert(self.api.tables[\u0027ACL\u0027])"},{"line_number":112,"context_line":"        acl.direction \u003d self.direction"},{"line_number":113,"context_line":"        acl.priority \u003d self.priority"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_802f73f5","line":110,"range":{"start_line":110,"start_character":32,"end_line":110,"end_character":50},"updated":"2017-06-29 18:44:27.000000000","message":"Maybe we should put direction, priority and match to this message.","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            if self.may_exist:"},{"line_number":108,"context_line":"                self.result \u003d ovs_idl.RowView(acls[0])"},{"line_number":109,"context_line":"                return"},{"line_number":110,"context_line":"            raise RuntimeError(\"ACL already exists\")"},{"line_number":111,"context_line":"        acl \u003d txn.insert(self.api.tables[\u0027ACL\u0027])"},{"line_number":112,"context_line":"        acl.direction \u003d self.direction"},{"line_number":113,"context_line":"        acl.priority \u003d self.priority"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_ec404f0a","line":110,"range":{"start_line":110,"start_character":32,"end_line":110,"end_character":50},"in_reply_to":"3f1d235d_802f73f5","updated":"2017-06-30 03:08:58.000000000","message":"Done","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self.switch \u003d switch"},{"line_number":136,"context_line":"        self.conditions \u003d []"},{"line_number":137,"context_line":"        if direction:"},{"line_number":138,"context_line":"            self.conditions +\u003d [(\u0027direction\u0027, \u0027\u003d\u0027, direction)]"},{"line_number":139,"context_line":"            # priority can be 0"},{"line_number":140,"context_line":"            if match:  # and therefor prioroity due to the above check"},{"line_number":141,"context_line":"                self.conditions +\u003d [(\u0027priority\u0027, \u0027\u003d\u0027, priority),"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_0024830c","line":138,"range":{"start_line":138,"start_character":12,"end_line":138,"end_character":62},"updated":"2017-06-29 18:44:27.000000000","message":"self.conditions.append((\u0027direction\u0027, \u0027\u003d\u0027, direction))","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self.switch \u003d switch"},{"line_number":136,"context_line":"        self.conditions \u003d []"},{"line_number":137,"context_line":"        if direction:"},{"line_number":138,"context_line":"            self.conditions +\u003d [(\u0027direction\u0027, \u0027\u003d\u0027, direction)]"},{"line_number":139,"context_line":"            # priority can be 0"},{"line_number":140,"context_line":"            if match:  # and therefor prioroity due to the above check"},{"line_number":141,"context_line":"                self.conditions +\u003d [(\u0027priority\u0027, \u0027\u003d\u0027, priority),"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_ac4a5724","line":138,"range":{"start_line":138,"start_character":12,"end_line":138,"end_character":62},"in_reply_to":"3f1d235d_0024830c","updated":"2017-06-30 03:08:58.000000000","message":"Done (though since it is the first, I can just do an assignment).","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def run_idl(self, txn):"},{"line_number":145,"context_line":"        ls \u003d self.api.lookup(\u0027Logical_Switch\u0027, self.switch)"},{"line_number":146,"context_line":"        for acl in filter(lambda r: idlutils.row_match(r, self.conditions),"},{"line_number":147,"context_line":"                          ls.acls):"},{"line_number":148,"context_line":"            ls.delvalue(\u0027acls\u0027, acl)"},{"line_number":149,"context_line":"            acl.delete()"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_c04b2bae","line":147,"range":{"start_line":146,"start_character":0,"end_line":147,"end_character":34},"updated":"2017-06-29 18:44:27.000000000","message":"for acl in [acl for acl in ls.acl\n            if idlutils.row_match(acl, self.conditions)]:","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def run_idl(self, txn):"},{"line_number":145,"context_line":"        ls \u003d self.api.lookup(\u0027Logical_Switch\u0027, self.switch)"},{"line_number":146,"context_line":"        for acl in filter(lambda r: idlutils.row_match(r, self.conditions),"},{"line_number":147,"context_line":"                          ls.acls):"},{"line_number":148,"context_line":"            ls.delvalue(\u0027acls\u0027, acl)"},{"line_number":149,"context_line":"            acl.delete()"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_ec984f6b","line":147,"range":{"start_line":146,"start_character":0,"end_line":147,"end_character":34},"in_reply_to":"3f1d235d_c04b2bae","updated":"2017-06-30 03:08:58.000000000","message":"Done. This is much faster as a set comprehension.","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                        self.port, self.switch)"},{"line_number":186,"context_line":"                if self.parent:"},{"line_number":187,"context_line":"                    if not lsp.parent_name:"},{"line_number":188,"context_line":"                        msg \u003d \"%s exists but has no parent\" % self.port"},{"line_number":189,"context_line":"                    # parent_name, being optional, is stored as list"},{"line_number":190,"context_line":"                    if self.parent not in lsp.parent_name:"},{"line_number":191,"context_line":"                        msg \u003d \"%s exists with different parent\" % self.port"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_660d9036","line":188,"range":{"start_line":188,"start_character":40,"end_line":188,"end_character":41},"updated":"2017-06-29 18:44:27.000000000","message":"I noticed there is a comma in other messages. I\u0027m no native speaker, I just want to point this out whether it\u0027s correct or not :)","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                        self.port, self.switch)"},{"line_number":186,"context_line":"                if self.parent:"},{"line_number":187,"context_line":"                    if not lsp.parent_name:"},{"line_number":188,"context_line":"                        msg \u003d \"%s exists but has no parent\" % self.port"},{"line_number":189,"context_line":"                    # parent_name, being optional, is stored as list"},{"line_number":190,"context_line":"                    if self.parent not in lsp.parent_name:"},{"line_number":191,"context_line":"                        msg \u003d \"%s exists with different parent\" % self.port"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_cc9d935a","line":188,"range":{"start_line":188,"start_character":40,"end_line":188,"end_character":41},"in_reply_to":"3f1d235d_660d9036","updated":"2017-06-30 03:08:58.000000000","message":"Done. The comma is correct. :)","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        for addr in addresses:"},{"line_number":286,"context_line":"            if not self.addr_re.match(addr):"},{"line_number":287,"context_line":"                raise TypeError("},{"line_number":288,"context_line":"                    \"address must be router/unknown/dynamic/ethaddr ipaadr...\")"},{"line_number":289,"context_line":"        super(LspSetAddressesCommand, self).__init__(api)"},{"line_number":290,"context_line":"        self.port \u003d port"},{"line_number":291,"context_line":"        self.addresses \u003d addresses"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_43915b52","line":288,"range":{"start_line":288,"start_character":68,"end_line":288,"end_character":74},"updated":"2017-06-29 18:44:27.000000000","message":"Should this be here?","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        for addr in addresses:"},{"line_number":286,"context_line":"            if not self.addr_re.match(addr):"},{"line_number":287,"context_line":"                raise TypeError("},{"line_number":288,"context_line":"                    \"address must be router/unknown/dynamic/ethaddr ipaadr...\")"},{"line_number":289,"context_line":"        super(LspSetAddressesCommand, self).__init__(api)"},{"line_number":290,"context_line":"        self.port \u003d port"},{"line_number":291,"context_line":"        self.addresses \u003d addresses"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_6cdaff17","line":288,"range":{"start_line":288,"start_character":68,"end_line":288,"end_character":74},"in_reply_to":"3f1d235d_43915b52","updated":"2017-06-30 03:08:58.000000000","message":"Yes. The format of the \"address\" field is weird. From manpage:\n\n       lsp-set-addresses port [address]...\n              Sets the addresses associated with port to address.  Each address should be one of the following:\n\n              an Ethernet address, optionally followed by a space and one or more IP addresses\n                     OVN delivers packets for the Ethernet address to this port.\n\n              unknown\n                     OVN delivers unicast Ethernet packets whose destination MAC address is not in any logical port’s addresses column to ports with address unknown.\n\n              dynamic\n                     Use  this  keyword to make ovn-northd generate a globally unique MAC address and choose an unused IPv4 address with the logical port’s subnet and store them in the port’s\n                     dynamic_addresses column.\n\n              Multiple addresses may be set.  If no address argument is given, port will have no addresses associated with it.","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        self.result \u003d dhcpopt.uuid"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def post_commit(self, txn):"},{"line_number":442,"context_line":"        uuid \u003d txn.get_insert_uuid(self.result)"},{"line_number":443,"context_line":"        row \u003d self.api.tables[\u0027DHCP_Options\u0027].rows[uuid]"},{"line_number":444,"context_line":"        self.result \u003d ovs_idl.RowView(row)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"class DhcpOptionsDelCommand(cmd.BaseCommand):"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_63d0d7f8","line":444,"range":{"start_line":442,"start_character":0,"end_line":444,"end_character":42},"updated":"2017-06-29 18:44:27.000000000","message":"This pattern repeats a lot, maybe we should do something like:\n\n def get_row_from_uuid(result, table_name):\n     uuid \u003d txn.get_insert_uuid(self.result)\n     row \u003d self.api.tables[table_name].rows[uuid]\n     return ovs_idl.RowView(row)\n\n ...\n\n def post_commit(self, txn):\n     self.result \u003d get_row_from_uuid(self.result)","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        self.result \u003d dhcpopt.uuid"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def post_commit(self, txn):"},{"line_number":442,"context_line":"        uuid \u003d txn.get_insert_uuid(self.result)"},{"line_number":443,"context_line":"        row \u003d self.api.tables[\u0027DHCP_Options\u0027].rows[uuid]"},{"line_number":444,"context_line":"        self.result \u003d ovs_idl.RowView(row)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"class DhcpOptionsDelCommand(cmd.BaseCommand):"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_cc391342","line":444,"range":{"start_line":442,"start_character":0,"end_line":444,"end_character":42},"in_reply_to":"3f1d235d_63d0d7f8","updated":"2017-06-30 03:08:58.000000000","message":"It does. Good point. I may just do a:\n\n class AddCommand(cmd.BaseCommand):\n     def post_commit(self, txn):\n         real_uuid \u003d txn.get_insert_uuid(self.result) or self.result\n         row \u003d self.api.tables[self.table_name].rows[real_uuid]\n         self.result \u003d ovs_idl.RowView(row)\n\nand then define table_name like\n\n class DhcpOptionsAddCommand(AddCommand):\n     table_name \u003d \u0027DHCP_Options\u0027\n\netc. and not even define post_commit in the subclasses. Especially since there are a bunch more in the next patch as well.","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e2a6874c6b39b97f2c348ac5fd20d63d10c57821","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        for addr in addresses:"},{"line_number":291,"context_line":"            if not self.addr_re.match(addr):"},{"line_number":292,"context_line":"                raise TypeError("},{"line_number":293,"context_line":"                    \"address must be router/unknown/dynamic/ethaddr ipaadr...\")"},{"line_number":294,"context_line":"        super(LspSetAddressesCommand, self).__init__(api)"},{"line_number":295,"context_line":"        self.port \u003d port"},{"line_number":296,"context_line":"        self.addresses \u003d addresses"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_1b7138aa","line":293,"range":{"start_line":293,"start_character":68,"end_line":293,"end_character":74},"updated":"2017-07-03 16:28:36.000000000","message":"Should it be ipaddr ?","commit_id":"b1ebfa6132357f20e2e824258653fc9a3f7636ed"}],"ovsdbapp/schema/ovn_northbound/impl_idl.py":[{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"81a917fbf826fb01bea2154074569bdd2ab8cd94","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            OvnNbApiIdlImpl.ovsdb_connection.timeout,"},{"line_number":60,"context_line":"            check_error, log_errors)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def ls_add(self, switch\u003dNone, may_exist\u003dFalse, **columns):"},{"line_number":63,"context_line":"        return cmd.LsAddCommand(self, switch, may_exist, **columns)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def ls_del(self, switch, if_exists\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":23,"id":"5f201791_4cc5118e","line":62,"updated":"2017-06-21 00:43:54.000000000","message":"The abstract method in the parent class is missing **columns param.","commit_id":"a803f33080260623c2eca36332ff4a1662497ab6"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c60de413ad26864aa743d301e1e0c8aac5fac57e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            OvnNbApiIdlImpl.ovsdb_connection.timeout,"},{"line_number":60,"context_line":"            check_error, log_errors)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def ls_add(self, switch\u003dNone, may_exist\u003dFalse, **columns):"},{"line_number":63,"context_line":"        return cmd.LsAddCommand(self, switch, may_exist, **columns)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def ls_del(self, switch, if_exists\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":23,"id":"5f201791_4577113c","line":62,"in_reply_to":"5f201791_4cc5118e","updated":"2017-06-21 14:45:11.000000000","message":"Done","commit_id":"a803f33080260623c2eca36332ff4a1662497ab6"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"81a917fbf826fb01bea2154074569bdd2ab8cd94","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def acl_list(self, switch):"},{"line_number":80,"context_line":"        return cmd.AclListCommand(self, switch)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def lsp_add(self, switch, port, parent\u003dNone, tag\u003dNone, may_exist\u003dFalse,"},{"line_number":83,"context_line":"                **columns):"},{"line_number":84,"context_line":"        return cmd.LspAddCommand(self, switch, port, parent, tag, may_exist,"},{"line_number":85,"context_line":"                                 **columns)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5f201791_6c456d17","line":82,"updated":"2017-06-21 00:43:54.000000000","message":"Same as above comment. The abstract lsp_add function is missing **columns param","commit_id":"a803f33080260623c2eca36332ff4a1662497ab6"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c60de413ad26864aa743d301e1e0c8aac5fac57e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def acl_list(self, switch):"},{"line_number":80,"context_line":"        return cmd.AclListCommand(self, switch)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def lsp_add(self, switch, port, parent\u003dNone, tag\u003dNone, may_exist\u003dFalse,"},{"line_number":83,"context_line":"                **columns):"},{"line_number":84,"context_line":"        return cmd.LspAddCommand(self, switch, port, parent, tag, may_exist,"},{"line_number":85,"context_line":"                                 **columns)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5f201791_25741535","line":82,"in_reply_to":"5f201791_6c456d17","updated":"2017-06-21 14:45:11.000000000","message":"Done","commit_id":"a803f33080260623c2eca36332ff4a1662497ab6"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"515b4cdb028e3316c018a552906022f188b4468b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def lsp_del(self, port, switch\u003dNone, if_exists\u003dFalse):"},{"line_number":88,"context_line":"        return cmd.LspDelCommand(self, port, switch, if_exists)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def lsp_list(self):"},{"line_number":91,"context_line":"        return cmd.LspListCommand(self)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def lsp_get_parent(self, port):"}],"source_content_type":"text/x-python","patch_set":23,"id":"5f201791_23cf8980","line":90,"updated":"2017-06-20 21:11:06.000000000","message":"This command should take a \"switch\" option and limit results to ports on the switch.","commit_id":"a803f33080260623c2eca36332ff4a1662497ab6"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c60de413ad26864aa743d301e1e0c8aac5fac57e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def lsp_del(self, port, switch\u003dNone, if_exists\u003dFalse):"},{"line_number":88,"context_line":"        return cmd.LspDelCommand(self, port, switch, if_exists)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def lsp_list(self):"},{"line_number":91,"context_line":"        return cmd.LspListCommand(self)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def lsp_get_parent(self, port):"}],"source_content_type":"text/x-python","patch_set":23,"id":"5f201791_058fd923","line":90,"in_reply_to":"5f201791_23cf8980","updated":"2017-06-21 14:45:11.000000000","message":"Done","commit_id":"a803f33080260623c2eca36332ff4a1662497ab6"}],"ovsdbapp/tests/functional/base.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e2a6874c6b39b97f2c348ac5fd20d63d10c57821","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    @classmethod"},{"line_number":31,"context_line":"    def set_connection(cls):"},{"line_number":32,"context_line":"        if cls.connection is not None:"},{"line_number":33,"context_line":"            return"},{"line_number":34,"context_line":"        if cls.schema \u003d\u003d \"Open_vSwitch\":"},{"line_number":35,"context_line":"            conn \u003d cls.ovsvenv.ovs_connection"},{"line_number":36,"context_line":"        elif cls.schema \u003d\u003d \"OVN_Northbound\":"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_e0380b3e","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":18},"updated":"2017-07-03 16:28:36.000000000","message":"I\u0027m a bit confused about this code. If we have a single process running the test and this class is created, connection is set to None.\n\nThen test with Open_vSwitch starts running and setUp() calls to this code - as connection reference is inherited, TestOvsdbIdl test will set the connection and schema.\n\nLater, test with OVN_Northbound schema is executed (OvnNorthboundTest) but the connection will be already set by TestOvsdbIdl and thus will never reach L36 to set proper schema.\n\nRunning the tests locally with single process works, but I don\u0027t understand why the reference in OvnNorthboundTest doesn\u0027t point to FunctionalTestCase class attribute connection.","commit_id":"b1ebfa6132357f20e2e824258653fc9a3f7636ed"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6e687161647fb22735a1f9a544359e7a2bf330e9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    @classmethod"},{"line_number":31,"context_line":"    def set_connection(cls):"},{"line_number":32,"context_line":"        if cls.connection is not None:"},{"line_number":33,"context_line":"            return"},{"line_number":34,"context_line":"        if cls.schema \u003d\u003d \"Open_vSwitch\":"},{"line_number":35,"context_line":"            conn \u003d cls.ovsvenv.ovs_connection"},{"line_number":36,"context_line":"        elif cls.schema \u003d\u003d \"OVN_Northbound\":"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_52c1ce2d","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":18},"in_reply_to":"3f1d235d_9b22e8ff","updated":"2017-07-03 19:39:59.000000000","message":"Yeah, I ran this several times - the theory I have should be on a single process but that works as well. I just don\u0027t understand why superclass.class_attribute is not subclass.class_attribute ... the subclass should have reference to superclass.\n\nhttp://paste.openstack.org/show/614338/\n\nAnyway, it works so there is a lack of knowledge on my end :)","commit_id":"b1ebfa6132357f20e2e824258653fc9a3f7636ed"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"9e6b814e1933321465ca00b27840a403197425a6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    @classmethod"},{"line_number":31,"context_line":"    def set_connection(cls):"},{"line_number":32,"context_line":"        if cls.connection is not None:"},{"line_number":33,"context_line":"            return"},{"line_number":34,"context_line":"        if cls.schema \u003d\u003d \"Open_vSwitch\":"},{"line_number":35,"context_line":"            conn \u003d cls.ovsvenv.ovs_connection"},{"line_number":36,"context_line":"        elif cls.schema \u003d\u003d \"OVN_Northbound\":"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_9b22e8ff","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":18},"in_reply_to":"3f1d235d_e0380b3e","updated":"2017-07-03 16:42:12.000000000","message":"I haven\u0027t had time to really look at this and have to be somewhere in a few minutes so maybe I just didn\u0027t read carefully, but since this is a classmethod cls will be different for every class that inherits from this, so the connection will be set on those classes.\n\nI\u0027ve been running the tests on an 8-core machine w/o trouble.","commit_id":"b1ebfa6132357f20e2e824258653fc9a3f7636ed"}],"ovsdbapp/tests/functional/schema/ovn_northbound/test_impl_idl.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e2a6874c6b39b97f2c348ac5fd20d63d10c57821","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        r1 \u003d self._acl_add(\u0027from-lport\u0027, 0, \u0027output \u003d\u003d \"fake_port\"\u0027, \u0027drop\u0027)"},{"line_number":128,"context_line":"        self.api.acl_del(self.switch.uuid).execute(check_error\u003dTrue)"},{"line_number":129,"context_line":"        self.assertNotIn(r1.uuid, self.api.tables[\u0027ACL\u0027].rows)"},{"line_number":130,"context_line":"        self.assertEqual([], self.switch.acls)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_acl_del_direction(self):"},{"line_number":133,"context_line":"        r1 \u003d self._acl_add(\u0027from-lport\u0027, 0, \u0027output \u003d\u003d \"fake_port\"\u0027, \u0027drop\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_80fef734","line":130,"range":{"start_line":130,"start_character":13,"end_line":130,"end_character":46},"updated":"2017-07-03 16:28:36.000000000","message":"Nit: self.assertFalse(self.switch.acls)","commit_id":"b1ebfa6132357f20e2e824258653fc9a3f7636ed"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e2a6874c6b39b97f2c348ac5fd20d63d10c57821","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        lsp2 \u003d self._lsp_add(self.switch.uuid, lsp1.name, may_exist\u003dTrue)"},{"line_number":190,"context_line":"        self.assertEqual(lsp1, lsp2)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def test_lsp_add_may_exist_wrong_switch(self):"},{"line_number":193,"context_line":"        sw \u003d self.useFixture(fixtures.LogicalSwitchFixture()).obj"},{"line_number":194,"context_line":"        lsp \u003d self._lsp_add(self.switch.uuid, None)"},{"line_number":195,"context_line":"        self.assertRaises(RuntimeError, self._lsp_add, sw, lsp.name,"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_5b00d001","line":192,"range":{"start_line":192,"start_character":31,"end_line":192,"end_character":43},"updated":"2017-07-03 16:28:36.000000000","message":"Maybe \"attached_port\" would be better, it took me some time what is wrong with switch sw :)","commit_id":"b1ebfa6132357f20e2e824258653fc9a3f7636ed"}],"ovsdbapp/venv.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class OvsVenvFixture(fixtures.Fixture):"},{"line_number":24,"context_line":"    def __init__(self, venv, ovsdir\u003dNone, dummy\u003dNone, remove\u003dFalse):"},{"line_number":25,"context_line":"        self.venv \u003d venv"},{"line_number":26,"context_line":"        self.ovsdir \u003d ovsdir if ovsdir else os.path.join(venv, \u0027ovs\u0027)"},{"line_number":27,"context_line":"        self._dummy \u003d dummy"}],"source_content_type":"text/x-python","patch_set":25,"id":"5f201791_52c14353","line":24,"range":{"start_line":24,"start_character":29,"end_line":24,"end_character":40},"updated":"2017-06-29 18:44:27.000000000","message":"Maybe this should be mandatory then?","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class OvsVenvFixture(fixtures.Fixture):"},{"line_number":24,"context_line":"    def __init__(self, venv, ovsdir\u003dNone, dummy\u003dNone, remove\u003dFalse):"},{"line_number":25,"context_line":"        self.venv \u003d venv"},{"line_number":26,"context_line":"        self.ovsdir \u003d ovsdir if ovsdir else os.path.join(venv, \u0027ovs\u0027)"},{"line_number":27,"context_line":"        self._dummy \u003d dummy"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_c7d0cc53","line":24,"range":{"start_line":24,"start_character":29,"end_line":24,"end_character":40},"in_reply_to":"5f201791_52c14353","updated":"2017-06-30 03:08:58.000000000","message":"Yeah, I suppose if it isn\u0027t already a build directory, nothing we can do since mean old Ihar made me take out the git clone stuff. :p\n\nDone.","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.addCleanup(self.deactivate)"},{"line_number":75,"context_line":"        if not os.path.isdir(self.venv):"},{"line_number":76,"context_line":"            os.mkdir(self.venv)"},{"line_number":77,"context_line":"        if not os.path.isdir(self.ovsdir) and self.giturl:"},{"line_number":78,"context_line":"            self.clone_repo()"},{"line_number":79,"context_line":"        if not os.path.isdir(self.ovsdir):"},{"line_number":80,"context_line":"            raise Exception(\"Could not create directory %s\" % self.ovsdir)"},{"line_number":81,"context_line":"        self.create_db(\u0027conf.db\u0027, self.ovs_schema)"},{"line_number":82,"context_line":"        self.create_db(\u0027ovnsb.db\u0027, self.ovnsb_schema)"},{"line_number":83,"context_line":"        self.create_db(\u0027ovnnb.db\u0027, self.ovnnb_schema)"}],"source_content_type":"text/x-python","patch_set":25,"id":"5f201791_b219b722","line":80,"range":{"start_line":77,"start_character":0,"end_line":80,"end_character":74},"updated":"2017-06-29 18:44:27.000000000","message":"Is this the remnant of previous patches?","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.addCleanup(self.deactivate)"},{"line_number":75,"context_line":"        if not os.path.isdir(self.venv):"},{"line_number":76,"context_line":"            os.mkdir(self.venv)"},{"line_number":77,"context_line":"        if not os.path.isdir(self.ovsdir) and self.giturl:"},{"line_number":78,"context_line":"            self.clone_repo()"},{"line_number":79,"context_line":"        if not os.path.isdir(self.ovsdir):"},{"line_number":80,"context_line":"            raise Exception(\"Could not create directory %s\" % self.ovsdir)"},{"line_number":81,"context_line":"        self.create_db(\u0027conf.db\u0027, self.ovs_schema)"},{"line_number":82,"context_line":"        self.create_db(\u0027ovnsb.db\u0027, self.ovnsb_schema)"},{"line_number":83,"context_line":"        self.create_db(\u0027ovnnb.db\u0027, self.ovnnb_schema)"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_478efc78","line":80,"range":{"start_line":77,"start_character":0,"end_line":80,"end_character":74},"in_reply_to":"5f201791_b219b722","updated":"2017-06-30 03:08:58.000000000","message":"It is indeed. Done.","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                   \u0027--ssl-protocols\u003ddb:OVN_Southbound,SSL,ssl_protocols\u0027,"},{"line_number":107,"context_line":"                   \u0027--ssl-ciphers\u003ddb:OVN_Southbound,SSL,ssl_ciphers\u0027,"},{"line_number":108,"context_line":"                   \u0027--remote\u003dp\u0027 + self.ovnsb_connection, \u0027ovnsb.db\u0027])"},{"line_number":109,"context_line":"        time.sleep(1)  # wait_until_true(os.path.isfile(db_sock)"},{"line_number":110,"context_line":"        self.call([\u0027ovs-vsctl\u0027, \u0027--no-wait\u0027, \u0027--\u0027, \u0027init\u0027])"},{"line_number":111,"context_line":"        self.call([\u0027ovs-vswitchd\u0027, \u0027--detach\u0027, \u0027--no-chdir\u0027, \u0027--pidfile\u0027,"},{"line_number":112,"context_line":"                   \u0027-vconsole:off\u0027, \u0027-vvconn\u0027, \u0027-vnetdev_dummy\u0027, \u0027--log-file\u0027,"}],"source_content_type":"text/x-python","patch_set":25,"id":"5f201791_528f0329","line":109,"updated":"2017-06-29 18:44:27.000000000","message":"I like the active waiting more :)","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                   \u0027--ssl-protocols\u003ddb:OVN_Southbound,SSL,ssl_protocols\u0027,"},{"line_number":107,"context_line":"                   \u0027--ssl-ciphers\u003ddb:OVN_Southbound,SSL,ssl_ciphers\u0027,"},{"line_number":108,"context_line":"                   \u0027--remote\u003dp\u0027 + self.ovnsb_connection, \u0027ovnsb.db\u0027])"},{"line_number":109,"context_line":"        time.sleep(1)  # wait_until_true(os.path.isfile(db_sock)"},{"line_number":110,"context_line":"        self.call([\u0027ovs-vsctl\u0027, \u0027--no-wait\u0027, \u0027--\u0027, \u0027init\u0027])"},{"line_number":111,"context_line":"        self.call([\u0027ovs-vswitchd\u0027, \u0027--detach\u0027, \u0027--no-chdir\u0027, \u0027--pidfile\u0027,"},{"line_number":112,"context_line":"                   \u0027-vconsole:off\u0027, \u0027-vvconn\u0027, \u0027-vnetdev_dummy\u0027, \u0027--log-file\u0027,"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_87e3f405","line":109,"in_reply_to":"5f201791_528f0329","updated":"2017-06-30 03:08:58.000000000","message":"I have a utils.py in the next patch that I\u0027ll add a wait_until_true-type function to and fix this then.","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            \u0027external_ids:ovn-encap-type\u003dgeneve\u0027,"},{"line_number":121,"context_line":"            \u0027external_ids:ovn-encap-ip\u003d127.0.0.1\u0027])"},{"line_number":122,"context_line":"        # TODO(twilson) SSL stuff"},{"line_number":123,"context_line":"        if False:"},{"line_number":124,"context_line":"            pass"},{"line_number":125,"context_line":"        else:"},{"line_number":126,"context_line":"            self.call([\u0027ovs-vsctl\u0027, \u0027set\u0027, \u0027open\u0027, \u0027.\u0027,"},{"line_number":127,"context_line":"                       \u0027external_ids:ovn-remote\u003d\u0027 + self.ovnsb_connection])"},{"line_number":128,"context_line":"        self.call([\u0027ovn-northd\u0027, \u0027--detach\u0027, \u0027--no-chdir\u0027, \u0027--pidfile\u0027,"}],"source_content_type":"text/x-python","patch_set":25,"id":"5f201791_32b007dd","line":125,"range":{"start_line":123,"start_character":0,"end_line":125,"end_character":13},"updated":"2017-06-29 18:44:27.000000000","message":"That should go away and come back with SSL support :)","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            \u0027external_ids:ovn-encap-type\u003dgeneve\u0027,"},{"line_number":121,"context_line":"            \u0027external_ids:ovn-encap-ip\u003d127.0.0.1\u0027])"},{"line_number":122,"context_line":"        # TODO(twilson) SSL stuff"},{"line_number":123,"context_line":"        if False:"},{"line_number":124,"context_line":"            pass"},{"line_number":125,"context_line":"        else:"},{"line_number":126,"context_line":"            self.call([\u0027ovs-vsctl\u0027, \u0027set\u0027, \u0027open\u0027, \u0027.\u0027,"},{"line_number":127,"context_line":"                       \u0027external_ids:ovn-remote\u003d\u0027 + self.ovnsb_connection])"},{"line_number":128,"context_line":"        self.call([\u0027ovn-northd\u0027, \u0027--detach\u0027, \u0027--no-chdir\u0027, \u0027--pidfile\u0027,"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_278f8024","line":125,"range":{"start_line":123,"start_character":0,"end_line":125,"end_character":13},"in_reply_to":"5f201791_32b007dd","updated":"2017-06-30 03:08:58.000000000","message":"It should. I just don\u0027t exactly know how to do it right now. In ovs-sandbox it depended on whether HAVE_SSL autconf variable was set. I could probably parse the build dir\u0027s config.log or something to get it, but I just haven\u0027t quite figured out whether its worth it yet. But I tried to make the code kind of jarring just to remind me whenever I looked at it. :p","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def call(self, *args, **kwargs):"},{"line_number":149,"context_line":"        cwd \u003d kwargs.pop(\u0027cwd\u0027, self.venv)"},{"line_number":150,"context_line":"        return subprocess.call(*args, env\u003dself.env, cwd\u003dcwd, **kwargs)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def get_pids(self):"},{"line_number":153,"context_line":"        files \u003d glob.glob(os.path.join(self.venv, \"*.pid\"))"}],"source_content_type":"text/x-python","patch_set":25,"id":"5f201791_72a31fb3","line":150,"updated":"2017-06-29 18:44:27.000000000","message":"Maybe we should check the returncode here and raise an exception on unsuccessful call?","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def call(self, *args, **kwargs):"},{"line_number":149,"context_line":"        cwd \u003d kwargs.pop(\u0027cwd\u0027, self.venv)"},{"line_number":150,"context_line":"        return subprocess.call(*args, env\u003dself.env, cwd\u003dcwd, **kwargs)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def get_pids(self):"},{"line_number":153,"context_line":"        files \u003d glob.glob(os.path.join(self.venv, \"*.pid\"))"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_07cc8433","line":150,"in_reply_to":"5f201791_72a31fb3","updated":"2017-06-30 03:08:58.000000000","message":"I\u0027ll just switch it to check_call()","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def get_pids(self):"},{"line_number":153,"context_line":"        files \u003d glob.glob(os.path.join(self.venv, \"*.pid\"))"},{"line_number":154,"context_line":"        result \u003d {}"},{"line_number":155,"context_line":"        for fname in files:"},{"line_number":156,"context_line":"            with open(fname, \u0027r\u0027) as f:"},{"line_number":157,"context_line":"                result[fname] \u003d int(f.read().strip())"}],"source_content_type":"text/x-python","patch_set":25,"id":"5f201791_12e86bb0","line":154,"range":{"start_line":154,"start_character":17,"end_line":154,"end_character":19},"updated":"2017-06-29 18:44:27.000000000","message":"Is it used as dict anywhere? Maybe list will be more convenient looking at the way it\u0027s used.","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def get_pids(self):"},{"line_number":153,"context_line":"        files \u003d glob.glob(os.path.join(self.venv, \"*.pid\"))"},{"line_number":154,"context_line":"        result \u003d {}"},{"line_number":155,"context_line":"        for fname in files:"},{"line_number":156,"context_line":"            with open(fname, \u0027r\u0027) as f:"},{"line_number":157,"context_line":"                result[fname] \u003d int(f.read().strip())"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_47f03c91","line":154,"range":{"start_line":154,"start_character":17,"end_line":154,"end_character":19},"in_reply_to":"5f201791_12e86bb0","updated":"2017-06-30 03:08:58.000000000","message":"Not anymore anyway. I think I had some log messages during development in kill_processes that showed the filename.\n\nDone.","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e2a6874c6b39b97f2c348ac5fd20d63d10c57821","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class OvsVenvFixture(fixtures.Fixture):"},{"line_number":24,"context_line":"    def __init__(self, venv, ovsdir, dummy\u003dNone, remove\u003dFalse):"},{"line_number":25,"context_line":"        if not os.path.isdir(ovsdir):"},{"line_number":26,"context_line":"            raise Exception(\"%s is not a directory %s\" % self.ovsdir)"},{"line_number":27,"context_line":"        self.venv \u003d venv"},{"line_number":28,"context_line":"        self.ovsdir \u003d ovsdir"},{"line_number":29,"context_line":"        self._dummy \u003d dummy"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_a049fed0","line":26,"range":{"start_line":26,"start_character":57,"end_line":26,"end_character":68},"updated":"2017-07-03 16:28:36.000000000","message":"self.ovsdir is not set yet, should be just ovsdir","commit_id":"b1ebfa6132357f20e2e824258653fc9a3f7636ed"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e2a6874c6b39b97f2c348ac5fd20d63d10c57821","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            \u0027external_ids:ovn-encap-type\u003dgeneve\u0027,"},{"line_number":119,"context_line":"            \u0027external_ids:ovn-encap-ip\u003d127.0.0.1\u0027])"},{"line_number":120,"context_line":"        # TODO(twilson) SSL stuff"},{"line_number":121,"context_line":"        if False:"},{"line_number":122,"context_line":"            pass"},{"line_number":123,"context_line":"        else:"},{"line_number":124,"context_line":"            self.call([\u0027ovs-vsctl\u0027, \u0027set\u0027, \u0027open\u0027, \u0027.\u0027,"},{"line_number":125,"context_line":"                       \u0027external_ids:ovn-remote\u003d\u0027 + self.ovnsb_connection])"},{"line_number":126,"context_line":"        self.call([\u0027ovn-northd\u0027, \u0027--detach\u0027, \u0027--no-chdir\u0027, \u0027--pidfile\u0027,"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_7b8dcc79","line":123,"range":{"start_line":121,"start_character":0,"end_line":123,"end_character":13},"updated":"2017-07-03 16:28:36.000000000","message":"So is this really intended here? I\u0027m confused :) Isn\u0027t TODO enough?","commit_id":"b1ebfa6132357f20e2e824258653fc9a3f7636ed"}],"tools/tox_install.sh":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# We require at least OVS 2.7. Testing infrastructure doesn\u0027t support it yet,"},{"line_number":52,"context_line":"# so build it. Eventually, we should run some checks to see what is actually"},{"line_number":53,"context_line":"# installed and see if we can use it instead."},{"line_number":54,"context_line":"if [ \"$OVS_SRCDIR\" ] \u0026\u0026 [ ! -d \"$OVS_SRCDIR\" ]; then"},{"line_number":55,"context_line":"    echo \"Building OVS in $OVS_SRCDIR\""},{"line_number":56,"context_line":"    mkdir -p $OVS_SRCDIR"},{"line_number":57,"context_line":"    git clone git://github.com/openvswitch/ovs.git $OVS_SRCDIR"}],"source_content_type":"text/x-sh","patch_set":25,"id":"5f201791_b2f1b797","line":54,"range":{"start_line":54,"start_character":19,"end_line":54,"end_character":25},"updated":"2017-06-29 18:44:27.000000000","message":"Nit: You can run it as a singe call\n\n [ \"$OVS_SRCDIR\" -a ! -d \"$OVS_SRCDIR\" ]","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# We require at least OVS 2.7. Testing infrastructure doesn\u0027t support it yet,"},{"line_number":52,"context_line":"# so build it. Eventually, we should run some checks to see what is actually"},{"line_number":53,"context_line":"# installed and see if we can use it instead."},{"line_number":54,"context_line":"if [ \"$OVS_SRCDIR\" ] \u0026\u0026 [ ! -d \"$OVS_SRCDIR\" ]; then"},{"line_number":55,"context_line":"    echo \"Building OVS in $OVS_SRCDIR\""},{"line_number":56,"context_line":"    mkdir -p $OVS_SRCDIR"},{"line_number":57,"context_line":"    git clone git://github.com/openvswitch/ovs.git $OVS_SRCDIR"}],"source_content_type":"text/x-sh","patch_set":25,"id":"3f1d235d_f2082429","line":54,"range":{"start_line":54,"start_character":19,"end_line":54,"end_character":25},"in_reply_to":"5f201791_b2f1b797","updated":"2017-06-30 03:08:58.000000000","message":"Done","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e731ba3422b0259cddac2905c3307e8d6ba45a82","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    echo \"Building OVS in $OVS_SRCDIR\""},{"line_number":56,"context_line":"    mkdir -p $OVS_SRCDIR"},{"line_number":57,"context_line":"    git clone git://github.com/openvswitch/ovs.git $OVS_SRCDIR"},{"line_number":58,"context_line":"    cd $OVS_SRCDIR"},{"line_number":59,"context_line":"    ./boot.sh"},{"line_number":60,"context_line":"    PYTHON\u003d/usr/bin/python ./configure"},{"line_number":61,"context_line":"    make -j$(($(nproc) + 1))"}],"source_content_type":"text/x-sh","patch_set":25,"id":"5f201791_12362b52","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":6},"updated":"2017-06-29 18:44:27.000000000","message":"Would be safer to use\n\n pushd $OVS_SRCDIR\n ... do compilation ...\n popd","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a709cf51f19bc58448e174ece58c91d24ef91c3a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    echo \"Building OVS in $OVS_SRCDIR\""},{"line_number":56,"context_line":"    mkdir -p $OVS_SRCDIR"},{"line_number":57,"context_line":"    git clone git://github.com/openvswitch/ovs.git $OVS_SRCDIR"},{"line_number":58,"context_line":"    cd $OVS_SRCDIR"},{"line_number":59,"context_line":"    ./boot.sh"},{"line_number":60,"context_line":"    PYTHON\u003d/usr/bin/python ./configure"},{"line_number":61,"context_line":"    make -j$(($(nproc) + 1))"}],"source_content_type":"text/x-sh","patch_set":25,"id":"3f1d235d_9238d0d3","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":6},"in_reply_to":"5f201791_12362b52","updated":"2017-06-30 03:08:58.000000000","message":"initially had it all in a (cd $OVS_SRCDIR \u0026\u0026 ./boot.sh ...) but took it out when debugging. Putting it back.","commit_id":"ecbb82f92da51aa56f71109bcffddf30ae1a3697"}]}
