)]}'
{"ovsdbapp/schema/ovn_northbound/api.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"da5886426baa1481d7898c17404b5f940b0d2359","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    @abc.abstractmethod"},{"line_number":142,"context_line":"    def lsp_list(self, switch\u003dNone):"},{"line_number":143,"context_line":"        \"\"\"Get the logical ports on switch"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        :param switch:  The name or uuid of the switch"},{"line_number":146,"context_line":"        :type switch:   string or uuid.UUID"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_af2942f3","line":143,"updated":"2017-07-07 18:48:40.000000000","message":"... or all ports if switch is None","commit_id":"bdbbd9a1b648c51bc7a7ff2844dc3129e5136f5c"},{"author":{"_account_id":25007,"name":"Marcin Mirecki","email":"mmirecki@redhat.com","username":"mmirecki"},"change_message_id":"e25a6d93e7f95d7db84fc1b3a42ca16a26728423","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    @abc.abstractmethod"},{"line_number":142,"context_line":"    def lsp_list(self, switch\u003dNone):"},{"line_number":143,"context_line":"        \"\"\"Get the logical ports on switch"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        :param switch:  The name or uuid of the switch"},{"line_number":146,"context_line":"        :type switch:   string or uuid.UUID"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_ccc5a50c","line":143,"in_reply_to":"3f1d235d_af2942f3","updated":"2017-07-07 22:46:55.000000000","message":"Done","commit_id":"bdbbd9a1b648c51bc7a7ff2844dc3129e5136f5c"}],"ovsdbapp/schema/ovn_northbound/commands.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"da5886426baa1481d7898c17404b5f940b0d2359","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        self.switch \u003d switch"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def run_idl(self, txn):"},{"line_number":264,"context_line":"        ports \u003d ("},{"line_number":265,"context_line":"            self.api.lookup(\u0027Logical_Switch\u0027, self.switch).ports"},{"line_number":266,"context_line":"            if self.switch else"},{"line_number":267,"context_line":"            self.api.tables[\u0027Logical_Switch_Port\u0027].rows.values()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_afbca26c","line":264,"updated":"2017-07-07 18:48:40.000000000","message":"I\u0027m also a fan of ternary operators, but I found this hard to read. This was easier for me and is more idiomatic in OpenStack projects anyway:\n\n ports \u003d (self.api.lookup(\u0027Logical_Switch\u0027, self.switch).ports if self.switch\n          else self.api.tables[\u0027Logical_Switch_Port\u0027].rows.values())\n\nOtherwise, even just doing an if/else ends up being clearer and takes less lines.","commit_id":"bdbbd9a1b648c51bc7a7ff2844dc3129e5136f5c"},{"author":{"_account_id":25007,"name":"Marcin Mirecki","email":"mmirecki@redhat.com","username":"mmirecki"},"change_message_id":"e25a6d93e7f95d7db84fc1b3a42ca16a26728423","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        self.switch \u003d switch"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def run_idl(self, txn):"},{"line_number":264,"context_line":"        ports \u003d ("},{"line_number":265,"context_line":"            self.api.lookup(\u0027Logical_Switch\u0027, self.switch).ports"},{"line_number":266,"context_line":"            if self.switch else"},{"line_number":267,"context_line":"            self.api.tables[\u0027Logical_Switch_Port\u0027].rows.values()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_ac66e928","line":264,"in_reply_to":"3f1d235d_afbca26c","updated":"2017-07-07 22:46:55.000000000","message":"Going for if/else.\nIt\u0027s hard to keep the line \u003c80 with the first option.\n\nDone","commit_id":"bdbbd9a1b648c51bc7a7ff2844dc3129e5136f5c"}],"ovsdbapp/tests/functional/schema/ovn_northbound/test_impl_idl.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5c520d696054db6b7c9a0d2f025e92eb895dbfc4","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        port_set \u003d set(self.api.lsp_list(self.switch.uuid).execute("},{"line_number":290,"context_line":"            check_error\u003dTrue))"},{"line_number":291,"context_line":"        self.assertTrue(ports.issubset(port_set))"},{"line_number":292,"context_line":"        other_switch \u003d self.useFixture(fixtures.LogicalSwitchFixture("},{"line_number":293,"context_line":"            name\u003dutils.get_rand_device_name())).obj"},{"line_number":294,"context_line":"        other_port \u003d self._lsp_add(other_switch, None)"},{"line_number":295,"context_line":"        all_ports \u003d set(self.api.lsp_list().execute(check_error\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f1a1f67_ff1daa0f","line":292,"updated":"2017-07-12 12:07:34.000000000","message":"This should be a separate test, it\u0027s a different scenario (no switch vs. passed switch)","commit_id":"9f1a12cf535811fb6cb94e6ae5aeb82430c9b54b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"5b72946efd4ffbe9fff4c7026122967ec85b3633","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        port_set \u003d set(self.api.lsp_list(self.switch.uuid).execute("},{"line_number":290,"context_line":"            check_error\u003dTrue))"},{"line_number":291,"context_line":"        self.assertTrue(ports.issubset(port_set))"},{"line_number":292,"context_line":"        other_switch \u003d self.useFixture(fixtures.LogicalSwitchFixture("},{"line_number":293,"context_line":"            name\u003dutils.get_rand_device_name())).obj"},{"line_number":294,"context_line":"        other_port \u003d self._lsp_add(other_switch, None)"},{"line_number":295,"context_line":"        all_ports \u003d set(self.api.lsp_list().execute(check_error\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f1a1f67_94bc50bc","line":292,"in_reply_to":"1f1a1f67_ff1daa0f","updated":"2017-07-12 17:26:45.000000000","message":"Ok. The new test requires all of the code of the existing test to be run, so I figured I\u0027d just save a bit of time by combining them. Happy to change it if you prefer.","commit_id":"9f1a12cf535811fb6cb94e6ae5aeb82430c9b54b"}]}