)]}'
{"TESTING.rst":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"494610b126a0723909ccfa4d21572fefe42241ed","unresolved":false,"context_lines":[{"line_number":8,"context_line":"externalities. Unit tests using mock are acceptable if something is hard to"},{"line_number":9,"context_line":"test without it. BUT, please think carefully before writing a test that makes"},{"line_number":10,"context_line":"heavy use of mock.assert_called_once_with() as those tests *very* often tend"},{"line_number":11,"context_line":"to test what a function *currently does* and not what a function *should do*."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Running tests"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f1a1f67_9df3359f","line":11,"updated":"2017-07-13 12:28:41.000000000","message":"A clippo image \"Are you sure?\" would be handy here :)","commit_id":"d2b185d85c8f596949ec1b31c76b1ef4c0a01976"}],"ovsdbapp/tests/functional/base.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"3fb7b2adc2db9d28298e016fc92e378ad580dfb9","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        cls.connection \u003d connection.Connection(idl, constants.DEFAULT_TIMEOUT)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def setUp(self):"},{"line_number":80,"context_line":"        super(FunctionalTestCase, self).setUp()"},{"line_number":81,"context_line":"        self.set_connection()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_8962b4ac","line":80,"updated":"2017-07-11 14:17:10.000000000","message":"Why not just call venv_log(self.ovsvenvlog, self.id()) here? This will remove the need for metaclass, and I think will generate simpler code.","commit_id":"7cc0f17f59cb5044c806fddf69ff2bef5c47317b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"09a122884a5d6b94a03136c61ca016008a56189e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        cls.connection \u003d connection.Connection(idl, constants.DEFAULT_TIMEOUT)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def setUp(self):"},{"line_number":80,"context_line":"        super(FunctionalTestCase, self).setUp()"},{"line_number":81,"context_line":"        self.set_connection()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_a0357edc","line":80,"in_reply_to":"3f1d235d_8962b4ac","updated":"2017-07-11 15:31:33.000000000","message":"Because I didn\u0027t know about self.id(). Well. That\u0027s a lot simpler. :p","commit_id":"7cc0f17f59cb5044c806fddf69ff2bef5c47317b"}],"tools/debug_venv":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"3fb7b2adc2db9d28298e016fc92e378ad580dfb9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Use a shell script to launch toosl/debub_venv.py so that we can enter a"},{"line_number":3,"context_line":"# virtual environment if we are not already in one"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"for option;do"},{"line_number":6,"context_line":"\tif test -n \"$prev\";then"},{"line_number":7,"context_line":"\t\teval $prev\u003d\\$option"},{"line_number":8,"context_line":"\t\tprev\u003d"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f1d235d_293e0029","line":5,"updated":"2017-07-11 14:17:10.000000000","message":"Isn\u0027t this basically reimplementing getopt?\n\nMaybe using shift 1/shift 2 will be better than the eval/continue trick?","commit_id":"7cc0f17f59cb5044c806fddf69ff2bef5c47317b"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"bec184d8cfcb9078f9e3a5e65d694bee726b50a1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Use a shell script to launch toosl/debub_venv.py so that we can enter a"},{"line_number":3,"context_line":"# virtual environment if we are not already in one"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"for option;do"},{"line_number":6,"context_line":"\tif test -n \"$prev\";then"},{"line_number":7,"context_line":"\t\teval $prev\u003d\\$option"},{"line_number":8,"context_line":"\t\tprev\u003d"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1f1a1f67_f1f26406","line":5,"in_reply_to":"3f1d235d_20ccceba","updated":"2017-07-13 04:45:18.000000000","message":"Sure.","commit_id":"7cc0f17f59cb5044c806fddf69ff2bef5c47317b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"3b18b551707c588b92f178233d16661f5e06fa9f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Use a shell script to launch toosl/debub_venv.py so that we can enter a"},{"line_number":3,"context_line":"# virtual environment if we are not already in one"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"for option;do"},{"line_number":6,"context_line":"\tif test -n \"$prev\";then"},{"line_number":7,"context_line":"\t\teval $prev\u003d\\$option"},{"line_number":8,"context_line":"\t\tprev\u003d"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f1d235d_20ccceba","line":5,"in_reply_to":"3f1d235d_293e0029","updated":"2017-07-11 15:34:06.000000000","message":"we could. basically just used the same method that ovs-sandbox did because it had been a while since I used getopt w/ bash.","commit_id":"7cc0f17f59cb5044c806fddf69ff2bef5c47317b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"494610b126a0723909ccfa4d21572fefe42241ed","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"# Use a shell script to launch toosl/debub_venv.py so that we can enter a"},{"line_number":3,"context_line":"# virtual environment if we are not already in one"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"for option;do"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f1a1f67_bd0a7123","line":2,"range":{"start_line":2,"start_character":31,"end_line":2,"end_character":36},"updated":"2017-07-13 12:28:41.000000000","message":"tools","commit_id":"d2b185d85c8f596949ec1b31c76b1ef4c0a01976"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"44739e503246e8ac9554fb491b40ec1980c1a8d2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"# Use a shell script to launch toosl/debub_venv.py so that we can enter a"},{"line_number":3,"context_line":"# virtual environment if we are not already in one"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"for option;do"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f1a1f67_be3dc7bc","line":2,"range":{"start_line":2,"start_character":31,"end_line":2,"end_character":36},"in_reply_to":"1f1a1f67_bd0a7123","updated":"2017-07-13 13:18:21.000000000","message":"Done.","commit_id":"d2b185d85c8f596949ec1b31c76b1ef4c0a01976"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"494610b126a0723909ccfa4d21572fefe42241ed","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# virtual environment if we are not already in one"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"for option;do"},{"line_number":6,"context_line":"\tif test -n \"$prev\";then"},{"line_number":7,"context_line":"\t\teval $prev\u003d\\$option"},{"line_number":8,"context_line":"\t\tprev\u003d"},{"line_number":9,"context_line":"\t\tcontinue"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f1a1f67_1db84574","line":6,"updated":"2017-07-13 12:28:41.000000000","message":"Aren\u0027t spaces for any reason better than tabs?","commit_id":"d2b185d85c8f596949ec1b31c76b1ef4c0a01976"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"44739e503246e8ac9554fb491b40ec1980c1a8d2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# virtual environment if we are not already in one"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"for option;do"},{"line_number":6,"context_line":"\tif test -n \"$prev\";then"},{"line_number":7,"context_line":"\t\teval $prev\u003d\\$option"},{"line_number":8,"context_line":"\t\tprev\u003d"},{"line_number":9,"context_line":"\t\tcontinue"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f1a1f67_83e1989d","line":6,"in_reply_to":"1f1a1f67_1db84574","updated":"2017-07-13 13:18:21.000000000","message":"I\u0027ll forward your question to Linus and you two can discuss it. :)\n\n(I changed it here though)","commit_id":"d2b185d85c8f596949ec1b31c76b1ef4c0a01976"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"494610b126a0723909ccfa4d21572fefe42241ed","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\t\t\t\texit 1"},{"line_number":37,"context_line":"\t\t\tfi"},{"line_number":38,"context_line":"\tesac"},{"line_number":39,"context_line":"done"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"if [ -z \"$regex\" -a -z \"$ovsvenv\" ]; then"},{"line_number":42,"context_line":"\techo \"Need regex or ovsvenv\" 1\u003e\u00262"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f1a1f67_5d311d0b","line":39,"updated":"2017-07-13 12:28:41.000000000","message":"Was the above inspired by ovs-sandbox from ovs? It looks like it does what getopts bash built-in does - is it because you don\u0027t want to stick to bash but generally to sh?","commit_id":"d2b185d85c8f596949ec1b31c76b1ef4c0a01976"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"44739e503246e8ac9554fb491b40ec1980c1a8d2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\t\t\t\texit 1"},{"line_number":37,"context_line":"\t\t\tfi"},{"line_number":38,"context_line":"\tesac"},{"line_number":39,"context_line":"done"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"if [ -z \"$regex\" -a -z \"$ovsvenv\" ]; then"},{"line_number":42,"context_line":"\techo \"Need regex or ovsvenv\" 1\u003e\u00262"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f1a1f67_a39254f5","line":39,"in_reply_to":"1f1a1f67_5d311d0b","updated":"2017-07-13 13:18:21.000000000","message":"I believe that is why they did what they did. I did what *I* did because I am lazy. :p","commit_id":"d2b185d85c8f596949ec1b31c76b1ef4c0a01976"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"494610b126a0723909ccfa4d21572fefe42241ed","unresolved":false,"context_lines":[{"line_number":55,"context_line":"\t\techo \"Could not match $regex\" 1\u003e\u00262"},{"line_number":56,"context_line":"\t\texit 1"},{"line_number":57,"context_line":"\tfi"},{"line_number":58,"context_line":"\ttest_file\u003d$(echo $lookup|cut -d: -f1)"},{"line_number":59,"context_line":"\ttest_match\u003d\", matched $(echo $lookup|rev|cut -d: -f1|rev)\""},{"line_number":60,"context_line":"\tovsvenv\u003d$(head -1 $test_file)"},{"line_number":61,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f1a1f67_785187d8","line":58,"range":{"start_line":58,"start_character":37,"end_line":58,"end_character":38},"updated":"2017-07-13 12:28:41.000000000","message":"Shouldn\u0027t you translate dots to backslashes? As per docs TestCase.id() returns module name (which I assume has dots, I haven\u0027t tried).","commit_id":"d2b185d85c8f596949ec1b31c76b1ef4c0a01976"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"44739e503246e8ac9554fb491b40ec1980c1a8d2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"\t\techo \"Could not match $regex\" 1\u003e\u00262"},{"line_number":56,"context_line":"\t\texit 1"},{"line_number":57,"context_line":"\tfi"},{"line_number":58,"context_line":"\ttest_file\u003d$(echo $lookup|cut -d: -f1)"},{"line_number":59,"context_line":"\ttest_match\u003d\", matched $(echo $lookup|rev|cut -d: -f1|rev)\""},{"line_number":60,"context_line":"\tovsvenv\u003d$(head -1 $test_file)"},{"line_number":61,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f1a1f67_be3827d3","line":58,"range":{"start_line":58,"start_character":37,"end_line":58,"end_character":38},"in_reply_to":"1f1a1f67_785187d8","updated":"2017-07-13 13:18:21.000000000","message":"lookup will have the output of grep which does filename: $matched_line. We\u0027re just grabbing the filename part returned by grep. Then below in test_match, dots are fine since we are just grepping for test names and not file names.","commit_id":"d2b185d85c8f596949ec1b31c76b1ef4c0a01976"}]}
