)]}'
{"ovsdbapp/schema/ovn_northbound/api.py":[{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"15c48703867d526e88da73ae9f6c0e0be12dcac5","unresolved":false,"context_lines":[{"line_number":711,"context_line":"        :type hostname: string"},{"line_number":712,"context_line":"        :param addresses: value for the \u0027hostname\u0027 key in the DNS \u0027records\u0027"},{"line_number":713,"context_line":"                         dict"},{"line_number":714,"context_line":"        :type addresses: string  "},{"line_number":715,"context_line":"        :returns:    :class:`Command` with no result"},{"line_number":716,"context_line":"        \"\"\""},{"line_number":717,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_c363f119","line":714,"updated":"2017-08-24 12:32:50.000000000","message":"Damn whitespace. Will be corrected in the next patch","commit_id":"cc0899557ebdaf74846fb4a49f883acf8d81c200"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"15c48703867d526e88da73ae9f6c0e0be12dcac5","unresolved":false,"context_lines":[{"line_number":720,"context_line":"        \"\"\"Deletes a dns record in \u0027records\u0027 field of the DNS row"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"        :param uuid: The uuid of the DNS row"},{"line_number":723,"context_line":"        :type uuid:  string or uuid.UUID"},{"line_number":724,"context_line":"        :param hostname: key in the DNS \u0027records\u0027 dict to delete "},{"line_number":725,"context_line":"        :type hostname: string"},{"line_number":726,"context_line":"        :returns:    :class:`Command` with no result"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_a366a528","line":723,"updated":"2017-08-24 12:32:50.000000000","message":"Damn here as well :)","commit_id":"cc0899557ebdaf74846fb4a49f883acf8d81c200"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"31cb6d0084d0d7adaf1036471e9f10230b0f0b3d","unresolved":false,"context_lines":[{"line_number":691,"context_line":"        \"\"\""},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    @abc.abstractmethod"},{"line_number":694,"context_line":"    def dns_set_records(self, uuid, **records):"},{"line_number":695,"context_line":"        \"\"\"Sets the \u0027records\u0027 field of the DNS row"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        :param uuid: The uuid of the DNS row to set the records with"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_4641a009","line":694,"updated":"2017-11-07 18:36:12.000000000","message":"Some people working on oVirt have suggested similar field-specific set/update commands that I\u0027ve pushed back on a bit since we have a generic methods like db_set, db_add, etc. where you pass in the table name and the columns/values that you want to update. The idea being that it\u0027s the same operation for all of these things, so why duplicate the code for every object/column. With that said, because I mirrored the ovn-nbctl commands, we have lots of methods like this for LSPs. Are there going to be similar commands added to ovn-nbctl for DNS?\n\nIf we need table-specific versions of these (I\u0027ve heard arguments that it feels less \"clean\" passing table names), we could probably find a way to generate them.","commit_id":"0e616a8435af787230ff5756364441b2411ee932"}],"ovsdbapp/schema/ovn_northbound/commands.py":[{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"15c48703867d526e88da73ae9f6c0e0be12dcac5","unresolved":false,"context_lines":[{"line_number":1047,"context_line":"        self.row_uuid \u003d row_uuid"},{"line_number":1048,"context_line":"        self.hostname \u003d hostname"},{"line_number":1049,"context_line":"        self.addresses \u003d addresses"},{"line_number":1050,"context_line":"        "},{"line_number":1051,"context_line":"    def run_idl(self, txn):"},{"line_number":1052,"context_line":"        try:"},{"line_number":1053,"context_line":"            dns \u003d self.api.lookup(\u0027DNS\u0027, self.row_uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_e37b8dbb","line":1050,"updated":"2017-08-24 12:32:50.000000000","message":"Now, its shame on me","commit_id":"cc0899557ebdaf74846fb4a49f883acf8d81c200"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"31cb6d0084d0d7adaf1036471e9f10230b0f0b3d","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"    def __init__(self, api, uuid):"},{"line_number":1010,"context_line":"        super(DnsDelCommand, self).__init__(api, \u0027DNS\u0027, uuid)"},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"class _DnsDelCommand(cmd.BaseCommand):"},{"line_number":1014,"context_line":"    def __init__(self, api, uuid):"},{"line_number":1015,"context_line":"        super(_DnsDelCommand, self).__init__(api)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_c66fd05d","line":1012,"updated":"2017-11-07 18:36:12.000000000","message":"You have two DnsDelCommands","commit_id":"0e616a8435af787230ff5756364441b2411ee932"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"9b73822986747f33e8e4d68e9a467416d73fc6f7","unresolved":false,"context_lines":[{"line_number":995,"context_line":"class DnsAddCommand(cmd.AddCommand):"},{"line_number":996,"context_line":"    table_name \u003d \u0027DNS\u0027"},{"line_number":997,"context_line":""},{"line_number":998,"context_line":"    def __init__(self, api, **external_ids):"},{"line_number":999,"context_line":"        super(DnsAddCommand, self).__init__(api)"},{"line_number":1000,"context_line":"        self.external_ids \u003d external_ids"},{"line_number":1001,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_a2038b0f","line":998,"updated":"2017-11-09 17:11:48.000000000","message":"Didn\u0027t notice this before: currently there are just external_ids/records columns in DNS. Are we absolutely sure more columns won\u0027t be added in the future? If not, then we should probably do **columns like most of the other AddCommands instead and:\n\n    self.set_columns(dns, **columns)\n\nIf we are sure, then I\u0027m fine with the way things are. I see that AclAddCommand weirdly does a lot of named columns, then **external_ids. Not sure why I did that now.","commit_id":"03c61db11185ccd85dbcbc6264f121fb6b03e5ad"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"e15de36d238758d5b3f8ca605dd1b40b6f15fad6","unresolved":false,"context_lines":[{"line_number":995,"context_line":"class DnsAddCommand(cmd.AddCommand):"},{"line_number":996,"context_line":"    table_name \u003d \u0027DNS\u0027"},{"line_number":997,"context_line":""},{"line_number":998,"context_line":"    def __init__(self, api, **external_ids):"},{"line_number":999,"context_line":"        super(DnsAddCommand, self).__init__(api)"},{"line_number":1000,"context_line":"        self.external_ids \u003d external_ids"},{"line_number":1001,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_4074cf99","line":998,"in_reply_to":"1f485f77_a2038b0f","updated":"2017-11-09 18:08:22.000000000","message":"Yes. I am pretty sure we will not be adding more columns. My idea is in the function create_network_postcommit of networking-ovn to create a new DNS row (with external_ids set to neutron:network_id\u003d\u003cNET_ID\u003e) and set it in the logical_switch\u0027s dns_records and later when a port is created or updated with dns_name, add the dns record in the DNS row, records column.","commit_id":"03c61db11185ccd85dbcbc6264f121fb6b03e5ad"}],"ovsdbapp/tests/functional/schema/ovn_northbound/test_impl_idl.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b675b5002b671e14d395653003f375e0d59deade","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"            dns.uuid, **{}).execute(check_error\u003dTrue)"},{"line_number":1131,"context_line":"        self.assertEqual({}, dns.records)"},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"    def test_dns_set_external_ids(self):"},{"line_number":1134,"context_line":"        dns \u003d self._dns_add()"},{"line_number":1135,"context_line":"        external_ids \u003d {\u0027a\u0027: \u0027one\u0027, \u0027b\u0027: \u0027two\u0027}"},{"line_number":1136,"context_line":"        self.api.dns_set_external_ids("}],"source_content_type":"text/x-python","patch_set":5,"id":"1f485f77_9a0542c5","line":1133,"updated":"2017-11-14 11:40:02.000000000","message":"A followup patch could be to add more tests to cover cases when setting DNS record on not existing DNS and checking it raises a RuntimeError.","commit_id":"d7e3313b2c6b9b7ee03dd6606dedc9dc4b3cb7dc"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"e184a74fbbcc82022a51eae197c4b4231c8fb981","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"            dns.uuid, **{}).execute(check_error\u003dTrue)"},{"line_number":1131,"context_line":"        self.assertEqual({}, dns.records)"},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"    def test_dns_set_external_ids(self):"},{"line_number":1134,"context_line":"        dns \u003d self._dns_add()"},{"line_number":1135,"context_line":"        external_ids \u003d {\u0027a\u0027: \u0027one\u0027, \u0027b\u0027: \u0027two\u0027}"},{"line_number":1136,"context_line":"        self.api.dns_set_external_ids("}],"source_content_type":"text/x-python","patch_set":5,"id":"1f485f77_3ab9aee8","line":1133,"in_reply_to":"1f485f77_9a0542c5","updated":"2017-11-14 11:44:15.000000000","message":"Ack","commit_id":"d7e3313b2c6b9b7ee03dd6606dedc9dc4b3cb7dc"}]}