)]}'
{"ovsdbapp/backend/ovs_idl/__init__.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"75bd9a5205e106ec46bdad8401786e0013542527","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    lookup_table \u003d {}"},{"line_number":27,"context_line":"    ovsdb_connection \u003d None"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, connection, override\u003dFalse):"},{"line_number":30,"context_line":"        super(Backend, self).__init__()"},{"line_number":31,"context_line":"        self.start_connection(connection, override)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_79ccf7bb","line":29,"updated":"2017-09-12 17:56:44.000000000","message":"Can we now get rid of the override attribute entirely since we don\u0027t have to delete the connection to restart it anymore now that the thread is joined, etc.? Can we just add a restart_connection() that does a cls.ovsdb_connection.stop() / cls.ovsdb_conneciton.start()?","commit_id":"a59a284f5f0001a09793442161f234ecec35adb9"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"c046a43dbdde4907db46b18770dda2e6881ee5fc","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    lookup_table \u003d {}"},{"line_number":27,"context_line":"    ovsdb_connection \u003d None"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, connection, override\u003dFalse):"},{"line_number":30,"context_line":"        super(Backend, self).__init__()"},{"line_number":31,"context_line":"        self.start_connection(connection, override)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_3feabcab","line":29,"in_reply_to":"5f2577a7_79ccf7bb","updated":"2017-09-13 02:51:41.000000000","message":"The override option allows you to replace/change the connection. This functionality covers more than just a restart.\n\n+1 on adding restart_connection().\n\nI\u0027ll check if calling restart_connection is enough to restore a dropped connection. If so, my usecase doesn\u0027t need the override attribute, and I can remove it.","commit_id":"a59a284f5f0001a09793442161f234ecec35adb9"}],"ovsdbapp/backend/ovs_idl/connection.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"8b50b4835905ce2faf19b762185fc4472b00023b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.lock \u003d threading.Lock()"},{"line_number":65,"context_line":"        self.idl \u003d idl"},{"line_number":66,"context_line":"        self.thread \u003d None"},{"line_number":67,"context_line":"        self._is_running \u003d True"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def start(self):"},{"line_number":70,"context_line":"        \"\"\"Start the connection.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_4a637f43","line":67,"updated":"2017-08-25 00:50:17.000000000","message":"This is a lie. :)","commit_id":"2fdd0e56d175fb26fdda054c740cb456b4c0b2b1"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"5a254902005cf61745424675c3bef53932e11d0d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.lock \u003d threading.Lock()"},{"line_number":65,"context_line":"        self.idl \u003d idl"},{"line_number":66,"context_line":"        self.thread \u003d None"},{"line_number":67,"context_line":"        self._is_running \u003d True"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def start(self):"},{"line_number":70,"context_line":"        \"\"\"Start the connection.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_94e65844","line":67,"in_reply_to":"7f287b81_4a637f43","updated":"2017-09-12 05:46:40.000000000","message":"Done. Surprisingly, it works better after I changed it :)","commit_id":"2fdd0e56d175fb26fdda054c740cb456b4c0b2b1"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"8b50b4835905ce2faf19b762185fc4472b00023b","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def stop(self):"},{"line_number":108,"context_line":"        self._is_running \u003d False"},{"line_number":109,"context_line":"        self.poller.immediate_wake()"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def queue_txn(self, txn):"},{"line_number":112,"context_line":"        self.txns.put(txn)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_0a8457d3","line":109,"updated":"2017-08-25 00:50:17.000000000","message":"I don\u0027t think this is sufficient since (I think) immediate_wake doesn\u0027t actually wake a current block() call, but only ensures the next call to block() doesn\u0027t block. That\u0027s why I did all of the weird TransactionQueue alert_fileno stuff, to actually wake up the block(). You could wake it up by writing a byte txns.alert_fileno/using the alert_notify stuff.\n\nIt\u0027s not horrible right now since timer_wait() wakes things up every second, but I\u0027m not sure that is actually necessary (and if it still is, it\u0027s a bug that needs to be fixed and will eventually go away anyway--which potentially could mean blocking forever).\n\nAlso, shouldn\u0027t we join the thread to make sure it is actually stopped, then set it to None? Then start() could be called again to recreate it all? Seems like with existing code you could call stop, then call start again before the thread was set to None.\n\nI realize that if you are deleting the connection after stopping, it doesn\u0027t really matter, but it\u0027s not obvious from this API that that has to happen.","commit_id":"2fdd0e56d175fb26fdda054c740cb456b4c0b2b1"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"5a254902005cf61745424675c3bef53932e11d0d","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def stop(self):"},{"line_number":108,"context_line":"        self._is_running \u003d False"},{"line_number":109,"context_line":"        self.poller.immediate_wake()"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def queue_txn(self, txn):"},{"line_number":112,"context_line":"        self.txns.put(txn)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_b4d95484","line":109,"in_reply_to":"7f287b81_0a8457d3","updated":"2017-09-12 05:46:40.000000000","message":"Changed according to your recommendations.","commit_id":"2fdd0e56d175fb26fdda054c740cb456b4c0b2b1"}],"ovsdbapp/tests/functional/schema/open_vswitch/test_impl_idl.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"75bd9a5205e106ec46bdad8401786e0013542527","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            connection \u003d type(self).create_connection(self.schemas[0])"},{"line_number":118,"context_line":"            self.api \u003d impl_idl.OvsdbIdl(connection, override\u003dTrue)"},{"line_number":119,"context_line":"            old_connection.stop.assert_called_once()"},{"line_number":120,"context_line":"            exists \u003d self.api.br_exists(self.brname).execute(check_error\u003dTrue)"},{"line_number":121,"context_line":"            self.assertFalse(exists)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_connection_disconnect_timeout(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_0effe734","line":120,"updated":"2017-09-12 17:56:44.000000000","message":"nit: could just run self.test_br_exists_false()","commit_id":"a59a284f5f0001a09793442161f234ecec35adb9"}]}
