)]}'
{"ovsdbapp/schema/ovn_northbound/commands.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9007cbde4e1218b0f9968100f47acb9ad5ca21cc","unresolved":false,"context_lines":[{"line_number":84,"context_line":"class AclAddCommand(cmd.AddCommand):"},{"line_number":85,"context_line":"    table_name \u003d \u0027ACL\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def __init__(self, api, switch, direction, priority, match, action,"},{"line_number":88,"context_line":"                 log\u003dFalse, may_exist\u003dFalse, **external_ids):"},{"line_number":89,"context_line":"        if direction not in (\u0027from-lport\u0027, \u0027to-lport\u0027):"},{"line_number":90,"context_line":"            raise TypeError(\"direction must be either from-lport or to-lport\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_fafffcfe","line":87,"range":{"start_line":87,"start_character":28,"end_line":87,"end_character":34},"updated":"2018-06-01 09:23:35.000000000","message":"What if we make the switch parameter optional, but, enforce it in the interface implementation (impl_idl.py). E.g\n\ndef acl_add(self, switch, direction, priority, match, action, ...):\n    cmd.AclAddCommand(self, direction, priority, match, action, switch\u003dswitch)\n\ndef acl_add_no_ls(self, direction, priority, match, action, ...):\n     cmd.AclAddCommand(self, direction, priority, match, action)\n\n\nSame for the AclDelCommand and AclListCommand, at least we avoid the code duplication in this file since the methods are almost the same but don\u0027t have the LS bits.","commit_id":"f4d5ba0b1127818fd8a9ef78fbdb1dc3b0171b72"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8063f83cc5e2de9b1032fbc2f5d05fcb7b988586","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        for acl in [a for a in pg.acls"},{"line_number":235,"context_line":"                    if idlutils.row_match(a, self.conditions)]:"},{"line_number":236,"context_line":"            pg.delvalue(\u0027acls\u0027, acl)"},{"line_number":237,"context_line":"            acl.delete()"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"class PgAclListCommand(cmd.BaseCommand):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_9fc6bf49","line":237,"updated":"2018-06-05 09:06:03.000000000","message":"I wonder if we could make the PgAclAddCommand, PgAclDelCommand, AclAddCOmmand and AclDelCommand generic. They are essentially the same the only difference apparently is that one adds/remove items from the Logical_Switch or Port_Group tables.","commit_id":"5a612a162ebb5e4c36986c201193f9e85089c883"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"dc13add2d285bbc3d90e434354181214eb6ff794","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        for acl in [a for a in pg.acls"},{"line_number":235,"context_line":"                    if idlutils.row_match(a, self.conditions)]:"},{"line_number":236,"context_line":"            pg.delvalue(\u0027acls\u0027, acl)"},{"line_number":237,"context_line":"            acl.delete()"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"class PgAclListCommand(cmd.BaseCommand):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_62e1c82a","line":237,"in_reply_to":"5f7c97a3_9fc6bf49","updated":"2018-06-05 09:32:46.000000000","message":"Si! Lemme try :)","commit_id":"5a612a162ebb5e4c36986c201193f9e85089c883"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"329ac7316c5b5c91affc07f716b8ec09344345bf","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.result \u003d acl.uuid"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"class AclAddCommand(_AclAddHelper):"},{"line_number":133,"context_line":"    lookup_table \u003d \u0027Logical_Switch\u0027"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_98fd7070","line":132,"updated":"2018-06-05 14:36:14.000000000","message":"Do you think we should worry about potentially breaking any code that creates an AclAddCommand outside of acl_add() due to the argument \"switch\" becoming \"entity\"? We can *probably* get away with it, but it at least theoretically could require a change to user code. an __init__ that wraps it could fix the name here and in AclDelCommand.","commit_id":"07da4816fd5369444eb8ef5066f11b2749a78895"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"329ac7316c5b5c91affc07f716b8ec09344345bf","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"                pass"},{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"        pg \u003d txn.insert(self.api._tables[self.table_name])"},{"line_number":1200,"context_line":"        if self.name:"},{"line_number":1201,"context_line":"            pg.name \u003d self.name"},{"line_number":1202,"context_line":"        else:"},{"line_number":1203,"context_line":"            # because ovs.db.idl brokenly requires a changed column"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_583cb82f","line":1200,"updated":"2018-06-05 14:36:14.000000000","message":"could just be pg.name \u003d self.name or \"\"","commit_id":"07da4816fd5369444eb8ef5066f11b2749a78895"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"23745b998ce56a57a44724f32c061f400394a9ee","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"                pass"},{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"        pg \u003d txn.insert(self.api._tables[self.table_name])"},{"line_number":1200,"context_line":"        if self.name:"},{"line_number":1201,"context_line":"            pg.name \u003d self.name"},{"line_number":1202,"context_line":"        else:"},{"line_number":1203,"context_line":"            # because ovs.db.idl brokenly requires a changed column"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_1be4fa3b","line":1200,"in_reply_to":"5f7c97a3_583cb82f","updated":"2018-06-06 11:17:29.000000000","message":"++","commit_id":"07da4816fd5369444eb8ef5066f11b2749a78895"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"5b40c3797897b214756f3465adb12fa9c9837e1e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    table_name \u003d \u0027ACL\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def __init__(self, api, entity, direction, priority, match, action,"},{"line_number":88,"context_line":"                 log\u003dFalse, may_exist\u003dFalse, **external_ids):"},{"line_number":89,"context_line":"        if direction not in (\u0027from-lport\u0027, \u0027to-lport\u0027):"},{"line_number":90,"context_line":"            raise TypeError(\"direction must be either from-lport or to-lport\")"},{"line_number":91,"context_line":"        if not 0 \u003c\u003d priority \u003c\u003d const.ACL_PRIORITY_MAX:"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_83b96a7a","line":88,"updated":"2018-06-06 11:11:42.000000000","message":"@Terry, in networking-ovn we\u0027re supporting \u0027name\u0027 and \u0027severity\u0027 columns but in ovsdbapp is not possible to support it without breaking the current interface as the last argument is **external_ids. Any ideas? :(","commit_id":"1979723234bc5f43b12f37af66030519d600be73"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"23745b998ce56a57a44724f32c061f400394a9ee","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    table_name \u003d \u0027ACL\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def __init__(self, api, entity, direction, priority, match, action,"},{"line_number":88,"context_line":"                 log\u003dFalse, may_exist\u003dFalse, **external_ids):"},{"line_number":89,"context_line":"        if direction not in (\u0027from-lport\u0027, \u0027to-lport\u0027):"},{"line_number":90,"context_line":"            raise TypeError(\"direction must be either from-lport or to-lport\")"},{"line_number":91,"context_line":"        if not 0 \u003c\u003d priority \u003c\u003d const.ACL_PRIORITY_MAX:"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_431ef274","line":88,"in_reply_to":"5f7c97a3_83b96a7a","updated":"2018-06-06 11:17:29.000000000","message":"Maybe we can add those fields as part of the optional arguments ?\n\ne.g\n\ndef __init__(self, api, direction ... may_exist\u003dFalse, severity\u003d0, name\u003dNone, **external_ids):\n\nNot sure it would break the interface, unless someone was passing a \"severity\" and \"name\" keys as part of the external_ids column.","commit_id":"1979723234bc5f43b12f37af66030519d600be73"}],"ovsdbapp/schema/ovn_northbound/impl_idl.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"a7ac3e673d059f838a2ee40c7a0a18911d58849c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def acl_list(self, switch):"},{"line_number":65,"context_line":"        return cmd.AclListCommand(self, switch)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def aclnols_add(self, direction, priority, match, action, log\u003dFalse, name\u003dNone,"},{"line_number":68,"context_line":"                    may_exist\u003dFalse, **external_ids):"},{"line_number":69,"context_line":"        return cmd.AclNoLSAddCommand(self, direction, priority, match, action,"},{"line_number":70,"context_line":"                                     log, name, may_exist, **external_ids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1ade786c","line":67,"updated":"2018-06-01 08:30:03.000000000","message":"as per our brainstorming on IRC, we found no good way of integrating this in acl_add in a backwards compatible way without messing things too much.\n\nwhat about pg_acl_add / pg_acl_del / pg_acl_list ? :)","commit_id":"f4d5ba0b1127818fd8a9ef78fbdb1dc3b0171b72"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9007cbde4e1218b0f9968100f47acb9ad5ca21cc","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def acl_list(self, switch):"},{"line_number":65,"context_line":"        return cmd.AclListCommand(self, switch)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def aclnols_add(self, direction, priority, match, action, log\u003dFalse, name\u003dNone,"},{"line_number":68,"context_line":"                    may_exist\u003dFalse, **external_ids):"},{"line_number":69,"context_line":"        return cmd.AclNoLSAddCommand(self, direction, priority, match, action,"},{"line_number":70,"context_line":"                                     log, name, may_exist, **external_ids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5d54eafd","line":67,"in_reply_to":"5f7c97a3_1ade786c","updated":"2018-06-01 09:23:35.000000000","message":"That\u0027s an alternative too","commit_id":"f4d5ba0b1127818fd8a9ef78fbdb1dc3b0171b72"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"56e7006dc39cc18a955f213d4837a9e348c2f6c0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def acl_list(self, switch):"},{"line_number":65,"context_line":"        return cmd.AclListCommand(self, switch)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def aclnols_add(self, direction, priority, match, action, log\u003dFalse, name\u003dNone,"},{"line_number":68,"context_line":"                    may_exist\u003dFalse, **external_ids):"},{"line_number":69,"context_line":"        return cmd.AclNoLSAddCommand(self, direction, priority, match, action,"},{"line_number":70,"context_line":"                                     log, name, may_exist, **external_ids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3daece2d","line":67,"in_reply_to":"5f7c97a3_5d54eafd","updated":"2018-06-01 10:01:29.000000000","message":"Investigating more, apparently that\u0027s the only alternative.\n\nThe ACL table in OVN has a \"isRoot\": false, so we can\u0027t create it standalone. It needs to belong to either a Logical_Switch or a Port_Group","commit_id":"f4d5ba0b1127818fd8a9ef78fbdb1dc3b0171b72"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"a7ac3e673d059f838a2ee40c7a0a18911d58849c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        return cmd.AclNoLSAddCommand(self, direction, priority, match, action,"},{"line_number":70,"context_line":"                                     log, name, may_exist, **external_ids)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def aclnols_del(self, acl):"},{"line_number":73,"context_line":"        return cmd.AclNoLSDelCommand(self, acl)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def aclnols_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9a4e086d","line":72,"updated":"2018-06-01 08:30:03.000000000","message":"acl \u003d\u003e acl_uuid or acl_name??\n\nI think we need to still admit matching on specific fields, because outside of neutron, somebody could want to remove acls by specific matchings.","commit_id":"f4d5ba0b1127818fd8a9ef78fbdb1dc3b0171b72"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9007cbde4e1218b0f9968100f47acb9ad5ca21cc","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        return cmd.AclNoLSAddCommand(self, direction, priority, match, action,"},{"line_number":70,"context_line":"                                     log, name, may_exist, **external_ids)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def aclnols_del(self, acl):"},{"line_number":73,"context_line":"        return cmd.AclNoLSDelCommand(self, acl)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def aclnols_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3d3d6eba","line":72,"in_reply_to":"5f7c97a3_9a4e086d","updated":"2018-06-01 09:23:35.000000000","message":"acl_id maybe, cause \"identifier\" is generic. Could be UUID or name.","commit_id":"f4d5ba0b1127818fd8a9ef78fbdb1dc3b0171b72"}],"ovsdbapp/tests/functional/schema/ovn_northbound/test_impl_idl.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"05040c6244654fed6392a4b5d4c9a5be74cb0b4e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        return aclrow"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def test_acl_add(self):"},{"line_number":130,"context_line":"        self._acl_add(True, \u0027from-lport\u0027, 0, \u0027output \u003d\u003d \"fake_port\" \u0026\u0026 ip\u0027,"},{"line_number":131,"context_line":"                      \u0027drop\u0027)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_acl_add_exists(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_14cb8d4a","line":130,"updated":"2018-06-04 09:53:32.000000000","message":"I\u0027d create a constant USE_LSWITCH USE_PG\n\nso it\u0027s more clear what the \"True\" / \"False\" means :)","commit_id":"2d3c7c1b616403a3c61edeaee77b1a5c17a0151f"}]}
