)]}'
{"ovsdbapp/api.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"65ac395f19afdddfc4bf3b4d76f6810aa06ab882","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @contextlib.contextmanager"},{"line_number":91,"context_line":"    def transaction(self, check_error\u003dFalse, log_errors\u003dTrue,"},{"line_number":92,"context_line":"                    nested\u003dTrue, **kwargs):"},{"line_number":93,"context_line":"        \"\"\"Create a transaction context."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        :param check_error: Allow the transaction to raise an exception?"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_1286bd67","line":92,"range":{"start_line":92,"start_character":20,"end_line":92,"end_character":26},"updated":"2019-01-28 11:31:34.000000000","message":"Are there any downsides in calling create_transaction() instead of transaction() when you don\u0027t need nesting?","commit_id":"829da6ad9d7353fbffde5d862a13764df58537fb"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e0110d637305a1582e4421fffb079848ea76d58d","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @contextlib.contextmanager"},{"line_number":91,"context_line":"    def transaction(self, check_error\u003dFalse, log_errors\u003dTrue,"},{"line_number":92,"context_line":"                    nested\u003dTrue, **kwargs):"},{"line_number":93,"context_line":"        \"\"\"Create a transaction context."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        :param check_error: Allow the transaction to raise an exception?"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_52bd2500","line":92,"range":{"start_line":92,"start_character":20,"end_line":92,"end_character":26},"in_reply_to":"9fdfeff1_1286bd67","updated":"2019-01-28 11:36:41.000000000","message":"Oh I just now noticed that function there... The name is a bit misleading but I think it does the same as nested\u003dFalse. Right ?\n\nThere\u0027s no downsides (not that I can think of), I just didn\u0027t know it existed haha","commit_id":"829da6ad9d7353fbffde5d862a13764df58537fb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5b0ff191f1ec5d1365de6240e70a3e46a9f77a60","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @contextlib.contextmanager"},{"line_number":91,"context_line":"    def transaction(self, check_error\u003dFalse, log_errors\u003dTrue,"},{"line_number":92,"context_line":"                    nested\u003dTrue, **kwargs):"},{"line_number":93,"context_line":"        \"\"\"Create a transaction context."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        :param check_error: Allow the transaction to raise an exception?"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_b2f8117b","line":92,"range":{"start_line":92,"start_character":20,"end_line":92,"end_character":26},"in_reply_to":"9fdfeff1_52bd2500","updated":"2019-01-28 11:51:33.000000000","message":"Ah :) I suggested to Daniel last week to use create_transaction() where nesting must not be used instead so I thought that maybe there was a reason we should not do that.","commit_id":"829da6ad9d7353fbffde5d862a13764df58537fb"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e15cf3dbc577c1f0643423d4e12ea43c29140d50","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @contextlib.contextmanager"},{"line_number":91,"context_line":"    def transaction(self, check_error\u003dFalse, log_errors\u003dTrue,"},{"line_number":92,"context_line":"                    nested\u003dTrue, **kwargs):"},{"line_number":93,"context_line":"        \"\"\"Create a transaction context."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        :param check_error: Allow the transaction to raise an exception?"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_d4110054","line":92,"range":{"start_line":92,"start_character":20,"end_line":92,"end_character":26},"in_reply_to":"9fdfeff1_b2f8117b","updated":"2019-01-28 14:02:10.000000000","message":"Yeah, I was talking to Daniel about it...\n\nI\u0027m happy to abandon this patch but wanted to raise one more question. This separation of transaction() Vs. create_transaction() by one being nested and the other not doesn\u0027t seem really user-friendly.\n\nDo you think that a parameter as this patch proposes would be better in that aspect ? Cause if so, we can deprecate create_transaction() and keep only one method for it.","commit_id":"829da6ad9d7353fbffde5d862a13764df58537fb"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"f68200b0e8e569097060f54692a7c7eadb410d33","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @contextlib.contextmanager"},{"line_number":91,"context_line":"    def transaction(self, check_error\u003dFalse, log_errors\u003dTrue,"},{"line_number":92,"context_line":"                    nested\u003dTrue, **kwargs):"},{"line_number":93,"context_line":"        \"\"\"Create a transaction context."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        :param check_error: Allow the transaction to raise an exception?"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_d030d158","line":92,"range":{"start_line":92,"start_character":20,"end_line":92,"end_character":26},"in_reply_to":"9fdfeff1_d4110054","updated":"2019-02-01 17:54:37.000000000","message":"I lean toward the idea \"If you don\u0027t want nested transactions, just don\u0027t write nested transactions.\" But, given the lack of ovsdbapp documentation/examples I can also see how surprising the automatic nested behavior could be.","commit_id":"829da6ad9d7353fbffde5d862a13764df58537fb"}]}