)]}'
{"ovsdbapp/backend/ovs_idl/command.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"65990893e269deb74125fa321a6f29e7f2292a2b","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        records_found \u003d []"},{"line_number":239,"context_line":"        if idx and self.records:"},{"line_number":240,"context_line":"            if self.if_exists:"},{"line_number":241,"context_line":"                match \u003d lambda row: getattr(row, idx) in self.records"},{"line_number":242,"context_line":"            else:"},{"line_number":243,"context_line":"                # If we\u0027re using the approach of removing the unwanted"},{"line_number":244,"context_line":"                # elements, we\u0027ll use a helper list to remove elements as we"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_2371a4aa","side":"PARENT","line":241,"updated":"2020-03-27 15:03:29.000000000","message":"Is this change related to some linter check that forbids lambda? The lambdas here make sense to me.","commit_id":"c52e53b1bc3bb2d783ec1716094893fd2dd77eb0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"df45888ca548a50808cf80e8ce798745300df0ea","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        records_found \u003d []"},{"line_number":239,"context_line":"        if idx and self.records:"},{"line_number":240,"context_line":"            if self.if_exists:"},{"line_number":241,"context_line":"                match \u003d lambda row: getattr(row, idx) in self.records"},{"line_number":242,"context_line":"            else:"},{"line_number":243,"context_line":"                # If we\u0027re using the approach of removing the unwanted"},{"line_number":244,"context_line":"                # elements, we\u0027ll use a helper list to remove elements as we"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_e6950ae6","side":"PARENT","line":241,"in_reply_to":"df33271e_0688ee1c","updated":"2020-03-27 16:20:48.000000000","message":"me too, but people who wrote pep8 know much much more than I do about Python :)","commit_id":"c52e53b1bc3bb2d783ec1716094893fd2dd77eb0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4135aee6e7d80bf731d62da3cd9824db7b43c18f","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        records_found \u003d []"},{"line_number":239,"context_line":"        if idx and self.records:"},{"line_number":240,"context_line":"            if self.if_exists:"},{"line_number":241,"context_line":"                match \u003d lambda row: getattr(row, idx) in self.records"},{"line_number":242,"context_line":"            else:"},{"line_number":243,"context_line":"                # If we\u0027re using the approach of removing the unwanted"},{"line_number":244,"context_line":"                # elements, we\u0027ll use a helper list to remove elements as we"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_23a6c411","side":"PARENT","line":241,"in_reply_to":"df33271e_2371a4aa","updated":"2020-03-27 15:04:55.000000000","message":"Ok, my comment on previous PS answers the question :) PEP8 says:\n\nAlways use a def statement instead of an assignment statement that binds a lambda expression directly to an identifier.","commit_id":"c52e53b1bc3bb2d783ec1716094893fd2dd77eb0"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"f55bb30ed5391b722242f846005b49dea1ab2763","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        records_found \u003d []"},{"line_number":239,"context_line":"        if idx and self.records:"},{"line_number":240,"context_line":"            if self.if_exists:"},{"line_number":241,"context_line":"                match \u003d lambda row: getattr(row, idx) in self.records"},{"line_number":242,"context_line":"            else:"},{"line_number":243,"context_line":"                # If we\u0027re using the approach of removing the unwanted"},{"line_number":244,"context_line":"                # elements, we\u0027ll use a helper list to remove elements as we"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_0688ee1c","side":"PARENT","line":241,"in_reply_to":"df33271e_23a6c411","updated":"2020-03-27 16:10:11.000000000","message":"To be honest, I disagree with pep8 on this one.","commit_id":"c52e53b1bc3bb2d783ec1716094893fd2dd77eb0"}],"ovsdbapp/backend/ovs_idl/idlutils.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1b51bff9804210c4861aa2c583129e6e2c671c6b","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        for k, v in six.iteritems(obj):"},{"line_number":298,"context_line":"            if isinstance(v, api.Command):"},{"line_number":299,"context_line":"                obj[k] \u003d v.result"},{"line_number":300,"context_line":"    elif (isinstance(obj, collections.Sequence) and not"},{"line_number":301,"context_line":"          isinstance(obj, six.string_types)):"},{"line_number":302,"context_line":"        for i, v in enumerate(obj):"},{"line_number":303,"context_line":"            if isinstance(v, api.Command):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_e51b7ec7","line":300,"range":{"start_line":300,"start_character":52,"end_line":300,"end_character":55},"updated":"2019-03-21 11:54:35.000000000","message":"should this \"not\" go to the line below?","commit_id":"063c725ee26a1b97059faf5d66092e0a476c0792"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"213d45a92636de611b80bf972741e95ee9937ee0","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        for k, v in six.iteritems(obj):"},{"line_number":298,"context_line":"            if isinstance(v, api.Command):"},{"line_number":299,"context_line":"                obj[k] \u003d v.result"},{"line_number":300,"context_line":"    elif (isinstance(obj, collections.Sequence) and not"},{"line_number":301,"context_line":"          isinstance(obj, six.string_types)):"},{"line_number":302,"context_line":"        for i, v in enumerate(obj):"},{"line_number":303,"context_line":"            if isinstance(v, api.Command):"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_2387e5d9","line":300,"range":{"start_line":300,"start_character":52,"end_line":300,"end_character":55},"in_reply_to":"5fc1f717_e51b7ec7","updated":"2020-03-27 14:54:11.000000000","message":"Newer hacking rules actually want this at the EOL.","commit_id":"063c725ee26a1b97059faf5d66092e0a476c0792"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"30e6619759f81b26590335a7625197887d8e8784","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        for k, v in six.iteritems(obj):"},{"line_number":298,"context_line":"            if isinstance(v, api.Command):"},{"line_number":299,"context_line":"                obj[k] \u003d v.result"},{"line_number":300,"context_line":"    elif (isinstance(obj, collections.Sequence) and not"},{"line_number":301,"context_line":"          isinstance(obj, six.string_types)):"},{"line_number":302,"context_line":"        for i, v in enumerate(obj):"},{"line_number":303,"context_line":"            if isinstance(v, api.Command):"}],"source_content_type":"text/x-python","patch_set":9,"id":"df33271e_acd9d322","line":300,"range":{"start_line":300,"start_character":52,"end_line":300,"end_character":55},"updated":"2020-04-01 08:07:45.000000000","message":"I think the not should go to the next line","commit_id":"fc8768bd06ea889f6c4bb989b84ce0b691d04932"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fc42bcdf27a591f842ae6e50acd2bc16dbf48e32","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        for k, v in six.iteritems(obj):"},{"line_number":298,"context_line":"            if isinstance(v, api.Command):"},{"line_number":299,"context_line":"                obj[k] \u003d v.result"},{"line_number":300,"context_line":"    elif (isinstance(obj, collections.Sequence) and not"},{"line_number":301,"context_line":"          isinstance(obj, six.string_types)):"},{"line_number":302,"context_line":"        for i, v in enumerate(obj):"},{"line_number":303,"context_line":"            if isinstance(v, api.Command):"}],"source_content_type":"text/x-python","patch_set":9,"id":"df33271e_a801b608","line":300,"range":{"start_line":300,"start_character":52,"end_line":300,"end_character":55},"in_reply_to":"df33271e_acd9d322","updated":"2020-04-01 14:07:17.000000000","message":"Yes, according to pep8 rules it should, don\u0027t know why it didn\u0027t catch it.","commit_id":"fc8768bd06ea889f6c4bb989b84ce0b691d04932"}],"test-requirements.txt":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e62f9d66fcae2fa063641d50f24af83aa2e72086","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"hacking\u003e\u003d3.0.0,\u003c3.1.0 # Apache-2.0"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":8,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":8,"id":"df33271e_9757e158","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":21},"updated":"2020-03-30 23:18:31.000000000","message":"should change this to 4.0.0","commit_id":"7e23da675d2107b8c4e5033237c0dec6caa4d63c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c62988a40cc4d7b695f36a1d52dae580ba84a53b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"hacking\u003e\u003d3.0.0,\u003c3.1.0 # Apache-2.0"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":8,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":8,"id":"df33271e_cde71512","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":21},"in_reply_to":"df33271e_9757e158","updated":"2020-03-31 02:37:20.000000000","message":"3.1.0 is right one. In case we minor version break something as it is hard to analyse the backward compatible changes on hacking from all users.","commit_id":"7e23da675d2107b8c4e5033237c0dec6caa4d63c"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"dd344f5d2b239f6cf120bd85c47a63dfadb58df6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"hacking\u003e\u003d3.0.0,\u003c3.1.0 # Apache-2.0"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":8,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":8,"id":"df33271e_ea5d9215","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":21},"in_reply_to":"df33271e_cde71512","updated":"2020-03-31 13:21:59.000000000","message":"I agree","commit_id":"7e23da675d2107b8c4e5033237c0dec6caa4d63c"}],"tox.ini":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1b51bff9804210c4861aa2c583129e6e2c671c6b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"# E123, E125 skipped as they are invalid PEP-8."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"show-source \u003d True"},{"line_number":58,"context_line":"ignore \u003d E123,E125,E731"},{"line_number":59,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"[testenv:lower-constraints]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"5fc1f717_85139ab8","line":58,"range":{"start_line":58,"start_character":19,"end_line":58,"end_character":23},"updated":"2019-03-21 11:54:35.000000000","message":"Maybe we should write above what does E731 do?","commit_id":"063c725ee26a1b97059faf5d66092e0a476c0792"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e06110a0f58d941705e08c59f5d93be1e52f8e56","unresolved":false,"context_lines":[{"line_number":55,"context_line":"# E123, E125 skipped as they are invalid PEP-8."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"show-source \u003d True"},{"line_number":58,"context_line":"ignore \u003d E123,E125,E731"},{"line_number":59,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"[testenv:lower-constraints]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3fa7e38b_d5406d0a","line":58,"range":{"start_line":58,"start_character":19,"end_line":58,"end_character":23},"in_reply_to":"5fc1f717_6cfd8a6c","updated":"2019-09-19 08:53:22.000000000","message":"As this has been inactive for a while, I had a look at what E731 does and it actually is a valid PEP8 rule: https://www.python.org/dev/peps/pep-0008/#programming-recommendations\n\nWe shouldn\u0027t ignore it and rather fix the code violations.","commit_id":"063c725ee26a1b97059faf5d66092e0a476c0792"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"502964f2cfc75344ee54148524e99f63a3e0aa88","unresolved":false,"context_lines":[{"line_number":55,"context_line":"# E123, E125 skipped as they are invalid PEP-8."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"show-source \u003d True"},{"line_number":58,"context_line":"ignore \u003d E123,E125,E731"},{"line_number":59,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"[testenv:lower-constraints]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"5fc1f717_6cfd8a6c","line":58,"range":{"start_line":58,"start_character":19,"end_line":58,"end_character":23},"in_reply_to":"5fc1f717_85139ab8","updated":"2019-03-28 16:35:56.000000000","message":"++","commit_id":"063c725ee26a1b97059faf5d66092e0a476c0792"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"38fb5efbc02791e58353a70020212c7619935d9e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"# E123, E125 skipped as they are invalid PEP-8."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"show-source \u003d True"},{"line_number":69,"context_line":"ignore \u003d E123,E125"},{"line_number":70,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"[testenv:lower-constraints]"}],"source_content_type":"text/x-properties","patch_set":10,"id":"df33271e_8b865565","side":"PARENT","line":69,"updated":"2020-04-02 10:01:53.000000000","message":"Leave something in ignore, otherwise a default list is used.\n\nSo, change to \"ignore \u003d _\" with comment","commit_id":"85d632327b0daad854151289c190dee0dcc680d5"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"a8eed7a098a73284274d6da80c04cba7ec32e4d1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"# E123, E125 skipped as they are invalid PEP-8."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"show-source \u003d True"},{"line_number":69,"context_line":"ignore \u003d E123,E125"},{"line_number":70,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"[testenv:lower-constraints]"}],"source_content_type":"text/x-properties","patch_set":10,"id":"df33271e_ba10c101","side":"PARENT","line":69,"in_reply_to":"df33271e_3ab95114","updated":"2020-04-02 13:28:07.000000000","message":"Sorrry, missed it!","commit_id":"85d632327b0daad854151289c190dee0dcc680d5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"95a17f96f2dfff59891de286975e1da55600a9c2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"# E123, E125 skipped as they are invalid PEP-8."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"show-source \u003d True"},{"line_number":69,"context_line":"ignore \u003d E123,E125"},{"line_number":70,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"[testenv:lower-constraints]"}],"source_content_type":"text/x-properties","patch_set":10,"id":"df33271e_3ab95114","side":"PARENT","line":69,"in_reply_to":"df33271e_8b865565","updated":"2020-04-02 13:26:54.000000000","message":"I actually moved the ignore to L69 to keep the same order as other tox.ini files in neutron*","commit_id":"85d632327b0daad854151289c190dee0dcc680d5"}]}