)]}'
{"ovsdbapp/tests/unit/schema/open_vswitch/test_impl_idl.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9f908e755f0def4cac5334a2831b454439457142","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def test_init_session(self):"},{"line_number":45,"context_line":"        conn \u003d mock.MagicMock()"},{"line_number":46,"context_line":"        backend \u003d impl_idl.OvsdbIdl(conn, start\u003dFalse)"},{"line_number":47,"context_line":"        self.assertFalse(backend.connection)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_c5c8c275","line":47,"range":{"start_line":47,"start_character":13,"end_line":47,"end_character":25},"updated":"2019-03-21 11:45:17.000000000","message":"One more comment, this should be AssertIsNone :)","commit_id":"f58514fbe662181410eee3a7ea54ec123575c7ca"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fe3a6ebce92e725397ddb4adcd3c735e9bee9b6c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def test_init_session(self):"},{"line_number":45,"context_line":"        conn \u003d mock.MagicMock()"},{"line_number":46,"context_line":"        backend \u003d impl_idl.OvsdbIdl(conn, start\u003dFalse)"},{"line_number":47,"context_line":"        self.assertFalse(backend.connection)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_c5e5223a","line":47,"range":{"start_line":47,"start_character":33,"end_line":47,"end_character":43},"updated":"2019-03-21 11:40:59.000000000","message":"Shouldn\u0027t it be ovsdb_connection ?\n\nI\u0027m also a bit concerned that ovsdb_connection is a class attribute and thus it can be instantiated by L41. I think we should add a cleanup handler in setUp() of this test class that always sets ovsdb_connectino of OvsdbIdl class to None to be safe.","commit_id":"f58514fbe662181410eee3a7ea54ec123575c7ca"},{"author":{"_account_id":27079,"name":"Frank Wang","email":"wangpeihuixyz@126.com","username":"FrankWang"},"change_message_id":"8ff761b4498d8f540f6a87d6b850753aa3d101cb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def test_init_session(self):"},{"line_number":45,"context_line":"        conn \u003d mock.MagicMock()"},{"line_number":46,"context_line":"        backend \u003d impl_idl.OvsdbIdl(conn, start\u003dFalse)"},{"line_number":47,"context_line":"        self.assertFalse(backend.connection)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_7cd5d71a","line":47,"range":{"start_line":47,"start_character":33,"end_line":47,"end_character":43},"in_reply_to":"5fc1f717_2ecba34a","updated":"2019-03-22 00:42:35.000000000","message":"Actually, connection is ovsdb_connection, but ovsdb_connection seems more clear. Done.","commit_id":"f58514fbe662181410eee3a7ea54ec123575c7ca"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"f6a139e57d64ba16b7aeff7473dca10841d9056b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def test_init_session(self):"},{"line_number":45,"context_line":"        conn \u003d mock.MagicMock()"},{"line_number":46,"context_line":"        backend \u003d impl_idl.OvsdbIdl(conn, start\u003dFalse)"},{"line_number":47,"context_line":"        self.assertFalse(backend.connection)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_2ecba34a","line":47,"range":{"start_line":47,"start_character":33,"end_line":47,"end_character":43},"in_reply_to":"5fc1f717_c5e5223a","updated":"2019-03-21 13:52:03.000000000","message":"Yeah, the ovsdb_connection thing is something networking-ovn worked around here: \nhttps://github.com/openstack/networking-ovn/blob/98ae4b80fd8e42bda389ff0b7592cbfd2a7527be/networking_ovn/ovsdb/impl_idl_ovn.py#L59","commit_id":"f58514fbe662181410eee3a7ea54ec123575c7ca"}]}