)]}'
{"ovsdbapp/schema/ovn_northbound/commands.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3b121342d57d95dc414898bc33457ac5482a3315","unresolved":false,"context_lines":[{"line_number":953,"context_line":"                except ValueError:"},{"line_number":954,"context_line":"                    # logical_ip can be IPNetwork"},{"line_number":955,"context_line":"                    if nat_type \u003d\u003d const.NAT_SNAT:"},{"line_number":956,"context_line":"                        match_ip \u003d str(netaddr.IPNetwork(match_ip))"},{"line_number":957,"context_line":"                    else:"},{"line_number":958,"context_line":"                        raise"},{"line_number":959,"context_line":"                self.col \u003d (\u0027logical_ip\u0027 if nat_type \u003d\u003d const.NAT_SNAT"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_3b778f3d","line":956,"updated":"2019-04-23 07:22:48.000000000","message":"Can you please add functional test coverage, similar to what is done in this area of code https://opendev.org/openstack/ovsdbapp/src/branch/master/ovsdbapp/tests/functional/schema/ovn_northbound/test_impl_idl.py#L810 ?","commit_id":"6a0f1d87030c209e90795b6e5202e41e3f43ca48"}],"ovsdbapp/tests/functional/schema/ovn_northbound/test_impl_idl.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"85344d6225f3be69bb2f32777f0142b49d4a4b3e","unresolved":false,"context_lines":[{"line_number":853,"context_line":"                            nat_type\u003dconst.NAT_SNAT,"},{"line_number":854,"context_line":"                            match_ip\u003d\u002710.17.4.0/24\u0027)"},{"line_number":855,"context_line":"        self.assertEqual([], lr.nat)"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"    def test_lr_nat_list(self):"},{"line_number":858,"context_line":"        lr \u003d self._three_nats()"},{"line_number":859,"context_line":"        nats \u003d self.api.lr_nat_list(lr.uuid).execute(check_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_81738cb1","line":856,"updated":"2019-04-24 09:10:25.000000000","message":"Maybe another negative case where we don\u0027t specify NAT_SNAT but pass cidr to match_ip should be added. We expect ValueError in that case.","commit_id":"93bede6a634de5e9040953ba0b9053ad3fdfe9d2"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5c0d530a3e859085e470e23f2f8a9e435ceeb51f","unresolved":false,"context_lines":[{"line_number":860,"context_line":"    def test_lr_nat_del_ip_network(self):"},{"line_number":861,"context_line":"        # Assert that ValueError is raised when IP Network is passed in"},{"line_number":862,"context_line":"        # match_ip for type const.NAT_DNAT and const.NAT_BOTH"},{"line_number":863,"context_line":"        self.assertRaises(ValueError, self._lr_nat_del,"},{"line_number":864,"context_line":"                          nat_type\u003dconst.NAT_DNAT, match_ip\u003d\u0027192.0.2.1/32\u0027)"},{"line_number":865,"context_line":"        self.assertRaises(ValueError, self._lr_nat_del,"},{"line_number":866,"context_line":"                          nat_type\u003dconst.NAT_BOTH, match_ip\u003d\u0027192.0.2.0/24\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_19a87475","line":863,"updated":"2019-04-24 11:38:21.000000000","message":"Shall we split it into three different methods then? If we get a failure on L863 then we won\u0027t get L865 and L868 tested so it will be unknown, if that works. The effort to split it into multiple methods is minimal.","commit_id":"ff141b16e609e7b6355e8f32a4c39b984cba3a80"}]}