)]}'
{"ovsdbapp/schema/ovn_northbound/api.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"e6980a646a8edda9351f40ba92c2a78e738d7784","unresolved":false,"context_lines":[{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"        :param name: The name or uuid of the ha chassis group"},{"line_number":1004,"context_line":"        :type name:  string or uuid.UUID"},{"line_number":1005,"context_line":"        :returns:     :class:`Command` with RowView result"},{"line_number":1006,"context_line":"        \"\"\""},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_8b4f7890","line":1005,"range":{"start_line":1005,"start_character":21,"end_line":1005,"end_character":22},"updated":"2019-08-22 07:01:26.000000000","message":"nit: remove a whitespace","commit_id":"045ce3ff970a66415bb728268c6ab85b634927f9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3794c1f32ce36740e6ecd4a282ff9c46bece41ce","unresolved":false,"context_lines":[{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"        :param name: The name or uuid of the ha chassis group"},{"line_number":1004,"context_line":"        :type name:  string or uuid.UUID"},{"line_number":1005,"context_line":"        :returns:     :class:`Command` with RowView result"},{"line_number":1006,"context_line":"        \"\"\""},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_813437fc","line":1005,"range":{"start_line":1005,"start_character":21,"end_line":1005,"end_character":22},"in_reply_to":"7faddb67_8b4f7890","updated":"2019-08-22 08:28:35.000000000","message":"++","commit_id":"045ce3ff970a66415bb728268c6ab85b634927f9"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"e6980a646a8edda9351f40ba92c2a78e738d7784","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"                                     **columns):"},{"line_number":1011,"context_line":"        \"\"\"Add a HA Chassis to a HA Chassis Group"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"        :param hcg_id: The name or uuid of the ha chassis group"},{"line_number":1014,"context_line":"        :type hcg_id:  string or uuid.UUID"},{"line_number":1015,"context_line":"        :param chassis: The name of the ha chassis"},{"line_number":1016,"context_line":"        :type chassis:  string"},{"line_number":1017,"context_line":"        :param priority: The priority of the ha chassis"},{"line_number":1018,"context_line":"        :type priority:  int"},{"line_number":1019,"context_line":"        :param columns:     Additional columns to directly set on the ha"},{"line_number":1020,"context_line":"                            chassis (e.g external_ids)"},{"line_number":1021,"context_line":"        :type columns:      dictionary"},{"line_number":1022,"context_line":"        :returns:           :class:`Command` with RowView result"},{"line_number":1023,"context_line":"        \"\"\""},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_2b420469","line":1022,"range":{"start_line":1013,"start_character":0,"end_line":1022,"end_character":64},"updated":"2019-08-22 07:01:26.000000000","message":"nit: we want a uniform visual indentation if possible. Not all of the docstring in this file have it though :)","commit_id":"045ce3ff970a66415bb728268c6ab85b634927f9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3794c1f32ce36740e6ecd4a282ff9c46bece41ce","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"                                     **columns):"},{"line_number":1011,"context_line":"        \"\"\"Add a HA Chassis to a HA Chassis Group"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"        :param hcg_id: The name or uuid of the ha chassis group"},{"line_number":1014,"context_line":"        :type hcg_id:  string or uuid.UUID"},{"line_number":1015,"context_line":"        :param chassis: The name of the ha chassis"},{"line_number":1016,"context_line":"        :type chassis:  string"},{"line_number":1017,"context_line":"        :param priority: The priority of the ha chassis"},{"line_number":1018,"context_line":"        :type priority:  int"},{"line_number":1019,"context_line":"        :param columns:     Additional columns to directly set on the ha"},{"line_number":1020,"context_line":"                            chassis (e.g external_ids)"},{"line_number":1021,"context_line":"        :type columns:      dictionary"},{"line_number":1022,"context_line":"        :returns:           :class:`Command` with RowView result"},{"line_number":1023,"context_line":"        \"\"\""},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_e1240bc8","line":1022,"range":{"start_line":1013,"start_character":0,"end_line":1022,"end_character":64},"in_reply_to":"7faddb67_2b420469","updated":"2019-08-22 08:28:35.000000000","message":"++","commit_id":"045ce3ff970a66415bb728268c6ab85b634927f9"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"1de2da89e22a5c42482f9e17091f8565a5926e88","unresolved":false,"context_lines":[{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    @abc.abstractmethod"},{"line_number":1026,"context_line":"    def ha_chassis_group_del_chassis(self, hcg_id, chassis, if_exists\u003dFalse):"},{"line_number":1027,"context_line":"        \"\"\"Deletes a HA Chassis from a HA Chassis Group"},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"        :param hcg_id:     The name or uuid of the ha chassis group"},{"line_number":1030,"context_line":"        :type hcg_id:      string or uuid.UUID"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_9fabe486","line":1027,"range":{"start_line":1027,"start_character":11,"end_line":1027,"end_character":18},"updated":"2019-08-27 14:26:16.000000000","message":"nitpicking :) . All the docstrings (except two :p) say \"Add/Create/...\" this should be \"Delete\" for consistency but definitely a nit nit.","commit_id":"c960e4c00bfa12a4d018ea4720d21329de663c14"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"15b1f88ca6220a300ce82c3e91606077662eb7af","unresolved":false,"context_lines":[{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    @abc.abstractmethod"},{"line_number":1026,"context_line":"    def ha_chassis_group_del_chassis(self, hcg_id, chassis, if_exists\u003dFalse):"},{"line_number":1027,"context_line":"        \"\"\"Deletes a HA Chassis from a HA Chassis Group"},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"        :param hcg_id:     The name or uuid of the ha chassis group"},{"line_number":1030,"context_line":"        :type hcg_id:      string or uuid.UUID"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_3f25100b","line":1027,"range":{"start_line":1027,"start_character":11,"end_line":1027,"end_character":18},"in_reply_to":"7faddb67_9fabe486","updated":"2019-08-27 15:04:42.000000000","message":"It\u0027s actually a pep256 that docstring should be in imperative form: https://www.python.org/dev/peps/pep-0256/","commit_id":"c960e4c00bfa12a4d018ea4720d21329de663c14"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2827e092c8cff67ed8ab42102815672e8a049918","unresolved":false,"context_lines":[{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    @abc.abstractmethod"},{"line_number":1026,"context_line":"    def ha_chassis_group_del_chassis(self, hcg_id, chassis, if_exists\u003dFalse):"},{"line_number":1027,"context_line":"        \"\"\"Deletes a HA Chassis from a HA Chassis Group"},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"        :param hcg_id:     The name or uuid of the ha chassis group"},{"line_number":1030,"context_line":"        :type hcg_id:      string or uuid.UUID"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_9f0e848a","line":1027,"range":{"start_line":1027,"start_character":11,"end_line":1027,"end_character":18},"in_reply_to":"7faddb67_9fabe486","updated":"2019-08-27 14:31:51.000000000","message":"ops yeah, will fix if I happen to submit a new patch set","commit_id":"c960e4c00bfa12a4d018ea4720d21329de663c14"}],"ovsdbapp/schema/ovn_northbound/commands.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"0694665a153d6370722ac776760f3611e94ea385","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"            except idlutils.RowNotFound:"},{"line_number":1365,"context_line":"                pass"},{"line_number":1366,"context_line":""},{"line_number":1367,"context_line":"        hcg \u003d txn.insert(self.api._tables[self.table_name])"},{"line_number":1368,"context_line":"        hcg.name \u003d self.name"},{"line_number":1369,"context_line":"        self.set_columns(hcg, **self.columns)"},{"line_number":1370,"context_line":"        self.result \u003d hcg.uuid"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_ad6ca5d0","line":1367,"updated":"2019-08-23 17:41:59.000000000","message":"If not self.may_exist, this doesn\u0027t look like it will fail until after the transaction is sent. I like that it removes a lookup if not may_exist, but it seems like the original code for most things in ovs-vsctl, nbctl, etc. locally did the check on may_exist back in the day and failed early.\n\nThough I see a mix of the two styles already and I don\u0027t even see may_exist as an option for this in the ovn-nbctl code, so at this point consistency is too late anyway I guess! Carry on. :D","commit_id":"a9a1dfdfd7833d770a95fb0002657fabb540c777"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b902c5d96a4272c65d344e7ac93bbcaa4f34fbb6","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"            except idlutils.RowNotFound:"},{"line_number":1365,"context_line":"                pass"},{"line_number":1366,"context_line":""},{"line_number":1367,"context_line":"        hcg \u003d txn.insert(self.api._tables[self.table_name])"},{"line_number":1368,"context_line":"        hcg.name \u003d self.name"},{"line_number":1369,"context_line":"        self.set_columns(hcg, **self.columns)"},{"line_number":1370,"context_line":"        self.result \u003d hcg.uuid"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_a3e6d049","line":1367,"in_reply_to":"7faddb67_ad6ca5d0","updated":"2019-08-27 09:07:10.000000000","message":"hah thanks, lemme know if you prefer me to change it.","commit_id":"a9a1dfdfd7833d770a95fb0002657fabb540c777"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"09b05497f156dd3d17448f82d1298482a076b64b","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"        hc_group \u003d self.api.lookup(\u0027HA_Chassis_Group\u0027, self.hcg_id)"},{"line_number":1408,"context_line":"        hc \u003d None"},{"line_number":1409,"context_line":"        found \u003d False"},{"line_number":1410,"context_line":"        for ch in hc_group.ha_chassis:"},{"line_number":1411,"context_line":"            if ch.chassis_name !\u003d self.chassis:"},{"line_number":1412,"context_line":"                continue"},{"line_number":1413,"context_line":"            hc \u003d ch"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_c4e3ddd7","line":1410,"range":{"start_line":1410,"start_character":12,"end_line":1410,"end_character":14},"updated":"2019-08-26 20:31:21.000000000","message":"Can\u0027t this just be \u0027hc\u0027 ?  Because if we don\u0027t find a match we\u0027ll be in the else anyways.  Same below.\n\nOr my brain is still on PTO :)","commit_id":"a9a1dfdfd7833d770a95fb0002657fabb540c777"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b902c5d96a4272c65d344e7ac93bbcaa4f34fbb6","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"        hc_group \u003d self.api.lookup(\u0027HA_Chassis_Group\u0027, self.hcg_id)"},{"line_number":1408,"context_line":"        hc \u003d None"},{"line_number":1409,"context_line":"        found \u003d False"},{"line_number":1410,"context_line":"        for ch in hc_group.ha_chassis:"},{"line_number":1411,"context_line":"            if ch.chassis_name !\u003d self.chassis:"},{"line_number":1412,"context_line":"                continue"},{"line_number":1413,"context_line":"            hc \u003d ch"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_8341540d","line":1410,"range":{"start_line":1410,"start_character":12,"end_line":1410,"end_character":14},"in_reply_to":"7faddb67_c4e3ddd7","updated":"2019-08-27 09:07:10.000000000","message":"Good point, following the logic here yes, I think it can reuse the same variable","commit_id":"a9a1dfdfd7833d770a95fb0002657fabb540c777"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"0694665a153d6370722ac776760f3611e94ea385","unresolved":false,"context_lines":[{"line_number":1447,"context_line":"                continue"},{"line_number":1448,"context_line":"            hc \u003d ch"},{"line_number":1449,"context_line":"            break"},{"line_number":1450,"context_line":"        else:"},{"line_number":1451,"context_line":"            if self.if_exists:"},{"line_number":1452,"context_line":"                return"},{"line_number":1453,"context_line":"            raise RuntimeError("}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_0da379b3","line":1450,"updated":"2019-08-23 17:41:59.000000000","message":"yay for for: else: :D","commit_id":"a9a1dfdfd7833d770a95fb0002657fabb540c777"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"29fb3adfb7446ffb0b5be87b11363063bb70aa2a","unresolved":false,"context_lines":[{"line_number":1449,"context_line":"            if self.if_exists:"},{"line_number":1450,"context_line":"                return"},{"line_number":1451,"context_line":"            raise RuntimeError("},{"line_number":1452,"context_line":"                \u0027HA Chassis %s does not exist\u0027 % self.chassis)"},{"line_number":1453,"context_line":""},{"line_number":1454,"context_line":"        hc_group.delvalue(\u0027ha_chassis\u0027, hc)"},{"line_number":1455,"context_line":"        hc.delete()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_f5ff9fa8","line":1452,"range":{"start_line":1452,"start_character":49,"end_line":1452,"end_character":61},"updated":"2019-08-27 10:08:53.000000000","message":"my bad, this should be the HA Chassis ID","commit_id":"2ad4b76cca91af89b6b9c295ebde463f5820e9e9"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"d42525dd6a924226979bc0767039586b29f2245b","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"    def run_idl(self, txn):"},{"line_number":1407,"context_line":"        hc_group \u003d self.api.lookup(\u0027HA_Chassis_Group\u0027, self.hcg_id)"},{"line_number":1408,"context_line":"        found \u003d False"},{"line_number":1409,"context_line":"        hc \u003d None"},{"line_number":1410,"context_line":"        for hc in hc_group.ha_chassis:"},{"line_number":1411,"context_line":"            if hc.chassis_name !\u003d self.chassis:"},{"line_number":1412,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_09f10296","line":1409,"updated":"2019-08-27 13:32:30.000000000","message":"With the for: else:, I think your hc is guaranteed to be assigned, so the hc \u003d None here and below in the GroupDelChassisCommand is unneeded. (and we try to access hc.\u003cstuff\u003e after each loop anyway which None would just change which exception we got)","commit_id":"c960e4c00bfa12a4d018ea4720d21329de663c14"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2827e092c8cff67ed8ab42102815672e8a049918","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"    def run_idl(self, txn):"},{"line_number":1407,"context_line":"        hc_group \u003d self.api.lookup(\u0027HA_Chassis_Group\u0027, self.hcg_id)"},{"line_number":1408,"context_line":"        found \u003d False"},{"line_number":1409,"context_line":"        hc \u003d None"},{"line_number":1410,"context_line":"        for hc in hc_group.ha_chassis:"},{"line_number":1411,"context_line":"            if hc.chassis_name !\u003d self.chassis:"},{"line_number":1412,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_7f8068c0","line":1409,"in_reply_to":"7faddb67_09f10296","updated":"2019-08-27 14:31:51.000000000","message":"Yeah that\u0027s how I did it first, but pep8 was complaining about it:\n\n************* Module ovsdbapp.schema.ovn_northbound.commands                                             \nW:1452,40: Using possibly undefined loop variable \u0027hc\u0027 (undefined-loop-variable)\nW:1453, 8: Using possibly undefined loop variable \u0027hc\u0027 (undefined-loop-variable)","commit_id":"c960e4c00bfa12a4d018ea4720d21329de663c14"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"8ff861b193c5796f5c268acaf12ca52be387cd4b","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"    def run_idl(self, txn):"},{"line_number":1407,"context_line":"        hc_group \u003d self.api.lookup(\u0027HA_Chassis_Group\u0027, self.hcg_id)"},{"line_number":1408,"context_line":"        found \u003d False"},{"line_number":1409,"context_line":"        hc \u003d None"},{"line_number":1410,"context_line":"        for hc in hc_group.ha_chassis:"},{"line_number":1411,"context_line":"            if hc.chassis_name !\u003d self.chassis:"},{"line_number":1412,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_707652a6","line":1409,"in_reply_to":"7faddb67_7f8068c0","updated":"2019-08-27 18:24:27.000000000","message":"Perhaps I will disable that rule since it is making people jump through imaginary hoops.","commit_id":"c960e4c00bfa12a4d018ea4720d21329de663c14"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a70ff3b05cb0df7f326d85ab8da0abbe199b0388","unresolved":false,"context_lines":[{"line_number":1444,"context_line":"        for hc in hc_group.ha_chassis:"},{"line_number":1445,"context_line":"            if hc.chassis_name !\u003d self.chassis:"},{"line_number":1446,"context_line":"                continue"},{"line_number":1447,"context_line":"            break"},{"line_number":1448,"context_line":"        else:"},{"line_number":1449,"context_line":"            if self.if_exists:"},{"line_number":1450,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_bfe6e049","line":1447,"updated":"2019-08-27 14:23:24.000000000","message":"And since we\u0027re still nitpicking... :) this might be cleaner like this:\n\nif hc.chassis_name \u003d\u003d self.chassis:\n    break\n\nSince the continue is implied.  Same above.\n\nBut you don\u0027t need to re-spin for this.","commit_id":"c960e4c00bfa12a4d018ea4720d21329de663c14"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2827e092c8cff67ed8ab42102815672e8a049918","unresolved":false,"context_lines":[{"line_number":1444,"context_line":"        for hc in hc_group.ha_chassis:"},{"line_number":1445,"context_line":"            if hc.chassis_name !\u003d self.chassis:"},{"line_number":1446,"context_line":"                continue"},{"line_number":1447,"context_line":"            break"},{"line_number":1448,"context_line":"        else:"},{"line_number":1449,"context_line":"            if self.if_exists:"},{"line_number":1450,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_3f6af01a","line":1447,"in_reply_to":"7faddb67_bfe6e049","updated":"2019-08-27 14:31:51.000000000","message":"Hah thanks! If I happen to submit a new patch-set I will fix this too","commit_id":"c960e4c00bfa12a4d018ea4720d21329de663c14"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0f1c1beef6a5bb5d4da19e28bbf3f037213e9140","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"        found \u003d False"},{"line_number":1409,"context_line":"        hc \u003d None"},{"line_number":1410,"context_line":"        for hc in hc_group.ha_chassis:"},{"line_number":1411,"context_line":"            if hc.chassis_name !\u003d self.chassis:"},{"line_number":1412,"context_line":"                continue"},{"line_number":1413,"context_line":"            found \u003d True"},{"line_number":1414,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_1f7934c4","line":1411,"updated":"2019-08-27 14:38:54.000000000","message":"Oh man, I should have added the same comment here :-o","commit_id":"74b52bb3491a9c4f6ec40e15d74652fc415269e0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ea67637962c7fb277feb22e8633f215254c55bd1","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"        found \u003d False"},{"line_number":1409,"context_line":"        hc \u003d None"},{"line_number":1410,"context_line":"        for hc in hc_group.ha_chassis:"},{"line_number":1411,"context_line":"            if hc.chassis_name !\u003d self.chassis:"},{"line_number":1412,"context_line":"                continue"},{"line_number":1413,"context_line":"            found \u003d True"},{"line_number":1414,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_3f0bd02b","line":1411,"in_reply_to":"7faddb67_1f7934c4","updated":"2019-08-27 14:44:17.000000000","message":"Ops my bad... If I need to respin another patch-set I will fix this too :D","commit_id":"74b52bb3491a9c4f6ec40e15d74652fc415269e0"}],"ovsdbapp/tests/functional/schema/ovn_northbound/test_impl_idl.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"0694665a153d6370722ac776760f3611e94ea385","unresolved":false,"context_lines":[{"line_number":1450,"context_line":"                              if_exists\u003dTrue).execute(check_error\u003dTrue)"},{"line_number":1451,"context_line":""},{"line_number":1452,"context_line":""},{"line_number":1453,"context_line":"class TestHAChassisGroup(OvnNorthboundTest):"},{"line_number":1454,"context_line":""},{"line_number":1455,"context_line":"    def setUp(self):"},{"line_number":1456,"context_line":"        super(TestHAChassisGroup, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_2d9bd573","line":1453,"updated":"2019-08-23 17:41:59.000000000","message":"could use some tests for if_exists/may_exist behavior, but im\u0027 ok with adding later.","commit_id":"a9a1dfdfd7833d770a95fb0002657fabb540c777"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b902c5d96a4272c65d344e7ac93bbcaa4f34fbb6","unresolved":false,"context_lines":[{"line_number":1450,"context_line":"                              if_exists\u003dTrue).execute(check_error\u003dTrue)"},{"line_number":1451,"context_line":""},{"line_number":1452,"context_line":""},{"line_number":1453,"context_line":"class TestHAChassisGroup(OvnNorthboundTest):"},{"line_number":1454,"context_line":""},{"line_number":1455,"context_line":"    def setUp(self):"},{"line_number":1456,"context_line":"        super(TestHAChassisGroup, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_2348a02c","line":1453,"in_reply_to":"7faddb67_2d9bd573","updated":"2019-08-27 09:07:10.000000000","message":"++ good point, will do!","commit_id":"a9a1dfdfd7833d770a95fb0002657fabb540c777"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"1de2da89e22a5c42482f9e17091f8565a5926e88","unresolved":false,"context_lines":[{"line_number":1469,"context_line":"        cmd \u003d self.api.ha_chassis_group_get(self.hcg_name)"},{"line_number":1470,"context_line":"        self.assertRaises(idlutils.RowNotFound, cmd.execute, check_error\u003dTrue)"},{"line_number":1471,"context_line":""},{"line_number":1472,"context_line":"    def test_ha_chassis_group_chassis(self):"},{"line_number":1473,"context_line":"        self.api.ha_chassis_group_add(self.hcg_name).execute(check_error\u003dTrue)"},{"line_number":1474,"context_line":"        priority \u003d 20"},{"line_number":1475,"context_line":"        self.api.ha_chassis_group_add_chassis("}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_3fc99059","line":1472,"range":{"start_line":1472,"start_character":8,"end_line":1472,"end_character":37},"updated":"2019-08-27 14:26:16.000000000","message":"From the name it\u0027s not really clear to me what this is testing.\nPerhaps test_ha_chassis_group_add_delete_chassis would be clearer","commit_id":"c960e4c00bfa12a4d018ea4720d21329de663c14"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"42c1174a431566473ceb115f82c6124d8e2c69c7","unresolved":false,"context_lines":[{"line_number":1469,"context_line":"        cmd \u003d self.api.ha_chassis_group_get(self.hcg_name)"},{"line_number":1470,"context_line":"        self.assertRaises(idlutils.RowNotFound, cmd.execute, check_error\u003dTrue)"},{"line_number":1471,"context_line":""},{"line_number":1472,"context_line":"    def test_ha_chassis_group_chassis(self):"},{"line_number":1473,"context_line":"        self.api.ha_chassis_group_add(self.hcg_name).execute(check_error\u003dTrue)"},{"line_number":1474,"context_line":"        priority \u003d 20"},{"line_number":1475,"context_line":"        self.api.ha_chassis_group_add_chassis("}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_df62bc3d","line":1472,"range":{"start_line":1472,"start_character":8,"end_line":1472,"end_character":37},"in_reply_to":"7faddb67_3fc99059","updated":"2019-08-27 14:32:07.000000000","message":"++","commit_id":"c960e4c00bfa12a4d018ea4720d21329de663c14"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"15b1f88ca6220a300ce82c3e91606077662eb7af","unresolved":false,"context_lines":[{"line_number":1500,"context_line":"        hcg \u003d self.api.ha_chassis_group_get(self.hcg_name).execute("},{"line_number":1501,"context_line":"            check_error\u003dTrue)"},{"line_number":1502,"context_line":"        self.assertEqual([], hcg.ha_chassis)"},{"line_number":1503,"context_line":""},{"line_number":1504,"context_line":"    def test_ha_chassis_group_if_exists(self):"},{"line_number":1505,"context_line":"        self.api.ha_chassis_group_add(self.hcg_name).execute(check_error\u003dTrue)"},{"line_number":1506,"context_line":"        self.api.ha_chassis_group_add_chassis("}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_9a99b26e","line":1503,"updated":"2019-08-27 15:04:42.000000000","message":"I think we\u0027re missing a case here where we call ha_chassis_group_add_chassis() with a chassis that already exists in the group.","commit_id":"c960e4c00bfa12a4d018ea4720d21329de663c14"}]}