)]}'
{"ovsdbapp/venv.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f8cbab193b04000730c5267ca36a516659f2f6b8","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":134,"context_line":"        self.add_chassis \u003d kwargs.pop(\u0027add_chassis\u0027, False)"},{"line_number":135,"context_line":"        self.ovndir \u003d kwargs.pop(\u0027ovndir\u0027) or \u0027/usr/local/share/ovn\u0027"},{"line_number":136,"context_line":"        self.PATH_VAR_TEMPLATE +\u003d ("},{"line_number":137,"context_line":"            \":{0}/controller:{0}/northd:{0}/utilities\".format("},{"line_number":138,"context_line":"                self.ovndir))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_870e3de3","line":135,"range":{"start_line":135,"start_character":22,"end_line":135,"end_character":68},"updated":"2019-10-05 15:04:03.000000000","message":"Probably\n\n kwargs.pop(\u0027ovndir\u0027, DEFAULT_OVN_DIR)\n\nwould be better :)","commit_id":"0e3d9743c06ce1112a96bf54d08090365fedf9b9"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0691ad140edf3efcc7801d5df9d2e0f1d4afb5ef","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":134,"context_line":"        self.add_chassis \u003d kwargs.pop(\u0027add_chassis\u0027, False)"},{"line_number":135,"context_line":"        self.ovndir \u003d kwargs.pop(\u0027ovndir\u0027) or \u0027/usr/local/share/ovn\u0027"},{"line_number":136,"context_line":"        self.PATH_VAR_TEMPLATE +\u003d ("},{"line_number":137,"context_line":"            \":{0}/controller:{0}/northd:{0}/utilities\".format("},{"line_number":138,"context_line":"                self.ovndir))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_672d3a45","line":135,"range":{"start_line":135,"start_character":22,"end_line":135,"end_character":68},"in_reply_to":"3fa7e38b_62368fea","updated":"2019-10-07 09:47:41.000000000","message":"oh, ok :) thanks","commit_id":"0e3d9743c06ce1112a96bf54d08090365fedf9b9"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a238d91218545a0d49b3b25c9f919ef4e70a84ae","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":134,"context_line":"        self.add_chassis \u003d kwargs.pop(\u0027add_chassis\u0027, False)"},{"line_number":135,"context_line":"        self.ovndir \u003d kwargs.pop(\u0027ovndir\u0027) or \u0027/usr/local/share/ovn\u0027"},{"line_number":136,"context_line":"        self.PATH_VAR_TEMPLATE +\u003d ("},{"line_number":137,"context_line":"            \":{0}/controller:{0}/northd:{0}/utilities\".format("},{"line_number":138,"context_line":"                self.ovndir))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_62368fea","line":135,"range":{"start_line":135,"start_character":22,"end_line":135,"end_character":68},"in_reply_to":"3fa7e38b_870e3de3","updated":"2019-10-05 17:33:42.000000000","message":"That doesn\u0027t work because it is passed, but is passed as None. (I know this because that was my first try too.) :D","commit_id":"0e3d9743c06ce1112a96bf54d08090365fedf9b9"}]}