)]}'
{"ovsdbapp/constants.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"3d7bb05e755e9a8d0e4605fcde724e4e2355881f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"PROTO_TCP \u003d \u0027tcp\u0027"},{"line_number":31,"context_line":"PROTO_UDP \u003d \u0027udp\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"OVS_INSTALL_SHARE_PATH \u003d \u0027/usr/local/share/openvswitch\u0027"},{"line_number":34,"context_line":"OVN_INSTALL_SHARE_PATH \u003d \u0027/usr/local/share/ovn\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_536c2035","line":33,"updated":"2019-10-29 23:12:37.000000000","message":"Since ovsdbapp can be used on Windows, I think we should do os.path.join() here (and should have previously on the ovn dir).","commit_id":"b0f55e4d9faaa7ac747ccf4021eca60eef032a91"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"b669dcef785dcc5c36329542bad27b3ddc1f40f9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"PROTO_TCP \u003d \u0027tcp\u0027"},{"line_number":31,"context_line":"PROTO_UDP \u003d \u0027udp\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"OVS_INSTALL_SHARE_PATH \u003d \u0027/usr/local/share/openvswitch\u0027"},{"line_number":34,"context_line":"OVN_INSTALL_SHARE_PATH \u003d \u0027/usr/local/share/ovn\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_82eb16a2","line":33,"in_reply_to":"3fa7e38b_2a7d621b","updated":"2019-10-30 19:10:36.000000000","message":"If you wanted to be a purist about it, since it isn\u0027t used anywhere else you could just put define them at the top of venv.py. I\u0027m happy either way.","commit_id":"b0f55e4d9faaa7ac747ccf4021eca60eef032a91"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"d5c86fbbf1a821fe26ae995fd4c3beadbaf2d930","unresolved":false,"context_lines":[{"line_number":30,"context_line":"PROTO_TCP \u003d \u0027tcp\u0027"},{"line_number":31,"context_line":"PROTO_UDP \u003d \u0027udp\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"OVS_INSTALL_SHARE_PATH \u003d \u0027/usr/local/share/openvswitch\u0027"},{"line_number":34,"context_line":"OVN_INSTALL_SHARE_PATH \u003d \u0027/usr/local/share/ovn\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_2a7d621b","line":33,"in_reply_to":"3fa7e38b_536c2035","updated":"2019-10-30 12:52:06.000000000","message":"ack. but that would mean we would need to \"import os\" in this file; is that an okay thing to do?","commit_id":"b0f55e4d9faaa7ac747ccf4021eca60eef032a91"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"05aa1f85e4c942c2903c8583637bed24e7cfc5ec","unresolved":false,"context_lines":[{"line_number":33,"context_line":"PROTO_TCP \u003d \u0027tcp\u0027"},{"line_number":34,"context_line":"PROTO_UDP \u003d \u0027udp\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"OVS_INSTALL_SHARE_PATH \u003d os.path.join(\u0027/usr\u0027, \u0027local\u0027, \u0027share\u0027, \u0027openvswitch\u0027)"},{"line_number":37,"context_line":"OVN_INSTALL_SHARE_PATH \u003d os.path.join(\u0027/usr\u0027, \u0027local\u0027, \u0027share\u0027, \u0027ovn\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_837d55b3","line":36,"range":{"start_line":36,"start_character":38,"end_line":36,"end_character":40},"updated":"2019-10-31 08:18:30.000000000","message":"I saw on earlier comments the os path join is because of Windows - but would this work on Windows? Shall we do something like this instead:\n\n os.path.join(os.path.sep, \u0027usr\u0027, ...)","commit_id":"d3f9bf490eddfd83c436cb42e9814127228473cd"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"39a68da97ce027a79796f9c27988614138f5a461","unresolved":false,"context_lines":[{"line_number":33,"context_line":"PROTO_TCP \u003d \u0027tcp\u0027"},{"line_number":34,"context_line":"PROTO_UDP \u003d \u0027udp\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"OVS_INSTALL_SHARE_PATH \u003d os.path.join(\u0027/usr\u0027, \u0027local\u0027, \u0027share\u0027, \u0027openvswitch\u0027)"},{"line_number":37,"context_line":"OVN_INSTALL_SHARE_PATH \u003d os.path.join(\u0027/usr\u0027, \u0027local\u0027, \u0027share\u0027, \u0027ovn\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_39ea900e","line":36,"range":{"start_line":36,"start_character":38,"end_line":36,"end_character":40},"in_reply_to":"3fa7e38b_837d55b3","updated":"2019-10-31 10:07:37.000000000","message":"oh, I have no experience with windows, but what you are suggesting seems reasonable. I used what was being used\nbefore, hoping that was the right way of doing it.\nLet me patch that up.","commit_id":"d3f9bf490eddfd83c436cb42e9814127228473cd"}]}