)]}'
{"ovsdbapp/venv.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f0523bde7ae0e193d8ce7c0f1f9dfa216295dd88","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        install_share_path \u003d self._get_install_share_path()"},{"line_number":137,"context_line":"        self.add_chassis \u003d kwargs.pop(\u0027add_chassis\u0027, False)"},{"line_number":138,"context_line":"        self.ovndir \u003d kwargs.pop(\u0027ovndir\u0027,"},{"line_number":139,"context_line":"                                 install_share_path) or install_share_path"},{"line_number":140,"context_line":"        self.PATH_VAR_TEMPLATE +\u003d ("},{"line_number":141,"context_line":"            \":{0}/controller:{0}/northd:{0}/utilities\".format("},{"line_number":142,"context_line":"                self.ovndir))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_c1b508d1","line":139,"range":{"start_line":139,"start_character":52,"end_line":139,"end_character":74},"updated":"2020-01-16 10:35:51.000000000","message":"Is this needed?","commit_id":"18eb60de2b0c400545eb79cb6df8c37ffaba21e8"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8b928ef0156ff240dbea7f0798208e45f178c9f0","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        install_share_path \u003d self._get_install_share_path()"},{"line_number":137,"context_line":"        self.add_chassis \u003d kwargs.pop(\u0027add_chassis\u0027, False)"},{"line_number":138,"context_line":"        self.ovndir \u003d kwargs.pop(\u0027ovndir\u0027,"},{"line_number":139,"context_line":"                                 install_share_path) or install_share_path"},{"line_number":140,"context_line":"        self.PATH_VAR_TEMPLATE +\u003d ("},{"line_number":141,"context_line":"            \":{0}/controller:{0}/northd:{0}/utilities\".format("},{"line_number":142,"context_line":"                self.ovndir))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_21673c55","line":139,"range":{"start_line":139,"start_character":52,"end_line":139,"end_character":74},"in_reply_to":"3fa7e38b_81fdd06e","updated":"2020-01-16 10:55:21.000000000","message":"Thanks for explanation, I missed that :)","commit_id":"18eb60de2b0c400545eb79cb6df8c37ffaba21e8"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"8cd76d0a456e36ab0254e4da5586a0f39cc3f566","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        install_share_path \u003d self._get_install_share_path()"},{"line_number":137,"context_line":"        self.add_chassis \u003d kwargs.pop(\u0027add_chassis\u0027, False)"},{"line_number":138,"context_line":"        self.ovndir \u003d kwargs.pop(\u0027ovndir\u0027,"},{"line_number":139,"context_line":"                                 install_share_path) or install_share_path"},{"line_number":140,"context_line":"        self.PATH_VAR_TEMPLATE +\u003d ("},{"line_number":141,"context_line":"            \":{0}/controller:{0}/northd:{0}/utilities\".format("},{"line_number":142,"context_line":"                self.ovndir))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_81fdd06e","line":139,"range":{"start_line":139,"start_character":52,"end_line":139,"end_character":74},"in_reply_to":"3fa7e38b_c1b508d1","updated":"2020-01-16 10:50:07.000000000","message":"ah, yes. it turns out it is needed here, because we have cases when the ovndir is present BUT it is None.\nSo, we definitely need to check for that here.","commit_id":"18eb60de2b0c400545eb79cb6df8c37ffaba21e8"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f0523bde7ae0e193d8ce7c0f1f9dfa216295dd88","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        super(OvsOvnVenvFixture, self).__init__(*args, **kwargs)"},{"line_number":144,"context_line":"        self.env.update({\u0027OVN_RUNDIR\u0027: self.venv})"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _get_install_share_path(self):"},{"line_number":147,"context_line":"        path \u003d os.path.join(const.OVN_INSTALL_SHARE_PATH, \u0027ovn-nb.ovsschema\u0027)"},{"line_number":148,"context_line":"        if os.path.isfile(path):"},{"line_number":149,"context_line":"            return const.OVN_INSTALL_SHARE_PATH"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_41983866","line":146,"range":{"start_line":146,"start_character":32,"end_line":146,"end_character":37},"updated":"2020-01-16 10:35:51.000000000","message":"nit: self is not used, it can be either a helper function or staticmethod","commit_id":"18eb60de2b0c400545eb79cb6df8c37ffaba21e8"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"8cd76d0a456e36ab0254e4da5586a0f39cc3f566","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        super(OvsOvnVenvFixture, self).__init__(*args, **kwargs)"},{"line_number":144,"context_line":"        self.env.update({\u0027OVN_RUNDIR\u0027: self.venv})"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _get_install_share_path(self):"},{"line_number":147,"context_line":"        path \u003d os.path.join(const.OVN_INSTALL_SHARE_PATH, \u0027ovn-nb.ovsschema\u0027)"},{"line_number":148,"context_line":"        if os.path.isfile(path):"},{"line_number":149,"context_line":"            return const.OVN_INSTALL_SHARE_PATH"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_21f41c88","line":146,"range":{"start_line":146,"start_character":32,"end_line":146,"end_character":37},"in_reply_to":"3fa7e38b_41983866","updated":"2020-01-16 10:50:07.000000000","message":"ack. let me change that!","commit_id":"18eb60de2b0c400545eb79cb6df8c37ffaba21e8"}],"tools/setup-ovs.sh":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a65793748da2e9b65c90c3d39daca06be0180280","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    # IF OVN_BRANCH is \"master\" or branch-2.13 (or higher), use the new"},{"line_number":8,"context_line":"    # OVN repository"},{"line_number":9,"context_line":"    if [ \"$OVN_BRANCH\" \u003d\u003d \"master\" ] || \\"},{"line_number":10,"context_line":"       [ $(echo $OVN_BRANCH | sed -e \u0027s/^branch-\\([0-9]*\\)\\.//\u0027) -ge 13 ]; then"},{"line_number":11,"context_line":"        return 0"},{"line_number":12,"context_line":"    else"},{"line_number":13,"context_line":"        return 1"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_9f6f9dc6","line":10,"updated":"2020-01-13 22:54:26.000000000","message":"Not that I\u0027m sure that it matters that much, but this would fail for branch 3.0-3.12 for example if they ever existed. If it does matter, we could do something like:\n\n    function use_new_ovn_repository {\n        # If OVN_BRANCH \u003e branch-2.12 return 0\n        return $(! printf \"%s\\n%s\" $OVN_BRANCH branch-2.12| sort -C -V)\n    }\n\n\nwhich theoretically would cover the case of OVN_BRANCH\u003dmaster as well as an accident. Branch \"awesomenewbranch\" would sort as older though :p","commit_id":"08ef9e4ce65b6a4df7ea1c7a51c5caa5a0e3fe8a"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"cf0127e74c1ad204742a07860925a3d568cbf6c3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    # IF OVN_BRANCH is \"master\" or branch-2.13 (or higher), use the new"},{"line_number":8,"context_line":"    # OVN repository"},{"line_number":9,"context_line":"    if [ \"$OVN_BRANCH\" \u003d\u003d \"master\" ] || \\"},{"line_number":10,"context_line":"       [ $(echo $OVN_BRANCH | sed -e \u0027s/^branch-\\([0-9]*\\)\\.//\u0027) -ge 13 ]; then"},{"line_number":11,"context_line":"        return 0"},{"line_number":12,"context_line":"    else"},{"line_number":13,"context_line":"        return 1"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_ea2b7179","line":10,"in_reply_to":"3fa7e38b_9f6f9dc6","updated":"2020-01-14 00:02:51.000000000","message":"Nice!!! Will do that.","commit_id":"08ef9e4ce65b6a4df7ea1c7a51c5caa5a0e3fe8a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f0523bde7ae0e193d8ce7c0f1f9dfa216295dd88","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    git clone git://github.com/openvswitch/ovs.git $OVS_SRCDIR"},{"line_number":18,"context_line":"    (cd $OVS_SRCDIR \u0026\u0026 git checkout $OVS_BRANCH \u0026\u0026 ./boot.sh \u0026\u0026 PYTHON\u003d/usr/bin/python ./configure \u0026\u0026 make -j$(($(nproc) + 1)))"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":"if use_new_ovn_repository; then"},{"line_number":21,"context_line":"    if [ \"$OVN_SRCDIR\" -a ! -d \"$OVN_SRCDIR\" ]; then"},{"line_number":22,"context_line":"        echo \"Building OVN branch $OVN_BRANCH in $OVN_SRCDIR\""},{"line_number":23,"context_line":"        mkdir -p $OVN_SRCDIR"},{"line_number":24,"context_line":"        git clone git://github.com/ovn-org/ovn.git $OVN_SRCDIR"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_8196303d","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":52},"updated":"2020-01-16 10:35:51.000000000","message":"nit: we can do\n\n if use_new_ovn_repository \u0026\u0026 [ ... ]; then\n\nas we don\u0027t do anything special in the use_new_ovn_repository block","commit_id":"18eb60de2b0c400545eb79cb6df8c37ffaba21e8"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"8cd76d0a456e36ab0254e4da5586a0f39cc3f566","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    git clone git://github.com/openvswitch/ovs.git $OVS_SRCDIR"},{"line_number":18,"context_line":"    (cd $OVS_SRCDIR \u0026\u0026 git checkout $OVS_BRANCH \u0026\u0026 ./boot.sh \u0026\u0026 PYTHON\u003d/usr/bin/python ./configure \u0026\u0026 make -j$(($(nproc) + 1)))"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":"if use_new_ovn_repository; then"},{"line_number":21,"context_line":"    if [ \"$OVN_SRCDIR\" -a ! -d \"$OVN_SRCDIR\" ]; then"},{"line_number":22,"context_line":"        echo \"Building OVN branch $OVN_BRANCH in $OVN_SRCDIR\""},{"line_number":23,"context_line":"        mkdir -p $OVN_SRCDIR"},{"line_number":24,"context_line":"        git clone git://github.com/ovn-org/ovn.git $OVN_SRCDIR"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_a1256c18","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":52},"in_reply_to":"3fa7e38b_8196303d","updated":"2020-01-16 10:50:07.000000000","message":"ack. yeah, and we can save on the indent. let me fix that.","commit_id":"18eb60de2b0c400545eb79cb6df8c37ffaba21e8"}]}