)]}'
{"ovsdbapp/tests/functional/schema/ovn_northbound/test_impl_idl.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a64f949a985426696afdedf14c7b088451aa54fa","unresolved":false,"context_lines":[{"line_number":1563,"context_line":""},{"line_number":1564,"context_line":"    def _check_values(self):"},{"line_number":1565,"context_line":"        ls_found \u003d self.api.ls_get(self.ls_name).execute(check_error\u003dTrue)"},{"line_number":1566,"context_line":"        self.assertIsNotNone(ls_found, \"Could not find ls\")"},{"line_number":1567,"context_line":"        lsp_found \u003d self.api.lsp_get(self.lsp_name).execute(check_error\u003dTrue)"},{"line_number":1568,"context_line":"        self.assertIsNotNone(lsp_found, \"Could not find lsp\")"},{"line_number":1569,"context_line":"        self.assertEqual(self.lsp_test_addresses,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_480cf839","line":1566,"updated":"2020-01-14 21:46:59.000000000","message":"I don\u0027t think these can ever return None, just raise RowNotFound or return a row, since they _get() basically just call lookup() w/ no default. So I think the fact that we don\u0027t throw an Exception when running is sufficient when checking.","commit_id":"5d0b5d2456e78d79dcf13ee79eaa5965780480ed"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"c117347e8734639e8bd0f3db0718374bc31c8af9","unresolved":false,"context_lines":[{"line_number":1563,"context_line":""},{"line_number":1564,"context_line":"    def _check_values(self):"},{"line_number":1565,"context_line":"        ls_found \u003d self.api.ls_get(self.ls_name).execute(check_error\u003dTrue)"},{"line_number":1566,"context_line":"        self.assertIsNotNone(ls_found, \"Could not find ls\")"},{"line_number":1567,"context_line":"        lsp_found \u003d self.api.lsp_get(self.lsp_name).execute(check_error\u003dTrue)"},{"line_number":1568,"context_line":"        self.assertIsNotNone(lsp_found, \"Could not find lsp\")"},{"line_number":1569,"context_line":"        self.assertEqual(self.lsp_test_addresses,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_e84a8480","line":1566,"in_reply_to":"3fa7e38b_480cf839","updated":"2020-01-14 22:25:54.000000000","message":"ack!","commit_id":"5d0b5d2456e78d79dcf13ee79eaa5965780480ed"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a64f949a985426696afdedf14c7b088451aa54fa","unresolved":false,"context_lines":[{"line_number":1565,"context_line":"        ls_found \u003d self.api.ls_get(self.ls_name).execute(check_error\u003dTrue)"},{"line_number":1566,"context_line":"        self.assertIsNotNone(ls_found, \"Could not find ls\")"},{"line_number":1567,"context_line":"        lsp_found \u003d self.api.lsp_get(self.lsp_name).execute(check_error\u003dTrue)"},{"line_number":1568,"context_line":"        self.assertIsNotNone(lsp_found, \"Could not find lsp\")"},{"line_number":1569,"context_line":"        self.assertEqual(self.lsp_test_addresses,"},{"line_number":1570,"context_line":"                         self.api.lsp_get_addresses(self.lsp_name).execute("},{"line_number":1571,"context_line":"                check_error\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6809b427","line":1568,"updated":"2020-01-14 21:46:59.000000000","message":"same","commit_id":"5d0b5d2456e78d79dcf13ee79eaa5965780480ed"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"c117347e8734639e8bd0f3db0718374bc31c8af9","unresolved":false,"context_lines":[{"line_number":1565,"context_line":"        ls_found \u003d self.api.ls_get(self.ls_name).execute(check_error\u003dTrue)"},{"line_number":1566,"context_line":"        self.assertIsNotNone(ls_found, \"Could not find ls\")"},{"line_number":1567,"context_line":"        lsp_found \u003d self.api.lsp_get(self.lsp_name).execute(check_error\u003dTrue)"},{"line_number":1568,"context_line":"        self.assertIsNotNone(lsp_found, \"Could not find lsp\")"},{"line_number":1569,"context_line":"        self.assertEqual(self.lsp_test_addresses,"},{"line_number":1570,"context_line":"                         self.api.lsp_get_addresses(self.lsp_name).execute("},{"line_number":1571,"context_line":"                check_error\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_883f50de","line":1568,"in_reply_to":"3fa7e38b_6809b427","updated":"2020-01-14 22:25:54.000000000","message":"Done","commit_id":"5d0b5d2456e78d79dcf13ee79eaa5965780480ed"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a64f949a985426696afdedf14c7b088451aa54fa","unresolved":false,"context_lines":[{"line_number":1568,"context_line":"        self.assertIsNotNone(lsp_found, \"Could not find lsp\")"},{"line_number":1569,"context_line":"        self.assertEqual(self.lsp_test_addresses,"},{"line_number":1570,"context_line":"                         self.api.lsp_get_addresses(self.lsp_name).execute("},{"line_number":1571,"context_line":"                check_error\u003dTrue))"},{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"    def test_lsp_add_by_name(self):"},{"line_number":1574,"context_line":"        with self.api.transaction(check_error\u003dTrue) as txn:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_656d5d00","line":1571,"updated":"2020-01-14 21:46:59.000000000","message":"pep8 unhappy with the indent on this","commit_id":"5d0b5d2456e78d79dcf13ee79eaa5965780480ed"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"c117347e8734639e8bd0f3db0718374bc31c8af9","unresolved":false,"context_lines":[{"line_number":1568,"context_line":"        self.assertIsNotNone(lsp_found, \"Could not find lsp\")"},{"line_number":1569,"context_line":"        self.assertEqual(self.lsp_test_addresses,"},{"line_number":1570,"context_line":"                         self.api.lsp_get_addresses(self.lsp_name).execute("},{"line_number":1571,"context_line":"                check_error\u003dTrue))"},{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"    def test_lsp_add_by_name(self):"},{"line_number":1574,"context_line":"        with self.api.transaction(check_error\u003dTrue) as txn:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6856942e","line":1571,"in_reply_to":"3fa7e38b_656d5d00","updated":"2020-01-14 22:25:54.000000000","message":"oops!","commit_id":"5d0b5d2456e78d79dcf13ee79eaa5965780480ed"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"11ea7732c9abe5193b5f6f87c0f10f61efce6ca8","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"                                    \"addresses\", self.lsp_test_addresses[0]))"},{"line_number":1589,"context_line":"        self._check_values()"},{"line_number":1590,"context_line":""},{"line_number":1591,"context_line":"    def test_lsp_add_by_object_via_tx_add(self):"},{"line_number":1592,"context_line":"        self.skipTest(\"this is not supported yet. Stay tuned!\")"},{"line_number":1593,"context_line":"        with self.api.transaction(check_error\u003dTrue) as txn:"},{"line_number":1594,"context_line":"            sw \u003d txn.add(self.api.ls_add(self.ls_name))"},{"line_number":1595,"context_line":"            prt \u003d txn.add(self.api.lsp_add(sw, self.lsp_name))"},{"line_number":1596,"context_line":"            txn.add(self.api.lsp_set_addresses(prt,"},{"line_number":1597,"context_line":"                                               self.lsp_test_addresses))"},{"line_number":1598,"context_line":"        self._check_values()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_33d78f53","line":1598,"range":{"start_line":1591,"start_character":0,"end_line":1598,"end_character":28},"updated":"2020-01-16 11:35:24.000000000","message":"how about adding this test once it is supported (copy\u0026paste from this review)","commit_id":"48645eb7404d57455b61c1634c10dbb2a1389853"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"91052d5db07e62922409fae5f19456118cfe543c","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"                                    \"addresses\", self.lsp_test_addresses[0]))"},{"line_number":1589,"context_line":"        self._check_values()"},{"line_number":1590,"context_line":""},{"line_number":1591,"context_line":"    def test_lsp_add_by_object_via_tx_add(self):"},{"line_number":1592,"context_line":"        self.skipTest(\"this is not supported yet. Stay tuned!\")"},{"line_number":1593,"context_line":"        with self.api.transaction(check_error\u003dTrue) as txn:"},{"line_number":1594,"context_line":"            sw \u003d txn.add(self.api.ls_add(self.ls_name))"},{"line_number":1595,"context_line":"            prt \u003d txn.add(self.api.lsp_add(sw, self.lsp_name))"},{"line_number":1596,"context_line":"            txn.add(self.api.lsp_set_addresses(prt,"},{"line_number":1597,"context_line":"                                               self.lsp_test_addresses))"},{"line_number":1598,"context_line":"        self._check_values()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a781f9fc","line":1598,"range":{"start_line":1591,"start_character":0,"end_line":1598,"end_character":28},"in_reply_to":"3fa7e38b_33d78f53","updated":"2020-01-16 15:23:55.000000000","message":"We could... let me remove it from here for now.","commit_id":"48645eb7404d57455b61c1634c10dbb2a1389853"}]}