)]}'
{"tools/debug_venv.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3df13e18602f15573b3b7b24f7a6f15a884b3863","unresolved":false,"context_lines":[{"line_number":38,"context_line":"try:"},{"line_number":39,"context_line":"    atexit.register(v.cleanUp)"},{"line_number":40,"context_line":"    v.setUp()"},{"line_number":41,"context_line":"except fixture.MultipleExceptions:"},{"line_number":42,"context_line":"    raise"},{"line_number":43,"context_line":"try:"},{"line_number":44,"context_line":"    print(\"*** Exit the shell when finished debugging ***\")"},{"line_number":45,"context_line":"    subprocess.call([os.getenv(\u0027SHELL\u0027), \u0027-i\u0027], env\u003dv.env)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_6a4950b5","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":9},"updated":"2020-04-02 07:14:45.000000000","message":"Is it even needed?","commit_id":"076152a9fb3a99142abf4023b8eae45913312846"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2576d2e47965f403d7f18feb9dbf1414facf1c16","unresolved":false,"context_lines":[{"line_number":38,"context_line":"try:"},{"line_number":39,"context_line":"    atexit.register(v.cleanUp)"},{"line_number":40,"context_line":"    v.setUp()"},{"line_number":41,"context_line":"except fixture.MultipleExceptions:"},{"line_number":42,"context_line":"    raise"},{"line_number":43,"context_line":"try:"},{"line_number":44,"context_line":"    print(\"*** Exit the shell when finished debugging ***\")"},{"line_number":45,"context_line":"    subprocess.call([os.getenv(\u0027SHELL\u0027), \u0027-i\u0027], env\u003dv.env)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_a70c2594","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":9},"in_reply_to":"df33271e_6a4950b5","updated":"2020-04-02 15:44:43.000000000","message":"probably not, we\u0027re raising for everything now.  In reality this change is probably wrong, since it was trying to raise just the first if there were many exceptions, i can look for a better non-six way.","commit_id":"076152a9fb3a99142abf4023b8eae45913312846"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"63e79e6cc3ac3c1e2382c93b5e060f67513f384c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"try:"},{"line_number":39,"context_line":"    atexit.register(v.cleanUp)"},{"line_number":40,"context_line":"    v.setUp()"},{"line_number":41,"context_line":"except fixture.MultipleExceptions:"},{"line_number":42,"context_line":"    raise"},{"line_number":43,"context_line":"try:"},{"line_number":44,"context_line":"    print(\"*** Exit the shell when finished debugging ***\")"},{"line_number":45,"context_line":"    subprocess.call([os.getenv(\u0027SHELL\u0027), \u0027-i\u0027], env\u003dv.env)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_e76e2d2d","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":9},"in_reply_to":"df33271e_a70c2594","updated":"2020-04-02 15:46:37.000000000","message":"I mean, here we catch the exception and raise it right away. We don\u0027t handle anything so I thought about just removing the L38 and L41-42","commit_id":"076152a9fb3a99142abf4023b8eae45913312846"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"5b4a2f09298e91ba4e947cd048cd4d1b131076f2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"try:"},{"line_number":39,"context_line":"    atexit.register(v.cleanUp)"},{"line_number":40,"context_line":"    v.setUp()"},{"line_number":41,"context_line":"except fixture.MultipleExceptions:"},{"line_number":42,"context_line":"    raise"},{"line_number":43,"context_line":"try:"},{"line_number":44,"context_line":"    print(\"*** Exit the shell when finished debugging ***\")"},{"line_number":45,"context_line":"    subprocess.call([os.getenv(\u0027SHELL\u0027), \u0027-i\u0027], env\u003dv.env)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_f38a6e61","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":9},"in_reply_to":"df33271e_e76e2d2d","updated":"2020-04-02 19:21:06.000000000","message":"The problem was that we would just get a MultipleException raised which completely hid what the real Exception was. six.reraise was used to just raise the initial Exception so I could see what was actually happening instead of just getting an annoying/useless fixtures.SetupError or whatever.","commit_id":"076152a9fb3a99142abf4023b8eae45913312846"}]}