)]}'
{"ovsdbapp/schema/ovn_northbound/commands.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"5816f2754ff724f96bad2c931eb3e3b145d7ad77","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"            lb \u003d self.api.lookup(\u0027Load_Balancer\u0027, self.lb)"},{"line_number":1050,"context_line":"            if self.vip:"},{"line_number":1051,"context_line":"                if self.vip in lb.vips:"},{"line_number":1052,"context_line":"                    if self.if_exists:"},{"line_number":1053,"context_line":"                        return"},{"line_number":1054,"context_line":"                    lb.delkey(\u0027vips\u0027, self.vip)"},{"line_number":1055,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_d213b30c","side":"PARENT","line":1052,"updated":"2020-05-11 14:54:37.000000000","message":"Yeah, this is all very wrong. :P","commit_id":"f8235d80225b7fcbb539679cb3d6fe2c585029ae"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"5816f2754ff724f96bad2c931eb3e3b145d7ad77","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"            return"},{"line_number":1054,"context_line":"        if self.vip:"},{"line_number":1055,"context_line":"            if self.vip in lb.vips:"},{"line_number":1056,"context_line":"                lb.delkey(\u0027vips\u0027, self.vip)"},{"line_number":1057,"context_line":"            elif not self.if_exists:"},{"line_number":1058,"context_line":"                raise idlutils.RowNotFound(table\u003d\u0027Load_Balancer\u0027, col\u003dself.vip,"},{"line_number":1059,"context_line":"                                           match\u003dself.lb)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_b2a0bfa7","line":1056,"updated":"2020-05-11 14:54:37.000000000","message":"Something I noticed in the ovn-nbctl code is that if we are deleting the last VIP, it also deletes the LoadBalancer. This makes sense since the lb-add doesn\u0027t let you create a LB w/o vips. We should probably add this while we are at it (though there is no db constraint that doesn\u0027t permit a vip-less LoadBalancer).\n\nI don\u0027t see any code that currently passes in vip, if that\u0027s the case it should be safe to change.","commit_id":"6baba06029f2aefe1d10ea472e74f4082a3fe181"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"80967c4e16710cbc12fb1f22947b859790267e9d","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"            return"},{"line_number":1054,"context_line":"        if self.vip:"},{"line_number":1055,"context_line":"            if self.vip in lb.vips:"},{"line_number":1056,"context_line":"                lb.delkey(\u0027vips\u0027, self.vip)"},{"line_number":1057,"context_line":"            elif not self.if_exists:"},{"line_number":1058,"context_line":"                raise idlutils.RowNotFound(table\u003d\u0027Load_Balancer\u0027, col\u003dself.vip,"},{"line_number":1059,"context_line":"                                           match\u003dself.lb)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_682e36a6","line":1056,"in_reply_to":"ff570b3c_b2a0bfa7","updated":"2020-05-11 16:10:28.000000000","message":"Done","commit_id":"6baba06029f2aefe1d10ea472e74f4082a3fe181"}]}