)]}'
{"ovsdbapp/backend/ovs_idl/connection.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"0d436a5f686d25ea6dae7d4db9b40a1a2bd305ea","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            try:"},{"line_number":100,"context_line":"                self.idl.wait(self.poller)"},{"line_number":101,"context_line":"                self.poller.fd_wait(self.txns.alert_fileno, poller.POLLIN)"},{"line_number":102,"context_line":"                # TODO(jlibosva): Remove next line once losing connection to"},{"line_number":103,"context_line":"                #                 ovsdb is solved."},{"line_number":104,"context_line":"                self.poller.timer_wait(self.timeout * 1000)"},{"line_number":105,"context_line":"                self.poller.block()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_83b901eb","side":"PARENT","line":102,"updated":"2020-08-11 21:10:06.000000000","message":"Waking up every second when we don\u0027t have any updates shouldn\u0027t be necessary and we *shouldn\u0027t* be losing connection to ovsdb anyway. Especially if we are going to start holding a lock it seems like doing it less is better.","commit_id":"3c64cf6d3798a1f991df07673a5f07188e4df286"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"1ddd81689d75962a79501ca09f941771d8d7a50d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            try:"},{"line_number":100,"context_line":"                self.idl.wait(self.poller)"},{"line_number":101,"context_line":"                self.poller.fd_wait(self.txns.alert_fileno, poller.POLLIN)"},{"line_number":102,"context_line":"                # TODO(jlibosva): Remove next line once losing connection to"},{"line_number":103,"context_line":"                #                 ovsdb is solved."},{"line_number":104,"context_line":"                self.poller.timer_wait(self.timeout * 1000)"},{"line_number":105,"context_line":"                self.poller.block()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d23e13d9","side":"PARENT","line":102,"in_reply_to":"9f560f44_83b901eb","updated":"2020-08-12 21:29:26.000000000","message":"Nice! I agree.","commit_id":"3c64cf6d3798a1f991df07673a5f07188e4df286"}],"ovsdbapp/tests/unit/backend/test_ovs_idl.py":[{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"1ddd81689d75962a79501ca09f941771d8d7a50d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"class TestBackendOvsIdl(base.TestCase):"},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(TestBackendOvsIdl, self).setUp()"},{"line_number":48,"context_line":"        self.backend \u003d FakeBackend(mock.MagicMock())"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_lookup_found(self):"},{"line_number":51,"context_line":"        row \u003d self.backend.lookup(\u0027Faketable\u0027, \u0027Fake1\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b5fd490a","line":48,"range":{"start_line":48,"start_character":35,"end_line":48,"end_character":51},"updated":"2020-08-12 21:29:26.000000000","message":"Not an issue, just curious: what is this change about?\nNeeded a little magic? :)","commit_id":"3cf8a427c0a4dfc248e0778c3b1ee65671d1d07b"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"8efc40b4ed8b35605235b5e0f02832709a85a309","unresolved":false,"context_lines":[{"line_number":45,"context_line":"class TestBackendOvsIdl(base.TestCase):"},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(TestBackendOvsIdl, self).setUp()"},{"line_number":48,"context_line":"        self.backend \u003d FakeBackend(mock.MagicMock())"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_lookup_found(self):"},{"line_number":51,"context_line":"        row \u003d self.backend.lookup(\u0027Faketable\u0027, \u0027Fake1\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_37181974","line":48,"range":{"start_line":48,"start_character":35,"end_line":48,"end_character":51},"in_reply_to":"9f560f44_75fc513e","updated":"2020-08-13 09:15:17.000000000","message":"Ack. TY. That explains the Lock -\u003e RLock change too.","commit_id":"3cf8a427c0a4dfc248e0778c3b1ee65671d1d07b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"8628f403768231bb3d1c64c112d88e030c2c2093","unresolved":false,"context_lines":[{"line_number":45,"context_line":"class TestBackendOvsIdl(base.TestCase):"},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(TestBackendOvsIdl, self).setUp()"},{"line_number":48,"context_line":"        self.backend \u003d FakeBackend(mock.MagicMock())"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_lookup_found(self):"},{"line_number":51,"context_line":"        row \u003d self.backend.lookup(\u0027Faketable\u0027, \u0027Fake1\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_75fc513e","line":48,"range":{"start_line":48,"start_character":35,"end_line":48,"end_character":51},"in_reply_to":"9f560f44_b5fd490a","updated":"2020-08-12 22:21:14.000000000","message":"Adding the call to with self.ovdsb_connection.lock: ended up adding a new call call to the mocked object, so needed a magic mock to automatically generate mocks for the methods on the backend.","commit_id":"3cf8a427c0a4dfc248e0778c3b1ee65671d1d07b"}]}