)]}'
{"ovsdbapp/backend/ovs_idl/connection.py":[{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"80c318170f257fdad423ee1eef06525eaa601dbd","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    idlutils.wait_for_change(self.idl, self.timeout)"},{"line_number":114,"context_line":"                sleep \u003d min(2 ** errors, 60)"},{"line_number":115,"context_line":"                LOG.info(\"Trying to recover, sleeping %s seconds\", sleep)"},{"line_number":116,"context_line":"                time.sleep(min(sleep, 60))"},{"line_number":117,"context_line":"                continue"},{"line_number":118,"context_line":"            errors \u003d 0"},{"line_number":119,"context_line":"            txn \u003d self.txns.get_nowait()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_424fc8bd","line":116,"range":{"start_line":116,"start_character":16,"end_line":116,"end_character":42},"updated":"2020-09-15 19:06:46.000000000","message":"no need to do min() again, right? you already took care of it on line 114.","commit_id":"514648593c334fd68fa24a34106ac3db8ece1014"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"781dca396a581fe3ed5210ee4a78cae5fc1ebc87","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    idlutils.wait_for_change(self.idl, self.timeout)"},{"line_number":114,"context_line":"                sleep \u003d min(2 ** errors, 60)"},{"line_number":115,"context_line":"                LOG.info(\"Trying to recover, sleeping %s seconds\", sleep)"},{"line_number":116,"context_line":"                time.sleep(min(sleep, 60))"},{"line_number":117,"context_line":"                continue"},{"line_number":118,"context_line":"            errors \u003d 0"},{"line_number":119,"context_line":"            txn \u003d self.txns.get_nowait()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_42598859","line":116,"range":{"start_line":116,"start_character":16,"end_line":116,"end_character":42},"in_reply_to":"9f560f44_424fc8bd","updated":"2020-09-15 19:19:11.000000000","message":"doh, added the sleep variable and then just replaced inside min() instead of whole min call. :p","commit_id":"514648593c334fd68fa24a34106ac3db8ece1014"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"db1665ca28b8f394f3a9a45375f9b66a5dcb87e2","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                    self.idl.force_reconnect()"},{"line_number":113,"context_line":"                    try:"},{"line_number":114,"context_line":"                        idlutils.wait_for_change(self.idl, self.timeout)"},{"line_number":115,"context_line":"                    except Exception:"},{"line_number":116,"context_line":"                        # This could throw the same exception as idl.run()"},{"line_number":117,"context_line":"                        # or Exception(\"timeout\"), either way continue"},{"line_number":118,"context_line":"                        pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d9ff3da9","line":115,"updated":"2020-09-16 12:43:42.000000000","message":"Wouldn\u0027t it be safer to log this exception as error at least?","commit_id":"04263acc850b10c38a4cc5c352df95297d7b9ce0"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"803dabe15942d2b6bb5e37694c96d4cf6844b4fc","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                    self.idl.force_reconnect()"},{"line_number":113,"context_line":"                    try:"},{"line_number":114,"context_line":"                        idlutils.wait_for_change(self.idl, self.timeout)"},{"line_number":115,"context_line":"                    except Exception:"},{"line_number":116,"context_line":"                        # This could throw the same exception as idl.run()"},{"line_number":117,"context_line":"                        # or Exception(\"timeout\"), either way continue"},{"line_number":118,"context_line":"                        pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_934702a4","line":115,"in_reply_to":"9f560f44_22527836","updated":"2020-09-22 13:20:31.000000000","message":"Done","commit_id":"04263acc850b10c38a4cc5c352df95297d7b9ce0"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"b009d4ffce24de6cf543aa5184ae4fcf98d026d7","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                    self.idl.force_reconnect()"},{"line_number":113,"context_line":"                    try:"},{"line_number":114,"context_line":"                        idlutils.wait_for_change(self.idl, self.timeout)"},{"line_number":115,"context_line":"                    except Exception:"},{"line_number":116,"context_line":"                        # This could throw the same exception as idl.run()"},{"line_number":117,"context_line":"                        # or Exception(\"timeout\"), either way continue"},{"line_number":118,"context_line":"                        pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_22527836","line":115,"in_reply_to":"9f560f44_d9ff3da9","updated":"2020-09-17 01:39:22.000000000","message":"Maybe? Seems like it is most likely to be exactly the same Exception as logged in line 110 since both mostly just call idl.run() so I figured \"meh.\" I\u0027m not against adding it though.","commit_id":"04263acc850b10c38a4cc5c352df95297d7b9ce0"}]}