)]}'
{"ovsdbapp/backend/ovs_idl/connection.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"52f7a9ea82136153d83a20b8525012e0b8feb9a8","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        :type tables: List"},{"line_number":178,"context_line":"        :param schema: Schema description"},{"line_number":179,"context_line":"        :type schema: dict or string"},{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        schema_helper \u003d idlutils.create_schema_helper(schema)"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_e0362651","line":180,"updated":"2020-11-13 09:07:44.000000000","message":"Shouldn\u0027t you register those new tables and unregister the removed ones at the end of this method?","commit_id":"341e1e5402a4653a63b68c44f0550f6e58069573"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8fc87f914fc3c14521bcf01139762cffba00e32a","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        :type tables: List"},{"line_number":178,"context_line":"        :param schema: Schema description"},{"line_number":179,"context_line":"        :type schema: dict or string"},{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        schema_helper \u003d idlutils.create_schema_helper(schema)"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_80aad215","line":180,"in_reply_to":"1f621f24_009ec205","updated":"2020-11-13 09:39:22.000000000","message":"Maybe I don\u0027t understand what exactly do you mean. Can you write a code snippet?","commit_id":"341e1e5402a4653a63b68c44f0550f6e58069573"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c84e808e9d22949fb8bb59903c808a613f898b36","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        :type tables: List"},{"line_number":178,"context_line":"        :param schema: Schema description"},{"line_number":179,"context_line":"        :type schema: dict or string"},{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        schema_helper \u003d idlutils.create_schema_helper(schema)"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_d1101a03","line":180,"in_reply_to":"1f621f24_80aad215","updated":"2020-11-13 13:41:17.000000000","message":"talked in IRC, question solved","commit_id":"341e1e5402a4653a63b68c44f0550f6e58069573"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4ecbc08eb72e3cc590c5c1ab8194afb9143786dc","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        :type tables: List"},{"line_number":178,"context_line":"        :param schema: Schema description"},{"line_number":179,"context_line":"        :type schema: dict or string"},{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        schema_helper \u003d idlutils.create_schema_helper(schema)"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_009ec205","line":180,"in_reply_to":"1f621f24_e00f4685","updated":"2020-11-13 09:29:50.000000000","message":"But I was talking about the schema register, to receive updates from the server. I thought that you needed to register the tables to receive events related to them from the server. Maybe I\u0027m wrong here.","commit_id":"341e1e5402a4653a63b68c44f0550f6e58069573"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"62086a4e0fbe7fef15dea6e8ca317c2ea965ac44","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        :type tables: List"},{"line_number":178,"context_line":"        :param schema: Schema description"},{"line_number":179,"context_line":"        :type schema: dict or string"},{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        schema_helper \u003d idlutils.create_schema_helper(schema)"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_e00f4685","line":180,"in_reply_to":"1f621f24_e0362651","updated":"2020-11-13 09:10:44.000000000","message":"It first modifies the tables in the schema helper on L186-L188 and then based on those data modifies the Idl object on lines 191-201","commit_id":"341e1e5402a4653a63b68c44f0550f6e58069573"}],"ovsdbapp/tests/functional/backend/ovs_idl/test_connection.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"13e2aa105605c820b3995b186d159dd41c9142f6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                self.schema_map[TestingOvsIdl.schema], TestingOvsIdl.schema)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def validate_tables(self, tables, present):"},{"line_number":62,"context_line":"        if present:"},{"line_number":63,"context_line":"            valid_func \u003d self.assertIn"},{"line_number":64,"context_line":"        else:"},{"line_number":65,"context_line":"            valid_func \u003d self.assertNotIn"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_7748232c","line":62,"updated":"2020-11-12 19:44:20.000000000","message":"super nit just to find *something* to comment on:\n\n valid_func \u003d self.assertIn if present else self.assertNotIn\n\nor just do:\n\n def validate_tables(self, tables, test_fn):\n\nand pass in self.assertIn/NotIn","commit_id":"341e1e5402a4653a63b68c44f0550f6e58069573"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"62086a4e0fbe7fef15dea6e8ca317c2ea965ac44","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                self.schema_map[TestingOvsIdl.schema], TestingOvsIdl.schema)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def validate_tables(self, tables, present):"},{"line_number":62,"context_line":"        if present:"},{"line_number":63,"context_line":"            valid_func \u003d self.assertIn"},{"line_number":64,"context_line":"        else:"},{"line_number":65,"context_line":"            valid_func \u003d self.assertNotIn"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_402a7ada","line":62,"in_reply_to":"1f621f24_7748232c","updated":"2020-11-13 09:10:44.000000000","message":"Done","commit_id":"341e1e5402a4653a63b68c44f0550f6e58069573"}]}