)]}'
{"ovsdbapp/backend/ovs_idl/__init__.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c5a5e1a9a2c0d468448bb0955393a17d9227b5e7","unresolved":true,"context_lines":[{"line_number":194,"context_line":"                return t.rows[record]"},{"line_number":195,"context_line":"            except KeyError as e:"},{"line_number":196,"context_line":"                raise idlutils.RowNotFound(table\u003dtable, col\u003d\u0027uuid\u0027,"},{"line_number":197,"context_line":"                                           match\u003drecord) from e"},{"line_number":198,"context_line":"        try:"},{"line_number":199,"context_line":"            uuid_ \u003d uuid.UUID(record)"},{"line_number":200,"context_line":"            return t.rows[uuid_]"}],"source_content_type":"text/x-python","patch_set":1,"id":"64cf4ae2_c1cd1a87","line":197,"range":{"start_line":197,"start_character":56,"end_line":197,"end_character":63},"updated":"2021-01-04 13:25:24.000000000","message":"Do we need this? Seems like the traceback from L194 won\u0027t provide us more information than what we have without it. If it\u0027s here just to satisfy the linter, I\u0027d do \"from None\" to disable the traceback. What do you think?","commit_id":"c2abfa6cf126a75cd33ed9f102f2c150a747fdbc"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"9a66d2de95570cce7ba8df053d35098561472478","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    _ovsdb_connection \u003d None"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, connection, start\u003dTrue, auto_index\u003dTrue, **kwargs):"},{"line_number":30,"context_line":"        super().__init__(**kwargs)"},{"line_number":31,"context_line":"        self.ovsdb_connection \u003d connection"},{"line_number":32,"context_line":"        if auto_index:"},{"line_number":33,"context_line":"            if connection.is_running:"}],"source_content_type":"text/x-python","patch_set":2,"id":"c5181dde_d88e6bac","line":30,"updated":"2021-01-05 18:51:52.000000000","message":"Doing these everywhere is going to make backporting kind of a pain. Though I\u0027ve been using super() for new code, so maybe it is worth it as opposed to adding super-with-arguments to .pylintrc\u0027s ignores.\n\nI\u0027ve seen code in multi-inheritance situations where super(X, self) fails, but super() magically works. So I know they aren\u0027t *completely* equivalent. Though I\u0027ve never seen anything where super(X, self) -\u003e super() broke code. I don\u0027t really understand why, though.","commit_id":"0968b410ce13b6420131b28b4d09bdd16e306853"}],"ovsdbapp/backend/ovs_idl/transaction.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"9a66d2de95570cce7ba8df053d35098561472478","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                # idl.run() again. So, call idl.run() here just in case."},{"line_number":105,"context_line":"                self.api.idl.run()"},{"line_number":106,"context_line":"                continue"},{"line_number":107,"context_line":"            if status in (txn.ERROR, txn.NOT_LOCKED):"},{"line_number":108,"context_line":"                msg \u003d \u0027OVSDB Error: \u0027"},{"line_number":109,"context_line":"                if status \u003d\u003d txn.NOT_LOCKED:"},{"line_number":110,"context_line":"                    msg +\u003d (\"The transaction failed because the IDL has \""}],"source_content_type":"text/x-python","patch_set":2,"id":"c8764756_45be4979","line":107,"updated":"2021-01-05 18:51:52.000000000","message":"I will go with the pylint people on this one, even though I think elif makes it more clear that only one of these things is going to happen without having to read the whole block looking for returns/continues/etc.","commit_id":"0968b410ce13b6420131b28b4d09bdd16e306853"}]}