)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cbfe3603100592d3c51696383c8a7634500ac996","unresolved":true,"context_lines":[{"line_number":9,"context_line":"While creating ACL rows, avoid setting the name, severity, or meter"},{"line_number":10,"context_line":"columns when no values were provided."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This issue was introduced in"},{"line_number":13,"context_line":"https://review.opendev.org/c/openstack/ovsdbapp/+/767574"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6e39d2059c1c8ba1960b49c7be5e6a4dc5516d69"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c459f49c_8cb268bf","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":10},"updated":"2021-01-14 10:03:55.000000000","message":"What issue? It\u0027s not clear to me what problems it causes when adding None to the acl columns. If there is a problem, we should also add functional tests to make sure not passing name, severity or meter doesn\u0027t cause any troubles.","commit_id":"a728b90f0370fdd6b80042631f165074daea2c88"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a0a925676fcd00daa1acde036b94ca0fef68d2aa","unresolved":true,"context_lines":[{"line_number":9,"context_line":"While creating ACL rows, avoid setting the name, severity, or meter"},{"line_number":10,"context_line":"columns when no values were provided."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This issue was introduced in"},{"line_number":13,"context_line":"https://review.opendev.org/c/openstack/ovsdbapp/+/767574"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6e39d2059c1c8ba1960b49c7be5e6a4dc5516d69"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"8429da8b_0e2d7878","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":10},"in_reply_to":"3964cd53_680c7bed","updated":"2021-01-14 10:29:09.000000000","message":"I see the patch introduced the problem is only in master. In general, I think it\u0027s good to have LP. As we won\u0027t need any backport I\u0027d open LP if the problem is observed on the gate, for search purposes and to raise awareness in case someone hits it.","commit_id":"a728b90f0370fdd6b80042631f165074daea2c88"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"666a4d53dbee6c76461a21790e110ba96360b0ff","unresolved":true,"context_lines":[{"line_number":9,"context_line":"While creating ACL rows, avoid setting the name, severity, or meter"},{"line_number":10,"context_line":"columns when no values were provided."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This issue was introduced in"},{"line_number":13,"context_line":"https://review.opendev.org/c/openstack/ovsdbapp/+/767574"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6e39d2059c1c8ba1960b49c7be5e6a4dc5516d69"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7c45da27_53709e45","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":10},"in_reply_to":"8429da8b_0e2d7878","updated":"2021-01-14 10:33:34.000000000","message":"Ack","commit_id":"a728b90f0370fdd6b80042631f165074daea2c88"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"a2a4dca47d48cad2482b9a6b990ee857f4778718","unresolved":true,"context_lines":[{"line_number":9,"context_line":"While creating ACL rows, avoid setting the name, severity, or meter"},{"line_number":10,"context_line":"columns when no values were provided."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This issue was introduced in"},{"line_number":13,"context_line":"https://review.opendev.org/c/openstack/ovsdbapp/+/767574"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6e39d2059c1c8ba1960b49c7be5e6a4dc5516d69"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3964cd53_680c7bed","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":10},"in_reply_to":"c459f49c_8cb268bf","updated":"2021-01-14 10:26:39.000000000","message":"Good point. I will add a test on this.\nBecause of the latest change, this is what it looks like when adding an acl:\n\nJan 13 22:11:40 stack neutron-server[113780]: ERROR ovsdbapp.backend.ovs_idl.vlog [None req-7773fb60-079a-4a00-8572-54a31244c058 None None] attempting to write bad value to column meter (ovsdb error: expected string, got \u003cclass \u0027NoneType\u0027\u003e): ovs.db.error.Error: ovsdb error: expected string, got \u003cclass \u0027NoneType\u0027\u003e\n\nDo you think I should open a lp as well? I was thinking that would be overkill but maybe not.","commit_id":"a728b90f0370fdd6b80042631f165074daea2c88"}]}