)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"54ff68d5f24bca2e67e40e8d7d9a91fb58b1ab70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5a5a972b_6bccbf53","updated":"2023-02-03 09:38:39.000000000","message":"Hello folks, is this patch still relevant? Thanks!","commit_id":"cea583c60b6f764d824258607bbbe49b7c0482a8"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"3a50cf6c8f198a80e49ad4e514c8dd6c966b8701","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"385d871a_d852bdda","updated":"2024-03-18 14:24:32.000000000","message":"The upstream code of cmd_chassis_del now also finds and deletes the Chassis_Private. I see no reason not to approve this.","commit_id":"cea583c60b6f764d824258607bbbe49b7c0482a8"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"3d2e35ecc42ea7faa2b114b83876c80b1747c2bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c768fabb_977d7c30","updated":"2024-03-18 16:13:14.000000000","message":"recheck bug 2058264","commit_id":"f86a5985e7a309e69fa93658000b8356242b6322"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c73cc37afbc56b4ff6e59b7d4a03e88adeef95d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c26ae788_f4970754","updated":"2024-03-18 14:45:46.000000000","message":"zuul seems to be happy (so far, checking the queue)","commit_id":"f86a5985e7a309e69fa93658000b8356242b6322"}],"ovsdbapp/schema/ovn_southbound/commands.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e93256093b0ea898e7b18be7c6ea0edd0bf3b4cb","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        chassis.delete()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            chassis_private \u003d self.api.lookup(\u0027Chassis_Private\u0027, self.chassis)"},{"line_number":79,"context_line":"            chassis_private.delete()"},{"line_number":80,"context_line":"        except idlutils.RowNotFound:"},{"line_number":81,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"b53e7551_a4fbc8fd","line":78,"updated":"2021-11-18 15:32:45.000000000","message":"I don\u0027t think we should delete both registers. I know both are related but this executing an hidden operation while the ovsdbapp API should be transparent. If we need to delete both, then we need to command two deletion operations.\n\nLet me ask you, what is the aim of this patch? Do you have a related bug to read more information about this?","commit_id":"cea583c60b6f764d824258607bbbe49b7c0482a8"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"31cf1296de6ecb91fd174e91380e175078b9577e","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        chassis.delete()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            chassis_private \u003d self.api.lookup(\u0027Chassis_Private\u0027, self.chassis)"},{"line_number":79,"context_line":"            chassis_private.delete()"},{"line_number":80,"context_line":"        except idlutils.RowNotFound:"},{"line_number":81,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"90d4fe0e_b7050091","line":78,"in_reply_to":"6ff273c3_f25165c8","updated":"2021-11-18 22:02:24.000000000","message":"From what I can tell, even though chassis-del upstream doesn\u0027t delete the chassis_private, I think it makes sense to do it.\n\nI wonder if we should make it configurable by adding delete_private\u003dTrue/False as a default argument? Opinions?","commit_id":"cea583c60b6f764d824258607bbbe49b7c0482a8"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"64af670a7140b34ebe63e1be6a7fa18b28f06012","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        chassis.delete()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            chassis_private \u003d self.api.lookup(\u0027Chassis_Private\u0027, self.chassis)"},{"line_number":79,"context_line":"            chassis_private.delete()"},{"line_number":80,"context_line":"        except idlutils.RowNotFound:"},{"line_number":81,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b02bf9c_f9ca0b0a","line":78,"in_reply_to":"90d4fe0e_b7050091","updated":"2021-11-19 16:21:30.000000000","message":"\u003e From what I can tell, even though chassis-del upstream doesn\u0027t delete the chassis_private, I think it makes sense to do it.\n\u003e \n\u003e I wonder if we should make it configurable by adding delete_private\u003dTrue/False as a default argument? Opinions?\n\nI faced this when I removed a compute node and the `OpenStack network agent list` wasn\u0027t working because the node still existed in Chassis_private.\nI\u0027m OK with making it configurable. If you are let me know to change my PR.","commit_id":"cea583c60b6f764d824258607bbbe49b7c0482a8"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c434b5e0926ec9edaaec569fea318535fc25a722","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        chassis.delete()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            chassis_private \u003d self.api.lookup(\u0027Chassis_Private\u0027, self.chassis)"},{"line_number":79,"context_line":"            chassis_private.delete()"},{"line_number":80,"context_line":"        except idlutils.RowNotFound:"},{"line_number":81,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"ab6d0cad_d418d167","line":78,"in_reply_to":"9b02bf9c_f9ca0b0a","updated":"2024-03-27 21:10:55.000000000","message":"Done","commit_id":"cea583c60b6f764d824258607bbbe49b7c0482a8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e83f9ba87f878c591defb82891ad8aed2b56ca20","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        chassis.delete()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            chassis_private \u003d self.api.lookup(\u0027Chassis_Private\u0027, self.chassis)"},{"line_number":79,"context_line":"            chassis_private.delete()"},{"line_number":80,"context_line":"        except idlutils.RowNotFound:"},{"line_number":81,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"6ff273c3_f25165c8","line":78,"in_reply_to":"b53e7551_a4fbc8fd","updated":"2021-11-18 15:52:14.000000000","message":"In any case, I prefer Terry to review this patch first. I could make sense this operation (but we should document it).\n\nAnd we should review Neutron code that is deleting both \"chassis\" and \"chassis_private\" manually in two operations.","commit_id":"cea583c60b6f764d824258607bbbe49b7c0482a8"}]}