)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9b67d176501499c7b708c05fa81a2fcec60db1ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c2bf59a2_c7e2447c","updated":"2021-12-03 14:04:22.000000000","message":"This is exactly what I had in mind :) ","commit_id":"2ffe3322fffe6872ba73a93639772e951ade2fc7"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"44bbfe8ce95d406bf3dc140b6a654b5bcdf73556","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ce6eb1f0_72bf0de8","updated":"2021-12-03 05:38:33.000000000","message":"feel free to revert to the previous patch, but interesting that this patch affected the lsp_bind tests. they seem a bit fragile. other patches have affected then as well. this time they fail on my machine locally as well, but not if I run just them.","commit_id":"2ffe3322fffe6872ba73a93639772e951ade2fc7"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"488c0d2cc4df0d48f04e29e13bc6e63f5d84db32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f0f73568_16fbeff9","in_reply_to":"c2bf59a2_c7e2447c","updated":"2021-12-03 14:51:17.000000000","message":"yay! now if only we can make it work. :D","commit_id":"2ffe3322fffe6872ba73a93639772e951ade2fc7"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"5934e50fcb9a067e19b556eb8247895c4efc7d3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6bb3f096_3dd97010","updated":"2022-01-04 18:31:56.000000000","message":"recheck","commit_id":"8a21d5f3a3ef7ad86bbde0297b1073bc0f431f6c"}],"ovsdbapp/tests/functional/schema/ovn_ic_northbound/test_impl_idl.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9b67d176501499c7b708c05fa81a2fcec60db1ae","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    @classmethod"},{"line_number":24,"context_line":"    def setUpClass(cls):"},{"line_number":25,"context_line":"        super().setUpClass()"},{"line_number":26,"context_line":"        cls.schema_map[\u0027OVN_IC_Northbound\u0027] \u003d cls.ovsvenv.ovn_icnb_connection"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        if not self.ovsvenv.has_icnb():"}],"source_content_type":"text/x-python","patch_set":2,"id":"e69be1e3_8b9a0a48","line":26,"updated":"2021-12-03 14:04:22.000000000","message":"I think you need to make a copy of schema_map, because cls.schema_map is from FunctionalTestCase so some tests may have the schema map configured too depending on the order of execution.","commit_id":"2ffe3322fffe6872ba73a93639772e951ade2fc7"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"488c0d2cc4df0d48f04e29e13bc6e63f5d84db32","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    @classmethod"},{"line_number":24,"context_line":"    def setUpClass(cls):"},{"line_number":25,"context_line":"        super().setUpClass()"},{"line_number":26,"context_line":"        cls.schema_map[\u0027OVN_IC_Northbound\u0027] \u003d cls.ovsvenv.ovn_icnb_connection"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        if not self.ovsvenv.has_icnb():"}],"source_content_type":"text/x-python","patch_set":2,"id":"f389980f_bb38283f","line":26,"in_reply_to":"e69be1e3_8b9a0a48","updated":"2021-12-03 14:51:17.000000000","message":"ah, good point.","commit_id":"2ffe3322fffe6872ba73a93639772e951ade2fc7"}],"ovsdbapp/venv.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9b67d176501499c7b708c05fa81a2fcec60db1ae","unresolved":true,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"class OvsOvnIcVenvFixture(OvsOvnVenvFixture):"},{"line_number":237,"context_line":"    def _setUp(self):"},{"line_number":238,"context_line":"        if self.has_icnb():"},{"line_number":239,"context_line":"            super()._setUp()"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":2,"id":"db6becee_02e396a4","line":238,"updated":"2021-12-03 14:04:22.000000000","message":"do we need this? If someone instantiates this fixture, he/she should be already aware if he wants it or not.","commit_id":"2ffe3322fffe6872ba73a93639772e951ade2fc7"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"488c0d2cc4df0d48f04e29e13bc6e63f5d84db32","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"class OvsOvnIcVenvFixture(OvsOvnVenvFixture):"},{"line_number":237,"context_line":"    def _setUp(self):"},{"line_number":238,"context_line":"        if self.has_icnb():"},{"line_number":239,"context_line":"            super()._setUp()"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":2,"id":"582fda0d_d28e8cfe","line":238,"in_reply_to":"db6becee_02e396a4","updated":"2021-12-03 14:51:17.000000000","message":"We need a way to disable the tests that require IC as well. And detecting support for IC requires at least initing this fixture. So there will be tests that use it, but that shouldn\u0027t try to do anything at setUp because IC isn\u0027t supported. I\u0027m open to other solutions, though.","commit_id":"2ffe3322fffe6872ba73a93639772e951ade2fc7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ecdb7714f2052c7bb520efdba8d2fb713c679c77","unresolved":true,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"class OvsOvnIcVenvFixture(OvsOvnVenvFixture):"},{"line_number":237,"context_line":"    def _setUp(self):"},{"line_number":238,"context_line":"        if self.has_icnb():"},{"line_number":239,"context_line":"            super()._setUp()"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @property"},{"line_number":242,"context_line":"    def ovn_icnb_connection(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"72272788_e1c3e952","line":239,"range":{"start_line":238,"start_character":0,"end_line":239,"end_character":28},"updated":"2021-12-08 22:11:32.000000000","message":"I would rather fail here with an exception if somebody tries to spawn a fixture on OVN that doesn\u0027t have the schema.","commit_id":"8a21d5f3a3ef7ad86bbde0297b1073bc0f431f6c"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"b999e2226e6094c540b5f5ada1bd08d52c115db9","unresolved":true,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"class OvsOvnIcVenvFixture(OvsOvnVenvFixture):"},{"line_number":237,"context_line":"    def _setUp(self):"},{"line_number":238,"context_line":"        if self.has_icnb():"},{"line_number":239,"context_line":"            super()._setUp()"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @property"},{"line_number":242,"context_line":"    def ovn_icnb_connection(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"131185e3_d8a4c869","line":239,"range":{"start_line":238,"start_character":0,"end_line":239,"end_character":28},"in_reply_to":"72272788_e1c3e952","updated":"2021-12-10 13:53:18.000000000","message":"The problem is that if we do that, then super().setUpClass() for ovn-ic-nb tests will fail when it tries to create the DBs in setup_dbs() (the problem this patch is trying to fix). And it\u0027ll do so after going to the trouble of creating north/south dbs, etc., but before we can politely skip the tests in setUp(). It\u0027s a little tricky and I had very little time to work on it before PTO, so I went with what I could get to work.\n\nIf you want to do some testing to find different ways to do things while I\u0027m away, you can just:\n\n mv .tox/functional/src/ovn/ovn-ic-nb.ovsscheama{,.bak}\n\nand run the ovn_ic_northbound tests.","commit_id":"8a21d5f3a3ef7ad86bbde0297b1073bc0f431f6c"}]}