)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"8acf53eac9649e293ea95c7b85e19bdfc4db507c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9b3f534f_37ff76fd","updated":"2022-01-04 16:07:23.000000000","message":"recheck","commit_id":"358d1a5bbafcd7af9033a1a4fbca35a61f99b7cd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dacbd899cf092d0ae541486e390d0844b37402f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"aac1950d_c57dff6a","updated":"2021-12-22 23:58:40.000000000","message":"recheck","commit_id":"358d1a5bbafcd7af9033a1a4fbca35a61f99b7cd"}],"ovsdbapp/tests/functional/backend/ovs_idl/test_backend.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"42a6f0df5457f4e3d9ec54a744d1b77c168e8b5d","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super(TestOvnNbIndex, self).setUp()"},{"line_number":28,"context_line":"        self.api \u003d impl_idl.OvnNbApiIdlImpl(self.connection)"},{"line_number":29,"context_line":"        self.addCleanup(self.api._reset_connection)"},{"line_number":30,"context_line":"        self.lsp_name \u003d str(uuid.uuid4())"},{"line_number":31,"context_line":"        self.a \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"92fde3a6_91e748c6","line":28,"range":{"start_line":28,"start_character":28,"end_line":28,"end_character":43},"updated":"2021-12-03 19:30:39.000000000","message":"the bonus would be to make this api wrapped into a fixture so we won\u0027t to explicitly call the _reset 😊","commit_id":"4278c3e5b5e4a76e81bf5a11cb1a1c5915540814"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"2f2544a59045a16272c04371d69207fa2bb1893f","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super(TestOvnNbIndex, self).setUp()"},{"line_number":28,"context_line":"        self.api \u003d impl_idl.OvnNbApiIdlImpl(self.connection)"},{"line_number":29,"context_line":"        self.addCleanup(self.api._reset_connection)"},{"line_number":30,"context_line":"        self.lsp_name \u003d str(uuid.uuid4())"},{"line_number":31,"context_line":"        self.a \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"6a28feec_032bbe4d","line":28,"range":{"start_line":28,"start_character":28,"end_line":28,"end_character":43},"in_reply_to":"045bf710_4c4a96f1","updated":"2021-12-05 22:22:47.000000000","message":"Done","commit_id":"4278c3e5b5e4a76e81bf5a11cb1a1c5915540814"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"3e4408a00421cbd1f67fa5d20f21f6acf1266951","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super(TestOvnNbIndex, self).setUp()"},{"line_number":28,"context_line":"        self.api \u003d impl_idl.OvnNbApiIdlImpl(self.connection)"},{"line_number":29,"context_line":"        self.addCleanup(self.api._reset_connection)"},{"line_number":30,"context_line":"        self.lsp_name \u003d str(uuid.uuid4())"},{"line_number":31,"context_line":"        self.a \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"045bf710_4c4a96f1","line":28,"range":{"start_line":28,"start_character":28,"end_line":28,"end_character":43},"in_reply_to":"92fde3a6_91e748c6","updated":"2021-12-03 19:35:59.000000000","message":"👍","commit_id":"4278c3e5b5e4a76e81bf5a11cb1a1c5915540814"}],"ovsdbapp/tests/functional/schema/fixtures.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"6a618db90bb96e37054e5330d792bb5cf78f0bbc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        # Create a class for api_cls that has no ovsdb_connection property"},{"line_number":45,"context_line":"        # which creates singleton attribute that is stored on the class which"},{"line_number":46,"context_line":"        # different tests running in the same process can trample on"},{"line_number":47,"context_line":"        self.cls \u003d type(\u0027Test\u0027 + self.api_cls.__name__, (self.api_cls,),"},{"line_number":48,"context_line":"                        {\u0027ovsdb_connection\u0027: None})"},{"line_number":49,"context_line":"        delattr(self.cls, \u0027ovsdb_connection\u0027)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"956b39bd_70c4c5f3","line":47,"updated":"2021-12-04 00:41:27.000000000","message":"It occurs to me that since we are creating an new class here for each fixture, no tests will share the same class and deleting the ovsdb_connection isn\u0027t strictly necessary. Not that it hurts anything either.","commit_id":"afe5bc315f773e86c872079be6c335100c1fb4e1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"945280798776386d5232c7efe7367e1d95e8b7a1","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        self.cls \u003d type(\u0027Test\u0027 + self.api_cls.__name__, (self.api_cls,), {})"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _setUp(self):"},{"line_number":50,"context_line":"        self.obj \u003d self.cls(*self.args, **self.kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"59b9fee6_14bfa359","line":50,"updated":"2021-12-09 08:33:21.000000000","message":"If we are going to create a connection and an IDL per class, shouldn\u0027t we close it after each test? If not, that will keep too many connections open, regardless of having an independent OVN fixture env per test.\n\nNot related: shouldn\u0027t we delete the OVN fixture environment after each test?","commit_id":"358d1a5bbafcd7af9033a1a4fbca35a61f99b7cd"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"6c6f868814e30471ff61669e0314edf4434d2a1e","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        self.cls \u003d type(\u0027Test\u0027 + self.api_cls.__name__, (self.api_cls,), {})"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _setUp(self):"},{"line_number":50,"context_line":"        self.obj \u003d self.cls(*self.args, **self.kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"97e16d92_4bfc24ac","line":50,"in_reply_to":"59b9fee6_14bfa359","updated":"2021-12-10 13:58:38.000000000","message":"re: closing, I remember trying it and things still failing miserably. It\u0027s possible it was a previous iteration and things would now work, but it\u0027s easy enough to test (by someone not on PTO) 😄\n\nre: deleting the environment, ovsdbapp went with the model (at least tried to before this patch) of having an environment per class instead of the overhead of doing an environment per test. It\u0027s easy enough to write tests in a class that don\u0027t step on each other, and the benefit is the functional tests run in ~10s.","commit_id":"358d1a5bbafcd7af9033a1a4fbca35a61f99b7cd"}]}