)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"49cb16a2b951cd60783137ebe5532a48b21b1f08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e966db4f_76fe14b1","updated":"2022-01-21 13:22:51.000000000","message":"Nice addition","commit_id":"7bc5b8c4d29df45271771a6967aaeed02b7bd5fa"}],"ovsdbapp/backend/ovs_idl/transaction.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"b4e9574e63975227583f76ccac2c679b0fe47928","unresolved":true,"context_lines":[{"line_number":93,"context_line":"                    command.run_idl(txn)"},{"line_number":94,"context_line":"                except Exception as e:"},{"line_number":95,"context_line":"                    txn.abort()"},{"line_number":96,"context_line":"                    LOG.debug(\"txn n\u003d%(n)d command(idx\u003d%(idx)s): %(cmd)s \","},{"line_number":97,"context_line":"                              \"aborted due to error: %(err)s\","},{"line_number":98,"context_line":"                              {\u0027idx\u0027: i,"},{"line_number":99,"context_line":"                               \u0027cmd\u0027: command,"}],"source_content_type":"text/x-python","patch_set":1,"id":"39136a92_82232a99","line":96,"updated":"2022-01-21 16:34:08.000000000","message":"Should we wrap this in:\n\n if self.log_errors:\n     ...\n\nIt seems like if we specifically have an option that defaults to True and have set it to False, we should obey it and not log.","commit_id":"7bc5b8c4d29df45271771a6967aaeed02b7bd5fa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6bc6ca727f4e64133ad7e14650c582caa0084bda","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                    command.run_idl(txn)"},{"line_number":94,"context_line":"                except Exception as e:"},{"line_number":95,"context_line":"                    txn.abort()"},{"line_number":96,"context_line":"                    LOG.debug(\"txn n\u003d%(n)d command(idx\u003d%(idx)s): %(cmd)s \","},{"line_number":97,"context_line":"                              \"aborted due to error: %(err)s\","},{"line_number":98,"context_line":"                              {\u0027idx\u0027: i,"},{"line_number":99,"context_line":"                               \u0027cmd\u0027: command,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6ca96f39_f9ec0577","line":96,"in_reply_to":"2c26b154_fac54d45","updated":"2022-01-24 09:01:46.000000000","message":"Done","commit_id":"7bc5b8c4d29df45271771a6967aaeed02b7bd5fa"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"f5272b026805d6d8ee9caf27123d5a870b3cf0e7","unresolved":true,"context_lines":[{"line_number":93,"context_line":"                    command.run_idl(txn)"},{"line_number":94,"context_line":"                except Exception as e:"},{"line_number":95,"context_line":"                    txn.abort()"},{"line_number":96,"context_line":"                    LOG.debug(\"txn n\u003d%(n)d command(idx\u003d%(idx)s): %(cmd)s \","},{"line_number":97,"context_line":"                              \"aborted due to error: %(err)s\","},{"line_number":98,"context_line":"                              {\u0027idx\u0027: i,"},{"line_number":99,"context_line":"                               \u0027cmd\u0027: command,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2c26b154_fac54d45","line":96,"in_reply_to":"39136a92_82232a99","updated":"2022-01-21 16:40:57.000000000","message":"Also, if we are checking log_errors, it might even make since to log at a higher level than debug. But only in the case that check_error\u003dFalse and log_errors\u003dTrue, otherwise we\u0027ll get two log messages I think.\n\nso maybe:\n\n except Exception as e:\n     txn.abort()\n     if self.check_error:\n         raise\n     if self.log_errors:\n         LOG.error(...)","commit_id":"7bc5b8c4d29df45271771a6967aaeed02b7bd5fa"}]}