)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"556322b63a9f5d4cbfce722f3659d3d624c682ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"31b7b521_eec059db","updated":"2022-03-24 18:44:48.000000000","message":"If this is something specific for how neutron/os-vif are doing things, I\u0027d rather keep it out of the ovsdbapp reference implementation if at all possible.\n\nIt seems like os-vif and neutron should just decide who is in charge of creating/deleting these specific bridges. When we talked about this earlier, it sounded like it was going to be possible to just have neutron let os-vif handle vhostuser bridge creation/deletion. Did that not work out?","commit_id":"27f052de06d9f09aabfb7f881fe2068fff268e58"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0f63721cbeeb2a70b628f66ff9115dab0af1409a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd5a53ca_9110789d","in_reply_to":"31b7b521_eec059db","updated":"2022-03-24 23:03:37.000000000","message":"Thanks for your review. I see and understand your point. I just want to have a discussion over code on the best way to fix this issue. I invited Rodolfo to comment. I just fixed pep8 issues in PS2. I invite you to -1 it again to record your disagreement. Let\u0027s see what Rodolfo has to say","commit_id":"27f052de06d9f09aabfb7f881fe2068fff268e58"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"de0253a465225cbfb7bda7f1a5f5a8acda8e8922","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1af6a982_4e499341","updated":"2022-03-25 13:28:17.000000000","message":"In general, we try to avoid setting specific external_ids in ovsdbapp. Its job is to allow users to set the things they want in the database, not force them into specific paradigms. Normally if os-vif/neutron wanted to set/read these values, they\u0027d just go ahead and do that on their own outside of ovsdbapp.\n\nWith that said, I\u0027m always a bit skeptical when I see multiple processes or machines relying on timestamps. Especially with OVSDB since there can be a significant delay between two different connections getting updates from the server.\n\nI seem to remember looking at the os-vif code and thinking that for vhostuser it could handle the create/delete of the Bridge, then in neutron since we would know whether or not it was vhostuser we could just not create/delete in that case and not have to worry about synchronization. But that was also a while ago, and I realize I haven\u0027t looked at this issue nearly as much as the rest of you. ;)","commit_id":"093932ff80f0442b06816eadf4283cd7ee50a7d2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8294263fa9a3ad07a143d7d388b7998863dc6fc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a1983df0_6cd12891","updated":"2022-08-16 14:10:21.000000000","message":"Is this patch still valid?","commit_id":"093932ff80f0442b06816eadf4283cd7ee50a7d2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"258855d887779c721a55fa7408ab820863cf8c9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"640909b0_c532ee34","updated":"2022-03-25 22:02:48.000000000","message":"Terry and Sean, thanks for your comments.\n\nI had a conversation with Sean and it seems it will be possible to have os-vif both create and delete the bridge, as long as Neutron communicates the name of the integration bridge. So I\u0027m going to mark this patch as WIP and I\u0027m going to propose a session during the Neutron PTG to get everybody on-board with the idea that for trunks os-vif will create and delete the corresponding bridge","commit_id":"093932ff80f0442b06816eadf4283cd7ee50a7d2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"07ca1b26e80f175ea30b485cfeb2796f58431fbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"90d280f9_9dfdee11","in_reply_to":"1af6a982_4e499341","updated":"2022-03-25 13:43:04.000000000","message":"we cant delete the bridge today becasue we dont know if its the integration bridge\nhowever nutron coudl tell use to delete the bridge or not in the binding details if it did that nova coudl pass that to os-vif and it could certenly then safely delete it.\n\nthe other option would be to list the integration bridge in the os-vif config and then os-vif woudl only delete the bridge if it did not match.\nthat could be a backportable workaround to enabel os-vif to do bridge deletion in this case.","commit_id":"093932ff80f0442b06816eadf4283cd7ee50a7d2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f3c85c9557891e581ad47927549ae29c40b1f8e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"888d2f0e_8e9cf318","in_reply_to":"a1983df0_6cd12891","updated":"2022-08-22 08:06:44.000000000","message":"and do we want it to be in last Zed release?","commit_id":"093932ff80f0442b06816eadf4283cd7ee50a7d2"}]}