)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e141a7eb10792fd9bc727d2e3d25e996a44e6b3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0d0966bc_15752acc","updated":"2022-03-29 20:15:57.000000000","message":"Code looks good, just an idea we should be more explicit about what happened to the removed parameters in the logs.","commit_id":"fef18708eaab2c4abffdd40e093dc8ad99fdbe55"}],"ovsdbapp/backend/ovs_idl/__init__.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e141a7eb10792fd9bc727d2e3d25e996a44e6b3e","unresolved":true,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def lookup(self, table, record, default\u003d_NO_DEFAULT, timeout\u003dNone,"},{"line_number":175,"context_line":"               notify_handler\u003dNone):"},{"line_number":176,"context_line":"        if (timeout or notify_handler):"},{"line_number":177,"context_line":"            LOG.warning(\"The timeout and notify_handler parameters have been \""},{"line_number":178,"context_line":"                        \"removed.\")"},{"line_number":179,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"0b8fea37_3c4030b6","line":176,"range":{"start_line":176,"start_character":11,"end_line":176,"end_character":12},"updated":"2022-03-29 20:15:57.000000000","message":"nit: parens not needed","commit_id":"fef18708eaab2c4abffdd40e093dc8ad99fdbe55"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1feea36e4cd21797856ebed64aaa8ad446b2c6b1","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def lookup(self, table, record, default\u003d_NO_DEFAULT, timeout\u003dNone,"},{"line_number":175,"context_line":"               notify_handler\u003dNone):"},{"line_number":176,"context_line":"        if (timeout or notify_handler):"},{"line_number":177,"context_line":"            LOG.warning(\"The timeout and notify_handler parameters have been \""},{"line_number":178,"context_line":"                        \"removed.\")"},{"line_number":179,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"0205deda_91c805ab","line":176,"range":{"start_line":176,"start_character":11,"end_line":176,"end_character":12},"in_reply_to":"0b8fea37_3c4030b6","updated":"2022-03-30 16:06:18.000000000","message":"Done","commit_id":"fef18708eaab2c4abffdd40e093dc8ad99fdbe55"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e141a7eb10792fd9bc727d2e3d25e996a44e6b3e","unresolved":true,"context_lines":[{"line_number":175,"context_line":"               notify_handler\u003dNone):"},{"line_number":176,"context_line":"        if (timeout or notify_handler):"},{"line_number":177,"context_line":"            LOG.warning(\"The timeout and notify_handler parameters have been \""},{"line_number":178,"context_line":"                        \"removed.\")"},{"line_number":179,"context_line":"        try:"},{"line_number":180,"context_line":"            with self.ovsdb_connection.lock:"},{"line_number":181,"context_line":"                return self._lookup(table, record)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c9e18ef4_1e4bb2a3","line":178,"updated":"2022-03-29 20:15:57.000000000","message":"Maybe we can be more verbose? It sounds to me like somebody removed parameters I just passed to the functions and that\u0027s confusing. Maybe something like \"Timeout and notify_handler parameters are not used in the code - please update calls to lookup() that pass timeout or notify_handler in your code.\" ?","commit_id":"fef18708eaab2c4abffdd40e093dc8ad99fdbe55"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1feea36e4cd21797856ebed64aaa8ad446b2c6b1","unresolved":false,"context_lines":[{"line_number":175,"context_line":"               notify_handler\u003dNone):"},{"line_number":176,"context_line":"        if (timeout or notify_handler):"},{"line_number":177,"context_line":"            LOG.warning(\"The timeout and notify_handler parameters have been \""},{"line_number":178,"context_line":"                        \"removed.\")"},{"line_number":179,"context_line":"        try:"},{"line_number":180,"context_line":"            with self.ovsdb_connection.lock:"},{"line_number":181,"context_line":"                return self._lookup(table, record)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c249174e_18e91600","line":178,"in_reply_to":"c9e18ef4_1e4bb2a3","updated":"2022-03-30 16:06:18.000000000","message":"Done","commit_id":"fef18708eaab2c4abffdd40e093dc8ad99fdbe55"}]}