)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"eaa6ff354e7ddaadbadb0fa031290a53d910825b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f65649d3_9d260a58","updated":"2023-01-30 16:29:26.000000000","message":"Thanks Rodolfo for fixing the bug. I\u0027m wondering if we\u0027re missing some functional tests that would cover we return the right thing.","commit_id":"ac65f8b55b23960b698cde111fb3e9fbec983726"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f5dacdd1d5433193a85f73d4d6646c5ab7ee308c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c2968449_10dc6062","in_reply_to":"3e631fe4_4abf7170","updated":"2023-01-31 09:47:51.000000000","message":"I\u0027ve added a note in the commit message.","commit_id":"ac65f8b55b23960b698cde111fb3e9fbec983726"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7c28b471c5667d13bb9c83bec693c7730a8b046e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e631fe4_4abf7170","in_reply_to":"f65649d3_9d260a58","updated":"2023-01-30 17:08:18.000000000","message":"Right, I\u0027ll add the corresponding FT tests. My main concern here is the Neutron CI. We have a job reading from ovsdbapp master. Before releasing a new ovsdbapp version, we\u0027ll need to check it.","commit_id":"ac65f8b55b23960b698cde111fb3e9fbec983726"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f9d23074cefaf9425ca326c9f505d6a61c43aa87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1021cb2e_7096850c","updated":"2023-02-01 10:22:54.000000000","message":"good catch","commit_id":"4821a9ffc0d2aacf683ef9c030b0a1e0f3268fbd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c76e8e628cf925610b6f312a498d341d9980feaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d9231d3a_7cf2d558","updated":"2023-02-23 11:01:42.000000000","message":"Ok, let\u0027s go for this one now.","commit_id":"019f0a2acb8696c6a05646be3f0634c1d638ddee"}],"ovsdbapp/schema/ovn_northbound/commands.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e6db997e26cb8ddfee10812a009cb0344c4e7caa","unresolved":false,"context_lines":[{"line_number":1447,"context_line":"        lb.delkey(\u0027ip_port_mappings\u0027, self.endpoint_ip)"},{"line_number":1448,"context_line":""},{"line_number":1449,"context_line":""},{"line_number":1450,"context_line":"class HealthCheckAddCommand(cmd.AddCommand):"},{"line_number":1451,"context_line":"    table_name \u003d \u0027Load_Balancer_Health_Check\u0027"},{"line_number":1452,"context_line":""},{"line_number":1453,"context_line":"    def __init__(self, api, vip, **options):"}],"source_content_type":"text/x-python","patch_set":3,"id":"caa963a4_d813f54b","line":1450,"updated":"2023-02-06 18:06:43.000000000","message":"Ultimately used in lb_add_health_check, I don\u0027t actually see this called anywhere outside of test code:\n\nhttps://codesearch.openstack.org/?q\u003dlb_add_health_check\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"019f0a2acb8696c6a05646be3f0634c1d638ddee"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e6db997e26cb8ddfee10812a009cb0344c4e7caa","unresolved":false,"context_lines":[{"line_number":1749,"context_line":"        gwc.chassis_name \u003d self.chassis_name"},{"line_number":1750,"context_line":"        gwc.priority \u003d self.priority"},{"line_number":1751,"context_line":"        self.set_columns(gwc, **self.columns)"},{"line_number":1752,"context_line":"        self.result \u003d gwc.uuid"},{"line_number":1753,"context_line":""},{"line_number":1754,"context_line":""},{"line_number":1755,"context_line":"class HAChassisGroupAddCommand(cmd.AddCommand):"}],"source_content_type":"text/x-python","patch_set":3,"id":"898462ee_9e40d628","line":1752,"updated":"2023-02-06 18:06:43.000000000","message":"This one looked a little concerning because [1] looks like it would expect a row, but python-ovs [2] just uses the row to convert to a uuid, and if it isn\u0027t row [3] just returns whatever we pass--which in this case is the UUID that would be expected to return. So given that it is passing functional tests, it *looks* safe. But given _row_to_uuid() is an internal function and isn\u0027t really documented with any guarantees as to behavior, it\u0027s at least theoretically possible it could break in a new release. But it should also be noted that that code has pretty much never changed.\n\n[1] https://opendev.org/openstack/ovsdbapp/src/commit/7733f0c5364de3805d7f8d5be429e0a464a7c6b1/ovsdbapp/schema/ovn_northbound/commands.py#L876\n\n[2] https://github.com/openvswitch/ovs/blob/e85e8a7541cbe7d9c57bd34ae99d47edad92f111/python/ovs/db/idl.py#L1410\n\n[3] https://github.com/openvswitch/ovs/blob/e85e8a7541cbe7d9c57bd34ae99d47edad92f111/python/ovs/db/idl.py#L1187","commit_id":"019f0a2acb8696c6a05646be3f0634c1d638ddee"}]}