)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7343dec10389ec7b835f1785988e864467ee73f9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Terry Wilson \u003ctwilson@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-17 17:31:29 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add if_exsits and **kwargs columns to db_set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The original API for db_set() out of an over-abundance of caution"},{"line_number":10,"context_line":"use *args tuples in the format of (\u0027column_name\u0027, value) due to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ee0be801_e4fa1399","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":13},"updated":"2023-04-18 15:52:13.000000000","message":"nit: if_exists","commit_id":"f5c1ba873217c4b258dc456cd09767044e769a6f"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"4b429f040d8ef9a06714b21a3d6fe1389d79bfab","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Terry Wilson \u003ctwilson@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-17 17:31:29 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add if_exsits and **kwargs columns to db_set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The original API for db_set() out of an over-abundance of caution"},{"line_number":10,"context_line":"use *args tuples in the format of (\u0027column_name\u0027, value) due to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"215a83f8_5a553f8c","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":13},"in_reply_to":"ee0be801_e4fa1399","updated":"2023-04-19 00:44:57.000000000","message":"Done","commit_id":"f5c1ba873217c4b258dc456cd09767044e769a6f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"335f62b14a9f3af966b35f2fa85a530d47ab6cdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e0ab552b_1b2a34ee","updated":"2023-04-19 06:16:05.000000000","message":"I was going to ask why if_exists was needed on a db set instead of failing with NotExists or something, but that is already explained in the commit message. LGTM","commit_id":"5bd0bb9857f847293ab120fecc481e63b1cc1e94"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"379623b39134c90a4b6ea951ebbb48ce198383d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"07d93fed_e8b34ccc","updated":"2023-04-19 15:23:16.000000000","message":"Waiting for the CI but code looks good.","commit_id":"6ab3f75388f583c99ac38d9c651f2529d68b617f"}],"ovsdbapp/api.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e28489ddb28c6f3064f556a84a3d559da88b024c","unresolved":true,"context_lines":[{"line_number":167,"context_line":"        :param columns:    The columns and their associated values"},{"line_number":168,"context_line":"                           (mutually exclusive with col_values and col_values"},{"line_number":169,"context_line":"                           is used if available)"},{"line_number":170,"context_line":"        :type columns:      Dictionary of columns names and values"},{"line_number":171,"context_line":"        :returns:          :class:`Command` with no result"},{"line_number":172,"context_line":"        \"\"\""},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d6ae03cc_f7c798e1","line":170,"range":{"start_line":170,"start_character":27,"end_line":170,"end_character":28},"updated":"2023-04-18 17:56:00.000000000","message":"nit: Too many spaces","commit_id":"f5c1ba873217c4b258dc456cd09767044e769a6f"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"4b429f040d8ef9a06714b21a3d6fe1389d79bfab","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        :param columns:    The columns and their associated values"},{"line_number":168,"context_line":"                           (mutually exclusive with col_values and col_values"},{"line_number":169,"context_line":"                           is used if available)"},{"line_number":170,"context_line":"        :type columns:      Dictionary of columns names and values"},{"line_number":171,"context_line":"        :returns:          :class:`Command` with no result"},{"line_number":172,"context_line":"        \"\"\""},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a9168689_63d087a4","line":170,"range":{"start_line":170,"start_character":27,"end_line":170,"end_character":28},"in_reply_to":"d6ae03cc_f7c798e1","updated":"2023-04-19 00:44:57.000000000","message":"Done","commit_id":"f5c1ba873217c4b258dc456cd09767044e769a6f"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"335f62b14a9f3af966b35f2fa85a530d47ab6cdd","unresolved":true,"context_lines":[{"line_number":159,"context_line":"        :type table:       string"},{"line_number":160,"context_line":"        :param record:     The record id (name/uuid) to be modified"},{"line_number":161,"context_line":"        :type table:       string"},{"line_number":162,"context_line":"        :param if_exists:  Do not fail if record does not exist"},{"line_number":163,"context_line":"        :type if_exists:   bool"},{"line_number":164,"context_line":"        :param col_values: The columns and their associated values"},{"line_number":165,"context_line":"        :type col_values:  Tuples of (column, value). Values may be atomic"},{"line_number":166,"context_line":"                           values or unnested sequences/mappings"}],"source_content_type":"text/x-python","patch_set":2,"id":"b7cda951_7435bba0","line":163,"range":{"start_line":162,"start_character":1,"end_line":163,"end_character":31},"updated":"2023-04-19 06:16:05.000000000","message":"nit, not in the same order as the parameters in L155","commit_id":"5bd0bb9857f847293ab120fecc481e63b1cc1e94"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"83134a348f621f398b57c494d6beb215cece5f08","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        :type table:       string"},{"line_number":160,"context_line":"        :param record:     The record id (name/uuid) to be modified"},{"line_number":161,"context_line":"        :type table:       string"},{"line_number":162,"context_line":"        :param if_exists:  Do not fail if record does not exist"},{"line_number":163,"context_line":"        :type if_exists:   bool"},{"line_number":164,"context_line":"        :param col_values: The columns and their associated values"},{"line_number":165,"context_line":"        :type col_values:  Tuples of (column, value). Values may be atomic"},{"line_number":166,"context_line":"                           values or unnested sequences/mappings"}],"source_content_type":"text/x-python","patch_set":2,"id":"0ba8fbc8_ba80884c","line":163,"range":{"start_line":162,"start_character":1,"end_line":163,"end_character":31},"in_reply_to":"b7cda951_7435bba0","updated":"2023-04-19 14:34:27.000000000","message":"Done","commit_id":"5bd0bb9857f847293ab120fecc481e63b1cc1e94"}],"ovsdbapp/backend/ovs_idl/command.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"84c4a60bf2db35f01280989f07fd37f688f257db","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        self.table \u003d table"},{"line_number":144,"context_line":"        self.record \u003d record"},{"line_number":145,"context_line":"        self.col_values \u003d col_values or columns.items()"},{"line_number":146,"context_line":"        self.if_exists \u003d if_exists"},{"line_number":147,"context_line":"        self.columns \u003d columns"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def run_idl(self, txn):"}],"source_content_type":"text/x-python","patch_set":1,"id":"8b31b953_d47d6d3f","line":146,"updated":"2023-04-18 15:51:59.000000000","message":"Where are we using this?","commit_id":"f5c1ba873217c4b258dc456cd09767044e769a6f"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"4b429f040d8ef9a06714b21a3d6fe1389d79bfab","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        self.table \u003d table"},{"line_number":144,"context_line":"        self.record \u003d record"},{"line_number":145,"context_line":"        self.col_values \u003d col_values or columns.items()"},{"line_number":146,"context_line":"        self.if_exists \u003d if_exists"},{"line_number":147,"context_line":"        self.columns \u003d columns"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def run_idl(self, txn):"}],"source_content_type":"text/x-python","patch_set":1,"id":"67f40b5c_12fd8e2d","line":146,"in_reply_to":"8b31b953_d47d6d3f","updated":"2023-04-19 00:44:57.000000000","message":"There is an upcoming patch where it will be used to fix an issue with ACL logging.","commit_id":"f5c1ba873217c4b258dc456cd09767044e769a6f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e28489ddb28c6f3064f556a84a3d559da88b024c","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        self.record \u003d record"},{"line_number":145,"context_line":"        self.col_values \u003d col_values or columns.items()"},{"line_number":146,"context_line":"        self.if_exists \u003d if_exists"},{"line_number":147,"context_line":"        self.columns \u003d columns"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def run_idl(self, txn):"},{"line_number":150,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"563cbbb2_77d22124","line":147,"updated":"2023-04-18 17:56:00.000000000","message":"You mean this, right? 😊","commit_id":"f5c1ba873217c4b258dc456cd09767044e769a6f"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"4b429f040d8ef9a06714b21a3d6fe1389d79bfab","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self.record \u003d record"},{"line_number":145,"context_line":"        self.col_values \u003d col_values or columns.items()"},{"line_number":146,"context_line":"        self.if_exists \u003d if_exists"},{"line_number":147,"context_line":"        self.columns \u003d columns"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def run_idl(self, txn):"},{"line_number":150,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"2f3955b0_a9c06e01","line":147,"in_reply_to":"563cbbb2_77d22124","updated":"2023-04-19 00:44:57.000000000","message":"Yeah, I can drop that. It was from a previous iteration. Done.","commit_id":"f5c1ba873217c4b258dc456cd09767044e769a6f"}],"ovsdbapp/tests/functional/schema/open_vswitch/test_common_db.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"84c4a60bf2db35f01280989f07fd37f688f257db","unresolved":true,"context_lines":[{"line_number":113,"context_line":"            \u0027Queue\u0027, external_ids\u003d{\u0027x\u0027: \u0027x\u0027}).execute(check_error\u003dTrue)"},{"line_number":114,"context_line":"        self.assertIsInstance(row, rowview.RowView)"},{"line_number":115,"context_line":"        self.api.db_destroy(\u0027Queue\u0027, row.uuid).execute(check_error\u003dTrue)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_db_set_args(self):"},{"line_number":118,"context_line":"        brname \u003d self.bridges[0][\u0027name\u0027]"},{"line_number":119,"context_line":"        br \u003d self.api.lookup(\u0027Bridge\u0027, brname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3757d463_14db6635","line":116,"updated":"2023-04-18 15:51:59.000000000","message":"Why don\u0027t you check when passing \"col_values\" and \"columns\"?","commit_id":"f5c1ba873217c4b258dc456cd09767044e769a6f"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"4b429f040d8ef9a06714b21a3d6fe1389d79bfab","unresolved":true,"context_lines":[{"line_number":113,"context_line":"            \u0027Queue\u0027, external_ids\u003d{\u0027x\u0027: \u0027x\u0027}).execute(check_error\u003dTrue)"},{"line_number":114,"context_line":"        self.assertIsInstance(row, rowview.RowView)"},{"line_number":115,"context_line":"        self.api.db_destroy(\u0027Queue\u0027, row.uuid).execute(check_error\u003dTrue)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_db_set_args(self):"},{"line_number":118,"context_line":"        brname \u003d self.bridges[0][\u0027name\u0027]"},{"line_number":119,"context_line":"        br \u003d self.api.lookup(\u0027Bridge\u0027, brname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9182a4cc_883f7f68","line":116,"in_reply_to":"3757d463_14db6635","updated":"2023-04-19 00:44:57.000000000","message":"I\u0027m sorry, I don\u0027t understand the question. The first added test uses col_values, and the rest are using columns.","commit_id":"f5c1ba873217c4b258dc456cd09767044e769a6f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"473a8f5f77b09d631e5286c2531f11e9ecaced0e","unresolved":true,"context_lines":[{"line_number":113,"context_line":"            \u0027Queue\u0027, external_ids\u003d{\u0027x\u0027: \u0027x\u0027}).execute(check_error\u003dTrue)"},{"line_number":114,"context_line":"        self.assertIsInstance(row, rowview.RowView)"},{"line_number":115,"context_line":"        self.api.db_destroy(\u0027Queue\u0027, row.uuid).execute(check_error\u003dTrue)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_db_set_args(self):"},{"line_number":118,"context_line":"        brname \u003d self.bridges[0][\u0027name\u0027]"},{"line_number":119,"context_line":"        br \u003d self.api.lookup(\u0027Bridge\u0027, brname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a882eb56_4a41e97e","line":116,"in_reply_to":"9182a4cc_883f7f68","updated":"2023-04-19 11:42:04.000000000","message":"What I\u0027m saying is that you never tested passing \"col_values\" and \"columns\" at the same time. These are mutually exclusive and that should be tested.","commit_id":"f5c1ba873217c4b258dc456cd09767044e769a6f"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"b90931c6682aabbe65cb8f468c7f59f43aa3ee08","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            \u0027Queue\u0027, external_ids\u003d{\u0027x\u0027: \u0027x\u0027}).execute(check_error\u003dTrue)"},{"line_number":114,"context_line":"        self.assertIsInstance(row, rowview.RowView)"},{"line_number":115,"context_line":"        self.api.db_destroy(\u0027Queue\u0027, row.uuid).execute(check_error\u003dTrue)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_db_set_args(self):"},{"line_number":118,"context_line":"        brname \u003d self.bridges[0][\u0027name\u0027]"},{"line_number":119,"context_line":"        br \u003d self.api.lookup(\u0027Bridge\u0027, brname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bd3fbc94_0c98df8b","line":116,"in_reply_to":"a882eb56_4a41e97e","updated":"2023-04-19 13:36:20.000000000","message":"Ah, yes. You are right. I\u0027ll add that. Thanks!","commit_id":"f5c1ba873217c4b258dc456cd09767044e769a6f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"84c4a60bf2db35f01280989f07fd37f688f257db","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        ext_ids \u003d {\u0027test\u0027: \u0027value\u0027}"},{"line_number":144,"context_line":"        self.api.db_set(\u0027Bridge\u0027, brname, if_exists\u003dTrue,"},{"line_number":145,"context_line":"                        external_ids\u003dext_ids).execute(check_error\u003dTrue)"},{"line_number":146,"context_line":"        # didn\u0027t fail"}],"source_content_type":"text/x-python","patch_set":1,"id":"d49e935d_6106d69e","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":7},"updated":"2023-04-18 15:51:59.000000000","message":"nit: is this comment needed?","commit_id":"f5c1ba873217c4b258dc456cd09767044e769a6f"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"4b429f040d8ef9a06714b21a3d6fe1389d79bfab","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        ext_ids \u003d {\u0027test\u0027: \u0027value\u0027}"},{"line_number":144,"context_line":"        self.api.db_set(\u0027Bridge\u0027, brname, if_exists\u003dTrue,"},{"line_number":145,"context_line":"                        external_ids\u003dext_ids).execute(check_error\u003dTrue)"},{"line_number":146,"context_line":"        # didn\u0027t fail"}],"source_content_type":"text/x-python","patch_set":1,"id":"55d779a4_7709132f","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":7},"in_reply_to":"d49e935d_6106d69e","updated":"2023-04-19 00:44:57.000000000","message":"It seemed useful since we aren\u0027t asserting anything about the last run and I figured letting people know \"we\u0027re just testing that this doesn\u0027t throw an exception\" might be useful. I\u0027ll make it better.","commit_id":"f5c1ba873217c4b258dc456cd09767044e769a6f"}]}