)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"3857a9fa3418ed12dfdc6e56282944b36b2d580d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added method and command to allow setting \u0027dns.options\u0027 column"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Initially it would to be used to set \u0027ovn-owned\u0027 option."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Related-Issue: OSPRH-10758"},{"line_number":12,"context_line":"Change-Id: I6a364e06ece23ec40abe983ba14e249522ba1b09"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dbfe66f4_49da85c3","line":9,"range":{"start_line":9,"start_character":37,"end_line":9,"end_character":48},"updated":"2025-02-20 16:13:22.000000000","message":"I find it especially irritating when the ovs/ovn folks pick key names that have dashes in them, since that means you are forced to use `options\u003d{\u0027ovn-owned\u0027: True}` and then pass `**options` when passing the values and can\u0027t actually use them as kwargs since they aren\u0027t valid python, e.g. `dns_set_options(..., ovn-owned\u003dTrue)` won\u0027t work.","commit_id":"8e5bd24b5051e850028b1125ddaaa78f08513df0"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"38b3b6adb7522b850887d074898aee34684ca09c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added method and command to allow setting \u0027dns.options\u0027 column"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Initially it would to be used to set \u0027ovn-owned\u0027 option."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Related-Issue: OSPRH-10758"},{"line_number":12,"context_line":"Change-Id: I6a364e06ece23ec40abe983ba14e249522ba1b09"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ba84e88_9b45f4cb","line":9,"range":{"start_line":9,"start_character":37,"end_line":9,"end_character":48},"in_reply_to":"dbfe66f4_49da85c3","updated":"2025-02-24 07:49:38.000000000","message":"No idea why they choose those names :)","commit_id":"8e5bd24b5051e850028b1125ddaaa78f08513df0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e207e526c30507e976a16e8c35c4cff105f83468","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"82e6cd6b_e91b1421","updated":"2025-02-20 15:56:42.000000000","message":"Looks ok, just a comment to add the kwarg ``if_exists\u003dFalse`` in the command.","commit_id":"8e5bd24b5051e850028b1125ddaaa78f08513df0"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"38b3b6adb7522b850887d074898aee34684ca09c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e52db537_09a48c49","in_reply_to":"82e6cd6b_e91b1421","updated":"2025-02-24 07:49:38.000000000","message":"Ok done but instead did add the default as if_exists\u003dTrue and added tests for that.","commit_id":"8e5bd24b5051e850028b1125ddaaa78f08513df0"}],"ovsdbapp/schema/ovn_northbound/commands.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c4fb94185f51510e40fdf9291c9523792ca730f9","unresolved":true,"context_lines":[{"line_number":1902,"context_line":"    def run_idl(self, txn):"},{"line_number":1903,"context_line":"        try:"},{"line_number":1904,"context_line":"            dns \u003d self.api.lookup(\u0027DNS\u0027, self.row_uuid)"},{"line_number":1905,"context_line":"            dns.options \u003d self.options"},{"line_number":1906,"context_line":"        except idlutils.RowNotFound as e:"},{"line_number":1907,"context_line":"            msg \u003d \"DNS %s does not exist\" % self.row_uuid"},{"line_number":1908,"context_line":"            raise RuntimeError(msg) from e"}],"source_content_type":"text/x-python","patch_set":1,"id":"3c98b03a_b7df6a6a","line":1905,"updated":"2025-02-20 15:55:18.000000000","message":"This would mean that we overwrite all options every time this is called. Should we expect the CMS to always know all of the options that are set? Or should successive calls set new options and leave the originals untouched, like db_set() does? I can see arguments for either way.","commit_id":"8e5bd24b5051e850028b1125ddaaa78f08513df0"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"38b3b6adb7522b850887d074898aee34684ca09c","unresolved":true,"context_lines":[{"line_number":1902,"context_line":"    def run_idl(self, txn):"},{"line_number":1903,"context_line":"        try:"},{"line_number":1904,"context_line":"            dns \u003d self.api.lookup(\u0027DNS\u0027, self.row_uuid)"},{"line_number":1905,"context_line":"            dns.options \u003d self.options"},{"line_number":1906,"context_line":"        except idlutils.RowNotFound as e:"},{"line_number":1907,"context_line":"            msg \u003d \"DNS %s does not exist\" % self.row_uuid"},{"line_number":1908,"context_line":"            raise RuntimeError(msg) from e"}],"source_content_type":"text/x-python","patch_set":1,"id":"b7eb7128_24d1a13c","line":1905,"in_reply_to":"3c98b03a_b7df6a6a","updated":"2025-02-24 07:49:38.000000000","message":"Thanks Terry, So currently i see dns support only ovn-owned as option but could be extended in future like any table.\nBut now i see we currently use override approach for various tables(lsp,lrp,dhcp,healthcheck), you mean DNS is something special or was generic comment and others also need to be changed for this?\nI updated this patch to removed duplicated part and use same parent class as others i am referring above.","commit_id":"8e5bd24b5051e850028b1125ddaaa78f08513df0"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"43a964ab5783d23c26672cc058995050b5ba58af","unresolved":false,"context_lines":[{"line_number":1902,"context_line":"    def run_idl(self, txn):"},{"line_number":1903,"context_line":"        try:"},{"line_number":1904,"context_line":"            dns \u003d self.api.lookup(\u0027DNS\u0027, self.row_uuid)"},{"line_number":1905,"context_line":"            dns.options \u003d self.options"},{"line_number":1906,"context_line":"        except idlutils.RowNotFound as e:"},{"line_number":1907,"context_line":"            msg \u003d \"DNS %s does not exist\" % self.row_uuid"},{"line_number":1908,"context_line":"            raise RuntimeError(msg) from e"}],"source_content_type":"text/x-python","patch_set":1,"id":"08c9e535_15852f2b","line":1905,"in_reply_to":"7783cc88_4cd28b91","updated":"2025-02-24 14:22:16.000000000","message":"Done","commit_id":"8e5bd24b5051e850028b1125ddaaa78f08513df0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"47a982b7b5b72bb67444cbda25e17790c593ea1a","unresolved":true,"context_lines":[{"line_number":1902,"context_line":"    def run_idl(self, txn):"},{"line_number":1903,"context_line":"        try:"},{"line_number":1904,"context_line":"            dns \u003d self.api.lookup(\u0027DNS\u0027, self.row_uuid)"},{"line_number":1905,"context_line":"            dns.options \u003d self.options"},{"line_number":1906,"context_line":"        except idlutils.RowNotFound as e:"},{"line_number":1907,"context_line":"            msg \u003d \"DNS %s does not exist\" % self.row_uuid"},{"line_number":1908,"context_line":"            raise RuntimeError(msg) from e"}],"source_content_type":"text/x-python","patch_set":1,"id":"7783cc88_4cd28b91","line":1905,"in_reply_to":"b7eb7128_24d1a13c","updated":"2025-02-24 08:00:49.000000000","message":"The new PS is consistent with other commands.","commit_id":"8e5bd24b5051e850028b1125ddaaa78f08513df0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e207e526c30507e976a16e8c35c4cff105f83468","unresolved":true,"context_lines":[{"line_number":1903,"context_line":"        try:"},{"line_number":1904,"context_line":"            dns \u003d self.api.lookup(\u0027DNS\u0027, self.row_uuid)"},{"line_number":1905,"context_line":"            dns.options \u003d self.options"},{"line_number":1906,"context_line":"        except idlutils.RowNotFound as e:"},{"line_number":1907,"context_line":"            msg \u003d \"DNS %s does not exist\" % self.row_uuid"},{"line_number":1908,"context_line":"            raise RuntimeError(msg) from e"},{"line_number":1909,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"97280440_769b6ffc","line":1906,"range":{"start_line":1906,"start_character":8,"end_line":1906,"end_character":41},"updated":"2025-02-20 15:56:42.000000000","message":"We usually add the flag ``if_exists\u003dFalse``.","commit_id":"8e5bd24b5051e850028b1125ddaaa78f08513df0"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"38b3b6adb7522b850887d074898aee34684ca09c","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"        try:"},{"line_number":1904,"context_line":"            dns \u003d self.api.lookup(\u0027DNS\u0027, self.row_uuid)"},{"line_number":1905,"context_line":"            dns.options \u003d self.options"},{"line_number":1906,"context_line":"        except idlutils.RowNotFound as e:"},{"line_number":1907,"context_line":"            msg \u003d \"DNS %s does not exist\" % self.row_uuid"},{"line_number":1908,"context_line":"            raise RuntimeError(msg) from e"},{"line_number":1909,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d9b0b7be_ed0ef802","line":1906,"range":{"start_line":1906,"start_character":8,"end_line":1906,"end_character":41},"in_reply_to":"97280440_769b6ffc","updated":"2025-02-24 07:49:38.000000000","message":"Done","commit_id":"8e5bd24b5051e850028b1125ddaaa78f08513df0"}]}