)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e963f23722aa1b920c85d8479a507ce995c899b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fc9ec640_de46526f","updated":"2025-08-26 14:32:28.000000000","message":"There is technically nothing that states that the event name should be the same as the class name, it just kind of turned out that that\u0027s what we always did by convention. I don\u0027t know what other people using the library have done though and am not sure we can just make this change.","commit_id":"ab20e01f3eb77aa92874f93e420158249d11d38e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ca930da491ed8f7c6263877020957405cf701ca2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ba7be174_32d6825b","in_reply_to":"7cd64a88_eb0307e9","updated":"2025-08-26 15:03:50.000000000","message":"I think PS2 addresses Terry\u0027s comments: all classes already using ``event_name`` (at class level or at instance level) will keep their current overridden name.\n\nJust one consideration, if ``event_name`` is defined at class level (e.g.: [1], instead of [2]), class.event_name will be a string, not a method. That is trivial but we should avoid it.\n\n[1]https://github.com/openstack/neutron/blob/1baf3b462d6c2adc3b8bdd098e0ca9de33575e7d/neutron/tests/functional/resources/ovsdb/events.py#L25\n[2]https://github.com/openstack/neutron/blob/1baf3b462d6c2adc3b8bdd098e0ca9de33575e7d/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/extensions/placement.py#L121","commit_id":"ab20e01f3eb77aa92874f93e420158249d11d38e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5b08f62f33669f9549156c406fb9f9f4d32de7e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c3b9b22f_f201961b","in_reply_to":"ba7be174_32d6825b","updated":"2025-08-26 15:13:29.000000000","message":"You mean if someone sets a custom event_name as a class attribute then it is ignored?","commit_id":"ab20e01f3eb77aa92874f93e420158249d11d38e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9405af6fee858c28c331dd612ef0b8c414e23cbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f94b7dd2_ada0e4ef","in_reply_to":"c3b9b22f_f201961b","updated":"2025-08-27 15:12:56.000000000","message":"No, it will be used. But \"event_name\" will no longer be a property method but a variable. For working purposes doesn\u0027t change anything but just something I found while testing.","commit_id":"ab20e01f3eb77aa92874f93e420158249d11d38e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b3ecc900464d0132fadd4459e76d2c1bf0c02624","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7cd64a88_eb0307e9","in_reply_to":"fc9ec640_de46526f","updated":"2025-08-26 14:42:34.000000000","message":"I\u0027m fine abandoning the patch. I just found myself annoyed writing `__init__` methods just to set the event_name whenever I subclass, so I came up with the property that does it automatically and I thought, hey, why not everyone can benefit that 😊","commit_id":"ab20e01f3eb77aa92874f93e420158249d11d38e"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c3b51ae590e21483ce2f1282f0b70df69a82014f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"561cecf8_fce47df6","updated":"2025-08-26 15:14:38.000000000","message":"I don\u0027t think any code actually uses event_name in ovsdbapp, does it? Does it even need to be defined? __repr__ just uses the class name. 😄","commit_id":"e0172f20c8f6c8b196d5f298a5c5f4dc5ffb24f2"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c740ef5f00d7f5cf3aa01d0da838b6e91a668b02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5c151229_b48c2092","updated":"2025-08-26 15:35:42.000000000","message":"This looks good to me, tested with a dummy version to ensure setting event_name via class and instance both worked. Just waiting for CI for +2.","commit_id":"03a2a11a8041c8b1c07e6285aa0396f8ef8651c5"}]}