)]}'
{"ovsdbapp/tests/functional/schema/hardware_vtep/test_impl_idl.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0e5221611f90d5ef1b0d14ddad85ebffb0319dee","unresolved":true,"context_lines":[{"line_number":368,"context_line":"        local_macs_cmd \u003d self.api.list_local_macs("},{"line_number":369,"context_line":"            self.ls.name)"},{"line_number":370,"context_line":"        for table in local_macs_cmd.table_names:"},{"line_number":371,"context_line":"            self._wait_db_rows(self.api.tables[table])"},{"line_number":372,"context_line":"        local_macs \u003d local_macs_cmd.execute(check_error\u003dTrue)"},{"line_number":373,"context_line":"        for macs in local_macs:"},{"line_number":374,"context_line":"            self.assertEqual(len(macs), 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ae3dbcc_65cc2001","line":371,"updated":"2025-10-02 18:23:31.000000000","message":"I\u0027d just add this to the setup right after the calls:\n```\ndef _wait_for_data(self):\n    tables \u003d [\n        self.api.tables[\u0027Ucast_Macs_Local\u0027],\n        self.api.tables[\u0027Mcast_Macs_Local\u0027],\n        self.api.tables[\u0027Ucast_Macs_Remote\u0027],\n        self.api.tables[\u0027Mcast_Macs_Remote\u0027],\n    ]\n    for table in [ucast_table, mcast_table]:\n        self._wait_db_rows(table)\n\ndef setUp(self):\n    ...\n    call()\n    ...\n    self._wait_for_data()\n```\n\nand then remove the active waiting from all the test methods as the waiting seems really part of the preparation steps.","commit_id":"3de2287d468d991421bf4a81670f28b6a80b3e1a"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"d47d1a9a88220190f0135387be1a797ccd3fbad5","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        local_macs_cmd \u003d self.api.list_local_macs("},{"line_number":369,"context_line":"            self.ls.name)"},{"line_number":370,"context_line":"        for table in local_macs_cmd.table_names:"},{"line_number":371,"context_line":"            self._wait_db_rows(self.api.tables[table])"},{"line_number":372,"context_line":"        local_macs \u003d local_macs_cmd.execute(check_error\u003dTrue)"},{"line_number":373,"context_line":"        for macs in local_macs:"},{"line_number":374,"context_line":"            self.assertEqual(len(macs), 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fe94ee5f_a8958f63","line":371,"in_reply_to":"9ae3dbcc_65cc2001","updated":"2025-10-02 22:13:35.000000000","message":"Fine, I\u0027ll take the time to fix it the right way. 😄","commit_id":"3de2287d468d991421bf4a81670f28b6a80b3e1a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"12ee7ba8218eae7b0f37cfd2891b53232eafc5d5","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        local_macs_cmd \u003d self.api.list_local_macs("},{"line_number":369,"context_line":"            self.ls.name)"},{"line_number":370,"context_line":"        for table in local_macs_cmd.table_names:"},{"line_number":371,"context_line":"            self._wait_db_rows(self.api.tables[table])"},{"line_number":372,"context_line":"        local_macs \u003d local_macs_cmd.execute(check_error\u003dTrue)"},{"line_number":373,"context_line":"        for macs in local_macs:"},{"line_number":374,"context_line":"            self.assertEqual(len(macs), 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6f602e12_17bde079","line":371,"in_reply_to":"fe94ee5f_a8958f63","updated":"2025-10-03 00:31:59.000000000","message":"we could have had a semi-between-the-right-and-not-the-right 😊","commit_id":"3de2287d468d991421bf4a81670f28b6a80b3e1a"}]}