)]}'
{"ovsdbapp/schema/ovn_southbound/impl_idl.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"8ab92c12ab80e70bd8313fbca5dee1d0695e7727","unresolved":true,"context_lines":[{"line_number":26,"context_line":"        ),"},{"line_number":27,"context_line":"    }"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def autocreate_indices(self):"},{"line_number":30,"context_line":"        super().autocreate_indices()"},{"line_number":31,"context_line":"        if \u0027hostname\u0027 in self.idl.tables[\u0027Chassis\u0027].columns:"},{"line_number":32,"context_line":"            self.create_index(\u0027Chassis\u0027, \u0027hostname\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"af41b536_39cb408f","line":29,"updated":"2026-06-30 20:18:15.000000000","message":"We definitely shouldn\u0027t override autocreate_indices in ovsdbapp. If a particular user of ovsdbapp wants to add an index to a field that is not set as an index in the schema, it needs to do that in its own code. If we need to facilitate that easier with a pre_start() method or something that can be overridden (to avoid forcing the client to start with WhateverImpl(start\u003dFalse) and then calling start_connection(), we can do that in this patch. But that\u0027s not a decision ovsdbapp itself should be making for the client.\n\nThe client code will also need to test how the indexing works with multiple rows with the same hostname, since it is not an indexed column in the schema and hostname can be \"\" for multiple hosts as well, etc. It\u0027s been long enough since I wrote indexing, I\u0027m not exactly sure what happens if you db_find() on an indexed column and there are multiple. I assume both are returned.","commit_id":"e731e1e985f1cd7e4875daf4758312ab8c6d2d0c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"50ae398429063c9426088f97cd2042b367a2c3f9","unresolved":true,"context_lines":[{"line_number":26,"context_line":"        ),"},{"line_number":27,"context_line":"    }"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def autocreate_indices(self):"},{"line_number":30,"context_line":"        super().autocreate_indices()"},{"line_number":31,"context_line":"        if \u0027hostname\u0027 in self.idl.tables[\u0027Chassis\u0027].columns:"},{"line_number":32,"context_line":"            self.create_index(\u0027Chassis\u0027, \u0027hostname\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e4e69821_a59609d0","line":29,"in_reply_to":"af41b536_39cb408f","updated":"2026-07-01 07:28:31.000000000","message":"Thanks for the feedback! I\u0027ll implement this change in Neutron then.","commit_id":"e731e1e985f1cd7e4875daf4758312ab8c6d2d0c"}]}