)]}'
{"panko/publisher/database.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"92626faa784fd8670f9dfc7baae50a58c6304bdf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    Then, panko:// should be added to Ceilometer\u0027s event_pipeline.yaml"},{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, conf, parsed_url):"},{"line_number":34,"context_line":"        conf \u003d service.prepare_service([])"},{"line_number":35,"context_line":"        self.conn \u003d storage.get_connection_from_config(conf)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_72bb17c5","line":33,"range":{"start_line":33,"start_character":23,"end_line":33,"end_character":28},"updated":"2017-02-21 03:45:43.000000000","message":"this may will be inited failed, no conf parameter will be passed, see:\n\nhttps://github.com/openstack/ceilometer/blob/master/ceilometer/publisher/__init__.py#L33-L36","commit_id":"c16c91625d13d1c82ae38c023a848f78bf594d37"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c0141527f7a38b40cf65b199263d8693138b056f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    Then, panko:// should be added to Ceilometer\u0027s event_pipeline.yaml"},{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, conf, parsed_url):"},{"line_number":34,"context_line":"        conf \u003d service.prepare_service([])"},{"line_number":35,"context_line":"        self.conn \u003d storage.get_connection_from_config(conf)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_5a39bc40","line":33,"range":{"start_line":33,"start_character":23,"end_line":33,"end_character":28},"in_reply_to":"da36d5c6_72bb17c5","updated":"2017-02-21 12:51:04.000000000","message":"weird. good to know.","commit_id":"c16c91625d13d1c82ae38c023a848f78bf594d37"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"042b1514e20eb3f877a5c71529f4b44deca1a05c","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, conf, parsed_url):"},{"line_number":34,"context_line":"        conf \u003d service.prepare_service([])"},{"line_number":35,"context_line":"        self.conn \u003d storage.get_connection_from_config(conf)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def publish_events(self, events):"},{"line_number":38,"context_line":"        if not isinstance(events, list):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_f299ea20","line":35,"updated":"2017-02-10 08:52:55.000000000","message":"i don;t think this initialization method can parse panko:// properly :)","commit_id":"c16c91625d13d1c82ae38c023a848f78bf594d37"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"862f055ecae0c578db81c94654883bac80a4863e","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, conf, parsed_url):"},{"line_number":34,"context_line":"        conf \u003d service.prepare_service([])"},{"line_number":35,"context_line":"        self.conn \u003d storage.get_connection_from_config(conf)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def publish_events(self, events):"},{"line_number":38,"context_line":"        if not isinstance(events, list):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_922d8b00","line":35,"in_reply_to":"fa31d9ce_7f080c92","updated":"2017-02-14 10:09:43.000000000","message":"seems no need parse url if we use connection settings in panko conf","commit_id":"c16c91625d13d1c82ae38c023a848f78bf594d37"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"54162f9b911f2d0caaafabf054f637c753a0e9a0","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, conf, parsed_url):"},{"line_number":34,"context_line":"        conf \u003d service.prepare_service([])"},{"line_number":35,"context_line":"        self.conn \u003d storage.get_connection_from_config(conf)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def publish_events(self, events):"},{"line_number":38,"context_line":"        if not isinstance(events, list):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_7f080c92","line":35,"in_reply_to":"fa31d9ce_aee8a3b5","updated":"2017-02-13 14:13:16.000000000","message":"well it\u0027s there to keep the same interface. but it\u0027s never used. since parsing \u0027panko://\u0027 will give you nothing interesting. we can accept \u0027panko://?connection\u003dmysql://...\u0027 but i don\u0027t think that\u0027s useful and will make password very visible.","commit_id":"c16c91625d13d1c82ae38c023a848f78bf594d37"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"104deee248dca7565e2c8b0f3ce2262611bec68e","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, conf, parsed_url):"},{"line_number":34,"context_line":"        conf \u003d service.prepare_service([])"},{"line_number":35,"context_line":"        self.conn \u003d storage.get_connection_from_config(conf)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def publish_events(self, events):"},{"line_number":38,"context_line":"        if not isinstance(events, list):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_fa0375b6","line":35,"in_reply_to":"fa31d9ce_f299ea20","updated":"2017-02-10 13:53:51.000000000","message":"it doesn\u0027t need to. it is using the conf file to grab db connection option\n\nthe idea is that ceilometer publisher loader will see \u0027panko://\u0027 and it will look for panko in entrypoints. it will therefore, hopefully, find this publisher.","commit_id":"c16c91625d13d1c82ae38c023a848f78bf594d37"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"dbd27d987887307bd19a221268f3ebb0b6f84725","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, conf, parsed_url):"},{"line_number":34,"context_line":"        conf \u003d service.prepare_service([])"},{"line_number":35,"context_line":"        self.conn \u003d storage.get_connection_from_config(conf)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def publish_events(self, events):"},{"line_number":38,"context_line":"        if not isinstance(events, list):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_aee8a3b5","line":35,"in_reply_to":"fa31d9ce_fa0375b6","updated":"2017-02-13 09:42:13.000000000","message":"I see. so the parsed_url shouldn\u0027t be kept in the initialization?","commit_id":"c16c91625d13d1c82ae38c023a848f78bf594d37"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"042b1514e20eb3f877a5c71529f4b44deca1a05c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def publish_events(self, events):"},{"line_number":38,"context_line":"        if not isinstance(events, list):"},{"line_number":39,"context_line":"            events \u003d [events]"},{"line_number":40,"context_line":"        self.conn.record_events(events)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_cd5d27ee","line":40,"updated":"2017-02-10 08:52:55.000000000","message":"record_events in dispatcher database is worth copying, doesn\u0027t it? or maybe a similar approach","commit_id":"c16c91625d13d1c82ae38c023a848f78bf594d37"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"dbd27d987887307bd19a221268f3ebb0b6f84725","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def publish_events(self, events):"},{"line_number":38,"context_line":"        if not isinstance(events, list):"},{"line_number":39,"context_line":"            events \u003d [events]"},{"line_number":40,"context_line":"        self.conn.record_events(events)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_0ece0f5a","line":40,"in_reply_to":"fa31d9ce_7ae785e4","updated":"2017-02-13 09:42:13.000000000","message":"thanks for the hints :)","commit_id":"c16c91625d13d1c82ae38c023a848f78bf594d37"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"104deee248dca7565e2c8b0f3ce2262611bec68e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def publish_events(self, events):"},{"line_number":38,"context_line":"        if not isinstance(events, list):"},{"line_number":39,"context_line":"            events \u003d [events]"},{"line_number":40,"context_line":"        self.conn.record_events(events)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_7ae785e4","line":40,"in_reply_to":"fa31d9ce_cd5d27ee","updated":"2017-02-10 13:53:51.000000000","message":"this doesn\u0027t need any other processing i believe. record_events method expects Event object which is what the ceilometer publisher has. the dispatcher has more code because it is pulling from queue so it has to rebuild the object.\n\nhttps://github.com/openstack/panko/blob/master/panko/storage/impl_sqlalchemy.py#L175","commit_id":"c16c91625d13d1c82ae38c023a848f78bf594d37"}],"setup.cfg":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"92626faa784fd8670f9dfc7baae50a58c6304bdf","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    panko \u003d panko.dispatcher.database:DatabaseDispatcher"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"ceilometer.event.publisher \u003d"},{"line_number":52,"context_line":"    panko \u003d panko.publisher.database:EventPublisher"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"oslo.config.opts \u003d"},{"line_number":55,"context_line":"    panko \u003d panko.opts:list_opts"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"da36d5c6_92996b71","line":52,"range":{"start_line":52,"start_character":37,"end_line":52,"end_character":51},"updated":"2017-02-21 03:45:43.000000000","message":"the class named DatabasePublisher","commit_id":"c16c91625d13d1c82ae38c023a848f78bf594d37"}]}
