)]}'
{"panko/api/controllers/v2/events.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"28274e659c8dbdac3f87b8d69bfd87a7a405cdbb","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                         {\u0027operator\u0027: i.op, \u0027field\u0027: i.field})"},{"line_number":219,"context_line":"                raise base.ClientSideError(error)"},{"line_number":220,"context_line":"            evt_model_filter[i.field] \u003d i.value"},{"line_number":221,"context_line":"        elif i.field \u003d\u003d \u0027all_tenants\u0027:"},{"line_number":222,"context_line":"            all_tenants \u003d strutils.bool_from_string(i.value)"},{"line_number":223,"context_line":"            if all_tenants:"},{"line_number":224,"context_line":"                admin_proj \u003d None"},{"line_number":225,"context_line":"        else:"},{"line_number":226,"context_line":"            trait_type \u003d i.type or \u0027string\u0027"},{"line_number":227,"context_line":"            traits_filter.append({\"key\": i.field,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_f536bfb4","line":224,"range":{"start_line":221,"start_character":2,"end_line":224,"end_character":33},"updated":"2017-10-11 01:23:04.000000000","message":"seems this didn\u0027t limited to only admin users, right ? this should be only available by admins.","commit_id":"0cea2a282e15a0ea2b749a46fa76bab44779566c"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e37e8bc7a146a58446812dd53f5bb1399f6e0d48","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                         {\u0027operator\u0027: i.op, \u0027field\u0027: i.field})"},{"line_number":219,"context_line":"                raise base.ClientSideError(error)"},{"line_number":220,"context_line":"            evt_model_filter[i.field] \u003d i.value"},{"line_number":221,"context_line":"        elif i.field \u003d\u003d \u0027all_tenants\u0027:"},{"line_number":222,"context_line":"            all_tenants \u003d strutils.bool_from_string(i.value)"},{"line_number":223,"context_line":"            if all_tenants:"},{"line_number":224,"context_line":"                admin_proj \u003d None"},{"line_number":225,"context_line":"        else:"},{"line_number":226,"context_line":"            trait_type \u003d i.type or \u0027string\u0027"},{"line_number":227,"context_line":"            traits_filter.append({\"key\": i.field,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_eb949cea","line":224,"range":{"start_line":221,"start_character":2,"end_line":224,"end_character":33},"in_reply_to":"5f4e5783_28219afc","updated":"2017-10-11 03:34:56.000000000","message":"yes, my misunderstanding, but seems it is redundant if admin_proj is None, maybe change the if condition as: \nelif i.field \u003d\u003d \u0027all_tenants\u0027 and admin_proj:","commit_id":"0cea2a282e15a0ea2b749a46fa76bab44779566c"},{"author":{"_account_id":20100,"name":"Shaoman Zhang","email":"zhang.shaoman@zte.com.cn","username":"zhang.shaoman"},"change_message_id":"3ba038f8c7e1786e288bbfda9046cf5fc20d064e","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                         {\u0027operator\u0027: i.op, \u0027field\u0027: i.field})"},{"line_number":219,"context_line":"                raise base.ClientSideError(error)"},{"line_number":220,"context_line":"            evt_model_filter[i.field] \u003d i.value"},{"line_number":221,"context_line":"        elif i.field \u003d\u003d \u0027all_tenants\u0027:"},{"line_number":222,"context_line":"            all_tenants \u003d strutils.bool_from_string(i.value)"},{"line_number":223,"context_line":"            if all_tenants:"},{"line_number":224,"context_line":"                admin_proj \u003d None"},{"line_number":225,"context_line":"        else:"},{"line_number":226,"context_line":"            trait_type \u003d i.type or \u0027string\u0027"},{"line_number":227,"context_line":"            traits_filter.append({\"key\": i.field,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_28219afc","line":224,"range":{"start_line":221,"start_character":2,"end_line":224,"end_character":33},"in_reply_to":"5f4e5783_f536bfb4","updated":"2017-10-11 02:31:09.000000000","message":"hi liusheng,\n    for non-admin, events are filtered by user and project, so \u0027admin_proj\u0027 is used to restrict the admin to access events :)","commit_id":"0cea2a282e15a0ea2b749a46fa76bab44779566c"},{"author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"change_message_id":"d4a95c59131645adf94cb17de9ba6686dcf4281f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    field \u003d wsme.wsattr(wtypes.text)"},{"line_number":67,"context_line":"    \u0027\u0027\u0027"},{"line_number":68,"context_line":"    Name of the field to filter on. Can be either a trait name or field of an"},{"line_number":69,"context_line":"    event. Use start_timestamp/end_timestamp to filter on `generated` field"},{"line_number":70,"context_line":"    \u0027\u0027\u0027"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def __repr__(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_a253eb38","line":69,"updated":"2017-10-25 01:05:21.000000000","message":"I think that you could mention the addition for this new special field \u0027all_tenants\u0027 here so that it\u0027ll be showed on the document.","commit_id":"badb8c8a78f8b543a0723fc673b0895d0efbcbdd"}],"panko/tests/functional/api/v2/test_event_scenarios.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"d4c0f2fcced4a62a3aa4128e1d2f80326bab51ad","unresolved":false,"context_lines":[{"line_number":645,"context_line":"                     \"X-Project-Id\": self.admin_proj_id}"},{"line_number":646,"context_line":"        data \u003d self.get_json(\u0027/events\u0027, headers\u003da_headers,"},{"line_number":647,"context_line":"                             q\u003d[{\u0027field\u0027: \u0027all_tenants\u0027,"},{"line_number":648,"context_line":"                                 \u0027value\u0027: \u00271\u0027,"},{"line_number":649,"context_line":"                                 \u0027type\u0027: \u0027string\u0027,"},{"line_number":650,"context_line":"                                 \u0027op\u0027: \u0027eq\u0027}])"},{"line_number":651,"context_line":"        self.assertEqual(3, len(data))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_3b6179aa","line":648,"updated":"2017-11-02 17:02:09.000000000","message":"this is weird. it should be True/False.\n\ni\u0027m pretty sure your code still works but let\u0027s update the test and docs i think.","commit_id":"ac3f7226fede2a3957af00c9d3e60fe6c7ab3cd9"},{"author":{"_account_id":20100,"name":"Shaoman Zhang","email":"zhang.shaoman@zte.com.cn","username":"zhang.shaoman"},"change_message_id":"2f0466497697378c19d7ba1501fffab3c7abb285","unresolved":false,"context_lines":[{"line_number":645,"context_line":"                     \"X-Project-Id\": self.admin_proj_id}"},{"line_number":646,"context_line":"        data \u003d self.get_json(\u0027/events\u0027, headers\u003da_headers,"},{"line_number":647,"context_line":"                             q\u003d[{\u0027field\u0027: \u0027all_tenants\u0027,"},{"line_number":648,"context_line":"                                 \u0027value\u0027: \u00271\u0027,"},{"line_number":649,"context_line":"                                 \u0027type\u0027: \u0027string\u0027,"},{"line_number":650,"context_line":"                                 \u0027op\u0027: \u0027eq\u0027}])"},{"line_number":651,"context_line":"        self.assertEqual(3, len(data))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_c255c71f","line":648,"in_reply_to":"3f4b6375_3b6179aa","updated":"2017-11-03 08:36:45.000000000","message":"Done","commit_id":"ac3f7226fede2a3957af00c9d3e60fe6c7ab3cd9"}]}